)]}'
{"id":"openstack%2Fosprofiler~737349","triplet_id":"openstack%2Fosprofiler~master~I312da1b175a04d4ddee7f823111b8320dd4777d6","project":"openstack/osprofiler","branch":"master","topic":"fix-empty-func-dict-with-jaeger","hashtags":[],"change_id":"I312da1b175a04d4ddee7f823111b8320dd4777d6","subject":"Fix empty \u0027args\u0027 and \u0027kwargs\u0027 when using \u0027hide_args\u0027 with Jaeger","status":"MERGED","created":"2020-06-22 18:28:24.000000000","updated":"2020-06-23 16:51:32.000000000","submitted":"2020-06-23 13:04:01.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"737349-1592917441919-9f56d81a","meta_rev_id":"de1740b0fd9c5b8fde5d8cc88083dc9963ce27e5","_number":737349,"virtual_id_number":737349,"owner":{"_account_id":31869,"name":"Daria Kobtseva","email":"daria.kobtseva@ovhcloud.com","username":"dkobtsev"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-06-23 13:04:01.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":5950,"name":"Ilya Shakhat","email":"shakhat@gmail.com","username":"shakhat"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":5950,"name":"Ilya Shakhat","email":"shakhat@gmail.com","username":"shakhat"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2020-06-23 11:23:22.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":5950,"name":"Ilya Shakhat","email":"shakhat@gmail.com","username":"shakhat"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":5950,"name":"Ilya Shakhat","email":"shakhat@gmail.com","username":"shakhat"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2020-06-23 11:23:22.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":5950,"name":"Ilya Shakhat","email":"shakhat@gmail.com","username":"shakhat"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Backport-Candidate":{"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":5950,"name":"Ilya Shakhat","email":"shakhat@gmail.com","username":"shakhat"}],"values":{"-2":"Do Not Backport","-1":"Not A Backport Candidate"," 0":"Backport Review Needed","+1":"Proposed Backport","+2":"Should Backport"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":5950,"name":"Ilya Shakhat","email":"shakhat@gmail.com","username":"shakhat"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-06-23 11:23:22.000000000","updated_by":{"_account_id":5950,"name":"Ilya Shakhat","email":"shakhat@gmail.com","username":"shakhat"},"reviewer":{"_account_id":5950,"name":"Ilya Shakhat","email":"shakhat@gmail.com","username":"shakhat"},"state":"REVIEWER"},{"updated":"2020-06-23 13:04:01.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"55b3da3cf1175a72cb6acb98027491d28b4ab697","author":{"_account_id":31869,"name":"Daria Kobtseva","email":"daria.kobtseva@ovhcloud.com","username":"dkobtsev"},"date":"2020-06-22 18:28:24.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"addc493c948070a370a96f6c4255921eeba0be36","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-22 19:52:42.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/ea98158afde243cda075bed0092bc0ae : SUCCESS in 1h 16m 41s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/162ddf8515064fb597264314997041bf : SUCCESS in 6m 00s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/856ec11deb074b2384d2721c6f3f51dd : SUCCESS in 5m 56s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/e0649ec177e0421fa0bb8785f18715a6 : SUCCESS in 9m 10s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/f38994e17bd3404ab5e37c9028b8fb40 : SUCCESS in 9m 37s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/8ea0707f7c0142c58f39af04d37e0de4 : SUCCESS in 5m 43s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/293b06aaecdc499b963bdf185fc4363d : SUCCESS in 5m 14s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/45721e297a36409eb93e27721bd54daf : SUCCESS in 7m 09s\n- tempest-smoke-py3-osprofiler-redis https://zuul.opendev.org/t/openstack/build/c78dddb1cdd44f90b08166dbd6e3864d : SUCCESS in 49m 48s (non-voting)\n- tempest-smoke-py3-osprofiler-sqlalchemy https://zuul.opendev.org/t/openstack/build/a153a9cacafa444187d1028afc6c625f : SUCCESS in 44m 16s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"61ce1b7bebd9fcbc3a8cd9bfe3007679c0f8020e","author":{"_account_id":5950,"name":"Ilya Shakhat","email":"shakhat@gmail.com","username":"shakhat"},"date":"2020-06-23 11:23:22.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"d34488a90f3f29439f4f22c0bcd4cf9f31419533","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-23 11:23:33.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"41df3452985b78eb2a44b4dd2fdc059ed82811e1","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-23 13:04:01.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/8416dc7964c6461ca7b8e9695e7b855f : SUCCESS in 1h 35m 00s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/2cadb32628bf44dc84b0535650cbeecd : SUCCESS in 4m 12s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/593ea73b701a4458b3a9500357ff6849 : SUCCESS in 4m 25s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/7f5e0dc35b50475bb095ddad29c90f1d : SUCCESS in 8m 21s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/3ac8c85198114d888ac006c3f287dfaf : SUCCESS in 5m 39s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a2af57f8725e440c8de05abba0545477 : SUCCESS in 7m 54s\n- openstack-tox-functional-py36 https://zuul.opendev.org/t/openstack/build/3e9abaf7507243b587b8448d9779d488 : SUCCESS in 9m 55s","accounts_in_message":[],"_revision_number":1},{"id":"486ae56022b96fdc5f1f08e2bc86f4d57e4aef60","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-23 13:04:01.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"bc5b90fb0ff1d024ca81aaefaf3ef104bd0fd446","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-23 13:06:24.000000000","message":"Patch Set 1:\n\nBuild failed (promote pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a382de9c904d4fb9a5402eaaaf16d090 : POST_FAILURE in 1m 59s","accounts_in_message":[],"_revision_number":1},{"id":"668bb3feefe007075b1e1d78a91782e844889885","author":{"_account_id":31869,"name":"Daria Kobtseva","email":"daria.kobtseva@ovhcloud.com","username":"dkobtsev"},"date":"2020-06-23 16:47:31.000000000","message":"Patch Set 1:\n\n\u003e Build failed (promote pipeline).  For information on how to\n \u003e proceed, see\n \u003e https://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n \u003e \n \u003e \n \u003e - promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a382de9c904d4fb9a5402eaaaf16d090\n \u003e : POST_FAILURE in 1m 59s\n\nHello, \n\nI don\u0027t know if there\u0027s something that needs to be done about this ? \nFrom what I understand \"POST_FAILURE\" may indicate an issue with the automated testing system and not the tests itself.\n\nThis is my first time submitting a change, don\u0027t hesitate to tell me if there\u0027s something else I need to do.","accounts_in_message":[],"_revision_number":1},{"id":"76e048b31508f3196b621bcfbd43405413ac1810","author":{"_account_id":31869,"name":"Daria Kobtseva","email":"daria.kobtseva@ovhcloud.com","username":"dkobtsev"},"date":"2020-06-23 16:51:32.000000000","message":"Patch Set 1:\n\n\u003e \u003e Build failed (promote pipeline).  For information on how to\n \u003e \u003e proceed, see\n \u003e \u003e https://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n \u003e \u003e\n \u003e \u003e\n \u003e \u003e - promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a382de9c904d4fb9a5402eaaaf16d090\n \u003e \u003e : POST_FAILURE in 1m 59s\n \u003e \n \u003e Hello,\n \u003e \n \u003e I don\u0027t know if there\u0027s something that needs to be done about this\n \u003e ?\n \u003e From what I understand \"POST_FAILURE\" may indicate an issue with\n \u003e the automated testing system and not the tests itself.\n \u003e \n \u003e This is my first time submitting a change, don\u0027t hesitate to tell\n \u003e me if there\u0027s something else I need to do.\n\nI just saw it\u0027s been merged :)","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"61a0ff8ace87e917d31231f28f3be6b21a113624","revisions":{"61a0ff8ace87e917d31231f28f3be6b21a113624":{"kind":"REWORK","_number":1,"created":"2020-06-22 18:28:24.000000000","uploader":{"_account_id":31869,"name":"Daria Kobtseva","email":"daria.kobtseva@ovhcloud.com","username":"dkobtsev"},"ref":"refs/changes/49/737349/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/osprofiler","ref":"refs/changes/49/737349/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/osprofiler refs/changes/49/737349/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/osprofiler refs/changes/49/737349/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/osprofiler refs/changes/49/737349/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/osprofiler refs/changes/49/737349/1"}}},"commit":{"parents":[{"commit":"8569b6d65fa1d35db6f8c9b6a4ca95ece88f7e4b","subject":"drop mock from lower-constraints","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/osprofiler/commit/8569b6d65fa1d35db6f8c9b6a4ca95ece88f7e4b"}]}],"author":{"name":"Daria Kobtseva","email":"daria.kts@gmail.com","date":"2020-06-21 10:29:42.000000000","tz":120},"committer":{"name":"Daria Kobtseva","email":"daria.kts@gmail.com","date":"2020-06-21 10:29:42.000000000","tz":120},"subject":"Fix empty \u0027args\u0027 and \u0027kwargs\u0027 when using \u0027hide_args\u0027 with Jaeger","message":"Fix empty \u0027args\u0027 and \u0027kwargs\u0027 when using \u0027hide_args\u0027 with Jaeger\n\nWhen \u0027hide_args\u003dTrue\u0027 is used in @profiler.trace() decorator\nalong with Jaeger driver, trace \u0027args\u0027 and \u0027kwargs\u0027 function\nparameters are empty, which leads to a key error.\n\nThis change introduces a key check before adding those parameters to\ntags.\n\nChange-Id: I312da1b175a04d4ddee7f823111b8320dd4777d6\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/osprofiler/commit/61a0ff8ace87e917d31231f28f3be6b21a113624"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/osprofiler/commit/61a0ff8ace87e917d31231f28f3be6b21a113624"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
