)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"ce3d52632a21dceed431b5eba38ca7ec7dbb2e37","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9eecee1d_7d1e827d","updated":"2023-02-08 10:55:37.000000000","message":"Still not clear the way that how port is passed","commit_id":"fa6f4f6133a596529530aef15abf9b8cbe7a6a73"}],"osprofiler/drivers/elasticsearch_driver.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"1ccf796b3d06afbde214624981def89815c95136","unresolved":true,"context_lines":[{"line_number":44,"context_line":"        client_url \u003d parser.urlunparse(parser.urlparse(self.connection_str)"},{"line_number":45,"context_line":"                                       ._replace(scheme\u003d\"http\"))"},{"line_number":46,"context_line":"        self.conf \u003d conf"},{"line_number":47,"context_line":"        self.client \u003d Elasticsearch(client_url + \":9200\")"},{"line_number":48,"context_line":"        self.index_name \u003d index_name"},{"line_number":49,"context_line":"        self.index_name_error \u003d \"osprofiler-notifications-error\""},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"e20bd13f_4b77dbc8","line":47,"updated":"2022-12-01 09:03:18.000000000","message":"Can have this passed through configurations instead of having hardcoded?","commit_id":"5833d9519a31665447250e9c734ca64c065dab64"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b02165ea076321d9a6ef4c7e3b172fe9e48e8aab","unresolved":true,"context_lines":[{"line_number":44,"context_line":"        client_url \u003d parser.urlunparse(parser.urlparse(self.connection_str)"},{"line_number":45,"context_line":"                                       ._replace(scheme\u003d\"http\"))"},{"line_number":46,"context_line":"        self.conf \u003d conf"},{"line_number":47,"context_line":"        self.client \u003d Elasticsearch(client_url + \":9200\")"},{"line_number":48,"context_line":"        self.index_name \u003d index_name"},{"line_number":49,"context_line":"        self.index_name_error \u003d \"osprofiler-notifications-error\""},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"80a42a13_67ff0342","line":47,"in_reply_to":"9a79e9ce_6ff776bc","updated":"2024-03-12 14:21:07.000000000","message":"I agree with Sahid. This breaks existing usage with explicit port. Also this completely breaks any deployment which requires non-default ports.","commit_id":"5833d9519a31665447250e9c734ca64c065dab64"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"c9782ff16a55910d41992666a4aeb90d790d171e","unresolved":true,"context_lines":[{"line_number":44,"context_line":"        client_url \u003d parser.urlunparse(parser.urlparse(self.connection_str)"},{"line_number":45,"context_line":"                                       ._replace(scheme\u003d\"http\"))"},{"line_number":46,"context_line":"        self.conf \u003d conf"},{"line_number":47,"context_line":"        self.client \u003d Elasticsearch(client_url + \":9200\")"},{"line_number":48,"context_line":"        self.index_name \u003d index_name"},{"line_number":49,"context_line":"        self.index_name_error \u003d \"osprofiler-notifications-error\""},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a79e9ce_6ff776bc","line":47,"in_reply_to":"e20bd13f_4b77dbc8","updated":"2022-12-01 09:12:16.000000000","message":"also that, if someone is using localhost:9000 on is client_url, this is going to create an issue, right?","commit_id":"5833d9519a31665447250e9c734ca64c065dab64"}],"test-requirements.txt":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"1ccf796b3d06afbde214624981def89815c95136","unresolved":true,"context_lines":[{"line_number":13,"context_line":"pymongo!\u003d3.1,\u003e\u003d3.0.2 # Apache-2.0"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"# Elasticsearch python client"},{"line_number":16,"context_line":"elasticsearch\u003e\u003d2.0.0,\u003c9.0.0 # Apache-2.0"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# Redis python client"},{"line_number":19,"context_line":"redis\u003e\u003d2.10.0 # MIT"}],"source_content_type":"text/plain","patch_set":1,"id":"9a5a690e_ed802396","line":16,"updated":"2022-12-01 09:03:18.000000000","message":"This is not related to your change. Could you remove it.","commit_id":"5833d9519a31665447250e9c734ca64c065dab64"}]}