)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"5a08b32cdc7d3e131a120efca15006b66c429ce2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"67dc5f0d_19705801","updated":"2023-01-30 12:55:47.000000000","message":"recheck","commit_id":"67cdeeaef19dd9d0f88c8a63e04315b3fc614a0f"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"69e494aa582da114802a7798176536175a583514","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b395db77_8edf140f","updated":"2023-01-30 15:21:07.000000000","message":"recheck time out","commit_id":"67cdeeaef19dd9d0f88c8a63e04315b3fc614a0f"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"8e3edc010b549caada8c4705e9ec150ae50e913a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"be3e9152_48d86efd","updated":"2023-02-13 14:04:05.000000000","message":"Thanks for update. The update looks good to me but I noticed one more point we have to fix. I\u0027ll vote my +2 once that is addressed.","commit_id":"0cea654a638462e95190b2d5f5053d4edd215a31"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"21d67f0c195356c922fcc18c302486768c340594","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f59db08f_4bf72ea6","updated":"2023-02-14 07:48:06.000000000","message":"recheck unrelated temptest test regarding volume","commit_id":"a12939bee1b66926fc464dff5fb4e24547e42e45"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"471d0ba2574a0e79c94904bea10701223ccee9af","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"5e7639ef_ecb99503","updated":"2023-02-16 12:02:05.000000000","message":"All of my comments were addressed. Closing one remaining open.","commit_id":"b7468756bcfdf3fe74e7cacb0562a7f969472250"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"0a8ab115eb1311594987ac33fab76905898e3347","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"a6759465_bf874321","updated":"2023-02-16 10:57:39.000000000","message":"Have you implemented Takashi\u0027s remarks?\n\nI compared the latest patch sets between them and if I\u0027m right I didn\u0027t see his remarks implemented.","commit_id":"b7468756bcfdf3fe74e7cacb0562a7f969472250"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"66f6d0f10915c79527826736eb3e2140cc0a0749","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"334b2c88_cea664ad","updated":"2023-02-16 12:34:39.000000000","message":"Ok thanks for your replies. Then LGTM","commit_id":"b7468756bcfdf3fe74e7cacb0562a7f969472250"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"768fd86a4751c40eac486b6ee1438df063d84324","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"b86f612f_75fcf9de","in_reply_to":"a6759465_bf874321","updated":"2023-02-16 11:08:49.000000000","message":"Which one I think I have implemented all no? The previous patch is just a rebase it should not have diff.","commit_id":"b7468756bcfdf3fe74e7cacb0562a7f969472250"}],"osprofiler/opts.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7493e6d2624d70deb7c20cf97cc6f8362a13777c","unresolved":true,"context_lines":[{"line_number":171,"context_line":"cfg.CONF.register_opts(_PROFILER_OPTS, group\u003d_profiler_opt_group)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"_jaegerprofiler_opt_group \u003d cfg.OptGroup("},{"line_number":174,"context_line":"    \"jaeger\","},{"line_number":175,"context_line":"    title\u003d\"Jaeger\u0027s driver related options\")"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"_service_name_prefix \u003d cfg.StrOpt("}],"source_content_type":"text/x-python","patch_set":2,"id":"2dcdc154_7920864b","line":174,"range":{"start_line":174,"start_character":5,"end_line":174,"end_character":11},"updated":"2023-02-13 11:57:14.000000000","message":"can we use profiler_jaeger instead ? That would avoid name collision in the future, especially when we add new options for other drivers such as redis driver.","commit_id":"413f6e013ee36ec1a0d079581ffa6417b922ff17"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"84f47e7d228bb710aeb236d2ee2bd412cbe37e5b","unresolved":false,"context_lines":[{"line_number":171,"context_line":"cfg.CONF.register_opts(_PROFILER_OPTS, group\u003d_profiler_opt_group)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"_jaegerprofiler_opt_group \u003d cfg.OptGroup("},{"line_number":174,"context_line":"    \"jaeger\","},{"line_number":175,"context_line":"    title\u003d\"Jaeger\u0027s driver related options\")"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"_service_name_prefix \u003d cfg.StrOpt("}],"source_content_type":"text/x-python","patch_set":2,"id":"cb1098d1_78630aa7","line":174,"range":{"start_line":174,"start_character":5,"end_line":174,"end_character":11},"in_reply_to":"2dcdc154_7920864b","updated":"2023-02-13 12:10:11.000000000","message":"Done","commit_id":"413f6e013ee36ec1a0d079581ffa6417b922ff17"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7493e6d2624d70deb7c20cf97cc6f8362a13777c","unresolved":true,"context_lines":[{"line_number":172,"context_line":""},{"line_number":173,"context_line":"_jaegerprofiler_opt_group \u003d cfg.OptGroup("},{"line_number":174,"context_line":"    \"jaeger\","},{"line_number":175,"context_line":"    title\u003d\"Jaeger\u0027s driver related options\")"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"_service_name_prefix \u003d cfg.StrOpt("},{"line_number":178,"context_line":"    \"service_name_prefix\","}],"source_content_type":"text/x-python","patch_set":2,"id":"06abfa51_da7ca0e0","line":175,"range":{"start_line":175,"start_character":20,"end_line":175,"end_character":26},"updated":"2023-02-13 11:57:14.000000000","message":"\"profiler driver\" would be better","commit_id":"413f6e013ee36ec1a0d079581ffa6417b922ff17"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"84f47e7d228bb710aeb236d2ee2bd412cbe37e5b","unresolved":false,"context_lines":[{"line_number":172,"context_line":""},{"line_number":173,"context_line":"_jaegerprofiler_opt_group \u003d cfg.OptGroup("},{"line_number":174,"context_line":"    \"jaeger\","},{"line_number":175,"context_line":"    title\u003d\"Jaeger\u0027s driver related options\")"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"_service_name_prefix \u003d cfg.StrOpt("},{"line_number":178,"context_line":"    \"service_name_prefix\","}],"source_content_type":"text/x-python","patch_set":2,"id":"0b24fdc2_4481a499","line":175,"range":{"start_line":175,"start_character":20,"end_line":175,"end_character":26},"in_reply_to":"06abfa51_da7ca0e0","updated":"2023-02-13 12:10:11.000000000","message":"Done","commit_id":"413f6e013ee36ec1a0d079581ffa6417b922ff17"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7493e6d2624d70deb7c20cf97cc6f8362a13777c","unresolved":true,"context_lines":[{"line_number":176,"context_line":""},{"line_number":177,"context_line":"_service_name_prefix \u003d cfg.StrOpt("},{"line_number":178,"context_line":"    \"service_name_prefix\","},{"line_number":179,"context_line":"    default\u003d\"\","},{"line_number":180,"context_line":"    help\u003d\"\"\""},{"line_number":181,"context_line":"Set service name prefix to Jaeger service name."},{"line_number":182,"context_line":"\"\"\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"995acb22_5971cb5f","line":179,"range":{"start_line":179,"start_character":4,"end_line":179,"end_character":15},"updated":"2023-02-13 11:57:14.000000000","message":"(nit) you can omit this and use None by default.","commit_id":"413f6e013ee36ec1a0d079581ffa6417b922ff17"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"84f47e7d228bb710aeb236d2ee2bd412cbe37e5b","unresolved":false,"context_lines":[{"line_number":176,"context_line":""},{"line_number":177,"context_line":"_service_name_prefix \u003d cfg.StrOpt("},{"line_number":178,"context_line":"    \"service_name_prefix\","},{"line_number":179,"context_line":"    default\u003d\"\","},{"line_number":180,"context_line":"    help\u003d\"\"\""},{"line_number":181,"context_line":"Set service name prefix to Jaeger service name."},{"line_number":182,"context_line":"\"\"\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"c3555cea_0b01d866","line":179,"range":{"start_line":179,"start_character":4,"end_line":179,"end_character":15},"in_reply_to":"995acb22_5971cb5f","updated":"2023-02-13 12:10:11.000000000","message":"Done","commit_id":"413f6e013ee36ec1a0d079581ffa6417b922ff17"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"8e3edc010b549caada8c4705e9ec150ae50e913a","unresolved":true,"context_lines":[{"line_number":254,"context_line":"        web.disable()"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"def list_opts():"},{"line_number":258,"context_line":"    return [(_profiler_opt_group.name, _PROFILER_OPTS)]"}],"source_content_type":"text/x-python","patch_set":3,"id":"b4ce7560_dc363a49","line":257,"range":{"start_line":257,"start_character":4,"end_line":257,"end_character":13},"updated":"2023-02-13 14:04:05.000000000","message":"Please also update this so that the new option is picked up by oslo-config-generator.","commit_id":"0cea654a638462e95190b2d5f5053d4edd215a31"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"471d0ba2574a0e79c94904bea10701223ccee9af","unresolved":false,"context_lines":[{"line_number":254,"context_line":"        web.disable()"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"def list_opts():"},{"line_number":258,"context_line":"    return [(_profiler_opt_group.name, _PROFILER_OPTS)]"}],"source_content_type":"text/x-python","patch_set":3,"id":"0a38f3cc_887e199c","line":257,"range":{"start_line":257,"start_character":4,"end_line":257,"end_character":13},"in_reply_to":"61e75d82_cc71b0a5","updated":"2023-02-16 12:02:05.000000000","message":"Done","commit_id":"0cea654a638462e95190b2d5f5053d4edd215a31"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"f1f2783564166e31a0dfeee26979480b34f53e75","unresolved":true,"context_lines":[{"line_number":254,"context_line":"        web.disable()"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"def list_opts():"},{"line_number":258,"context_line":"    return [(_profiler_opt_group.name, _PROFILER_OPTS)]"}],"source_content_type":"text/x-python","patch_set":3,"id":"61e75d82_cc71b0a5","line":257,"range":{"start_line":257,"start_character":4,"end_line":257,"end_character":13},"in_reply_to":"b4ce7560_dc363a49","updated":"2023-02-13 14:17:43.000000000","message":"good catch, thanks","commit_id":"0cea654a638462e95190b2d5f5053d4edd215a31"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"78a6141e2bf403d5ec8ca885a8ac38df67d41473","unresolved":true,"context_lines":[{"line_number":255,"context_line":""},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"def list_opts():"},{"line_number":258,"context_line":"    return [(_profiler_opt_group.name, _PROFILER_OPTS, _JAEGER_OPTS)]"}],"source_content_type":"text/x-python","patch_set":6,"id":"6e3749d2_56cf2b6b","line":258,"range":{"start_line":258,"start_character":39,"end_line":258,"end_character":67},"updated":"2023-02-15 02:02:39.000000000","message":"This is wrong because list_opts should return list of (group, options) tuple.\nAlso, _JAEGER_OPTS should appear in profiler_jager group.\n\nSo this should be\n\n```\n    return [(_profiler_opt_group.name, _PROFILER_OPTS),\n            (_jaegerprofiler_opt_group.name, _JAEGER_OPTS)]\n```","commit_id":"7fead31c8fe17102bf8fcb77fca9167a0e220993"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"003c608fbd2505f55638357274570ebc33d291b2","unresolved":false,"context_lines":[{"line_number":255,"context_line":""},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"def list_opts():"},{"line_number":258,"context_line":"    return [(_profiler_opt_group.name, _PROFILER_OPTS, _JAEGER_OPTS)]"}],"source_content_type":"text/x-python","patch_set":6,"id":"62a0c179_f90a416f","line":258,"range":{"start_line":258,"start_character":39,"end_line":258,"end_character":67},"in_reply_to":"6e3749d2_56cf2b6b","updated":"2023-02-15 07:58:00.000000000","message":"Ack","commit_id":"7fead31c8fe17102bf8fcb77fca9167a0e220993"}]}