)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"d1a95b04dad5389a46bda6b51d661d9069bb118f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"ab12b49e_9a8c8d49","updated":"2023-04-07 09:16:35.000000000","message":"Thanks for the latest patch set.\nChanges LGTM","commit_id":"4a4a13e7a996b081b70561e502e01cc221c60292"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"d9137aa56bfb95eddd1e5e44d7a4a9266201237d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"c0576e6b_95ec4f7a","updated":"2023-04-04 14:17:36.000000000","message":"recheck","commit_id":"4a4a13e7a996b081b70561e502e01cc221c60292"}],"devstack/lib/osprofiler":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"f3dddfdfa61fd2b174081a1f13a67d62e30bd3be","unresolved":true,"context_lines":[{"line_number":63,"context_line":"        install_package docker.io"},{"line_number":64,"context_line":"        start_service docker"},{"line_number":65,"context_line":"        add_user_to_group $STACK_USER docker"},{"line_number":66,"context_line":"        sg docker -c \"docker run -d --name jaeger -e COLLECTOR_ZIPKIN_HOST_PORT\u003d:9411 -e COLLECTOR_OTLP_ENABLED\u003dtrue -p 6831:6831/udp -p 6832:6832/udp -p 5778:5778 -p 16686:16686 -p 4317:4317 -p 4318:4318 -p 14250:14250 -p 14268:14268 -p 14269:14269 -p 9411:9411 jaegertracing/all-in-one:1.42\""},{"line_number":67,"context_line":"    else"},{"line_number":68,"context_line":"        exit_distro_not_supported \"docker.io installation\""},{"line_number":69,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"292250a1_8d3d36b1","line":66,"range":{"start_line":66,"start_character":117,"end_line":66,"end_character":262},"updated":"2023-03-30 09:26:35.000000000","message":"Do we need to publish all these features?\nBy example I\u0027m not convinced that we will use node.js (6832) in our openstack context.\n\nApparently we want to use 4318 in our context, so I wonder if publishing all these ports is mandatory because IMO it can cause security issues at some points if some CVE are discovered for one of them, so I\u0027d suggest to reduce the opened windows only to the ports we really needs.\n\nhttps://www.jaegertracing.io/docs/1.43/getting-started/#all-in-one","commit_id":"3806038dab03249b3040030b538ef01289dbd92e"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"689fb5a2fe8c104a49d9f74765b65e46b2e12778","unresolved":false,"context_lines":[{"line_number":63,"context_line":"        install_package docker.io"},{"line_number":64,"context_line":"        start_service docker"},{"line_number":65,"context_line":"        add_user_to_group $STACK_USER docker"},{"line_number":66,"context_line":"        sg docker -c \"docker run -d --name jaeger -e COLLECTOR_ZIPKIN_HOST_PORT\u003d:9411 -e COLLECTOR_OTLP_ENABLED\u003dtrue -p 6831:6831/udp -p 6832:6832/udp -p 5778:5778 -p 16686:16686 -p 4317:4317 -p 4318:4318 -p 14250:14250 -p 14268:14268 -p 14269:14269 -p 9411:9411 jaegertracing/all-in-one:1.42\""},{"line_number":67,"context_line":"    else"},{"line_number":68,"context_line":"        exit_distro_not_supported \"docker.io installation\""},{"line_number":69,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":8,"id":"5c668555_2190ee00","line":66,"range":{"start_line":66,"start_character":117,"end_line":66,"end_character":262},"in_reply_to":"292250a1_8d3d36b1","updated":"2023-04-03 09:28:48.000000000","message":"Done\n\nThis totally agree.","commit_id":"3806038dab03249b3040030b538ef01289dbd92e"}],"devstack/plugin.sh":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"484949c08f30807ba41f8704979f66ce8a89fc98","unresolved":true,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"elif [[ \"$1\" \u003d\u003d \"unstack\" ]]; then"},{"line_number":23,"context_line":"    if [[ \"$OSPROFILER_COLLECTOR\" \u003d\u003d \"jaeger\" || \\"},{"line_number":24,"context_line":"\t      \"$OSPROFILER_COLLECTOR\" \u003d\u003d \"jaeger+otlp\" ]]; then"},{"line_number":25,"context_line":"        echo_summary \"Deleting jaeger docker container\""},{"line_number":26,"context_line":"        drop_jaeger"},{"line_number":27,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":9,"id":"15e3039f_fc78db15","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":1},"updated":"2023-04-11 11:25:48.000000000","message":"replace tab by spaces","commit_id":"4a4a13e7a996b081b70561e502e01cc221c60292"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"ef900103ff512019801a41bfbac74bc0dab35a09","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"elif [[ \"$1\" \u003d\u003d \"unstack\" ]]; then"},{"line_number":23,"context_line":"    if [[ \"$OSPROFILER_COLLECTOR\" \u003d\u003d \"jaeger\" || \\"},{"line_number":24,"context_line":"\t      \"$OSPROFILER_COLLECTOR\" \u003d\u003d \"jaeger+otlp\" ]]; then"},{"line_number":25,"context_line":"        echo_summary \"Deleting jaeger docker container\""},{"line_number":26,"context_line":"        drop_jaeger"},{"line_number":27,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":9,"id":"6dd74487_320d8b82","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":1},"in_reply_to":"15e3039f_fc78db15","updated":"2023-05-03 09:08:46.000000000","message":"Done","commit_id":"4a4a13e7a996b081b70561e502e01cc221c60292"}],"osprofiler/drivers/jaeger_otlp.py":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"d35587df85b2a9ebf2e6f8b4d68817ec68af439e","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright 2018 Fujitsu Ltd."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"291b2d53_a68f83f8","line":1,"updated":"2023-03-14 11:47:35.000000000","message":"This is not right. I will remove it.","commit_id":"234a286ac741db5b6463e18ef9335176d8d2d8a7"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"efbeb795c74a4e48625a8c589bf7f4440ff1125d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2018 Fujitsu Ltd."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":1,"id":"eecf4c93_c0b27112","line":1,"in_reply_to":"291b2d53_a68f83f8","updated":"2023-03-30 08:53:20.000000000","message":"Done","commit_id":"234a286ac741db5b6463e18ef9335176d8d2d8a7"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"484949c08f30807ba41f8704979f66ce8a89fc98","unresolved":true,"context_lines":[{"line_number":22,"context_line":"from osprofiler import exc"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class JaegerOTLP(jaeger.Jaeger):"},{"line_number":26,"context_line":"    def __init__(self, connection_str, project\u003dNone, service\u003dNone, host\u003dNone,"},{"line_number":27,"context_line":"                 conf\u003dcfg.CONF, **kwargs):"},{"line_number":28,"context_line":"        \"\"\"Jaeger driver using OTLP exporters driver for OSProfiler.\"\"\""}],"source_content_type":"text/x-python","patch_set":9,"id":"44997333_0986793e","line":25,"range":{"start_line":25,"start_character":6,"end_line":25,"end_character":16},"updated":"2023-04-11 11:25:48.000000000","message":"Please correct me if I\u0027m wrong but IIUC OTLP is a generic protocol and the current implementation does not really look specific to Jaeger and can work with software which supports OTLP. Then can this be just OTPL driver instead of JaegerOTLP driver ?\n\nIf we can make this OLTP driver then we probably should not make this inherit the Jaeger driver. The current implementation cuases some confusions (eg __init__ does not call super.__init__)","commit_id":"4a4a13e7a996b081b70561e502e01cc221c60292"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"e62c535468059e4472eee226d357d98aed0abaa3","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from osprofiler import exc"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class JaegerOTLP(jaeger.Jaeger):"},{"line_number":26,"context_line":"    def __init__(self, connection_str, project\u003dNone, service\u003dNone, host\u003dNone,"},{"line_number":27,"context_line":"                 conf\u003dcfg.CONF, **kwargs):"},{"line_number":28,"context_line":"        \"\"\"Jaeger driver using OTLP exporters driver for OSProfiler.\"\"\""}],"source_content_type":"text/x-python","patch_set":9,"id":"85304341_800ddfc0","line":25,"range":{"start_line":25,"start_character":6,"end_line":25,"end_character":16},"in_reply_to":"44997333_0986793e","updated":"2023-04-29 18:40:00.000000000","message":"Done","commit_id":"4a4a13e7a996b081b70561e502e01cc221c60292"}],"osprofiler/drivers/otlp.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5d6091106c17bd42480a05f7d8e9568f2b5410fc","unresolved":true,"context_lines":[{"line_number":26,"context_line":"class OTLP(base.Driver):"},{"line_number":27,"context_line":"    def __init__(self, connection_str, project\u003dNone, service\u003dNone, host\u003dNone,"},{"line_number":28,"context_line":"                 conf\u003dcfg.CONF, **kwargs):"},{"line_number":29,"context_line":"        \"\"\"OTLP driver using OTLP exporters.\"\"\""},{"line_number":30,"context_line":"        try:"},{"line_number":31,"context_line":"            from opentelemetry import trace as trace_api"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"5a589ab5_f44ccc24","line":29,"updated":"2023-05-09 10:42:13.000000000","message":"I understand this is not useful because this driver does not inherit implementatios from base but we may want to call __init__ of parent to make sure we initialize the common implementations.\n\n```\n    super(OTLP, self).__init__(connection_str, project\u003dproject, \n                               service\u003dservice, host\u003dhost,\n                               conf\u003dconf, **kwargs)\n```","commit_id":"6f0a46a0b559ba45513e9646a5b2a40d7ca74759"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"7a9095d3020beecf51619d6041492da8bcf5fabf","unresolved":true,"context_lines":[{"line_number":26,"context_line":"class OTLP(base.Driver):"},{"line_number":27,"context_line":"    def __init__(self, connection_str, project\u003dNone, service\u003dNone, host\u003dNone,"},{"line_number":28,"context_line":"                 conf\u003dcfg.CONF, **kwargs):"},{"line_number":29,"context_line":"        \"\"\"OTLP driver using OTLP exporters.\"\"\""},{"line_number":30,"context_line":"        try:"},{"line_number":31,"context_line":"            from opentelemetry import trace as trace_api"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"e98cc7e9_82e06979","line":29,"in_reply_to":"5a589ab5_f44ccc24","updated":"2023-05-10 08:17:04.000000000","message":"yes that makes sense. Give me a moment to fix it.","commit_id":"6f0a46a0b559ba45513e9646a5b2a40d7ca74759"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"0eb845ebad6acd38cb5fb4348556a25677652170","unresolved":false,"context_lines":[{"line_number":26,"context_line":"class OTLP(base.Driver):"},{"line_number":27,"context_line":"    def __init__(self, connection_str, project\u003dNone, service\u003dNone, host\u003dNone,"},{"line_number":28,"context_line":"                 conf\u003dcfg.CONF, **kwargs):"},{"line_number":29,"context_line":"        \"\"\"OTLP driver using OTLP exporters.\"\"\""},{"line_number":30,"context_line":"        try:"},{"line_number":31,"context_line":"            from opentelemetry import trace as trace_api"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"d07ac96c_ff6bff03","line":29,"in_reply_to":"e98cc7e9_82e06979","updated":"2023-05-10 09:41:18.000000000","message":"Done","commit_id":"6f0a46a0b559ba45513e9646a5b2a40d7ca74759"}],"releasenotes/notes/otlp-driver-for-jaeger-tracing-cb932038ad580ac2.yaml":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"ed31ea101e873b7d26eebcb9d33ac434a20678fd","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    An OTLP (OpenTelemetry) exporter for Jaeger tracing is now supported. The"},{"line_number":5,"context_line":"    current support is experimental but the aim is to deprecate and"},{"line_number":6,"context_line":"    remove legacy Jaeger driver which is using the already deprecated"},{"line_number":7,"context_line":"    python library jaeger client. Operators who want to use it should"},{"line_number":8,"context_line":"    enable `jaeger+otlp`."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"fb9a54f8_94451661","line":8,"range":{"start_line":4,"start_character":4,"end_line":8,"end_character":25},"updated":"2023-03-30 09:19:31.000000000","message":"All these changes LGTM although I\u0027m not a jagger expert, however, I\u0027d appreciate to see more documentations here, to give more help to operators who want to enable it, example with some collectors docs: https://docs.openstack.org/osprofiler/latest/user/collectors.html\n\nPlease can you add some related documentation here?\n\nThanks in advance.","commit_id":"3806038dab03249b3040030b538ef01289dbd92e"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"689fb5a2fe8c104a49d9f74765b65e46b2e12778","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    An OTLP (OpenTelemetry) exporter for Jaeger tracing is now supported. The"},{"line_number":5,"context_line":"    current support is experimental but the aim is to deprecate and"},{"line_number":6,"context_line":"    remove legacy Jaeger driver which is using the already deprecated"},{"line_number":7,"context_line":"    python library jaeger client. Operators who want to use it should"},{"line_number":8,"context_line":"    enable `jaeger+otlp`."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"272085b5_f3d9b5d9","line":8,"range":{"start_line":4,"start_character":4,"end_line":8,"end_character":25},"in_reply_to":"fb9a54f8_94451661","updated":"2023-04-03 09:28:48.000000000","message":"++","commit_id":"3806038dab03249b3040030b538ef01289dbd92e"}]}