)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"6e0b9433a5de9e97f23424d6f9bdcdfc99f698ee","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"devstack: remove jaeger container on unstack"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Let\u0027s remove the docker container creater with Jaeger Tracing when"},{"line_number":10,"context_line":"unstacking."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Signed-off-by: Sahid Orentino Ferdjaoui \u003csahid.ferdjaoui@industrialdiscipline.com\u003e"},{"line_number":13,"context_line":"Change-Id: I785c7b23be92eb5bc4da0366f705a77c3910d5c2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"cd55b976_d06cd5a6","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":11},"updated":"2023-03-21 12:09:32.000000000","message":"Hello,\n\nWhy is this needed?\nThis patch doesn\u0027t really reflect why we should remove the docker container when we unstack. Please can you explain that point into this commit message.\n\nAlso I\u0027d suggest adding a release note explaining these changes.\n\nThanks","commit_id":"6298f62c21e31c730c59b869b8798a6f9d693c20"},{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"472d4d5447efb91f59f7272e6352b1d14a55b0b9","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"devstack: remove jaeger container on unstack"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Let\u0027s remove the docker container creater with Jaeger Tracing when"},{"line_number":10,"context_line":"unstacking."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Signed-off-by: Sahid Orentino Ferdjaoui \u003csahid.ferdjaoui@industrialdiscipline.com\u003e"},{"line_number":13,"context_line":"Change-Id: I785c7b23be92eb5bc4da0366f705a77c3910d5c2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"d5d18675_cc5484d6","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":11},"in_reply_to":"cd55b976_d06cd5a6","updated":"2023-03-21 13:10:05.000000000","message":"Sure I have updated the commit message and added a reno note.\n\nEach time that I had to recreate my devstack env the process failed because the container was already running. I had to drop it manually and restart the process.\n\nI think it\u0027s cleaner like that but I\u0027m open to any other idea :-)","commit_id":"6298f62c21e31c730c59b869b8798a6f9d693c20"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"d4165aba16e6ac1dc29948551f2c8355b53ac451","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"devstack: remove jaeger container on unstack"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Let\u0027s remove the docker container creater with Jaeger Tracing when"},{"line_number":10,"context_line":"unstacking."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Signed-off-by: Sahid Orentino Ferdjaoui \u003csahid.ferdjaoui@industrialdiscipline.com\u003e"},{"line_number":13,"context_line":"Change-Id: I785c7b23be92eb5bc4da0366f705a77c3910d5c2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1a2a6727_09d38020","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":11},"in_reply_to":"d5d18675_cc5484d6","updated":"2023-03-23 07:43:03.000000000","message":"Excellent! Thank you","commit_id":"6298f62c21e31c730c59b869b8798a6f9d693c20"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f9406ec0703a05df1d12042710da356bea02f287","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"97b38b08_21c3acbe","updated":"2023-03-23 09:38:40.000000000","message":"minor format problem. the other parts look good to me.","commit_id":"71cac386ddf048a820adf762467d707582ec787c"},{"author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"change_message_id":"0ef6adf0a8c81f2998f39e028dd740e9b948ec99","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7b3d9862_ebbaac2b","updated":"2023-03-23 16:16:23.000000000","message":"LGTM, indeed I see the tabs during my previous review but I missed to comment about them, sorry.","commit_id":"52246cfbf667f70dcfb1a019fcbc6aee021fe8b1"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"64aebf1ceff1daa4416912a4cb0ac97a3d06f882","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d4f5c808_01da75a7","updated":"2023-03-23 13:33:21.000000000","message":"Looks better. thanks !","commit_id":"52246cfbf667f70dcfb1a019fcbc6aee021fe8b1"}],"devstack/plugin.sh":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f9406ec0703a05df1d12042710da356bea02f287","unresolved":true,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"elif [[ \"$1\" \u003d\u003d \"unstack\" ]]; then"},{"line_number":23,"context_line":"    if [ \"$OSPROFILER_COLLECTOR\" \u003d\u003d \"jaeger\" ]; then"},{"line_number":24,"context_line":"\techo_summary \"Deleting jaeger docker container\""},{"line_number":25,"context_line":"\tdrop_jaeger"},{"line_number":26,"context_line":"    fi"},{"line_number":27,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":2,"id":"07d476d5_84ebd3e7","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":1},"updated":"2023-03-23 09:38:40.000000000","message":"Use spaces instead of tabs","commit_id":"71cac386ddf048a820adf762467d707582ec787c"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"64aebf1ceff1daa4416912a4cb0ac97a3d06f882","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"elif [[ \"$1\" \u003d\u003d \"unstack\" ]]; then"},{"line_number":23,"context_line":"    if [ \"$OSPROFILER_COLLECTOR\" \u003d\u003d \"jaeger\" ]; then"},{"line_number":24,"context_line":"\techo_summary \"Deleting jaeger docker container\""},{"line_number":25,"context_line":"\tdrop_jaeger"},{"line_number":26,"context_line":"    fi"},{"line_number":27,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":2,"id":"b94e0cc1_702b3868","line":24,"range":{"start_line":24,"start_character":0,"end_line":24,"end_character":1},"in_reply_to":"07d476d5_84ebd3e7","updated":"2023-03-23 13:33:21.000000000","message":"Done","commit_id":"71cac386ddf048a820adf762467d707582ec787c"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f9406ec0703a05df1d12042710da356bea02f287","unresolved":true,"context_lines":[{"line_number":22,"context_line":"elif [[ \"$1\" \u003d\u003d \"unstack\" ]]; then"},{"line_number":23,"context_line":"    if [ \"$OSPROFILER_COLLECTOR\" \u003d\u003d \"jaeger\" ]; then"},{"line_number":24,"context_line":"\techo_summary \"Deleting jaeger docker container\""},{"line_number":25,"context_line":"\tdrop_jaeger"},{"line_number":26,"context_line":"    fi"},{"line_number":27,"context_line":"fi"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"8df851da_b670845f","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":1},"updated":"2023-03-23 09:38:40.000000000","message":"ditto","commit_id":"71cac386ddf048a820adf762467d707582ec787c"}]}