)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"aba2f76095ebe33008d63870996f9b82eac0e3e5","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Eunkyung99 \u003cek121.kim@samsung.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-11-25 15:44:18 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix condition of otlp driver\u0027s notify attributes setting"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As KeyError Exception occurs when otlp exporter sets result attribute from \"db\" or \"function\" data, add checking \"result\" key in data before setting attribute."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"0fabac1a_75e93caa","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":56},"updated":"2025-11-25 14:02:36.000000000","message":"Please describe the problem, not the implementation part, you are fixing. For example\n\n\notlp: Fix KeyError in db access errors","commit_id":"410170b5186de9c34dfd4124754b8c7965480c31"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e003c76d5f8e4b9006f19fb6fc55776045a7ecd4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Eunkyung99 \u003cek121.kim@samsung.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2025-11-25 15:44:18 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix condition of otlp driver\u0027s notify attributes setting"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As KeyError Exception occurs when otlp exporter sets result attribute from \"db\" or \"function\" data, add checking \"result\" key in data before setting attribute."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"891574c2_0ce8e702","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":56},"in_reply_to":"0fabac1a_75e93caa","updated":"2026-02-26 23:08:03.000000000","message":"Done","commit_id":"410170b5186de9c34dfd4124754b8c7965480c31"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"aba2f76095ebe33008d63870996f9b82eac0e3e5","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix condition of otlp driver\u0027s notify attributes setting"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As KeyError Exception occurs when otlp exporter sets result attribute from \"db\" or \"function\" data, add checking \"result\" key in data before setting attribute."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Closes-Bug: 2132372"},{"line_number":12,"context_line":"Change-Id: If033865f1ebf79aa38e75fb26b55943b633186e9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"30f80723_a7426ba4","line":9,"updated":"2025-11-25 14:02:36.000000000","message":"Please wrap lines by 72 characters.\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"410170b5186de9c34dfd4124754b8c7965480c31"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"aba2f76095ebe33008d63870996f9b82eac0e3e5","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix condition of otlp driver\u0027s notify attributes setting"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As KeyError Exception occurs when otlp exporter sets result attribute from \"db\" or \"function\" data, add checking \"result\" key in data before setting attribute."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Closes-Bug: 2132372"},{"line_number":12,"context_line":"Change-Id: If033865f1ebf79aa38e75fb26b55943b633186e9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1e537701_220f1f8d","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":159},"updated":"2025-11-25 14:02:36.000000000","message":"This fixes the mechanism of the problem but has no real information about the actual trigger. Please update the commit message to describe it. For example;\n\nFix key error caused by sqlalchemy error, which generates a \"db\" data without \"result\" key. Also fix a similar problem found in the \"function\" data.","commit_id":"410170b5186de9c34dfd4124754b8c7965480c31"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e003c76d5f8e4b9006f19fb6fc55776045a7ecd4","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix condition of otlp driver\u0027s notify attributes setting"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As KeyError Exception occurs when otlp exporter sets result attribute from \"db\" or \"function\" data, add checking \"result\" key in data before setting attribute."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Closes-Bug: 2132372"},{"line_number":12,"context_line":"Change-Id: If033865f1ebf79aa38e75fb26b55943b633186e9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"e21a4861_4b7b2381","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":159},"in_reply_to":"1e537701_220f1f8d","updated":"2026-02-26 23:08:03.000000000","message":"Done","commit_id":"410170b5186de9c34dfd4124754b8c7965480c31"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e003c76d5f8e4b9006f19fb6fc55776045a7ecd4","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix condition of otlp driver\u0027s notify attributes setting"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As KeyError Exception occurs when otlp exporter sets result attribute from \"db\" or \"function\" data, add checking \"result\" key in data before setting attribute."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Closes-Bug: 2132372"},{"line_number":12,"context_line":"Change-Id: If033865f1ebf79aa38e75fb26b55943b633186e9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"8a692666_f4fb2f00","line":9,"in_reply_to":"30f80723_a7426ba4","updated":"2026-02-26 23:08:03.000000000","message":"Done","commit_id":"410170b5186de9c34dfd4124754b8c7965480c31"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3094c59a473357507beb03c4fe0e154aa9a11e91","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3cc432b7_9925e796","updated":"2025-11-25 06:00:52.000000000","message":"Looking at the code it seems even function type omits result when the function fails or hide_result is True. So I think the better approach here is to update otlp driver to omit result if the key does not present.","commit_id":"c7ffa69ac868ddaa3b5275e1cf714194f7890a59"},{"author":{"_account_id":36741,"name":"Eunkyung Kim","display_name":"eunkyung","email":"ek121.kim@samsung.com","username":"eunkyung"},"change_message_id":"ea535267ad0b7dc1637b68cf67d3345ab9736c21","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3b20f07b_535871d7","in_reply_to":"3cc432b7_9925e796","updated":"2025-11-25 06:25:22.000000000","message":"Thank you for review. I only thought about db fails, but as you said, I also think it\u0027s a driver bug. I will fix it.","commit_id":"c7ffa69ac868ddaa3b5275e1cf714194f7890a59"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"af14dfcce493bab3795cdc4182bc629722c35cc8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d940f5bd_ab17870c","updated":"2025-11-25 14:03:49.000000000","message":"The code change looks good at my first glance. Ideally we need unit test cases but I noticed that we have almost zero coverage about test data so I\u0027m ok with leaving that for follow-up.\n\n-1 due to a few problems with the commit message. Please see my comments inline.","commit_id":"410170b5186de9c34dfd4124754b8c7965480c31"},{"author":{"_account_id":36741,"name":"Eunkyung Kim","display_name":"eunkyung","email":"ek121.kim@samsung.com","username":"eunkyung"},"change_message_id":"000f4025471454647f9ea046fe8e00cfc8db48d4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8e6a55b2_73e22fa2","in_reply_to":"d940f5bd_ab17870c","updated":"2025-11-26 01:37:02.000000000","message":"I changed the commit message, and I also added few test cases for notify function.","commit_id":"410170b5186de9c34dfd4124754b8c7965480c31"}]}