)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"15f5e971388d03d41f26262ababdeb4dc07f4f9a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Create root span in the otlp driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1. Create root span if base_id and parent_id are the same."},{"line_number":10,"context_line":"2. Use base_id from the payload instead of the context"},{"line_number":11,"context_line":"   when initializing the span."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #2132957"},{"line_number":14,"context_line":"Change-Id: I1388751db9a36011eb222d18c503a217197ce4f3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"e395dd08_38731044","line":11,"range":{"start_line":10,"start_character":0,"end_line":11,"end_character":30},"updated":"2026-03-29 17:48:26.000000000","message":"This isn\u0027t really a behavior change. It\u0027s not even necessary either, if we first define trace id.","commit_id":"d980098f67b52e453a0e157e5534eaaa41edb28f"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":35657,"name":"LeeChunghwan","display_name":"chung00.lee","email":"chung00.lee@samsung.com","username":"chung00.lee"},"change_message_id":"b7d9a93840d39d2fa6f0795088cc804c2fb71272","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d2b39e0e_a4223f9f","updated":"2026-03-09 04:26:16.000000000","message":"I have submitted a patch to create root span when using the OTLP driver.\nCould you please review it?\n\nThank you.","commit_id":"851be0b663b80e21254c23b1bf7e5d5047a17377"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1aec67ed6e917b1718b6e8aeb2955bc45f7eadb2","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"52ba5e09_d072167b","updated":"2026-03-09 07:24:08.000000000","message":"I wonder if we could also update `osprofiler/tests/unit/drivers/test_otlp.py` to verify the proposed change ? I understand the existing unit test cases do not inspect the span instance but I think that\u0027s useful to make sure we won\u0027t break this behavior.","commit_id":"851be0b663b80e21254c23b1bf7e5d5047a17377"},{"author":{"_account_id":35657,"name":"LeeChunghwan","display_name":"chung00.lee","email":"chung00.lee@samsung.com","username":"chung00.lee"},"change_message_id":"87261e0d367d073d41f94516ce4faedd07c6203b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2d8cf407_00efc9c7","in_reply_to":"52ba5e09_d072167b","updated":"2026-03-18 04:53:15.000000000","message":"Thank you for the review. I added the test cases for the span instance.","commit_id":"851be0b663b80e21254c23b1bf7e5d5047a17377"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"989a957c830586e52b7b6c83621876b56aacbb29","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d4400a0b_a072ce87","updated":"2026-03-18 11:12:03.000000000","message":"Soft -1. I\u0027d just like a little more context here.","commit_id":"85926c389223e7c0dac4487cbfc995635e64b6ad"},{"author":{"_account_id":35657,"name":"LeeChunghwan","display_name":"chung00.lee","email":"chung00.lee@samsung.com","username":"chung00.lee"},"change_message_id":"4e0f2a07dc3f1eb7b092ea8498f1c79fe228f3bc","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"321cec22_f3210dce","updated":"2026-03-19 05:07:26.000000000","message":"I added comment to the branch and included the bug fix details in the commit message.","commit_id":"d980098f67b52e453a0e157e5534eaaa41edb28f"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"bd6fc1124663b230b9728579feca9164f4ca0e3e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3a28d5d9_ad54f535","updated":"2026-03-19 10:58:36.000000000","message":"Will leave +W to @kajinamit@oss.nttdata.com","commit_id":"d980098f67b52e453a0e157e5534eaaa41edb28f"},{"author":{"_account_id":35657,"name":"LeeChunghwan","display_name":"chung00.lee","email":"chung00.lee@samsung.com","username":"chung00.lee"},"change_message_id":"182a0eb1927c35ac519de8aa11ee4ebc803c397c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"63cc4c20_20697fe2","updated":"2026-03-31 08:13:17.000000000","message":"It seems the new patch set cleared your vote. Could you please re-approve this?\nto @kajinamit@oss.nttdata.com","commit_id":"46df220b13bb4f5565564a3a61c832ddebd40d11"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"f691187e4bb0de677d96f94a6659276f0748b450","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d8c2dc03_104d7822","updated":"2026-03-29 17:52:48.000000000","message":"Made a minor adjustment to generate trace_id once.","commit_id":"46df220b13bb4f5565564a3a61c832ddebd40d11"}],"osprofiler/drivers/otlp.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"989a957c830586e52b7b6c83621876b56aacbb29","unresolved":true,"context_lines":[{"line_number":120,"context_line":"        payload \u003d info"},{"line_number":121,"context_line":"        if payload[\"name\"].endswith(\"start\"):"},{"line_number":122,"context_line":"            ctx \u003d None"},{"line_number":123,"context_line":"            if payload[\"base_id\"] !\u003d payload[\"parent_id\"]:"},{"line_number":124,"context_line":"                parent \u003d self.trace_api.SpanContext("},{"line_number":125,"context_line":"                    trace_id\u003dutils.uuid_to_int128(payload[\"base_id\"]),"},{"line_number":126,"context_line":"                    span_id\u003dutils.shorten_id(payload[\"parent_id\"]),"}],"source_content_type":"text/x-python","patch_set":3,"id":"82465e37_7648fac7","line":123,"updated":"2026-03-18 11:12:03.000000000","message":"Could you add a comment here explaining why this branch is needed? Something like the below? Feel free to reword as you see fit.\n\n\n```suggestion\n            if payload[\"base_id\"] !\u003d payload[\"parent_id\"]:\n                # only non-root spans should have a parent span and context\n```","commit_id":"85926c389223e7c0dac4487cbfc995635e64b6ad"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"bd6fc1124663b230b9728579feca9164f4ca0e3e","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        payload \u003d info"},{"line_number":121,"context_line":"        if payload[\"name\"].endswith(\"start\"):"},{"line_number":122,"context_line":"            ctx \u003d None"},{"line_number":123,"context_line":"            if payload[\"base_id\"] !\u003d payload[\"parent_id\"]:"},{"line_number":124,"context_line":"                parent \u003d self.trace_api.SpanContext("},{"line_number":125,"context_line":"                    trace_id\u003dutils.uuid_to_int128(payload[\"base_id\"]),"},{"line_number":126,"context_line":"                    span_id\u003dutils.shorten_id(payload[\"parent_id\"]),"}],"source_content_type":"text/x-python","patch_set":3,"id":"90797b03_c304120c","line":123,"in_reply_to":"82465e37_7648fac7","updated":"2026-03-19 10:58:36.000000000","message":"Done","commit_id":"85926c389223e7c0dac4487cbfc995635e64b6ad"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"989a957c830586e52b7b6c83621876b56aacbb29","unresolved":true,"context_lines":[{"line_number":143,"context_line":"            )"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"            span._context \u003d self.trace_api.SpanContext(  # type: ignore[attr-defined]"},{"line_number":146,"context_line":"                trace_id\u003dutils.uuid_to_int128(payload[\"base_id\"]),"},{"line_number":147,"context_line":"                span_id\u003dutils.shorten_id(payload[\"trace_id\"]),"},{"line_number":148,"context_line":"                is_remote\u003dspan.context.is_remote,  # type: ignore[attr-defined]"},{"line_number":149,"context_line":"                trace_flags\u003dspan.context.trace_flags,  # type: ignore[attr-defined]"}],"source_content_type":"text/x-python","patch_set":3,"id":"b2747de3_eddf795f","line":146,"updated":"2026-03-18 11:12:03.000000000","message":"This looks like a separate (albeit correct) bug fix. Might be worth calling this out in the commit message?","commit_id":"85926c389223e7c0dac4487cbfc995635e64b6ad"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"bd6fc1124663b230b9728579feca9164f4ca0e3e","unresolved":false,"context_lines":[{"line_number":143,"context_line":"            )"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"            span._context \u003d self.trace_api.SpanContext(  # type: ignore[attr-defined]"},{"line_number":146,"context_line":"                trace_id\u003dutils.uuid_to_int128(payload[\"base_id\"]),"},{"line_number":147,"context_line":"                span_id\u003dutils.shorten_id(payload[\"trace_id\"]),"},{"line_number":148,"context_line":"                is_remote\u003dspan.context.is_remote,  # type: ignore[attr-defined]"},{"line_number":149,"context_line":"                trace_flags\u003dspan.context.trace_flags,  # type: ignore[attr-defined]"}],"source_content_type":"text/x-python","patch_set":3,"id":"6874ec6d_32543020","line":146,"in_reply_to":"b2747de3_eddf795f","updated":"2026-03-19 10:58:36.000000000","message":"Done","commit_id":"85926c389223e7c0dac4487cbfc995635e64b6ad"}]}
