)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"394a6901d766ff5d9bb437888465f59253f4f88c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ff75bc52_b121eaef","updated":"2023-05-10 16:50:35.000000000","message":"A few comments inline.","commit_id":"f84e12955e5620d3ba718c7d536eca6c7bf77f5e"}],"ossa/OSSA-2023-003.yaml":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"23fabfbe51bdf78de8e5fdc9a200411beadf6cd8","unresolved":true,"context_lines":[{"line_number":39,"context_line":"  Configuration Change"},{"line_number":40,"context_line":"  --------------------"},{"line_number":41,"context_line":"  To prevent the intentional case, the Block Storage API provided by"},{"line_number":42,"context_line":"  Cinder must accept only from Nova attachment delete requests for"},{"line_number":43,"context_line":"  instance-attached volumes. A complicating factor is that Nova"},{"line_number":44,"context_line":"  deletes an attachment by making a call to the Block Storage API on"},{"line_number":45,"context_line":"  behalf of the user (that is, by passing the user\u0027s token), which"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"81425e41_4a45ed03","line":42,"range":{"start_line":42,"start_character":9,"end_line":42,"end_character":62},"updated":"2023-05-10 16:38:53.000000000","message":"Reading this now, I think it should be:\n\n\"Cinder must only accept attachment delete requests from Nova for instance-attached volumes\"","commit_id":"f84e12955e5620d3ba718c7d536eca6c7bf77f5e"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"394a6901d766ff5d9bb437888465f59253f4f88c","unresolved":true,"context_lines":[{"line_number":39,"context_line":"  Configuration Change"},{"line_number":40,"context_line":"  --------------------"},{"line_number":41,"context_line":"  To prevent the intentional case, the Block Storage API provided by"},{"line_number":42,"context_line":"  Cinder must accept only from Nova attachment delete requests for"},{"line_number":43,"context_line":"  instance-attached volumes. A complicating factor is that Nova"},{"line_number":44,"context_line":"  deletes an attachment by making a call to the Block Storage API on"},{"line_number":45,"context_line":"  behalf of the user (that is, by passing the user\u0027s token), which"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"fce82d5f_8ac7f1c9","line":42,"range":{"start_line":42,"start_character":9,"end_line":42,"end_character":62},"in_reply_to":"81425e41_4a45ed03","updated":"2023-05-10 16:50:35.000000000","message":"Agree, Dan\u0027s suggestion reads better.","commit_id":"f84e12955e5620d3ba718c7d536eca6c7bf77f5e"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"bc62242e21e6092d85d8304d0b0fb243f992cd18","unresolved":false,"context_lines":[{"line_number":39,"context_line":"  Configuration Change"},{"line_number":40,"context_line":"  --------------------"},{"line_number":41,"context_line":"  To prevent the intentional case, the Block Storage API provided by"},{"line_number":42,"context_line":"  Cinder must accept only from Nova attachment delete requests for"},{"line_number":43,"context_line":"  instance-attached volumes. A complicating factor is that Nova"},{"line_number":44,"context_line":"  deletes an attachment by making a call to the Block Storage API on"},{"line_number":45,"context_line":"  behalf of the user (that is, by passing the user\u0027s token), which"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"a77773ac_7406a85d","line":42,"range":{"start_line":42,"start_character":9,"end_line":42,"end_character":62},"in_reply_to":"81425e41_4a45ed03","updated":"2023-05-10 16:55:05.000000000","message":"Done","commit_id":"f84e12955e5620d3ba718c7d536eca6c7bf77f5e"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3c04cd133c151d4a6271b288a4f12b5bf8f9b4c2","unresolved":false,"context_lines":[{"line_number":39,"context_line":"  Configuration Change"},{"line_number":40,"context_line":"  --------------------"},{"line_number":41,"context_line":"  To prevent the intentional case, the Block Storage API provided by"},{"line_number":42,"context_line":"  Cinder must accept only from Nova attachment delete requests for"},{"line_number":43,"context_line":"  instance-attached volumes. A complicating factor is that Nova"},{"line_number":44,"context_line":"  deletes an attachment by making a call to the Block Storage API on"},{"line_number":45,"context_line":"  behalf of the user (that is, by passing the user\u0027s token), which"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"23141faa_2e8351da","line":42,"range":{"start_line":42,"start_character":9,"end_line":42,"end_character":62},"in_reply_to":"fce82d5f_8ac7f1c9","updated":"2023-05-10 16:58:11.000000000","message":"Done","commit_id":"f84e12955e5620d3ba718c7d536eca6c7bf77f5e"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"23fabfbe51bdf78de8e5fdc9a200411beadf6cd8","unresolved":true,"context_lines":[{"line_number":56,"context_line":"  Patches and Associated Deployment Changes"},{"line_number":57,"context_line":"  -----------------------------------------"},{"line_number":58,"context_line":"  Given the above analysis, a thorough fix must include the following"},{"line_number":59,"context_line":"  elements..."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"  1. The os-brick library must implement the ``force`` option, which"},{"line_number":62,"context_line":"     has only been available for iSCSI, for fibre channel (covered by"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"d948ba4e_924fd6ef","line":59,"range":{"start_line":59,"start_character":10,"end_line":59,"end_character":13},"updated":"2023-05-10 16:38:53.000000000","message":"Probably a colon here","commit_id":"f84e12955e5620d3ba718c7d536eca6c7bf77f5e"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3c04cd133c151d4a6271b288a4f12b5bf8f9b4c2","unresolved":false,"context_lines":[{"line_number":56,"context_line":"  Patches and Associated Deployment Changes"},{"line_number":57,"context_line":"  -----------------------------------------"},{"line_number":58,"context_line":"  Given the above analysis, a thorough fix must include the following"},{"line_number":59,"context_line":"  elements..."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"  1. The os-brick library must implement the ``force`` option, which"},{"line_number":62,"context_line":"     has only been available for iSCSI, for fibre channel (covered by"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"a02e688b_792ef76d","line":59,"range":{"start_line":59,"start_character":10,"end_line":59,"end_character":13},"in_reply_to":"d948ba4e_924fd6ef","updated":"2023-05-10 16:58:11.000000000","message":"Done","commit_id":"f84e12955e5620d3ba718c7d536eca6c7bf77f5e"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"bc62242e21e6092d85d8304d0b0fb243f992cd18","unresolved":false,"context_lines":[{"line_number":56,"context_line":"  Patches and Associated Deployment Changes"},{"line_number":57,"context_line":"  -----------------------------------------"},{"line_number":58,"context_line":"  Given the above analysis, a thorough fix must include the following"},{"line_number":59,"context_line":"  elements..."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"  1. The os-brick library must implement the ``force`` option, which"},{"line_number":62,"context_line":"     has only been available for iSCSI, for fibre channel (covered by"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"f194391d_969e1f95","line":59,"range":{"start_line":59,"start_character":10,"end_line":59,"end_character":13},"in_reply_to":"d948ba4e_924fd6ef","updated":"2023-05-10 16:55:05.000000000","message":"Done","commit_id":"f84e12955e5620d3ba718c7d536eca6c7bf77f5e"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"23fabfbe51bdf78de8e5fdc9a200411beadf6cd8","unresolved":true,"context_lines":[{"line_number":58,"context_line":"  Given the above analysis, a thorough fix must include the following"},{"line_number":59,"context_line":"  elements..."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"  1. The os-brick library must implement the ``force`` option, which"},{"line_number":62,"context_line":"     has only been available for iSCSI, for fibre channel (covered by"},{"line_number":63,"context_line":"     included patches)."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"  2. Nova must call os-brick with the ``force`` option when"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"09918869_d7dc538f","line":62,"range":{"start_line":61,"start_character":63,"end_line":62,"end_character":57},"updated":"2023-05-10 16:38:53.000000000","message":"Probably better to rearrange these as it\u0027s confusing:\n\n\"for fibre channel, which has only been available for iSCSI until now (covered...\"","commit_id":"f84e12955e5620d3ba718c7d536eca6c7bf77f5e"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3c04cd133c151d4a6271b288a4f12b5bf8f9b4c2","unresolved":false,"context_lines":[{"line_number":58,"context_line":"  Given the above analysis, a thorough fix must include the following"},{"line_number":59,"context_line":"  elements..."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"  1. The os-brick library must implement the ``force`` option, which"},{"line_number":62,"context_line":"     has only been available for iSCSI, for fibre channel (covered by"},{"line_number":63,"context_line":"     included patches)."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"  2. Nova must call os-brick with the ``force`` option when"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"1c21c8d4_98311b75","line":62,"range":{"start_line":61,"start_character":63,"end_line":62,"end_character":57},"in_reply_to":"09918869_d7dc538f","updated":"2023-05-10 16:58:11.000000000","message":"Done","commit_id":"f84e12955e5620d3ba718c7d536eca6c7bf77f5e"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"bc62242e21e6092d85d8304d0b0fb243f992cd18","unresolved":false,"context_lines":[{"line_number":58,"context_line":"  Given the above analysis, a thorough fix must include the following"},{"line_number":59,"context_line":"  elements..."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"  1. The os-brick library must implement the ``force`` option, which"},{"line_number":62,"context_line":"     has only been available for iSCSI, for fibre channel (covered by"},{"line_number":63,"context_line":"     included patches)."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"  2. Nova must call os-brick with the ``force`` option when"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ee73c624_a9af5318","line":62,"range":{"start_line":61,"start_character":63,"end_line":62,"end_character":57},"in_reply_to":"09918869_d7dc538f","updated":"2023-05-10 16:55:05.000000000","message":"Done","commit_id":"f84e12955e5620d3ba718c7d536eca6c7bf77f5e"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"23fabfbe51bdf78de8e5fdc9a200411beadf6cd8","unresolved":true,"context_lines":[{"line_number":63,"context_line":"     included patches)."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"  2. Nova must call os-brick with the ``force`` option when"},{"line_number":66,"context_line":"     disconnecting volumes from instances (covered by included"},{"line_number":67,"context_line":"     patches)."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"  3. In deployments where Glance uses the cinder glance_store, glance"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"9307025c_9f659dc1","line":66,"updated":"2023-05-10 16:38:53.000000000","message":"This should be \"deleted instances\" as that\u0027s the only thing we\u0027re changing. We don\u0027t use force for regular detach because that could result in data loss.","commit_id":"f84e12955e5620d3ba718c7d536eca6c7bf77f5e"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3c04cd133c151d4a6271b288a4f12b5bf8f9b4c2","unresolved":false,"context_lines":[{"line_number":63,"context_line":"     included patches)."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"  2. Nova must call os-brick with the ``force`` option when"},{"line_number":66,"context_line":"     disconnecting volumes from instances (covered by included"},{"line_number":67,"context_line":"     patches)."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"  3. In deployments where Glance uses the cinder glance_store, glance"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"2bd0c018_2388f575","line":66,"in_reply_to":"9307025c_9f659dc1","updated":"2023-05-10 16:58:11.000000000","message":"Done","commit_id":"f84e12955e5620d3ba718c7d536eca6c7bf77f5e"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"bc62242e21e6092d85d8304d0b0fb243f992cd18","unresolved":false,"context_lines":[{"line_number":63,"context_line":"     included patches)."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"  2. Nova must call os-brick with the ``force`` option when"},{"line_number":66,"context_line":"     disconnecting volumes from instances (covered by included"},{"line_number":67,"context_line":"     patches)."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"  3. In deployments where Glance uses the cinder glance_store, glance"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f49e2ef_15d73d59","line":66,"in_reply_to":"9307025c_9f659dc1","updated":"2023-05-10 16:55:05.000000000","message":"Done","commit_id":"f84e12955e5620d3ba718c7d536eca6c7bf77f5e"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"23fabfbe51bdf78de8e5fdc9a200411beadf6cd8","unresolved":true,"context_lines":[{"line_number":66,"context_line":"     disconnecting volumes from instances (covered by included"},{"line_number":67,"context_line":"     patches)."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"  3. In deployments where Glance uses the cinder glance_store, glance"},{"line_number":70,"context_line":"     must call os-brick with the ``force`` option when disconnecting"},{"line_number":71,"context_line":"     volumes (covered by included patches)."},{"line_number":72,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"30f62762_29a54e97","line":69,"range":{"start_line":69,"start_character":49,"end_line":69,"end_character":61},"updated":"2023-05-10 16:38:53.000000000","message":"This should have been \"backend\" .. we had this realization downstream an hour ago. The glance_store is a reference to a project, but the users see it as a backend in glance.","commit_id":"f84e12955e5620d3ba718c7d536eca6c7bf77f5e"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"bc62242e21e6092d85d8304d0b0fb243f992cd18","unresolved":false,"context_lines":[{"line_number":66,"context_line":"     disconnecting volumes from instances (covered by included"},{"line_number":67,"context_line":"     patches)."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"  3. In deployments where Glance uses the cinder glance_store, glance"},{"line_number":70,"context_line":"     must call os-brick with the ``force`` option when disconnecting"},{"line_number":71,"context_line":"     volumes (covered by included patches)."},{"line_number":72,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"28330a18_21f01f6a","line":69,"range":{"start_line":69,"start_character":49,"end_line":69,"end_character":61},"in_reply_to":"30f62762_29a54e97","updated":"2023-05-10 16:55:05.000000000","message":"Done","commit_id":"f84e12955e5620d3ba718c7d536eca6c7bf77f5e"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"394a6901d766ff5d9bb437888465f59253f4f88c","unresolved":true,"context_lines":[{"line_number":66,"context_line":"     disconnecting volumes from instances (covered by included"},{"line_number":67,"context_line":"     patches)."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"  3. In deployments where Glance uses the cinder glance_store, glance"},{"line_number":70,"context_line":"     must call os-brick with the ``force`` option when disconnecting"},{"line_number":71,"context_line":"     volumes (covered by included patches)."},{"line_number":72,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"96048650_b8de0a81","line":69,"range":{"start_line":69,"start_character":49,"end_line":69,"end_character":61},"in_reply_to":"30f62762_29a54e97","updated":"2023-05-10 16:50:35.000000000","message":"I don\u0027t know about this one.  It\u0027s the cinder glance_store driver that we\u0027re talking about.","commit_id":"f84e12955e5620d3ba718c7d536eca6c7bf77f5e"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3c04cd133c151d4a6271b288a4f12b5bf8f9b4c2","unresolved":false,"context_lines":[{"line_number":66,"context_line":"     disconnecting volumes from instances (covered by included"},{"line_number":67,"context_line":"     patches)."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"  3. In deployments where Glance uses the cinder glance_store, glance"},{"line_number":70,"context_line":"     must call os-brick with the ``force`` option when disconnecting"},{"line_number":71,"context_line":"     volumes (covered by included patches)."},{"line_number":72,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"41756045_6586e272","line":69,"range":{"start_line":69,"start_character":49,"end_line":69,"end_character":61},"in_reply_to":"6bf370ae_5900372a","updated":"2023-05-10 16:58:11.000000000","message":"Ack","commit_id":"f84e12955e5620d3ba718c7d536eca6c7bf77f5e"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"cb4f640f058f230a4396698e1ae6c9fb68247d64","unresolved":true,"context_lines":[{"line_number":66,"context_line":"     disconnecting volumes from instances (covered by included"},{"line_number":67,"context_line":"     patches)."},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"  3. In deployments where Glance uses the cinder glance_store, glance"},{"line_number":70,"context_line":"     must call os-brick with the ``force`` option when disconnecting"},{"line_number":71,"context_line":"     volumes (covered by included patches)."},{"line_number":72,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"6bf370ae_5900372a","line":69,"range":{"start_line":69,"start_character":49,"end_line":69,"end_character":61},"in_reply_to":"96048650_b8de0a81","updated":"2023-05-10 16:55:01.000000000","message":"Okay, this case from a conversation between gorka and rajat in another forum. Not critical and worth holding things up.","commit_id":"f84e12955e5620d3ba718c7d536eca6c7bf77f5e"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"23fabfbe51bdf78de8e5fdc9a200411beadf6cd8","unresolved":true,"context_lines":[{"line_number":94,"context_line":"        https://docs.openstack.org/cinder/latest/configuration/block-storage/service-token.html"},{"line_number":95,"context_line":"        The Nova patch mentioned in step 2 includes a similar document"},{"line_number":96,"context_line":"        more focused on Nova:"},{"line_number":97,"context_line":"        doc/source/admin/configuration/service-user-token.rst"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"  5. The Cinder glance_store does not attach volumes to instances;"},{"line_number":100,"context_line":"     instead, it attaches volumes directly to the Glance node. Thus,"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"c8089ae0_e68fbc38","line":97,"updated":"2023-05-10 16:38:53.000000000","message":"Should this be a link? This is in the not-yet-merged bit though.","commit_id":"f84e12955e5620d3ba718c7d536eca6c7bf77f5e"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"bc62242e21e6092d85d8304d0b0fb243f992cd18","unresolved":true,"context_lines":[{"line_number":94,"context_line":"        https://docs.openstack.org/cinder/latest/configuration/block-storage/service-token.html"},{"line_number":95,"context_line":"        The Nova patch mentioned in step 2 includes a similar document"},{"line_number":96,"context_line":"        more focused on Nova:"},{"line_number":97,"context_line":"        doc/source/admin/configuration/service-user-token.rst"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"  5. The Cinder glance_store does not attach volumes to instances;"},{"line_number":100,"context_line":"     instead, it attaches volumes directly to the Glance node. Thus,"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"eb3dcf8b_cf7daa6a","line":97,"in_reply_to":"c8089ae0_e68fbc38","updated":"2023-05-10 16:55:05.000000000","message":"We can amend the published advisory once the master patch lands in nova, I wouldn\u0027t consider it additional errata worth announcing when we do a minor formatting change like that.","commit_id":"f84e12955e5620d3ba718c7d536eca6c7bf77f5e"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"276a47a6cb3857dd56e4af9460a47380ba48575c","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        https://docs.openstack.org/cinder/latest/configuration/block-storage/service-token.html"},{"line_number":95,"context_line":"        The Nova patch mentioned in step 2 includes a similar document"},{"line_number":96,"context_line":"        more focused on Nova:"},{"line_number":97,"context_line":"        doc/source/admin/configuration/service-user-token.rst"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"  5. The Cinder glance_store does not attach volumes to instances;"},{"line_number":100,"context_line":"     instead, it attaches volumes directly to the Glance node. Thus,"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ae7bcecb_100cf90e","line":97,"in_reply_to":"eb3dcf8b_cf7daa6a","updated":"2023-05-10 16:58:23.000000000","message":"Ack","commit_id":"f84e12955e5620d3ba718c7d536eca6c7bf77f5e"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"23fabfbe51bdf78de8e5fdc9a200411beadf6cd8","unresolved":true,"context_lines":[{"line_number":96,"context_line":"        more focused on Nova:"},{"line_number":97,"context_line":"        doc/source/admin/configuration/service-user-token.rst"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"  5. The Cinder glance_store does not attach volumes to instances;"},{"line_number":100,"context_line":"     instead, it attaches volumes directly to the Glance node. Thus,"},{"line_number":101,"context_line":"     the Cinder change in step 4 will recognize an attachment-delete"},{"line_number":102,"context_line":"     request coming from Glance as safe and allow it. (Of course, we"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"ca727cdf_27549dde","line":99,"range":{"start_line":99,"start_character":16,"end_line":99,"end_character":28},"updated":"2023-05-10 16:38:53.000000000","message":"\"backend for glance\"","commit_id":"f84e12955e5620d3ba718c7d536eca6c7bf77f5e"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3c04cd133c151d4a6271b288a4f12b5bf8f9b4c2","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        more focused on Nova:"},{"line_number":97,"context_line":"        doc/source/admin/configuration/service-user-token.rst"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"  5. The Cinder glance_store does not attach volumes to instances;"},{"line_number":100,"context_line":"     instead, it attaches volumes directly to the Glance node. Thus,"},{"line_number":101,"context_line":"     the Cinder change in step 4 will recognize an attachment-delete"},{"line_number":102,"context_line":"     request coming from Glance as safe and allow it. (Of course, we"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5cd8609b_2d715394","line":99,"range":{"start_line":99,"start_character":16,"end_line":99,"end_character":28},"in_reply_to":"90751875_bebd1575","updated":"2023-05-10 16:58:11.000000000","message":"Done","commit_id":"f84e12955e5620d3ba718c7d536eca6c7bf77f5e"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"bc62242e21e6092d85d8304d0b0fb243f992cd18","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        more focused on Nova:"},{"line_number":97,"context_line":"        doc/source/admin/configuration/service-user-token.rst"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"  5. The Cinder glance_store does not attach volumes to instances;"},{"line_number":100,"context_line":"     instead, it attaches volumes directly to the Glance node. Thus,"},{"line_number":101,"context_line":"     the Cinder change in step 4 will recognize an attachment-delete"},{"line_number":102,"context_line":"     request coming from Glance as safe and allow it. (Of course, we"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"81ab1a7c_b9d9623b","line":99,"range":{"start_line":99,"start_character":16,"end_line":99,"end_character":28},"in_reply_to":"ca727cdf_27549dde","updated":"2023-05-10 16:55:05.000000000","message":"Done","commit_id":"f84e12955e5620d3ba718c7d536eca6c7bf77f5e"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"394a6901d766ff5d9bb437888465f59253f4f88c","unresolved":true,"context_lines":[{"line_number":96,"context_line":"        more focused on Nova:"},{"line_number":97,"context_line":"        doc/source/admin/configuration/service-user-token.rst"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"  5. The Cinder glance_store does not attach volumes to instances;"},{"line_number":100,"context_line":"     instead, it attaches volumes directly to the Glance node. Thus,"},{"line_number":101,"context_line":"     the Cinder change in step 4 will recognize an attachment-delete"},{"line_number":102,"context_line":"     request coming from Glance as safe and allow it. (Of course, we"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"90751875_bebd1575","line":99,"range":{"start_line":99,"start_character":16,"end_line":99,"end_character":28},"in_reply_to":"ca727cdf_27549dde","updated":"2023-05-10 16:50:35.000000000","message":"No, make it \"cinder glance_store driver\" if it\u0027s not clear.","commit_id":"f84e12955e5620d3ba718c7d536eca6c7bf77f5e"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"23fabfbe51bdf78de8e5fdc9a200411beadf6cd8","unresolved":true,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"errata: \u003e"},{"line_number":107,"context_line":"  An additional nova patch is required to fix a minor regression in periodic"},{"line_number":108,"context_line":"  task cleanup (errata 1). Also a patch to tempest is needed to account for"},{"line_number":109,"context_line":"  behavior changes with fixes in place (errata 2)."},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"affected-products:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3021cb89_8b949536","line":108,"range":{"start_line":108,"start_character":2,"end_line":108,"end_character":15},"updated":"2023-05-10 16:38:53.000000000","message":"\"periodic tasks and some nova-manage actions\" (no cleanup)\n\nSome of the periodics are for cleanup, but not all.","commit_id":"f84e12955e5620d3ba718c7d536eca6c7bf77f5e"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3c04cd133c151d4a6271b288a4f12b5bf8f9b4c2","unresolved":false,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"errata: \u003e"},{"line_number":107,"context_line":"  An additional nova patch is required to fix a minor regression in periodic"},{"line_number":108,"context_line":"  task cleanup (errata 1). Also a patch to tempest is needed to account for"},{"line_number":109,"context_line":"  behavior changes with fixes in place (errata 2)."},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"affected-products:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"46a748a9_6e607e43","line":108,"range":{"start_line":108,"start_character":2,"end_line":108,"end_character":15},"in_reply_to":"3021cb89_8b949536","updated":"2023-05-10 16:58:11.000000000","message":"Done","commit_id":"f84e12955e5620d3ba718c7d536eca6c7bf77f5e"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"bc62242e21e6092d85d8304d0b0fb243f992cd18","unresolved":false,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"errata: \u003e"},{"line_number":107,"context_line":"  An additional nova patch is required to fix a minor regression in periodic"},{"line_number":108,"context_line":"  task cleanup (errata 1). Also a patch to tempest is needed to account for"},{"line_number":109,"context_line":"  behavior changes with fixes in place (errata 2)."},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"affected-products:"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5c67c293_04681843","line":108,"range":{"start_line":108,"start_character":2,"end_line":108,"end_character":15},"in_reply_to":"3021cb89_8b949536","updated":"2023-05-10 16:55:05.000000000","message":"Done","commit_id":"f84e12955e5620d3ba718c7d536eca6c7bf77f5e"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3c04cd133c151d4a6271b288a4f12b5bf8f9b4c2","unresolved":true,"context_lines":[{"line_number":59,"context_line":"  elements:"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"  1. The os-brick library must implement the ``force`` option for"},{"line_number":62,"context_line":"     fibre channel,, which which has only been available for iSCSI"},{"line_number":63,"context_line":"     until now (covered by the linked patches)."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"  2. Nova must call os-brick with the ``force`` option when"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"2ff965d5_e73c54e2","line":62,"range":{"start_line":62,"start_character":19,"end_line":62,"end_character":20},"updated":"2023-05-10 16:58:11.000000000","message":"Extra comma here","commit_id":"786d932321cf321f8b78720df2756e3b3b33818a"},{"author":{"_account_id":5263,"name":"Jeremy Stanley","display_name":"fungi","email":"fungi@yuggoth.org","username":"fungi","status":"missing, presumed fed"},"change_message_id":"2a72e2d4780bbe8e5da5e1aae2f1345521914b55","unresolved":false,"context_lines":[{"line_number":59,"context_line":"  elements:"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"  1. The os-brick library must implement the ``force`` option for"},{"line_number":62,"context_line":"     fibre channel,, which which has only been available for iSCSI"},{"line_number":63,"context_line":"     until now (covered by the linked patches)."},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"  2. Nova must call os-brick with the ``force`` option when"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"a712fa0d_beeee4ae","line":62,"range":{"start_line":62,"start_character":19,"end_line":62,"end_character":20},"in_reply_to":"2ff965d5_e73c54e2","updated":"2023-05-10 17:00:15.000000000","message":"Done","commit_id":"786d932321cf321f8b78720df2756e3b3b33818a"}]}