)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"650803c3b615fd0ae6e42059818755f45e0106cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"bafcf3b5_462d4add","updated":"2023-06-15 09:06:18.000000000","message":"LGTM! Waiting on the gate","commit_id":"1d00d2c58fb5cd3585e321e3eea54fc8ae0178d8"}],"ovn_bgp_agent/drivers/openstack/utils/wire.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"5a365b9261d00a9409fa3f67816af7e01b2f5d64","unresolved":true,"context_lines":[{"line_number":149,"context_line":"        ofport \u003d ovs.get_ovs_patch_port_ofport(localnet)"},{"line_number":150,"context_line":"    except Exception:"},{"line_number":151,"context_line":"        raise agent_exc.PatchPortNotFound(localnet\u003dlocalnet)"},{"line_number":152,"context_line":"    if ofport \u003d\u003d \u0027[]\u0027:"},{"line_number":153,"context_line":"        # NOTE(ltomasbo): there is a chance the patch port interface was"},{"line_number":154,"context_line":"        # created but not yet added to ovs bridge, therefore it exists but"},{"line_number":155,"context_line":"        # has an empty ofport. We should retry in this case"}],"source_content_type":"text/x-python","patch_set":4,"id":"e2bd3bc7_f4614a4e","line":152,"range":{"start_line":152,"start_character":4,"end_line":152,"end_character":22},"updated":"2023-06-15 08:39:32.000000000","message":"Instead of testing \u0027[]\u0027 here, should we change the get_ovs_patch_port_ofport() to raise the a PatchPortNotFound exception if the result \u0027[]\u0027 ?\n\nEven this broad try..except here probably should happen in the get_ovs_patch_port_ofport() function and it should raise PatchPortNotFound() instead.\n\nBecause right now for someone using get_ovs_patch_port_ofport() is really hard and confusing. You would need to check for exceptions and \u0027[]\u0027 as a string to know that the patch port wasn\u0027t found.","commit_id":"1fcbc8fa10a882b1e464eb64ba109cfbf055e939"}]}