)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"eb464a62ab1f371e462ab55a12cce9d69a9bce32","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5f128de4_2a53892d","updated":"2023-10-09 05:57:47.000000000","message":"Just couple of nit in the code. Besides that, I\u0027m not completely sure I understand... this is to have the option to \"override\" the value in the neutron port, and use the config AS instead, right? Well... more than override, when this information is not provided, we use the config one. I have a question, is this \"dynamic\" being set in the networking-bgpvpn patch? Perhaps this needs some updates to the documentation here, or adding a launchpad RFE to describe it a bit","commit_id":"3c977f199a32f131a9544a1fddcc0f645315a7b3"}],"ovn_bgp_agent/drivers/openstack/ovn_evpn_driver.py":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"eb464a62ab1f371e462ab55a12cce9d69a9bce32","unresolved":true,"context_lines":[{"line_number":766,"context_line":"                if \u0027gateway\u0027 in route_info[\u0027route\u0027].keys():  # subnet route"},{"line_number":767,"context_line":"                    possible_matchings \u003d ["},{"line_number":768,"context_line":"                        r for r in vrf_routes"},{"line_number":769,"context_line":"                        if (r.get(\u0027dst\u0027) \u003d\u003d route_info[\u0027route\u0027][\u0027dst\u0027] and"},{"line_number":770,"context_line":"                            r[\u0027dst_len\u0027] \u003d\u003d route_info[\u0027route\u0027][\u0027dst_len\u0027] and"},{"line_number":771,"context_line":"                            r.get(\u0027gateway\u0027) \u003d\u003d ("},{"line_number":772,"context_line":"                                route_info[\u0027route\u0027][\u0027gateway\u0027]) and"}],"source_content_type":"text/x-python","patch_set":1,"id":"22597c8d_29eb737e","line":769,"range":{"start_line":769,"start_character":28,"end_line":769,"end_character":40},"updated":"2023-10-09 05:57:47.000000000","message":"all changes in this file seems unrelated to this patch, right? perhaps worth to split in a different patch with a launchpad bug","commit_id":"3c977f199a32f131a9544a1fddcc0f645315a7b3"}],"ovn_bgp_agent/drivers/openstack/utils/ovn.py":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"eb464a62ab1f371e462ab55a12cce9d69a9bce32","unresolved":true,"context_lines":[{"line_number":447,"context_line":"            LOG.debug(\u0027Either \"%s\" or \"%s\" were not found or have an \u0027"},{"line_number":448,"context_line":"                      \u0027invalid value in the port %s \u0027"},{"line_number":449,"context_line":"                      \u0027external_ids %s\u0027, constants.OVN_EVPN_VNI_EXT_ID_KEY,"},{"line_number":450,"context_line":"                      constants.OVN_EVPN_AS_EXT_ID_KEY, port.logical_port,"},{"line_number":451,"context_line":"                      port.external_ids)"},{"line_number":452,"context_line":"            return {}"},{"line_number":453,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"d13deb06_66add64f","line":450,"range":{"start_line":450,"start_character":22,"end_line":450,"end_character":56},"updated":"2023-10-09 05:57:47.000000000","message":"this should be adapted too, right?","commit_id":"3c977f199a32f131a9544a1fddcc0f645315a7b3"}]}
