)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"8b5227ca3de14dd4732a77c1f2d362f481539654","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b4d34571_751a3d4d","updated":"2023-11-06 14:54:18.000000000","message":"missing testing, but tested locally and already working","commit_id":"60d7b258523037defb2a08b54c5c38b8d51c9072"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"e1a06f776ffa9b7041e3da4d3748bcaa82619030","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"035dcf6c_1c351ab1","updated":"2023-11-15 13:31:38.000000000","message":"Thanks Luis, comments inline","commit_id":"9dd3ea795f40bb32d640ef5d79a9f3d0219c6f5d"}],"ovn_bgp_agent/constants.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"e1a06f776ffa9b7041e3da4d3748bcaa82619030","unresolved":true,"context_lines":[{"line_number":34,"context_line":"OVN_FIP_NET_EXT_ID_KEY \u003d \u0027neutron:fip_network_id\u0027"},{"line_number":35,"context_line":"LB_VIP_PORT_PREFIX \u003d \"ovn-lb-vip-\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"OVS_RULE_COOKIE \u003d \"999\""},{"line_number":39,"context_line":"OVS_VRF_RULE_COOKIE \u003d \"998\""},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"b52b5782_509809e4","line":37,"updated":"2023-11-15 13:31:38.000000000","message":"nit: extra space","commit_id":"9dd3ea795f40bb32d640ef5d79a9f3d0219c6f5d"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"96432ea4eedba5cf53a9b6c20e68a378b87449e0","unresolved":false,"context_lines":[{"line_number":34,"context_line":"OVN_FIP_NET_EXT_ID_KEY \u003d \u0027neutron:fip_network_id\u0027"},{"line_number":35,"context_line":"LB_VIP_PORT_PREFIX \u003d \"ovn-lb-vip-\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"OVS_RULE_COOKIE \u003d \"999\""},{"line_number":39,"context_line":"OVS_VRF_RULE_COOKIE \u003d \"998\""},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"6ddad348_df5efb97","line":37,"in_reply_to":"b52b5782_509809e4","updated":"2023-11-15 15:31:47.000000000","message":"Done","commit_id":"9dd3ea795f40bb32d640ef5d79a9f3d0219c6f5d"}],"ovn_bgp_agent/drivers/openstack/nb_ovn_bgp_driver.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"e1a06f776ffa9b7041e3da4d3748bcaa82619030","unresolved":true,"context_lines":[{"line_number":634,"context_line":"            if not CONF.expose_tenant_networks:"},{"line_number":635,"context_line":"                # This means CONF.expose_ipv6_gua_tenant_networks is enabled"},{"line_number":636,"context_line":"                if not driver_utils.is_ipv6_gua(ip):"},{"line_number":637,"context_line":"                    continue"},{"line_number":638,"context_line":"            if not self._address_scope_allowed(ip,"},{"line_number":639,"context_line":"                                               subnet_info[\u0027address_scopes\u0027]):"},{"line_number":640,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":9,"id":"6a42c411_9e199510","line":637,"updated":"2023-11-15 13:31:38.000000000","message":"nit: could be an \"and\" on the previous conditional\n\n```\nif not CONF.expose_tenant_networks and not driver_utils.is_ipv6_gua(ip):\n    continue\n```","commit_id":"9dd3ea795f40bb32d640ef5d79a9f3d0219c6f5d"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"96432ea4eedba5cf53a9b6c20e68a378b87449e0","unresolved":false,"context_lines":[{"line_number":634,"context_line":"            if not CONF.expose_tenant_networks:"},{"line_number":635,"context_line":"                # This means CONF.expose_ipv6_gua_tenant_networks is enabled"},{"line_number":636,"context_line":"                if not driver_utils.is_ipv6_gua(ip):"},{"line_number":637,"context_line":"                    continue"},{"line_number":638,"context_line":"            if not self._address_scope_allowed(ip,"},{"line_number":639,"context_line":"                                               subnet_info[\u0027address_scopes\u0027]):"},{"line_number":640,"context_line":"                continue"}],"source_content_type":"text/x-python","patch_set":9,"id":"f81b8cc4_46b6a9c2","line":637,"in_reply_to":"6a42c411_9e199510","updated":"2023-11-15 15:31:47.000000000","message":"Done","commit_id":"9dd3ea795f40bb32d640ef5d79a9f3d0219c6f5d"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"e1a06f776ffa9b7041e3da4d3748bcaa82619030","unresolved":true,"context_lines":[{"line_number":649,"context_line":"                        self._exposed_ips["},{"line_number":650,"context_line":"                            subnet_info[\u0027associated_router\u0027]].pop(ip)"},{"line_number":651,"context_line":"                else:"},{"line_number":652,"context_line":"                    success \u003d False"},{"line_number":653,"context_line":"            except Exception as e:"},{"line_number":654,"context_line":"                LOG.exception(\"Unexpected exception while unwiring subnet \""},{"line_number":655,"context_line":"                              \"CIDRs %s: %s\", ip, e)"}],"source_content_type":"text/x-python","patch_set":9,"id":"4781ee28_3222a897","line":652,"updated":"2023-11-15 13:31:38.000000000","message":"Once success has been set to False it\u0027s not worth to continue to loop thru the IPs cause it never gets to be set to True again.\n\nSo I would either return False or break the loop","commit_id":"9dd3ea795f40bb32d640ef5d79a9f3d0219c6f5d"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"96432ea4eedba5cf53a9b6c20e68a378b87449e0","unresolved":false,"context_lines":[{"line_number":649,"context_line":"                        self._exposed_ips["},{"line_number":650,"context_line":"                            subnet_info[\u0027associated_router\u0027]].pop(ip)"},{"line_number":651,"context_line":"                else:"},{"line_number":652,"context_line":"                    success \u003d False"},{"line_number":653,"context_line":"            except Exception as e:"},{"line_number":654,"context_line":"                LOG.exception(\"Unexpected exception while unwiring subnet \""},{"line_number":655,"context_line":"                              \"CIDRs %s: %s\", ip, e)"}],"source_content_type":"text/x-python","patch_set":9,"id":"4c8882af_6a9dc25b","line":652,"in_reply_to":"4781ee28_3222a897","updated":"2023-11-15 15:31:47.000000000","message":"Done","commit_id":"9dd3ea795f40bb32d640ef5d79a9f3d0219c6f5d"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"e1a06f776ffa9b7041e3da4d3748bcaa82619030","unresolved":true,"context_lines":[{"line_number":653,"context_line":"            except Exception as e:"},{"line_number":654,"context_line":"                LOG.exception(\"Unexpected exception while unwiring subnet \""},{"line_number":655,"context_line":"                              \"CIDRs %s: %s\", ip, e)"},{"line_number":656,"context_line":"                success \u003d False"},{"line_number":657,"context_line":"        return success"},{"line_number":658,"context_line":""},{"line_number":659,"context_line":"    def _address_scope_allowed(self, ip, address_scopes):"}],"source_content_type":"text/x-python","patch_set":9,"id":"c9ad7f1f_7f2b3f4c","line":656,"updated":"2023-11-15 13:31:38.000000000","message":"ditto re success being False","commit_id":"9dd3ea795f40bb32d640ef5d79a9f3d0219c6f5d"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"96432ea4eedba5cf53a9b6c20e68a378b87449e0","unresolved":false,"context_lines":[{"line_number":653,"context_line":"            except Exception as e:"},{"line_number":654,"context_line":"                LOG.exception(\"Unexpected exception while unwiring subnet \""},{"line_number":655,"context_line":"                              \"CIDRs %s: %s\", ip, e)"},{"line_number":656,"context_line":"                success \u003d False"},{"line_number":657,"context_line":"        return success"},{"line_number":658,"context_line":""},{"line_number":659,"context_line":"    def _address_scope_allowed(self, ip, address_scopes):"}],"source_content_type":"text/x-python","patch_set":9,"id":"e52e68bc_4d36ab1a","line":656,"in_reply_to":"c9ad7f1f_7f2b3f4c","updated":"2023-11-15 15:31:47.000000000","message":"Done","commit_id":"9dd3ea795f40bb32d640ef5d79a9f3d0219c6f5d"}],"ovn_bgp_agent/drivers/openstack/utils/wire.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"e1a06f776ffa9b7041e3da4d3748bcaa82619030","unresolved":true,"context_lines":[{"line_number":632,"context_line":"                                         bridge_device, bridge_vlan,"},{"line_number":633,"context_line":"                                         routing_tables, cr_lrp_ips)"},{"line_number":634,"context_line":"    elif CONF.exposing_method \u003d\u003d constants.EXPOSE_METHOD_OVN:"},{"line_number":635,"context_line":"        # TO BE DONE"},{"line_number":636,"context_line":"        # Remove flow(s) and router route"},{"line_number":637,"context_line":"        return"},{"line_number":638,"context_line":""},{"line_number":639,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"d77255c6_72913735","line":636,"range":{"start_line":635,"start_character":0,"end_line":636,"end_character":41},"updated":"2023-11-15 13:31:38.000000000","message":"\\# TODO(...): Remove flow(s) and router route\n\nLet\u0027s keep the TODO syntax instead of \"TO BE DONE\" because that\u0027s the syntax used for things to be done in the code","commit_id":"9dd3ea795f40bb32d640ef5d79a9f3d0219c6f5d"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"96432ea4eedba5cf53a9b6c20e68a378b87449e0","unresolved":false,"context_lines":[{"line_number":632,"context_line":"                                         bridge_device, bridge_vlan,"},{"line_number":633,"context_line":"                                         routing_tables, cr_lrp_ips)"},{"line_number":634,"context_line":"    elif CONF.exposing_method \u003d\u003d constants.EXPOSE_METHOD_OVN:"},{"line_number":635,"context_line":"        # TO BE DONE"},{"line_number":636,"context_line":"        # Remove flow(s) and router route"},{"line_number":637,"context_line":"        return"},{"line_number":638,"context_line":""},{"line_number":639,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"47c7511e_16dfd97d","line":636,"range":{"start_line":635,"start_character":0,"end_line":636,"end_character":41},"in_reply_to":"d77255c6_72913735","updated":"2023-11-15 15:31:47.000000000","message":"Done","commit_id":"9dd3ea795f40bb32d640ef5d79a9f3d0219c6f5d"}],"ovn_bgp_agent/drivers/openstack/watchers/nb_bgp_watcher.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"e1a06f776ffa9b7041e3da4d3748bcaa82619030","unresolved":true,"context_lines":[{"line_number":410,"context_line":"            associated_router \u003d row.external_ids.get("},{"line_number":411,"context_line":"                constants.OVN_DEVICE_ID_EXT_ID_KEY)"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"            if associated_router not in self.agent.ovn_local_cr_lrps.keys():"},{"line_number":414,"context_line":"                return False"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"            if hasattr(old, \u0027up\u0027):"}],"source_content_type":"text/x-python","patch_set":9,"id":"b19edd84_b189dd8b","line":413,"range":{"start_line":413,"start_character":68,"end_line":413,"end_character":75},"updated":"2023-11-15 13:31:38.000000000","message":"nit: keys() not needed","commit_id":"9dd3ea795f40bb32d640ef5d79a9f3d0219c6f5d"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"96432ea4eedba5cf53a9b6c20e68a378b87449e0","unresolved":false,"context_lines":[{"line_number":410,"context_line":"            associated_router \u003d row.external_ids.get("},{"line_number":411,"context_line":"                constants.OVN_DEVICE_ID_EXT_ID_KEY)"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"            if associated_router not in self.agent.ovn_local_cr_lrps.keys():"},{"line_number":414,"context_line":"                return False"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"            if hasattr(old, \u0027up\u0027):"}],"source_content_type":"text/x-python","patch_set":9,"id":"09998379_f5d83203","line":413,"range":{"start_line":413,"start_character":68,"end_line":413,"end_character":75},"in_reply_to":"b19edd84_b189dd8b","updated":"2023-11-15 15:31:47.000000000","message":"Done","commit_id":"9dd3ea795f40bb32d640ef5d79a9f3d0219c6f5d"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"e1a06f776ffa9b7041e3da4d3748bcaa82619030","unresolved":true,"context_lines":[{"line_number":414,"context_line":"                return False"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"            if hasattr(old, \u0027up\u0027):"},{"line_number":417,"context_line":"                if not bool(old.up[0]):"},{"line_number":418,"context_line":"                    return True"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"            if hasattr(old, \u0027external_ids\u0027):"}],"source_content_type":"text/x-python","patch_set":9,"id":"6f522793_5ff6e8ab","line":417,"updated":"2023-11-15 13:31:38.000000000","message":"nit can be a \"and\" statement in the first condition\n\n```\nif hasattr(old, \u0027up\u0027) and not bool(old.up[0]):\n    return True\n```","commit_id":"9dd3ea795f40bb32d640ef5d79a9f3d0219c6f5d"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"96432ea4eedba5cf53a9b6c20e68a378b87449e0","unresolved":false,"context_lines":[{"line_number":414,"context_line":"                return False"},{"line_number":415,"context_line":""},{"line_number":416,"context_line":"            if hasattr(old, \u0027up\u0027):"},{"line_number":417,"context_line":"                if not bool(old.up[0]):"},{"line_number":418,"context_line":"                    return True"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"            if hasattr(old, \u0027external_ids\u0027):"}],"source_content_type":"text/x-python","patch_set":9,"id":"26267f39_698e0208","line":417,"in_reply_to":"6f522793_5ff6e8ab","updated":"2023-11-15 15:31:47.000000000","message":"Done","commit_id":"9dd3ea795f40bb32d640ef5d79a9f3d0219c6f5d"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"e1a06f776ffa9b7041e3da4d3748bcaa82619030","unresolved":true,"context_lines":[{"line_number":422,"context_line":"                    constants.OVN_DEVICE_ID_EXT_ID_KEY)"},{"line_number":423,"context_line":"                if (associated_router !\u003d previous_associated_router and"},{"line_number":424,"context_line":"                        previous_associated_router not in"},{"line_number":425,"context_line":"                        self.agent.ovn_local_cr_lrps.keys()):"},{"line_number":426,"context_line":"                    return True"},{"line_number":427,"context_line":"        except (IndexError, AttributeError):"},{"line_number":428,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":9,"id":"c1fc7771_cd013459","line":425,"range":{"start_line":425,"start_character":52,"end_line":425,"end_character":59},"updated":"2023-11-15 13:31:38.000000000","message":"ditto keys() not needed","commit_id":"9dd3ea795f40bb32d640ef5d79a9f3d0219c6f5d"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"96432ea4eedba5cf53a9b6c20e68a378b87449e0","unresolved":false,"context_lines":[{"line_number":422,"context_line":"                    constants.OVN_DEVICE_ID_EXT_ID_KEY)"},{"line_number":423,"context_line":"                if (associated_router !\u003d previous_associated_router and"},{"line_number":424,"context_line":"                        previous_associated_router not in"},{"line_number":425,"context_line":"                        self.agent.ovn_local_cr_lrps.keys()):"},{"line_number":426,"context_line":"                    return True"},{"line_number":427,"context_line":"        except (IndexError, AttributeError):"},{"line_number":428,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":9,"id":"5fc2c014_2ed9b403","line":425,"range":{"start_line":425,"start_character":52,"end_line":425,"end_character":59},"in_reply_to":"c1fc7771_cd013459","updated":"2023-11-15 15:31:47.000000000","message":"Done","commit_id":"9dd3ea795f40bb32d640ef5d79a9f3d0219c6f5d"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"e1a06f776ffa9b7041e3da4d3748bcaa82619030","unresolved":true,"context_lines":[{"line_number":461,"context_line":"            if event \u003d\u003d self.ROW_DELETE:"},{"line_number":462,"context_line":"                if not bool(row.up[0]):"},{"line_number":463,"context_line":"                    return False"},{"line_number":464,"context_line":"                if associated_router in self.agent.ovn_local_cr_lrps.keys():"},{"line_number":465,"context_line":"                    return True"},{"line_number":466,"context_line":"                return False"},{"line_number":467,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"b1eacdca_019223a8","line":464,"range":{"start_line":464,"start_character":69,"end_line":464,"end_character":75},"updated":"2023-11-15 13:31:38.000000000","message":"ditto keys() not needed","commit_id":"9dd3ea795f40bb32d640ef5d79a9f3d0219c6f5d"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"96432ea4eedba5cf53a9b6c20e68a378b87449e0","unresolved":false,"context_lines":[{"line_number":461,"context_line":"            if event \u003d\u003d self.ROW_DELETE:"},{"line_number":462,"context_line":"                if not bool(row.up[0]):"},{"line_number":463,"context_line":"                    return False"},{"line_number":464,"context_line":"                if associated_router in self.agent.ovn_local_cr_lrps.keys():"},{"line_number":465,"context_line":"                    return True"},{"line_number":466,"context_line":"                return False"},{"line_number":467,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"16ded7a8_72af360d","line":464,"range":{"start_line":464,"start_character":69,"end_line":464,"end_character":75},"in_reply_to":"b1eacdca_019223a8","updated":"2023-11-15 15:31:47.000000000","message":"Done","commit_id":"9dd3ea795f40bb32d640ef5d79a9f3d0219c6f5d"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"e1a06f776ffa9b7041e3da4d3748bcaa82619030","unresolved":true,"context_lines":[{"line_number":479,"context_line":"                    previous_associated_router \u003d old.external_ids.get("},{"line_number":480,"context_line":"                        constants.OVN_DEVICE_ID_EXT_ID_KEY)"},{"line_number":481,"context_line":"                    if previous_associated_router in ("},{"line_number":482,"context_line":"                            self.agent.ovn_local_cr_lrps.keys()):"},{"line_number":483,"context_line":"                        return True"},{"line_number":484,"context_line":"                else:"},{"line_number":485,"context_line":"                    if associated_router in ("}],"source_content_type":"text/x-python","patch_set":9,"id":"4d27b97b_2eb65932","line":482,"range":{"start_line":482,"start_character":56,"end_line":482,"end_character":63},"updated":"2023-11-15 13:31:38.000000000","message":"ditto keys() not needed","commit_id":"9dd3ea795f40bb32d640ef5d79a9f3d0219c6f5d"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"96432ea4eedba5cf53a9b6c20e68a378b87449e0","unresolved":false,"context_lines":[{"line_number":479,"context_line":"                    previous_associated_router \u003d old.external_ids.get("},{"line_number":480,"context_line":"                        constants.OVN_DEVICE_ID_EXT_ID_KEY)"},{"line_number":481,"context_line":"                    if previous_associated_router in ("},{"line_number":482,"context_line":"                            self.agent.ovn_local_cr_lrps.keys()):"},{"line_number":483,"context_line":"                        return True"},{"line_number":484,"context_line":"                else:"},{"line_number":485,"context_line":"                    if associated_router in ("}],"source_content_type":"text/x-python","patch_set":9,"id":"43e7937f_46e95841","line":482,"range":{"start_line":482,"start_character":56,"end_line":482,"end_character":63},"in_reply_to":"4d27b97b_2eb65932","updated":"2023-11-15 15:31:47.000000000","message":"Done","commit_id":"9dd3ea795f40bb32d640ef5d79a9f3d0219c6f5d"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"e1a06f776ffa9b7041e3da4d3748bcaa82619030","unresolved":true,"context_lines":[{"line_number":483,"context_line":"                        return True"},{"line_number":484,"context_line":"                else:"},{"line_number":485,"context_line":"                    if associated_router in ("},{"line_number":486,"context_line":"                            self.agent.ovn_local_cr_lrps.keys()):"},{"line_number":487,"context_line":"                        return True"},{"line_number":488,"context_line":"            else:"},{"line_number":489,"context_line":"                # no change in status"}],"source_content_type":"text/x-python","patch_set":9,"id":"24c2f4da_cc7f33ea","line":486,"range":{"start_line":486,"start_character":56,"end_line":486,"end_character":63},"updated":"2023-11-15 13:31:38.000000000","message":"ditto keys() not needed","commit_id":"9dd3ea795f40bb32d640ef5d79a9f3d0219c6f5d"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"96432ea4eedba5cf53a9b6c20e68a378b87449e0","unresolved":false,"context_lines":[{"line_number":483,"context_line":"                        return True"},{"line_number":484,"context_line":"                else:"},{"line_number":485,"context_line":"                    if associated_router in ("},{"line_number":486,"context_line":"                            self.agent.ovn_local_cr_lrps.keys()):"},{"line_number":487,"context_line":"                        return True"},{"line_number":488,"context_line":"            else:"},{"line_number":489,"context_line":"                # no change in status"}],"source_content_type":"text/x-python","patch_set":9,"id":"0c68382b_6f3ab19a","line":486,"range":{"start_line":486,"start_character":56,"end_line":486,"end_character":63},"in_reply_to":"24c2f4da_cc7f33ea","updated":"2023-11-15 15:31:47.000000000","message":"Done","commit_id":"9dd3ea795f40bb32d640ef5d79a9f3d0219c6f5d"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"e1a06f776ffa9b7041e3da4d3748bcaa82619030","unresolved":true,"context_lines":[{"line_number":496,"context_line":"                    if (previous_associated_router and"},{"line_number":497,"context_line":"                            associated_router !\u003d previous_associated_router and"},{"line_number":498,"context_line":"                            previous_associated_router in"},{"line_number":499,"context_line":"                            self.agent.ovn_local_cr_lrps.keys()):"},{"line_number":500,"context_line":"                        return True"},{"line_number":501,"context_line":"        except (IndexError, AttributeError):"},{"line_number":502,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":9,"id":"5d01cb2d_be7b26c6","line":499,"range":{"start_line":499,"start_character":56,"end_line":499,"end_character":63},"updated":"2023-11-15 13:31:38.000000000","message":"ditto keys() not needed","commit_id":"9dd3ea795f40bb32d640ef5d79a9f3d0219c6f5d"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"96432ea4eedba5cf53a9b6c20e68a378b87449e0","unresolved":false,"context_lines":[{"line_number":496,"context_line":"                    if (previous_associated_router and"},{"line_number":497,"context_line":"                            associated_router !\u003d previous_associated_router and"},{"line_number":498,"context_line":"                            previous_associated_router in"},{"line_number":499,"context_line":"                            self.agent.ovn_local_cr_lrps.keys()):"},{"line_number":500,"context_line":"                        return True"},{"line_number":501,"context_line":"        except (IndexError, AttributeError):"},{"line_number":502,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":9,"id":"91b8da8e_ce2a6c12","line":499,"range":{"start_line":499,"start_character":56,"end_line":499,"end_character":63},"in_reply_to":"5d01cb2d_be7b26c6","updated":"2023-11-15 15:31:47.000000000","message":"Done","commit_id":"9dd3ea795f40bb32d640ef5d79a9f3d0219c6f5d"}]}