)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"8c01f889a721523ea32751060216a833195d170f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e2dc5ec7_57bba0b8","updated":"2023-12-13 08:26:37.000000000","message":"needs some investigation to see if it is definitely needed","commit_id":"99c5e1f54142426bb240916a492499437cb1a425"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"de3bcb957a1077fbce6d1a5eabfa08d90a9c0622","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fd17c2eb_9b263ca7","updated":"2023-12-13 08:31:53.000000000","message":"on a second thought... worth to add it even if not always is needed as it simplifies the code and add protection in case of it being needed","commit_id":"99c5e1f54142426bb240916a492499437cb1a425"}],"ovn_bgp_agent/drivers/openstack/nb_ovn_bgp_driver.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"e3a4d05c1227de9ebf87f3a6f62a0864747ec23c","unresolved":true,"context_lines":[{"line_number":280,"context_line":""},{"line_number":281,"context_line":"    def _expose_provider_port(self, port_ips, mac, logical_switch,"},{"line_number":282,"context_line":"                              bridge_device, bridge_vlan, localnet,"},{"line_number":283,"context_line":"                              proxy_cidrs\u003d[]):"},{"line_number":284,"context_line":"        # Connect to OVN"},{"line_number":285,"context_line":"        try:"},{"line_number":286,"context_line":"            if wire_utils.wire_provider_port("}],"source_content_type":"text/x-python","patch_set":2,"id":"1ce9d702_bd307f99","line":283,"updated":"2023-12-12 15:57:19.000000000","message":"We can\u0027t have mutable default parameters in Python, this opens a big can of worms [0][1] \n\n[0] https://docs.python-guide.org/writing/gotchas/#mutable-default-arguments\n[1] https://florimond.dev/en/posts/2018/08/python-mutable-defaults-are-the-source-of-all-evil/","commit_id":"00050513ce199768c3be774abd1e8d7805602a99"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"a5c67fda1ebb1677faeacb9b5b748f85467a4fcf","unresolved":false,"context_lines":[{"line_number":280,"context_line":""},{"line_number":281,"context_line":"    def _expose_provider_port(self, port_ips, mac, logical_switch,"},{"line_number":282,"context_line":"                              bridge_device, bridge_vlan, localnet,"},{"line_number":283,"context_line":"                              proxy_cidrs\u003d[]):"},{"line_number":284,"context_line":"        # Connect to OVN"},{"line_number":285,"context_line":"        try:"},{"line_number":286,"context_line":"            if wire_utils.wire_provider_port("}],"source_content_type":"text/x-python","patch_set":2,"id":"7e001a70_ce0f2100","line":283,"in_reply_to":"0538290f_7fa4a702","updated":"2023-12-13 07:41:17.000000000","message":"Done","commit_id":"00050513ce199768c3be774abd1e8d7805602a99"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"f5d94cae9dfc3dbf363bcba7ed04340ac8c9570f","unresolved":true,"context_lines":[{"line_number":280,"context_line":""},{"line_number":281,"context_line":"    def _expose_provider_port(self, port_ips, mac, logical_switch,"},{"line_number":282,"context_line":"                              bridge_device, bridge_vlan, localnet,"},{"line_number":283,"context_line":"                              proxy_cidrs\u003d[]):"},{"line_number":284,"context_line":"        # Connect to OVN"},{"line_number":285,"context_line":"        try:"},{"line_number":286,"context_line":"            if wire_utils.wire_provider_port("}],"source_content_type":"text/x-python","patch_set":2,"id":"0538290f_7fa4a702","line":283,"in_reply_to":"1ce9d702_bd307f99","updated":"2023-12-13 07:10:11.000000000","message":"omg, yes! what I was thinking! you already told me so in a previous patch! I\u0027ll fix it right away!","commit_id":"00050513ce199768c3be774abd1e8d7805602a99"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"e3a4d05c1227de9ebf87f3a6f62a0864747ec23c","unresolved":true,"context_lines":[{"line_number":301,"context_line":"        return True"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"    def _withdraw_provider_port(self, port_ips, logical_switch, bridge_device,"},{"line_number":304,"context_line":"                                bridge_vlan, proxy_cidrs\u003d[]):"},{"line_number":305,"context_line":"        # Withdraw IP before disconnecting it"},{"line_number":306,"context_line":"        bgp_utils.withdraw_ips(port_ips)"},{"line_number":307,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"d4e239a8_87d9c259","line":304,"updated":"2023-12-12 15:57:19.000000000","message":"ditto","commit_id":"00050513ce199768c3be774abd1e8d7805602a99"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"a5c67fda1ebb1677faeacb9b5b748f85467a4fcf","unresolved":false,"context_lines":[{"line_number":301,"context_line":"        return True"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":"    def _withdraw_provider_port(self, port_ips, logical_switch, bridge_device,"},{"line_number":304,"context_line":"                                bridge_vlan, proxy_cidrs\u003d[]):"},{"line_number":305,"context_line":"        # Withdraw IP before disconnecting it"},{"line_number":306,"context_line":"        bgp_utils.withdraw_ips(port_ips)"},{"line_number":307,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"450527ba_a3743fcb","line":304,"in_reply_to":"d4e239a8_87d9c259","updated":"2023-12-13 07:41:17.000000000","message":"Done","commit_id":"00050513ce199768c3be774abd1e8d7805602a99"}],"ovn_bgp_agent/drivers/openstack/ovn_bgp_driver.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"e3a4d05c1227de9ebf87f3a6f62a0864747ec23c","unresolved":true,"context_lines":[{"line_number":324,"context_line":""},{"line_number":325,"context_line":"    def _expose_provider_port(self, port_ips, provider_datapath,"},{"line_number":326,"context_line":"                              bridge_device\u003dNone, bridge_vlan\u003dNone,"},{"line_number":327,"context_line":"                              lladdr\u003dNone, proxy_cidrs\u003d[]):"},{"line_number":328,"context_line":"        if not bridge_device and not bridge_vlan:"},{"line_number":329,"context_line":"            bridge_device, bridge_vlan \u003d self._get_bridge_for_datapath("},{"line_number":330,"context_line":"                provider_datapath)"}],"source_content_type":"text/x-python","patch_set":2,"id":"75f17496_5a0fcebf","line":327,"updated":"2023-12-12 15:57:19.000000000","message":"ditto","commit_id":"00050513ce199768c3be774abd1e8d7805602a99"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"a5c67fda1ebb1677faeacb9b5b748f85467a4fcf","unresolved":false,"context_lines":[{"line_number":324,"context_line":""},{"line_number":325,"context_line":"    def _expose_provider_port(self, port_ips, provider_datapath,"},{"line_number":326,"context_line":"                              bridge_device\u003dNone, bridge_vlan\u003dNone,"},{"line_number":327,"context_line":"                              lladdr\u003dNone, proxy_cidrs\u003d[]):"},{"line_number":328,"context_line":"        if not bridge_device and not bridge_vlan:"},{"line_number":329,"context_line":"            bridge_device, bridge_vlan \u003d self._get_bridge_for_datapath("},{"line_number":330,"context_line":"                provider_datapath)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ebabfe60_f95289aa","line":327,"in_reply_to":"75f17496_5a0fcebf","updated":"2023-12-13 07:41:17.000000000","message":"Done","commit_id":"00050513ce199768c3be774abd1e8d7805602a99"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"e3a4d05c1227de9ebf87f3a6f62a0864747ec23c","unresolved":true,"context_lines":[{"line_number":415,"context_line":""},{"line_number":416,"context_line":"    def _withdraw_provider_port(self, port_ips, provider_datapath,"},{"line_number":417,"context_line":"                                bridge_device\u003dNone, bridge_vlan\u003dNone,"},{"line_number":418,"context_line":"                                lladdr\u003dNone, proxy_cidrs\u003d[]):"},{"line_number":419,"context_line":"        # Withdraw IP before disconnecting it"},{"line_number":420,"context_line":"        bgp_utils.withdraw_ips(port_ips)"},{"line_number":421,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"d029f39d_4d63f970","line":418,"updated":"2023-12-12 15:57:19.000000000","message":"ditto","commit_id":"00050513ce199768c3be774abd1e8d7805602a99"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"a5c67fda1ebb1677faeacb9b5b748f85467a4fcf","unresolved":false,"context_lines":[{"line_number":415,"context_line":""},{"line_number":416,"context_line":"    def _withdraw_provider_port(self, port_ips, provider_datapath,"},{"line_number":417,"context_line":"                                bridge_device\u003dNone, bridge_vlan\u003dNone,"},{"line_number":418,"context_line":"                                lladdr\u003dNone, proxy_cidrs\u003d[]):"},{"line_number":419,"context_line":"        # Withdraw IP before disconnecting it"},{"line_number":420,"context_line":"        bgp_utils.withdraw_ips(port_ips)"},{"line_number":421,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"a1f94e85_5d62a89a","line":418,"in_reply_to":"d029f39d_4d63f970","updated":"2023-12-13 07:41:17.000000000","message":"Done","commit_id":"00050513ce199768c3be774abd1e8d7805602a99"}]}