)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"9bf24544f9749f346735977ea158bf310f8bfd57","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Luis Tomas Bolivar \u003cltomasbo@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-12-14 14:46:23 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix watcher logic for exposing OVN LB with t he NB DB driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I0641e79139d2452f1d6053f878769ff18a4a8a7d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa550691_d525f093","line":7,"range":{"start_line":7,"start_character":43,"end_line":7,"end_character":47},"updated":"2023-12-14 15:32:06.000000000","message":"the","commit_id":"bacaf7cc91fc7c51689e5fef11e0fe92035fe0c8"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"7373155a5c11ec1c3edbf42de61efa8e5998e79f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Luis Tomas Bolivar \u003cltomasbo@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-12-14 14:46:23 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix watcher logic for exposing OVN LB with t he NB DB driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I0641e79139d2452f1d6053f878769ff18a4a8a7d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"c7ac2fc3_44be545b","line":7,"range":{"start_line":7,"start_character":43,"end_line":7,"end_character":47},"in_reply_to":"fa550691_d525f093","updated":"2023-12-14 15:57:49.000000000","message":"Done","commit_id":"bacaf7cc91fc7c51689e5fef11e0fe92035fe0c8"}],"ovn_bgp_agent/drivers/openstack/watchers/nb_bgp_watcher.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"9bf24544f9749f346735977ea158bf310f8bfd57","unresolved":true,"context_lines":[{"line_number":666,"context_line":"        old_vip_fip \u003d self._get_vip_fip(old)"},{"line_number":667,"context_line":"        with _SYNC_STATE_LOCK.read_lock():"},{"line_number":668,"context_line":"            if hasattr(old, \u0027external_ids\u0027) and vip_fip !\u003d old_vip_fip:"},{"line_number":669,"context_line":"                return self.agent.expose_ovn_lb_fip(row)"},{"line_number":670,"context_line":"            self.agent.expose_ovn_lb_vip(row)"},{"line_number":671,"context_line":""},{"line_number":672,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"a7b62ebb_26a0ff93","line":669,"range":{"start_line":669,"start_character":16,"end_line":669,"end_character":56},"updated":"2023-12-14 15:32:06.000000000","message":"Mostly nit.\n\nIt just looks odd to have a \"return \u003cmethod\u003e\" statement in the code when this method is not suppose to return anything. I had to look if expose_ovn_lb_fip() was actually going to return something relevant to understand what was expected of _run(). I think it degrades a bit the readability of this function.\n\nMay I propose this to be:\n\n```\nif hasattr(old, \u0027external_ids\u0027) and vip_fip !\u003d old_vip_fip:\n    self.agent.expose_ovn_lb_fip(row)\nelse\n    self.agent.expose_ovn_lb_vip(row)\n```\n\nThat way it\u0027s clear that _run() will never return anything for whoever is reading this code in the future.","commit_id":"bacaf7cc91fc7c51689e5fef11e0fe92035fe0c8"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"7373155a5c11ec1c3edbf42de61efa8e5998e79f","unresolved":false,"context_lines":[{"line_number":666,"context_line":"        old_vip_fip \u003d self._get_vip_fip(old)"},{"line_number":667,"context_line":"        with _SYNC_STATE_LOCK.read_lock():"},{"line_number":668,"context_line":"            if hasattr(old, \u0027external_ids\u0027) and vip_fip !\u003d old_vip_fip:"},{"line_number":669,"context_line":"                return self.agent.expose_ovn_lb_fip(row)"},{"line_number":670,"context_line":"            self.agent.expose_ovn_lb_vip(row)"},{"line_number":671,"context_line":""},{"line_number":672,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"0d4bc5e4_a78c5ecd","line":669,"range":{"start_line":669,"start_character":16,"end_line":669,"end_character":56},"in_reply_to":"a7b62ebb_26a0ff93","updated":"2023-12-14 15:57:49.000000000","message":"ouch... Nice catch. I first have the if hasttr and the vip_fip !\u003d old_vip_fip split and then I added the return but then I joined them. I\u0027ll change it","commit_id":"bacaf7cc91fc7c51689e5fef11e0fe92035fe0c8"}]}