)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"dc1b9a66f4ba74f195741fe761934548e3121627","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"565882ef_78176711","updated":"2024-01-19 07:35:24.000000000","message":"change looks good, but please modify the docstring to reflect the fact that ID is being return if there is no hostnamne","commit_id":"16448f3da1b009fa3a63efa1b1fb6eef58fb3bbf"},{"author":{"_account_id":25468,"name":"Michel Nederlof","email":"michel@nederlof.info","username":"pellucid"},"change_message_id":"7a1d4f206aaf406158f231c190e2b8fdd04d778d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8c8b39c3_f6f4d808","in_reply_to":"565882ef_78176711","updated":"2024-01-19 10:00:13.000000000","message":"I have updated the docstring as requested. should we remove the other docstring as well? (in get_own_chassis_id)","commit_id":"16448f3da1b009fa3a63efa1b1fb6eef58fb3bbf"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"fe1aa53e91fd1d63d4156ab58fe8abdb2ff34ab5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5fca15f4_054523a5","updated":"2024-01-22 07:15:25.000000000","message":"On a second thought, I don\u0027t think this is the right way to do it. In the NB driver we have the next:\n        self.chassis \u003d self.ovs_idl.get_own_chassis_name()\n        self.chassis_id \u003d self.ovs_idl.get_own_chassis_id()\n\nSo, I would keep the get_own_chassis_name to return the name and if there is no name handle that the name is not set, instead of making the get_own_chassis_name return the ID instead.\n\nIn addition, the chassis name is later used on the get_active_lsp_on_chassis so this needs to be handled too","commit_id":"6c3c177b8f0b9eebee05c8025448400075458b65"},{"author":{"_account_id":25468,"name":"Michel Nederlof","email":"michel@nederlof.info","username":"pellucid"},"change_message_id":"ec1f2eb670d5529f893526fb017a9ff6a097b26c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ff623594_a8f462ce","in_reply_to":"077a8a84_5288965a","updated":"2024-01-22 09:27:32.000000000","message":"One other consideration is to make it configurable in the config file, though it would make more sense for those implementations to just fill that hostname field in the Open_vSwitch table. So i guess using the socket.gethostname() would suffice for now (this this is the same handling that ovn-controller uses)","commit_id":"6c3c177b8f0b9eebee05c8025448400075458b65"},{"author":{"_account_id":25468,"name":"Michel Nederlof","email":"michel@nederlof.info","username":"pellucid"},"change_message_id":"160e3c96697010acc0f999331c17b45654416770","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":3,"id":"077a8a84_5288965a","in_reply_to":"5fca15f4_054523a5","updated":"2024-01-22 09:06:52.000000000","message":"I\u0027ve re-read the handling of get_hostname in the ovn controller. and it is fetching the system hostname, if it is not set in the open_vswitch table [1].\n\nI\u0027ll change it accordingly.\n\n[1] https://github.com/ovn-org/ovn/blob/main/controller/chassis.c#L99","commit_id":"6c3c177b8f0b9eebee05c8025448400075458b65"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"aef79563c3cc828c5ecf0243c38970c87279ce82","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"99f716f6_663366d2","updated":"2024-01-22 09:43:24.000000000","message":"LGTM, just the little thing with the imports order","commit_id":"a6c315d1d1b73d8b20f109d6e4fec1d117cc3ab9"},{"author":{"_account_id":25468,"name":"Michel Nederlof","email":"michel@nederlof.info","username":"pellucid"},"change_message_id":"8c8fa83c6d80fd8c4b387f7bc53422420f966b2b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"5bb73fa6_dc6d4545","in_reply_to":"99f716f6_663366d2","updated":"2024-01-22 10:02:31.000000000","message":"Fixed that in newer patch set.","commit_id":"a6c315d1d1b73d8b20f109d6e4fec1d117cc3ab9"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"e7dc22f3f763f7474cf83ad23fc0753ebbf9359b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"365bc5d7_f058ac07","updated":"2024-01-22 10:24:13.000000000","message":"LGTM","commit_id":"c8970b667c984e232fcee7ed9b5de58f1c33fe1d"}],"ovn_bgp_agent/drivers/openstack/utils/ovs.py":[{"author":{"_account_id":25468,"name":"Michel Nederlof","email":"michel@nederlof.info","username":"pellucid"},"change_message_id":"7a1d4f206aaf406158f231c190e2b8fdd04d778d","unresolved":true,"context_lines":[{"line_number":282,"context_line":"        \"\"\"Return the external_ids:system-id value of the Open_vSwitch table."},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"        As long as ovn-controller is running on this node, the key is"},{"line_number":285,"context_line":"        guaranteed to exist and will include the chassis name."},{"line_number":286,"context_line":"        \"\"\""},{"line_number":287,"context_line":"        return self._get_from_ext_ids(\u0027system-id\u0027)"},{"line_number":288,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"db90fe85_b0de4168","side":"PARENT","line":285,"updated":"2024-01-19 10:00:13.000000000","message":"Should we remove these two lines in the docstring as well, since ovn-controller is not in charge of configuring those settings?","commit_id":"2fcf3a4c48dd5ab315b2be34daf620670232de2b"},{"author":{"_account_id":25468,"name":"Michel Nederlof","email":"michel@nederlof.info","username":"pellucid"},"change_message_id":"ec1f2eb670d5529f893526fb017a9ff6a097b26c","unresolved":false,"context_lines":[{"line_number":282,"context_line":"        \"\"\"Return the external_ids:system-id value of the Open_vSwitch table."},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"        As long as ovn-controller is running on this node, the key is"},{"line_number":285,"context_line":"        guaranteed to exist and will include the chassis name."},{"line_number":286,"context_line":"        \"\"\""},{"line_number":287,"context_line":"        return self._get_from_ext_ids(\u0027system-id\u0027)"},{"line_number":288,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"0ed52ab8_8bb08337","side":"PARENT","line":285,"in_reply_to":"57e83572_e0b2616e","updated":"2024-01-22 09:27:32.000000000","message":"removed.","commit_id":"2fcf3a4c48dd5ab315b2be34daf620670232de2b"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"fe1aa53e91fd1d63d4156ab58fe8abdb2ff34ab5","unresolved":true,"context_lines":[{"line_number":282,"context_line":"        \"\"\"Return the external_ids:system-id value of the Open_vSwitch table."},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"        As long as ovn-controller is running on this node, the key is"},{"line_number":285,"context_line":"        guaranteed to exist and will include the chassis name."},{"line_number":286,"context_line":"        \"\"\""},{"line_number":287,"context_line":"        return self._get_from_ext_ids(\u0027system-id\u0027)"},{"line_number":288,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"57e83572_e0b2616e","side":"PARENT","line":285,"in_reply_to":"db90fe85_b0de4168","updated":"2024-01-22 07:15:25.000000000","message":"yep, this can be removed I suppose","commit_id":"2fcf3a4c48dd5ab315b2be34daf620670232de2b"}]}