)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"7b2f7cbfef049e9d5986b768252dedef01d1c7b6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8fc15c89_c3afbe36","updated":"2024-01-26 06:51:01.000000000","message":"I think I found out the response to the first one... one thing is the htmml generated, but the actual command including --fail-under 82 is actually getting 83 coverage: https://f3330a8fb06a0f7d02f0-5040c108db9a551b6197ed5c6d96671e.ssl.cf5.rackcdn.com/906666/1/check/openstack-tox-cover/e67ce2c/tox/cover/6-commands%5B4%5D.log.\n\nSo, just the question about if we should tweak tox.ini too","commit_id":"4777cd788c1e9f3ba11a468a59007c0960106d9c"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"c4da10a7b9f2d99aed9278c71370d322f3b4ac61","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d51110dd_83ddb5db","updated":"2024-01-26 06:47:40.000000000","message":"Looks good but a couple of things needs discussion about this:\n- Why the gate is green reporting a 78 coverage while tox.ini states to fail under 82?\n- Should we remove the omit for the text folders in tox.ini then?\n    stestr run --exclude-regex \".tests.functional\" {posargs}\n    coverage combine\n    coverage html -d cover --omit\u003d\u0027ovn_bgp_agent/tests/*\u0027\n    coverage xml -o cover/coverage.xml --omit\u003d\u0027ovn_bgp_agent/tests/*\u0027\n    coverage report --fail-under\u003d82 --skip-covered --omit\u003d\u0027ovn_bgp_agent/tests/*,ovn_bgp_agent/privileged/linux_net.py,ovn_bgp_agent/utils/linux_net.py\u0027","commit_id":"4777cd788c1e9f3ba11a468a59007c0960106d9c"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"545b2a2db949c6076caca47362de54e48b04427d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"18957426_8d14305f","updated":"2024-01-26 08:07:40.000000000","message":"Awesome! much nicer indeed! Thanks!","commit_id":"54bddd5b9fdfeb5d2fa9a2620ad6a38623ff1158"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"07e1e892a07f7fd00b16404c3cf2d45db0c0c49f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6156c077_eddeddaa","updated":"2024-01-26 07:05:39.000000000","message":"Good catch about the options in tox.ini !\n\nI think the reasonable approach here is to add these omitted directories in .coveragerc, so that we can run coverage outside of tox.\n\nAlso, to me it does not make much sense to include modules which are excluded by the final threshold check, because it\u0027s confusing (as proved in this review).","commit_id":"54bddd5b9fdfeb5d2fa9a2620ad6a38623ff1158"}]}