)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"60af0842fc07948a4b98bcf6c068eaca03bc26c5","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Ignore Bridges where Interface is down"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When the interface of a bridge found in the bridge-mapping is down and not up, issue a warning and continue the sync without it."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Related-bug: #2060453"},{"line_number":12,"context_line":"Change-Id: I176c78cc3409ca72d2f0819078593a4c4ac768ec"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"de0c9f10_ea136852","line":9,"updated":"2024-08-15 15:13:37.000000000","message":"The commit message should be wrapped","commit_id":"566e9f9d5dfc08c672e00ebf0cfe5563b7cd9654"},{"author":{"_account_id":34799,"name":"Justin Lamp","email":"justin.lamp96@gmail.com","username":"justinlamp","status":"Netways GmbH"},"change_message_id":"60abe7e62205ce2ded29c733fac399394480976d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Ignore Bridges where Interface is down"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When the interface of a bridge found in the bridge-mapping is down and not up, issue a warning and continue the sync without it."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Related-bug: #2060453"},{"line_number":12,"context_line":"Change-Id: I176c78cc3409ca72d2f0819078593a4c4ac768ec"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"d19e07ff_b3b4216d","line":9,"in_reply_to":"de0c9f10_ea136852","updated":"2025-02-06 07:51:54.000000000","message":"Done","commit_id":"566e9f9d5dfc08c672e00ebf0cfe5563b7cd9654"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"60af0842fc07948a4b98bcf6c068eaca03bc26c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8b5ed1a9_1c0f0950","updated":"2024-08-15 15:13:37.000000000","message":"Thanks for the patch, just  some minor things inside  :)","commit_id":"566e9f9d5dfc08c672e00ebf0cfe5563b7cd9654"},{"author":{"_account_id":34799,"name":"Justin Lamp","email":"justin.lamp96@gmail.com","username":"justinlamp","status":"Netways GmbH"},"change_message_id":"60abe7e62205ce2ded29c733fac399394480976d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7f126a36_56f016cd","in_reply_to":"8b5ed1a9_1c0f0950","updated":"2025-02-06 07:51:54.000000000","message":"Sorry for the late reply, I must have missed the notification. Hopefully my Patchset ist okay now. 😊","commit_id":"566e9f9d5dfc08c672e00ebf0cfe5563b7cd9654"}],"ovn_bgp_agent/drivers/openstack/ovn_bgp_driver.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"60af0842fc07948a4b98bcf6c068eaca03bc26c5","unresolved":true,"context_lines":[{"line_number":31,"context_line":"from ovn_bgp_agent import exceptions as agent_exc"},{"line_number":32,"context_line":"from ovn_bgp_agent.utils import helpers"},{"line_number":33,"context_line":"from ovn_bgp_agent.utils import linux_net"},{"line_number":34,"context_line":"from pyroute2.netlink.exceptions import NetlinkError"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"CONF \u003d cfg.CONF"},{"line_number":37,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":2,"id":"35dac6bf_9a797ea1","line":34,"updated":"2024-08-15 15:13:37.000000000","message":"`pyroute2` is a third party library so should be in the group of modules on L19\nThe `exceptions` module should be imported and not just an object from the module.\nhttps://docs.openstack.org/hacking/latest/user/hacking.html#imports","commit_id":"566e9f9d5dfc08c672e00ebf0cfe5563b7cd9654"},{"author":{"_account_id":34799,"name":"Justin Lamp","email":"justin.lamp96@gmail.com","username":"justinlamp","status":"Netways GmbH"},"change_message_id":"60abe7e62205ce2ded29c733fac399394480976d","unresolved":false,"context_lines":[{"line_number":31,"context_line":"from ovn_bgp_agent import exceptions as agent_exc"},{"line_number":32,"context_line":"from ovn_bgp_agent.utils import helpers"},{"line_number":33,"context_line":"from ovn_bgp_agent.utils import linux_net"},{"line_number":34,"context_line":"from pyroute2.netlink.exceptions import NetlinkError"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"CONF \u003d cfg.CONF"},{"line_number":37,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":2,"id":"c876be4c_5e04fbb9","line":34,"in_reply_to":"35dac6bf_9a797ea1","updated":"2025-02-06 07:51:54.000000000","message":"Done","commit_id":"566e9f9d5dfc08c672e00ebf0cfe5563b7cd9654"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"60af0842fc07948a4b98bcf6c068eaca03bc26c5","unresolved":true,"context_lines":[{"line_number":161,"context_line":"                            self.ovn_routing_tables, bridge,"},{"line_number":162,"context_line":"                            CONF.bgp_vrf_table_id))"},{"line_number":163,"context_line":"                except NetlinkError as e:"},{"line_number":164,"context_line":"                    if e.args \u003d\u003d (100, \u0027Network is down\u0027):"},{"line_number":165,"context_line":"                        del self.ovn_bridge_mappings[network]"},{"line_number":166,"context_line":"                        LOG.warning("},{"line_number":167,"context_line":"                            \u0027Interface %s is down, skipping it\u0027, bridge)"}],"source_content_type":"text/x-python","patch_set":2,"id":"6ef54efe_8527be7c","line":164,"range":{"start_line":164,"start_character":39,"end_line":164,"end_character":56},"updated":"2024-08-15 15:13:37.000000000","message":"This seems specific to the system locales, perhaps it\u0027s enough to just compare the code?","commit_id":"566e9f9d5dfc08c672e00ebf0cfe5563b7cd9654"},{"author":{"_account_id":34799,"name":"Justin Lamp","email":"justin.lamp96@gmail.com","username":"justinlamp","status":"Netways GmbH"},"change_message_id":"60abe7e62205ce2ded29c733fac399394480976d","unresolved":false,"context_lines":[{"line_number":161,"context_line":"                            self.ovn_routing_tables, bridge,"},{"line_number":162,"context_line":"                            CONF.bgp_vrf_table_id))"},{"line_number":163,"context_line":"                except NetlinkError as e:"},{"line_number":164,"context_line":"                    if e.args \u003d\u003d (100, \u0027Network is down\u0027):"},{"line_number":165,"context_line":"                        del self.ovn_bridge_mappings[network]"},{"line_number":166,"context_line":"                        LOG.warning("},{"line_number":167,"context_line":"                            \u0027Interface %s is down, skipping it\u0027, bridge)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3e06f4f3_e075d83f","line":164,"range":{"start_line":164,"start_character":39,"end_line":164,"end_character":56},"in_reply_to":"6ef54efe_8527be7c","updated":"2025-02-06 07:51:54.000000000","message":"Done","commit_id":"566e9f9d5dfc08c672e00ebf0cfe5563b7cd9654"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"b03af186bb9c36a2ed8a81a42c18787d159480c9","unresolved":true,"context_lines":[{"line_number":19,"context_line":"from oslo_concurrency import lockutils"},{"line_number":20,"context_line":"from oslo_config import cfg"},{"line_number":21,"context_line":"from oslo_log import log as logging"},{"line_number":22,"context_line":"from pyroute2.netlink.exceptions import NetlinkError"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from ovn_bgp_agent import constants"},{"line_number":25,"context_line":"from ovn_bgp_agent.drivers import driver_api"}],"source_content_type":"text/x-python","patch_set":4,"id":"13035630_fbe0a0cd","line":22,"updated":"2025-02-24 18:51:47.000000000","message":"I think this has not been addressed fully. I left two comments in under one suggestion on PS3 - we should not import the objects from modules. So the line should be\n```\nfrom pyroute2.netlink import exceptions as netlink_e\n...\n# when using the exception\nnetlink_e.NetlinkError\n```","commit_id":"43a55bea1c1e4b6e5c50cbc03cec76db0f9d84ed"}]}