)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":24824,"name":"Dmitrii Shcherbakov","username":"dmitriis"},"change_message_id":"30d9e0ba6126ffdd6d6050a1b7a1f9437b02c410","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c500b9fe_427a149c","updated":"2024-06-27 17:25:12.000000000","message":"Passes locally.\n\n```\ntox -e functional\n\n\u003d\u003d\u003d\u003d\u003d\u003d\nTotals\n\u003d\u003d\u003d\u003d\u003d\u003d\nRan: 43 tests in 3.1976 sec.\n - Passed: 43\n - Skipped: 0\n - Expected Fail: 0\n - Unexpected Success: 0\n - Failed: 0\nSum of execute time for each test: 34.2308 sec.\n```","commit_id":"ddfde803f2483d0d0d11bb5bed7d7ee67ae7117c"},{"author":{"_account_id":24824,"name":"Dmitrii Shcherbakov","username":"dmitriis"},"change_message_id":"5ce41f64fce609e2f83c47bd406dc98b9bb5c63a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a991e9e4_511aa25b","updated":"2024-06-27 17:25:24.000000000","message":"recheck","commit_id":"ddfde803f2483d0d0d11bb5bed7d7ee67ae7117c"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"28b511df6ddfc12653aa56323b1934cf4fcfe323","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b66cbe17_d10acf40","updated":"2024-07-09 05:41:01.000000000","message":"this is just to create the internal ovs bridge and to wire it, so it is kind of unrelated to the actual ovn-chassis-id (the connection between that bridge and the relevant chassis goes into ovs configuration. Anyway, the change looks good, perhaps we need to complete the patch with:\n- State this is just for the ovn exposing method (i.e., when an extra OVN cluster is used for routing)\n- Update documentation about how to configure ovs/ovn and use this new config option","commit_id":"ddfde803f2483d0d0d11bb5bed7d7ee67ae7117c"},{"author":{"_account_id":24824,"name":"Dmitrii Shcherbakov","username":"dmitriis"},"change_message_id":"80319a5a583e0f8f0ff138b8b48e75afce125198","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7d5ab93c_22955ca7","in_reply_to":"3c200d28_e9535c40","updated":"2024-07-18 22:53:12.000000000","message":"I uploaded another change with an in-depth example of how to set the configuration options for two ovn-controllers that run on the same host.\n\nThe thing about chassis ID is that it\u0027s used to retrieve the suffixed options that are relevant for the extra ovn-controller (the logic inside ovn-controller C code itself) but this suffix needs to match what `ovn-bgp-agent` itself looks at as it retrieves ovn-bridge-mappings for the extra OVN cluster from the suffixed option:\n\nhttps://github.com/openstack/ovn-bgp-agent/blob/c0459dc8c6607b8f1cb742a6fad23738bc8c5118/ovn_bgp_agent/drivers/openstack/utils/wire.py#L241-L242\n\nI had a suffix other than `bgp` configured for those options initially and got confused as to why patch ports haven\u0027t been created. But, of course, the issue was that `ovn-bgp-agent` needs to create the topology in the local `ovn-nb` first and only then will `ovn-controller` look at the suffixed `ovn-bridge-mappings` option when implementing the changes based on the local `ovn-sb` state created by the local `ovn-northd`. Since `ovn-bgp-agent` was hard-coded to use `bgp` as a suffix, in the line I linked above, it never proceeded to create the local `ovn-nb` state.","commit_id":"ddfde803f2483d0d0d11bb5bed7d7ee67ae7117c"},{"author":{"_account_id":24824,"name":"Dmitrii Shcherbakov","username":"dmitriis"},"change_message_id":"87b198988574359ef8c0cb6d870cf6f59ef71179","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3c200d28_e9535c40","in_reply_to":"b66cbe17_d10acf40","updated":"2024-07-09 12:16:55.000000000","message":"Thanks for the review! I\u0027ll do another upload with the changes.\n\nI have the necessary steps for OVS in a form of ovs-vsctl commands and netplan config to do the same - going to find a place for it in the docs.","commit_id":"ddfde803f2483d0d0d11bb5bed7d7ee67ae7117c"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"775d995b0ffcb338e156cbe1d86f667bce0d48e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e41e453d_622debc9","updated":"2024-07-19 06:00:51.000000000","message":"Thanks! looks great! And nice to see usage of the ovn-routing mode!","commit_id":"e3cb1b4a472e0c2743690af62768a96a1c2b8c00"}]}