)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"917e1fd7164899948ddf72716981ade664c074e2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a261457f_6825399b","updated":"2024-07-19 12:26:07.000000000","message":"Thanks folks","commit_id":"656a427e39928b5a35a00289bef6dda0baac2829"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"b4d736fee4441a3c1cd9785db09e566c0c3f38bb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1224d3e0_64f30f76","updated":"2024-07-19 10:55:24.000000000","message":"Waiting on the author of the patch to ensure that he needs a backport of this or not.","commit_id":"656a427e39928b5a35a00289bef6dda0baac2829"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"8da91c33c30a58c865ede319edebf860936b18e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"3c3d5917_110f9d20","updated":"2024-07-19 10:24:51.000000000","message":"We usually don\u0027t allow backporting new configuration options (although we can also consider exceptions).","commit_id":"656a427e39928b5a35a00289bef6dda0baac2829"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"62ab18c12ac6085aaa10e90f6936f74320f9c891","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5e2074cd_cc65b73b","in_reply_to":"0abd2b25_3f99eb09","updated":"2024-07-19 11:27:38.000000000","message":"The default configuration was bgp (constant), and the new default configuration (config option) is also bgp, so it can not break current environments. The reason for backporting this is that with that system-id (bgp) harcoded, if there are system which were already using ovn-controller with -n option with that name, the ovn-bgp-agent cannot be configured to not clash with the existing one","commit_id":"656a427e39928b5a35a00289bef6dda0baac2829"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"46984f3307a0b60569c182448a14ddc43a015c65","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bee3eb96_e6ff2b2a","in_reply_to":"3c3d5917_110f9d20","updated":"2024-07-19 10:27:03.000000000","message":"In this case, the default value is the same as the previous value. It\u0027s not changing anything. Even then should we block on it ?","commit_id":"656a427e39928b5a35a00289bef6dda0baac2829"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"41c08120775d21c6be1d8844a9cc938905e6a0c6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"52399964_94c3bb70","in_reply_to":"5e2074cd_cc65b73b","updated":"2024-07-19 12:25:02.000000000","message":"Right, so not having this option could lead to an unusable environment. Then I would vote to backport it, also considering that the default value doesn\u0027t change the former hardcoded value.","commit_id":"656a427e39928b5a35a00289bef6dda0baac2829"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"1e9f20f57b24acff3c9a6012e188a569a07c1bc5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d6c7fed4_cc58dd4c","in_reply_to":"bee3eb96_e6ff2b2a","updated":"2024-07-19 10:33:27.000000000","message":"Is this a bug hitting older versions? Is it possible that a node can be named as \"bgp\", clashing with the current ovn-bgp-agent suffix used?","commit_id":"656a427e39928b5a35a00289bef6dda0baac2829"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"b4d736fee4441a3c1cd9785db09e566c0c3f38bb","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0abd2b25_3f99eb09","in_reply_to":"d6c7fed4_cc58dd4c","updated":"2024-07-19 10:55:24.000000000","message":"I don\u0027t see this as a bug but more like an enhancement of what we had previously.\n\nRegarding the clash, I don\u0027t see it happening because from what I understand, this is about the separate OVN cluster that is created when using the \"ovn\" mode.\n\nPerhaps we can wait for the author to see if he needs a backport or if it\u0027s OK to only allow this from master and forward.","commit_id":"656a427e39928b5a35a00289bef6dda0baac2829"}]}