)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"05f82acd27c823a92af3fc0c1444bafb7b12081f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ac75f6a1_9a59654e","updated":"2024-07-29 15:22:50.000000000","message":"I\u0027d like to delay merging this patch as I\u0027m investigation other options such as using the field in Neutron in a consistent way - meaning that external_mac is always set if DVR is enabled.","commit_id":"41c67f743b097014652c5934b8052ae0dc90420f"}],"ovn_bgp_agent/drivers/openstack/nb_ovn_bgp_driver.py":[{"author":{"_account_id":24824,"name":"Dmitrii Shcherbakov","username":"dmitriis"},"change_message_id":"7a9f9eea668ea6a808d1dd9ffb2d985ded0e9e5b","unresolved":true,"context_lines":[{"line_number":1080,"context_line":"            return"},{"line_number":1081,"context_line":""},{"line_number":1082,"context_line":"        try:"},{"line_number":1083,"context_line":"            external_ip, external_mac, ls_name \u003d ("},{"line_number":1084,"context_line":"                self.get_port_external_ip_and_ls(vip_lsp.name))"},{"line_number":1085,"context_line":"        except nb_exceptions.NATNotFound as e:"},{"line_number":1086,"context_line":"            LOG.debug(\"Something went wrong with the VIP %s: %s\","}],"source_content_type":"text/x-python","patch_set":2,"id":"395a9c61_a047b27e","line":1083,"range":{"start_line":1083,"start_character":25,"end_line":1083,"end_character":37},"updated":"2024-10-03 01:08:01.000000000","message":"Stumbled upon the lack of the mac address in the Static_Mac_Binding too because `enable_distributed_floating_ip` wasn\u0027t enabled by default in the Neutron config for OVN.\n\nIt doesn\u0027t look like it\u0027s mentioned at all in the docs or the repo:\n\n```\n➜  ovn-bgp-agent git:(master) ✗ vgrep -i enable_distributed_floating_ip\n➜  ovn-bgp-agent git:(master) ✗ \n```\n\nI think a doc entry about `enable_distributed_floating_ip` would help because debugging the lack of this option takes a lot of time.","commit_id":"92fa76057c8af72e8d6b7d6c4a78d04a43578647"}]}