)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"9c8d21a360326d2454b149a96facf40d1da4fb2f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1e944187_d7822986","updated":"2024-08-02 06:38:08.000000000","message":"I understand the logic behind this, but the utils method can be confusing if not split, for instance, _is_vip_or_fip only applies if the row is of LoadBalancer event type. Then, having them altogether in a utils function may lead to wrong usage in the future. Perhaps a better approach is to have several utils modules: lb_utils, port_utils, ... What do you think?","commit_id":"81bf90c916eb78d18833e27112b53299e4a84a30"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"37780f841482bf77fbdd2a381920e29ed3e338c0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2c267486_e8613bf4","in_reply_to":"1e944187_d7822986","updated":"2024-08-02 12:03:54.000000000","message":"Makes total sense, I tried to keep the table name included in the name of the function but I like the idea of having a module representing a table better. Thanks!","commit_id":"81bf90c916eb78d18833e27112b53299e4a84a30"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"1aa7f7a7dd1a7827f316545eae086a303d121a72","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"499b0d82_0a4e2447","updated":"2024-08-06 15:31:20.000000000","message":"Ninja approving since only a docstring was changed","commit_id":"fed8d0376d90c2db980b71afa3558491da0bb3c7"}],"ovn_bgp_agent/drivers/openstack/utils/loadbalancer.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"57a442b37abd012a6863bdb89c0404892121a5b2","unresolved":true,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"def get_diff_ip_from_vips(new, old):"},{"line_number":31,"context_line":"    \"Return a set of IPs that are present in \u0027new\u0027 but not in \u0027old\u0027\""},{"line_number":32,"context_line":"    return get_vips(new) - get_vips(old)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"eb39b751_5659e50a","line":31,"updated":"2024-08-06 15:26:53.000000000","message":"nit: Docstrings this should be triple-quoted (\"\"\"...\"\"\")","commit_id":"bace014faee7df3b30c110a126ee35fa2ef99149"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"96ca03b356315ed4050426d0086ec25c95f9ccf7","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"def get_diff_ip_from_vips(new, old):"},{"line_number":31,"context_line":"    \"Return a set of IPs that are present in \u0027new\u0027 but not in \u0027old\u0027\""},{"line_number":32,"context_line":"    return get_vips(new) - get_vips(old)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5047cb04_c85ebde0","line":31,"in_reply_to":"eb39b751_5659e50a","updated":"2024-08-06 15:31:29.000000000","message":"thanks! done","commit_id":"bace014faee7df3b30c110a126ee35fa2ef99149"}]}