)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"d81a732d9d01d9b432d6ba5ebef8f3da56f39872","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fafdf146_782baf98","updated":"2024-08-07 05:43:31.000000000","message":"I love the new exceptions, but those should be managed/catched on the driver, otherwise it is going to have side-effects. Most probably, in all the cases we just need to continue (iteration on the loop) or return","commit_id":"0bc65f38a3e86c821e42c1ccf800342f5f38c03c"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"3b7feb54423ebc86ffdae7f383f41b6134071650","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a550bbba_6f6753d2","in_reply_to":"31e341af_36d681d6","updated":"2024-08-07 12:29:51.000000000","message":"for the mac yes, but for the IPs no, right? Before, if empty, it will just be empty (instead of indexError/AttributeError, and now it will raise  exceptions.IpAddressNotFound(lsp\u003dlsp)","commit_id":"0bc65f38a3e86c821e42c1ccf800342f5f38c03c"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"3d89b93816c1c394fa8528228120122c725a2ee8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b33b8d59_f306634d","in_reply_to":"a550bbba_6f6753d2","updated":"2024-08-07 12:40:20.000000000","message":"You\u0027re right","commit_id":"0bc65f38a3e86c821e42c1ccf800342f5f38c03c"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"b72161704ba0df4380f23ec4103e6caa191af6e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"31e341af_36d681d6","in_reply_to":"fafdf146_782baf98","updated":"2024-08-07 12:12:30.000000000","message":"Good point, I will make the code more robust. Note that the behavior was not changed even with the new exceptions. If the LSP row was missing some data, the previous code would have raised exception too - either IndexError or AttributeError.","commit_id":"0bc65f38a3e86c821e42c1ccf800342f5f38c03c"}],"ovn_bgp_agent/drivers/openstack/watchers/nb_bgp_watcher.py":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"b19601818c7fef96d8ef5be70cd80d1df780169c","unresolved":true,"context_lines":[{"line_number":677,"context_line":"                            constants.OVN_VIRTUAL_VIF_PORT_TYPE]:"},{"line_number":678,"context_line":"            return"},{"line_number":679,"context_line":"        with _SYNC_STATE_LOCK.read_lock():"},{"line_number":680,"context_line":"            ips \u003d port_utils.get_ips_from_lsp(row)"},{"line_number":681,"context_line":"            mac \u003d port_utils.get_mac_from_lsp(row)"},{"line_number":682,"context_line":"            ips_info \u003d {"},{"line_number":683,"context_line":"                \u0027mac\u0027: mac,"}],"source_content_type":"text/x-python","patch_set":3,"id":"b240f340_32c51d60","line":680,"range":{"start_line":680,"start_character":12,"end_line":680,"end_character":50},"updated":"2024-10-04 08:18:37.000000000","message":"as in this case the row ips are not checkedi n the match_fn, should we do the try/except here too?","commit_id":"9693587948cbd228161c0e81db4511a3c7f319f1"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"fa7d7aa378fbcb2aeec178cee92addd7716869f5","unresolved":false,"context_lines":[{"line_number":677,"context_line":"                            constants.OVN_VIRTUAL_VIF_PORT_TYPE]:"},{"line_number":678,"context_line":"            return"},{"line_number":679,"context_line":"        with _SYNC_STATE_LOCK.read_lock():"},{"line_number":680,"context_line":"            ips \u003d port_utils.get_ips_from_lsp(row)"},{"line_number":681,"context_line":"            mac \u003d port_utils.get_mac_from_lsp(row)"},{"line_number":682,"context_line":"            ips_info \u003d {"},{"line_number":683,"context_line":"                \u0027mac\u0027: mac,"}],"source_content_type":"text/x-python","patch_set":3,"id":"d39cc49a_be3e7384","line":680,"range":{"start_line":680,"start_character":12,"end_line":680,"end_character":50},"in_reply_to":"77c6e468_91c9492f","updated":"2024-10-04 13:04:43.000000000","message":"Ahh, right,!","commit_id":"9693587948cbd228161c0e81db4511a3c7f319f1"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"884712c4e5d60f5a69d094785cabe42c62183fa6","unresolved":true,"context_lines":[{"line_number":677,"context_line":"                            constants.OVN_VIRTUAL_VIF_PORT_TYPE]:"},{"line_number":678,"context_line":"            return"},{"line_number":679,"context_line":"        with _SYNC_STATE_LOCK.read_lock():"},{"line_number":680,"context_line":"            ips \u003d port_utils.get_ips_from_lsp(row)"},{"line_number":681,"context_line":"            mac \u003d port_utils.get_mac_from_lsp(row)"},{"line_number":682,"context_line":"            ips_info \u003d {"},{"line_number":683,"context_line":"                \u0027mac\u0027: mac,"}],"source_content_type":"text/x-python","patch_set":3,"id":"77c6e468_91c9492f","line":680,"range":{"start_line":680,"start_character":12,"end_line":680,"end_character":50},"in_reply_to":"b240f340_32c51d60","updated":"2024-10-04 12:49:39.000000000","message":"I think if the address is missing, it\u0027s gonna return `False` in `match_fn` on L657 but I can doublecheck. Thanks :)","commit_id":"9693587948cbd228161c0e81db4511a3c7f319f1"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e4beac98bca1507fe18746fb79f19f795d87ffc6","unresolved":false,"context_lines":[{"line_number":677,"context_line":"                            constants.OVN_VIRTUAL_VIF_PORT_TYPE]:"},{"line_number":678,"context_line":"            return"},{"line_number":679,"context_line":"        with _SYNC_STATE_LOCK.read_lock():"},{"line_number":680,"context_line":"            ips \u003d port_utils.get_ips_from_lsp(row)"},{"line_number":681,"context_line":"            mac \u003d port_utils.get_mac_from_lsp(row)"},{"line_number":682,"context_line":"            ips_info \u003d {"},{"line_number":683,"context_line":"                \u0027mac\u0027: mac,"}],"source_content_type":"text/x-python","patch_set":3,"id":"47a59a4e_3b8612b3","line":680,"range":{"start_line":680,"start_character":12,"end_line":680,"end_character":50},"in_reply_to":"d39cc49a_be3e7384","updated":"2024-10-04 13:08:47.000000000","message":"I will leave a code comment here, it is not obvious from reading the code.","commit_id":"9693587948cbd228161c0e81db4511a3c7f319f1"}]}