)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"7258eee29c52fb5681c7bbcb3d620b2a08ff5a79","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"16ff8f59_a38aa586","updated":"2024-11-01 15:21:41.000000000","message":"Looks good to me. nittiest of nits on using assertCountEqual, but feel free to ignore that.","commit_id":"0540c31526c825e8efdb3f89e78843d7f8604e94"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"3c7b5f98204b56aeea6c1154cb8bdbe60f4da0f5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a5ef8a7d_1397282a","updated":"2024-10-31 15:18:08.000000000","message":"Small nit in the setup-ovs script","commit_id":"0540c31526c825e8efdb3f89e78843d7f8604e94"}],"ovn_bgp_agent/tests/functional/drivers/openstack/utils/test_ovn.py":[{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"7258eee29c52fb5681c7bbcb3d620b2a08ff5a79","unresolved":true,"context_lines":[{"line_number":45,"context_line":"                ls_name, lsp_name,"},{"line_number":46,"context_line":"                type_\u003dNone, tag\u003di + len_tags)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        tags \u003d sorted(self.api.get_network_vlan_tags())"},{"line_number":49,"context_line":"        self.assertEqual(expected_tags, tags)"}],"source_content_type":"text/x-python","patch_set":6,"id":"cf377f4f_ac1f4a08","line":49,"range":{"start_line":48,"start_character":0,"end_line":49,"end_character":45},"updated":"2024-11-01 15:21:41.000000000","message":"(nit) Can just use https://docs.python.org/3/library/unittest.html#unittest.TestCase.assertCountEqual here.","commit_id":"0540c31526c825e8efdb3f89e78843d7f8604e94"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"0bd829982c0de388a7554ba56509fd94d28d1d42","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                ls_name, lsp_name,"},{"line_number":46,"context_line":"                type_\u003dNone, tag\u003di + len_tags)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        tags \u003d sorted(self.api.get_network_vlan_tags())"},{"line_number":49,"context_line":"        self.assertEqual(expected_tags, tags)"}],"source_content_type":"text/x-python","patch_set":6,"id":"55476f98_28ff87af","line":49,"range":{"start_line":48,"start_character":0,"end_line":49,"end_character":45},"in_reply_to":"a1d37ee9_855d86a3","updated":"2024-11-01 15:26:35.000000000","message":"Done","commit_id":"0540c31526c825e8efdb3f89e78843d7f8604e94"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"bf12c6ecd8591dfa664e289a91ab23c0c95e227e","unresolved":true,"context_lines":[{"line_number":45,"context_line":"                ls_name, lsp_name,"},{"line_number":46,"context_line":"                type_\u003dNone, tag\u003di + len_tags)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        tags \u003d sorted(self.api.get_network_vlan_tags())"},{"line_number":49,"context_line":"        self.assertEqual(expected_tags, tags)"}],"source_content_type":"text/x-python","patch_set":6,"id":"a1d37ee9_855d86a3","line":49,"range":{"start_line":48,"start_character":0,"end_line":49,"end_character":45},"in_reply_to":"cf377f4f_ac1f4a08","updated":"2024-11-01 15:24:47.000000000","message":"THanks! will update","commit_id":"0540c31526c825e8efdb3f89e78843d7f8604e94"}],"tools/setup-ovs.sh":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"3c7b5f98204b56aeea6c1154cb8bdbe60f4da0f5","unresolved":true,"context_lines":[{"line_number":7,"context_line":"if [ \"$OVN_SRCDIR\" -a ! -d \"$OVN_SRCDIR\" ]; then"},{"line_number":8,"context_line":"    echo \"Building OVN branch $OVN_BRANCH in $OVN_SRCDIR\""},{"line_number":9,"context_line":"    mkdir -p $OVN_SRCDIR"},{"line_number":10,"context_line":"    git clone --recurse-submodules https://github.com/ovn-org/ovn.git $OVN_SRCDIR"},{"line_number":11,"context_line":"    pushd $OVN_SRCDIR"},{"line_number":12,"context_line":"    git checkout $OVN_BRANCH"},{"line_number":13,"context_line":"    pushd ovs"},{"line_number":14,"context_line":"    ./boot.sh \u0026\u0026 PYTHON\u003d/usr/bin/python ./configure \u0026\u0026 make -j$(($(nproc) + 1))"},{"line_number":15,"context_line":"    popd"},{"line_number":16,"context_line":"    ./boot.sh \u0026\u0026 PYTHON\u003d/usr/bin/python ./configure \u0026\u0026 make -j$(($(nproc) + 1))"},{"line_number":17,"context_line":"    popd"},{"line_number":18,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":6,"id":"4500ee24_75f6fc0e","line":17,"range":{"start_line":10,"start_character":4,"end_line":17,"end_character":8},"updated":"2024-10-31 15:18:08.000000000","message":"There is a compile_ovn method in devstack/lib/neutron_plugins/ovn_agent. Maybe you\u0027ll prefer to use it","commit_id":"0540c31526c825e8efdb3f89e78843d7f8604e94"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"d6a32d78560503542ca2a03ebc518dbd476152a9","unresolved":false,"context_lines":[{"line_number":7,"context_line":"if [ \"$OVN_SRCDIR\" -a ! -d \"$OVN_SRCDIR\" ]; then"},{"line_number":8,"context_line":"    echo \"Building OVN branch $OVN_BRANCH in $OVN_SRCDIR\""},{"line_number":9,"context_line":"    mkdir -p $OVN_SRCDIR"},{"line_number":10,"context_line":"    git clone --recurse-submodules https://github.com/ovn-org/ovn.git $OVN_SRCDIR"},{"line_number":11,"context_line":"    pushd $OVN_SRCDIR"},{"line_number":12,"context_line":"    git checkout $OVN_BRANCH"},{"line_number":13,"context_line":"    pushd ovs"},{"line_number":14,"context_line":"    ./boot.sh \u0026\u0026 PYTHON\u003d/usr/bin/python ./configure \u0026\u0026 make -j$(($(nproc) + 1))"},{"line_number":15,"context_line":"    popd"},{"line_number":16,"context_line":"    ./boot.sh \u0026\u0026 PYTHON\u003d/usr/bin/python ./configure \u0026\u0026 make -j$(($(nproc) + 1))"},{"line_number":17,"context_line":"    popd"},{"line_number":18,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":6,"id":"19794b2f_2b53014f","line":17,"range":{"start_line":10,"start_character":4,"end_line":17,"end_character":8},"in_reply_to":"06b9461b_6b0d0330","updated":"2024-11-20 14:10:57.000000000","message":"Done","commit_id":"0540c31526c825e8efdb3f89e78843d7f8604e94"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"2f8a142c79e4f1b452b9650a8afb2a0f2b7027bc","unresolved":true,"context_lines":[{"line_number":7,"context_line":"if [ \"$OVN_SRCDIR\" -a ! -d \"$OVN_SRCDIR\" ]; then"},{"line_number":8,"context_line":"    echo \"Building OVN branch $OVN_BRANCH in $OVN_SRCDIR\""},{"line_number":9,"context_line":"    mkdir -p $OVN_SRCDIR"},{"line_number":10,"context_line":"    git clone --recurse-submodules https://github.com/ovn-org/ovn.git $OVN_SRCDIR"},{"line_number":11,"context_line":"    pushd $OVN_SRCDIR"},{"line_number":12,"context_line":"    git checkout $OVN_BRANCH"},{"line_number":13,"context_line":"    pushd ovs"},{"line_number":14,"context_line":"    ./boot.sh \u0026\u0026 PYTHON\u003d/usr/bin/python ./configure \u0026\u0026 make -j$(($(nproc) + 1))"},{"line_number":15,"context_line":"    popd"},{"line_number":16,"context_line":"    ./boot.sh \u0026\u0026 PYTHON\u003d/usr/bin/python ./configure \u0026\u0026 make -j$(($(nproc) + 1))"},{"line_number":17,"context_line":"    popd"},{"line_number":18,"context_line":"fi"}],"source_content_type":"text/x-sh","patch_set":6,"id":"06b9461b_6b0d0330","line":17,"range":{"start_line":10,"start_character":4,"end_line":17,"end_character":8},"in_reply_to":"4500ee24_75f6fc0e","updated":"2024-10-31 19:20:45.000000000","message":"Thanks for the suggestion. Looking at the code it also installs the utilities (make install) while here we just need to compile it.\n\nAlso it would create a dependency on devstack. Having the code as is gives possibility to clone the ovn_bgp_agent code and run the functional tests without need of devstack.","commit_id":"0540c31526c825e8efdb3f89e78843d7f8604e94"}]}