)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"1b3b60b2694e641217d230afbd7268d0279b7790","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"573a7b21_f2282db1","updated":"2024-11-13 12:03:26.000000000","message":"BTW, although the original patch [1] introduced a new config option, that usually makes the patch not backportable, it was up to 2023.2.\n\n[1]https://review.opendev.org/q/Ida30b46e16ddcdc2d82af980546876f72a845c1d","commit_id":"4f8fe6adbfca242c5d4ef7d4d66b9240785f945e"}],"ovn_bgp_agent/config.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"10244d9e4ce2a12e6419e69ea05002871c2f3120","unresolved":false,"context_lines":[{"line_number":232,"context_line":"                default\u003d[\u0027192.168.0.0/16\u0027],"},{"line_number":233,"context_line":"                help\u003d\u0027List of prefixes for provider networks\u0027),"},{"line_number":234,"context_line":"    cfg.StrOpt(\u0027bgp_chassis_id\u0027,"},{"line_number":235,"context_line":"               default\u003d\u0027bgp\u0027,"},{"line_number":236,"context_line":"               help\u003d\u0027The chassis_id used for the ovn-controller instance\u0027"},{"line_number":237,"context_line":"                    \u0027 related to the node-local OVN instance. Used as a\u0027"},{"line_number":238,"context_line":"                    \u0027 suffix for getting instance-specific options\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"ecd053d0_7d360198","line":235,"range":{"start_line":235,"start_character":15,"end_line":235,"end_character":29},"updated":"2024-11-13 12:01:48.000000000","message":"Checking the ListOpt validator, it is accepted to pass a string in a ListOpt, it will be converted to a single element list. This is why the previous definition was working. NOTE: I think we should change that in oslo_config","commit_id":"4f8fe6adbfca242c5d4ef7d4d66b9240785f945e"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"53a7b74ef744e154cf0d0bb7c8b528e2ea7c8308","unresolved":false,"context_lines":[{"line_number":232,"context_line":"                default\u003d[\u0027192.168.0.0/16\u0027],"},{"line_number":233,"context_line":"                help\u003d\u0027List of prefixes for provider networks\u0027),"},{"line_number":234,"context_line":"    cfg.StrOpt(\u0027bgp_chassis_id\u0027,"},{"line_number":235,"context_line":"               default\u003d\u0027bgp\u0027,"},{"line_number":236,"context_line":"               help\u003d\u0027The chassis_id used for the ovn-controller instance\u0027"},{"line_number":237,"context_line":"                    \u0027 related to the node-local OVN instance. Used as a\u0027"},{"line_number":238,"context_line":"                    \u0027 suffix for getting instance-specific options\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"0d5cbf56_1f4a9b70","line":235,"range":{"start_line":235,"start_character":15,"end_line":235,"end_character":29},"in_reply_to":"76c2c18d_37bbf44b","updated":"2024-11-13 14:25:22.000000000","message":"We are saying the same: ListOpt converts the value provided, if it is a string, to a single element list.","commit_id":"4f8fe6adbfca242c5d4ef7d4d66b9240785f945e"},{"author":{"_account_id":31291,"name":"Eduardo Olivares","email":"eolivare@redhat.com","username":"eolivare"},"change_message_id":"74c4f0923f9fd372f525b35fdd80bb857d44b62e","unresolved":false,"context_lines":[{"line_number":232,"context_line":"                default\u003d[\u0027192.168.0.0/16\u0027],"},{"line_number":233,"context_line":"                help\u003d\u0027List of prefixes for provider networks\u0027),"},{"line_number":234,"context_line":"    cfg.StrOpt(\u0027bgp_chassis_id\u0027,"},{"line_number":235,"context_line":"               default\u003d\u0027bgp\u0027,"},{"line_number":236,"context_line":"               help\u003d\u0027The chassis_id used for the ovn-controller instance\u0027"},{"line_number":237,"context_line":"                    \u0027 related to the node-local OVN instance. Used as a\u0027"},{"line_number":238,"context_line":"                    \u0027 suffix for getting instance-specific options\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"76c2c18d_37bbf44b","line":235,"range":{"start_line":235,"start_character":15,"end_line":235,"end_character":29},"in_reply_to":"ecd053d0_7d360198","updated":"2024-11-13 12:35:59.000000000","message":"hmmm, this is strange because what I faced is that the default value was converted to a list.\nI addded some logs before line 243 at [1] and this is what I found:\n```\nNov 13 10:40:57 compute-dec7qr72-0 ovn_bgp_agent[15313]: 2024-11-13 10:40:57.416 2 DEBUG ovn_bgp_agent.drivers.openstack.utils.wire [-] EDU bgp_bridge_mappings \u003d [] _ensure_base_wiring_config_ovn /usr/lib/python3.9/site-packages/ovn_bgp_agent/drivers/openstack/utils/wire.py:243#033[00m\nNov 13 10:40:57 compute-dec7qr72-0 ovn_bgp_agent[15313]: 2024-11-13 10:40:57.417 2 DEBUG ovn_bgp_agent.drivers.openstack.utils.wire [-] EDU CONF.local_ovn_cluster.bgp_chassis_id \u003d [\u0027bgp\u0027] _ensure_base_wiring_config_ovn /usr/lib/python3.9/site-packages/ovn_bgp_agent/drivers/openstack/utils/wire.py:244\n```\n\nThen I fixed the type to StrOpt and I obtained the expected result:\n```\nNov 13 10:44:47 compute-dec7qr72-0 ovn_bgp_agent[16249]: 2024-11-13 10:44:47.465 2 DEBUG ovn_bgp_agent.drivers.openstack.utils.wire [-] EDU bgp_bridge_mappings \u003d [\u0027bgp-openstack:br-provider\u0027, \u0027bgp-ex:br-ex\u0027] _ensure_base_wiring_config_ovn /usr/lib/python3.9/site-packages/ovn_bgp_agent/drivers/openstack/utils/wire.py:243\nNov 13 10:44:47 compute-dec7qr72-0 ovn_bgp_agent[16249]: 2024-11-13 10:44:47.465 2 DEBUG ovn_bgp_agent.drivers.openstack.utils.wire [-] EDU CONF.local_ovn_cluster.bgp_chassis_id \u003d \u0027bgp\u0027 _ensure_base_wiring_config_ovn /usr/lib/python3.9/site-packages/ovn_bgp_agent/drivers/openstack/utils/wire.py:244\n```\n\n\n\n\n\n[1] https://opendev.org/openstack/ovn-bgp-agent/src/branch/master/ovn_bgp_agent/drivers/openstack/utils/wire.py#L243","commit_id":"4f8fe6adbfca242c5d4ef7d4d66b9240785f945e"}]}