)]}'
{"ovn_bgp_agent/drivers/openstack/utils/common.py":[{"author":{"_account_id":31291,"name":"Eduardo Olivares","email":"eolivare@redhat.com","username":"eolivare"},"change_message_id":"229bf0da46953f71eac8a700e562e6468038b207","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# limitations under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"def get_from_external_ids(row, key):"},{"line_number":17,"context_line":"    try:"},{"line_number":18,"context_line":"        return row.external_ids[key]"},{"line_number":19,"context_line":"    except (AttributeError, KeyError):"}],"source_content_type":"text/x-python","patch_set":1,"id":"8f8f9296_827d51a0","line":16,"range":{"start_line":16,"start_character":31,"end_line":16,"end_character":34},"updated":"2024-11-20 11:43:20.000000000","message":"I was thinking that, considering this patch always uses this method with key\u003dconstants.OVN_LS_NAME_EXT_ID_KEY, that could be the default value here.\n\nOTOH, that would make this code less generic and perhaps we\u0027d need to use this method to obtain different keys in the future.","commit_id":"b6a658ac95a423c474a53c1f0fa144dadf6598e3"},{"author":{"_account_id":31291,"name":"Eduardo Olivares","email":"eolivare@redhat.com","username":"eolivare"},"change_message_id":"330b82e53146baa3947687ac50a806bffdd77330","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# limitations under the License."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"def get_from_external_ids(row, key):"},{"line_number":17,"context_line":"    try:"},{"line_number":18,"context_line":"        return row.external_ids[key]"},{"line_number":19,"context_line":"    except (AttributeError, KeyError):"}],"source_content_type":"text/x-python","patch_set":1,"id":"a7472fcb_d8af5bc0","line":16,"range":{"start_line":16,"start_character":31,"end_line":16,"end_character":34},"in_reply_to":"8f8f9296_827d51a0","updated":"2024-11-20 11:45:23.000000000","message":"aha, next patch was the answer to my comment:\nhttps://review.opendev.org/c/openstack/ovn-bgp-agent/+/935212/1","commit_id":"b6a658ac95a423c474a53c1f0fa144dadf6598e3"}]}