)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"18488afdb8654332005dbcaaa88b238a06ac331a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"56ac3aeb_1c8dd609","updated":"2025-05-07 15:09:21.000000000","message":"@winterma.dong@gmail.com do you mind revising these small changes?","commit_id":"70ddf0cf13b214518ac875eebf3ca09fb2878bb6"},{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"cf99d4c8dd7653b8fc8847c19fc2381d8cf428d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"46cb8d2c_eb8d0daa","updated":"2025-04-04 00:36:32.000000000","message":"Can we get some love for this?  This really helps us and doesn\u0027t introduce much burden.","commit_id":"70ddf0cf13b214518ac875eebf3ca09fb2878bb6"},{"author":{"_account_id":9725,"name":"Dong Ma","email":"winterma.dong@gmail.com","username":"larainema"},"change_message_id":"3fc6e24d366a65ff2064912d1a3ba3e7439ab994","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"74c74e25_2be94a31","updated":"2025-03-14 10:53:41.000000000","message":"lgtm","commit_id":"70ddf0cf13b214518ac875eebf3ca09fb2878bb6"}],"ovn_bgp_agent/config.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"57a90138779f73cb0bd03196661df2c2e269498c","unresolved":true,"context_lines":[{"line_number":66,"context_line":"               choices\u003d(\u0027ovn_bgp_driver\u0027, \u0027ovn_evpn_driver\u0027,"},{"line_number":67,"context_line":"                        \u0027ovn_stretched_l2_bgp_driver\u0027, \u0027nb_ovn_bgp_driver\u0027),"},{"line_number":68,"context_line":"               default\u003d\u0027ovn_bgp_driver\u0027),"},{"line_number":69,"context_line":"    cfg.StrOpt(\u0027bgp_driver\u0027,"},{"line_number":70,"context_line":"               help\u003d\u0027BGP Driver to be used for exposing/witdrawing routes\u0027,"},{"line_number":71,"context_line":"               default\u003d\u0027frr\u0027),"},{"line_number":72,"context_line":"    cfg.StrOpt(\u0027ovsdb_connection\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a0eaf7f_34d561f5","line":69,"updated":"2025-04-04 18:39:01.000000000","message":"Opinion: I find it a little bit confusing having a `driver` that is for example `nb_ovn_bgp_driver` (bgp driver in the name) and another config option `bgp_driver`. It\u0027s also used only in two drivers. How about `evpn_driver` or `exposing_driver`. The latter is confusing with `exposing_method` ... any ideas? :)","commit_id":"70ddf0cf13b214518ac875eebf3ca09fb2878bb6"},{"author":{"_account_id":9725,"name":"Dong Ma","email":"winterma.dong@gmail.com","username":"larainema"},"change_message_id":"31814deb001fc2e5a33f6e77ae173423aa3f1c25","unresolved":false,"context_lines":[{"line_number":66,"context_line":"               choices\u003d(\u0027ovn_bgp_driver\u0027, \u0027ovn_evpn_driver\u0027,"},{"line_number":67,"context_line":"                        \u0027ovn_stretched_l2_bgp_driver\u0027, \u0027nb_ovn_bgp_driver\u0027),"},{"line_number":68,"context_line":"               default\u003d\u0027ovn_bgp_driver\u0027),"},{"line_number":69,"context_line":"    cfg.StrOpt(\u0027bgp_driver\u0027,"},{"line_number":70,"context_line":"               help\u003d\u0027BGP Driver to be used for exposing/witdrawing routes\u0027,"},{"line_number":71,"context_line":"               default\u003d\u0027frr\u0027),"},{"line_number":72,"context_line":"    cfg.StrOpt(\u0027ovsdb_connection\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"bba63811_d68b6022","line":69,"in_reply_to":"9a0eaf7f_34d561f5","updated":"2025-05-08 05:49:05.000000000","message":"how about use `routing_driver`?","commit_id":"70ddf0cf13b214518ac875eebf3ca09fb2878bb6"}],"ovn_bgp_agent/drivers/openstack/utils/frr.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"57a90138779f73cb0bd03196661df2c2e269498c","unresolved":true,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"DEFAULT_REDISTRIBUTE \u003d {\u0027connected\u0027}"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"CONFIGURE_ND_TEMPLATE \u003d \u0027\u0027\u0027"},{"line_number":33,"context_line":"interface {{ intf }}"}],"source_content_type":"text/x-python","patch_set":3,"id":"9d443cf8_19d9abc1","line":30,"updated":"2025-04-04 18:39:01.000000000","message":"This should become a class or an instance attribute since now we change it with an instance method on L224. I know the instance is likely a singleton but the cost of doing such a change is low.","commit_id":"70ddf0cf13b214518ac875eebf3ca09fb2878bb6"},{"author":{"_account_id":9725,"name":"Dong Ma","email":"winterma.dong@gmail.com","username":"larainema"},"change_message_id":"31814deb001fc2e5a33f6e77ae173423aa3f1c25","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"DEFAULT_REDISTRIBUTE \u003d {\u0027connected\u0027}"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"CONFIGURE_ND_TEMPLATE \u003d \u0027\u0027\u0027"},{"line_number":33,"context_line":"interface {{ intf }}"}],"source_content_type":"text/x-python","patch_set":3,"id":"ce30fa25_a9ddf32f","line":30,"in_reply_to":"9d443cf8_19d9abc1","updated":"2025-05-08 05:49:05.000000000","message":"Done","commit_id":"70ddf0cf13b214518ac875eebf3ca09fb2878bb6"}]}