)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"2e18dac149bd9c6b8002f4a2b59b798d8015b89d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1468d439_0ed14af0","updated":"2025-08-16 16:07:29.000000000","message":"Hello,\n\nPlease check tests too:\n\nhttps://opendev.org/openstack/ovn-bgp-agent/src/branch/master/ovn_bgp_agent/tests/unit/drivers/openstack/utils/test_wire.py#L373\n\nhttps://opendev.org/openstack/ovn-bgp-agent/src/commit/50e00d232bfc63861cd53867a10d168f015ebc20/ovn_bgp_agent/tests/unit/drivers/openstack/test_nb_ovn_bgp_driver.py#L147","commit_id":"5a5927fd6e97548ab76df6b7bbb53c49546c10eb"},{"author":{"_account_id":36998,"name":"Ilia Baikov","display_name":"Ilia Baikov","email":"ilia.baikov@ib.systems","username":"frct1"},"change_message_id":"53f0398dd02a3e4eff652cb5ddcf7fa5bc65edcd","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2068a69c_3d18555f","updated":"2025-08-16 13:27:38.000000000","message":"It needs to be cherry-picked to previous branches as well. First occurence happened at Zed release. Didn\u0027t test on older releases but them are also affected.","commit_id":"5a5927fd6e97548ab76df6b7bbb53c49546c10eb"},{"author":{"_account_id":36998,"name":"Ilia Baikov","display_name":"Ilia Baikov","email":"ilia.baikov@ib.systems","username":"frct1"},"change_message_id":"44b5ddbad5787a73d6fdbd3ca331cafb04acd1c1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e529db96_284e3700","in_reply_to":"1468d439_0ed14af0","updated":"2025-08-16 16:31:56.000000000","message":"Since test methods pass IPs as set argument I\u0027m thinking to convert set to list in `delete_exposed_ips` method itself. WDYT?","commit_id":"5a5927fd6e97548ab76df6b7bbb53c49546c10eb"},{"author":{"_account_id":36998,"name":"Ilia Baikov","display_name":"Ilia Baikov","email":"ilia.baikov@ib.systems","username":"frct1"},"change_message_id":"44b5ddbad5787a73d6fdbd3ca331cafb04acd1c1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8c71c135_af31cd67","in_reply_to":"2068a69c_3d18555f","updated":"2025-08-16 16:31:56.000000000","message":"Done","commit_id":"5a5927fd6e97548ab76df6b7bbb53c49546c10eb"},{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"c28cab9b38db9ea3ed5e075965f3ebeb7f54a17c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5a396ad4_df508015","in_reply_to":"8c71c135_af31cd67","updated":"2025-08-17 01:35:08.000000000","message":"Done","commit_id":"5a5927fd6e97548ab76df6b7bbb53c49546c10eb"},{"author":{"_account_id":36998,"name":"Ilia Baikov","display_name":"Ilia Baikov","email":"ilia.baikov@ib.systems","username":"frct1"},"change_message_id":"0855ee20dc476f0a6d79fcf8d8fa70c8a2e4a383","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6f6f06b8_987d6ae1","in_reply_to":"b3698028_3c7343bf","updated":"2025-08-16 16:36:59.000000000","message":"Acknowledged","commit_id":"5a5927fd6e97548ab76df6b7bbb53c49546c10eb"},{"author":{"_account_id":37598,"name":"Ivan Anfimov","display_name":"Ivan Anfimov","email":"lazekteam@gmail.com","username":"anfimovir"},"change_message_id":"bfbfa2ec45a42e0adb21bd0bc588b8d5b202582b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b3698028_3c7343bf","in_reply_to":"e529db96_284e3700","updated":"2025-08-16 16:34:08.000000000","message":"Yes, I think this will be the right choice, let\u0027s see the test results.","commit_id":"5a5927fd6e97548ab76df6b7bbb53c49546c10eb"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a81706301897014c33688ec804ba2811d3bebe1d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8bc7763e_91fc979b","updated":"2025-09-09 14:38:20.000000000","message":"Hi, what is the problem with passing a set? The method `delete_exposed_ips` [1] just iterates any variable passed. It doesn\u0027t matter if this is a set or a list.\n\n[1]https://github.com/openstack/ovn-bgp-agent/blob/d9b0b54ec3fbaebabc35b483eae1adfc812a7c25/ovn_bgp_agent/privileged/linux_net.py#L181-L182","commit_id":"653f1c9591ecbdca7a0bfd94c50b80e3da47ec9f"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"9aeb530386c28bc49d7304c66ea8414ec2c9613f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"677619ab_e3f81582","updated":"2025-09-09 14:14:20.000000000","message":"Is there a bug associated with this change? You mention backporting. If not please open one and link in the commit message. thanks.","commit_id":"653f1c9591ecbdca7a0bfd94c50b80e3da47ec9f"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6d1afa67c263b3634aa2e6ceb33359887dfdfc7c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d00c006a_0c4ccbd7","in_reply_to":"88fcf1b7_04de745e","updated":"2025-09-10 07:17:33.000000000","message":"Makes sense. I is useful to add this comment in the method that is calling the privsep one. Also, in this case, you can enforce via typing hints in the privsep method signature what is the expected variable type.","commit_id":"653f1c9591ecbdca7a0bfd94c50b80e3da47ec9f"},{"author":{"_account_id":36998,"name":"Ilia Baikov","display_name":"Ilia Baikov","email":"ilia.baikov@ib.systems","username":"frct1"},"change_message_id":"40aa6d17124453ffb4d2d6664b5180de9abd72ff","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"88fcf1b7_04de745e","in_reply_to":"8bc7763e_91fc979b","updated":"2025-09-09 15:14:44.000000000","message":"Hi, my bad, didn\u0027t mention bug there\nhttps://bugs.launchpad.net/ovn-bgp-agent/+bug/2120757\nLogs are also attached to the bug description. Probably a privsep thing, but this is a working workaround (deployed on 2 sites, no issues)","commit_id":"653f1c9591ecbdca7a0bfd94c50b80e3da47ec9f"},{"author":{"_account_id":36998,"name":"Ilia Baikov","display_name":"Ilia Baikov","email":"ilia.baikov@ib.systems","username":"frct1"},"change_message_id":"2cff80fa27a116ca439620a747bc766da2a9e231","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3f4e2484_aab4e97f","in_reply_to":"d00c006a_0c4ccbd7","updated":"2025-10-04 20:47:45.000000000","message":"Uploaded a patch. Is this it? Not familiar on how privsep handles it","commit_id":"653f1c9591ecbdca7a0bfd94c50b80e3da47ec9f"},{"author":{"_account_id":36998,"name":"Ilia Baikov","display_name":"Ilia Baikov","email":"ilia.baikov@ib.systems","username":"frct1"},"change_message_id":"dec51da58bfc7d8d87dacca6b43cb0a7892b9aea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"54343d43_98e93cee","updated":"2025-10-05 00:05:52.000000000","message":"Tried with typings hint on a method signature, no success. Probably i did it wrong.","commit_id":"e92aada4f1f7813f6a04fdc20c15cc9c0a72b6d6"},{"author":{"_account_id":34380,"name":"Maximilian Stinsky","email":"maximilian@stinsky.com","username":"mstinsky"},"change_message_id":"15a747249e93d00c4cf202e523e377345c082adb","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"a2c7633c_1efeec5d","updated":"2025-11-09 11:25:41.000000000","message":"Could we add a `Closes-Bug: #2120757` to the commit message so we link this patch to the bug report? Had to search to find that someone was already working on it here. And possibly change the commit message so it reflects what the patch does now.","commit_id":"b78f80090507f2b431570c4f7d43c815647154d3"},{"author":{"_account_id":24824,"name":"Dmitrii Shcherbakov","username":"dmitriis"},"change_message_id":"7bea74c1bce356cdd43294ad4fc698e660642097","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"6c3ce2d0_e99cca8a","updated":"2025-10-30 18:47:34.000000000","message":"I also have this issue fixed in https://review.opendev.org/c/openstack/ovn-bgp-agent/+/964741 - it surfaced in the functional tests I was adding for the extended cleanup functionality.\n\nLooks like originally the issue appeared in the last revision of this change: https://review.opendev.org/c/openstack/ovn-bgp-agent/+/940224/comment/04c6ce3d_91873e4f/ which, unfortunately, was not what I was running in prod downstream. The existing func tests did not catch it either but the new func tests I am proposing do.","commit_id":"b78f80090507f2b431570c4f7d43c815647154d3"},{"author":{"_account_id":36998,"name":"Ilia Baikov","display_name":"Ilia Baikov","email":"ilia.baikov@ib.systems","username":"frct1"},"change_message_id":"06fe17375913f3b750e4086f0430fa06081b274b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"74cfe48d_f1e1305d","in_reply_to":"6c3ce2d0_e99cca8a","updated":"2025-10-30 19:55:43.000000000","message":"Hey, sound great!\nI also have 2 more little bug fixes, mac address regression is observed internally recently, didn\u0027t add the patch. Let me know if this case is fixed as well otherwise I can push it to the new PR.\n\nhttps://gist.github.com/frct1/1d30b0d83ba0df92d5c067d0da6cbab1","commit_id":"b78f80090507f2b431570c4f7d43c815647154d3"},{"author":{"_account_id":24824,"name":"Dmitrii Shcherbakov","username":"dmitriis"},"change_message_id":"a21aa47bf668c8962946d4fe64be9bd06546af6f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"2146c060_5f9b1d2c","in_reply_to":"74cfe48d_f1e1305d","updated":"2025-10-31 16:40:59.000000000","message":"The gist looks different from what I have in my change so go for it.","commit_id":"b78f80090507f2b431570c4f7d43c815647154d3"},{"author":{"_account_id":36998,"name":"Ilia Baikov","display_name":"Ilia Baikov","email":"ilia.baikov@ib.systems","username":"frct1"},"change_message_id":"68a1825ef99de7bc4f8fbbefba66d01498784c4c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"ff8cccbf_c21179a8","in_reply_to":"a2c7633c_1efeec5d","updated":"2025-11-09 16:22:27.000000000","message":"For sure.","commit_id":"b78f80090507f2b431570c4f7d43c815647154d3"},{"author":{"_account_id":34380,"name":"Maximilian Stinsky","email":"maximilian@stinsky.com","username":"mstinsky"},"change_message_id":"c46a1dd64fd9e960553ed7f828f874ec07e36a6c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"025707eb_683a6a13","updated":"2026-04-21 08:19:30.000000000","message":"@haleyb.dev@gmail.com @ralonsoh@redhat.com\nCould we get some review here? This is an important bug fix in the bgp agent as it has quite that hard impact when hit.","commit_id":"22e9b076a60beda3c57dcbb1d245cad76cb7bf8c"}]}