)]}'
{"ovn_bgp_agent/privileged/linux_net.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"361ea6a168f3b79d05d085c9a60dce3e22df335c","unresolved":true,"context_lines":[{"line_number":335,"context_line":"        os.makedirs(rt_tables_dir, mode\u003d0o755)"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"    if not os.path.exists(rt_tables_path):"},{"line_number":338,"context_line":"        # Copy default rt_tables file from /usr/share/iproute2/rt_tables"},{"line_number":339,"context_line":"        if not os.path.exists(default_rt_tables):"},{"line_number":340,"context_line":"            raise agent_exc.RoutingTablesFileNotFound(path\u003ddefault_rt_tables)"},{"line_number":341,"context_line":"        shutil.copy2(default_rt_tables, rt_tables_path)"}],"source_content_type":"text/x-python","patch_set":2,"id":"84447592_ca537551","line":338,"updated":"2026-02-16 14:23:03.000000000","message":"so in the system with new version of iproute2, where that file is in the `/etc/iproute2/` directory, you will basically copy it to the old location. Why not try to simply read from both locations in the https://review.opendev.org/c/openstack/ovn-bgp-agent/+/976242/2/ovn_bgp_agent/utils/linux_net.py instead?","commit_id":"a12af57fd1a85c399a0d36485b2e9637736d4bc9"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"1cfdb324b772db9a0d88fa775e0a3c88db3c7835","unresolved":false,"context_lines":[{"line_number":335,"context_line":"        os.makedirs(rt_tables_dir, mode\u003d0o755)"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"    if not os.path.exists(rt_tables_path):"},{"line_number":338,"context_line":"        # Copy default rt_tables file from /usr/share/iproute2/rt_tables"},{"line_number":339,"context_line":"        if not os.path.exists(default_rt_tables):"},{"line_number":340,"context_line":"            raise agent_exc.RoutingTablesFileNotFound(path\u003ddefault_rt_tables)"},{"line_number":341,"context_line":"        shutil.copy2(default_rt_tables, rt_tables_path)"}],"source_content_type":"text/x-python","patch_set":2,"id":"70170c3d_85f95d35","line":338,"in_reply_to":"53b58033_785fda70","updated":"2026-02-16 15:16:14.000000000","message":"makes sense then, thx for explanation","commit_id":"a12af57fd1a85c399a0d36485b2e9637736d4bc9"},{"author":{"_account_id":34380,"name":"Maximilian Stinsky","email":"maximilian@stinsky.com","username":"mstinsky"},"change_message_id":"8d17a9f2af88a9fb4b5f5791977664275580a0a3","unresolved":true,"context_lines":[{"line_number":335,"context_line":"        os.makedirs(rt_tables_dir, mode\u003d0o755)"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"    if not os.path.exists(rt_tables_path):"},{"line_number":338,"context_line":"        # Copy default rt_tables file from /usr/share/iproute2/rt_tables"},{"line_number":339,"context_line":"        if not os.path.exists(default_rt_tables):"},{"line_number":340,"context_line":"            raise agent_exc.RoutingTablesFileNotFound(path\u003ddefault_rt_tables)"},{"line_number":341,"context_line":"        shutil.copy2(default_rt_tables, rt_tables_path)"}],"source_content_type":"text/x-python","patch_set":2,"id":"53b58033_785fda70","line":338,"in_reply_to":"84447592_ca537551","updated":"2026-02-16 14:31:28.000000000","message":"Because /usr/share/iproute2/rt_tables is just the \"new\" default of iprotue2, we are not supposed to write in that file.\n\nWe are creating a routing table for the agent: https://opendev.org/openstack/ovn-bgp-agent/src/commit/81d53f0d48b5fadb7bafca9f3022a56230defa3b/ovn_bgp_agent/privileged/linux_net.py#L326-L329\nTherefore when we dont find a rt_tables config we need to copy the default one and can than write into that file.","commit_id":"a12af57fd1a85c399a0d36485b2e9637736d4bc9"}]}
