)]}'
{"ovn_octavia_provider/driver.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"5959058ca6f98d7f266e92405d84d092272e9c47","unresolved":false,"context_lines":[{"line_number":1018,"context_line":"            constants.LOADBALANCERS: [lbalancer_status],"},{"line_number":1019,"context_line":"            constants.LISTENERS: [],"},{"line_number":1020,"context_line":"            constants.POOLS: [],"},{"line_number":1021,"context_line":"            constants.MEMBERS: []}"},{"line_number":1022,"context_line":""},{"line_number":1023,"context_line":"        ovn_lbs \u003d None"},{"line_number":1024,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_5bde5f3f","line":1021,"updated":"2020-03-26 21:40:10.000000000","message":"So this changes it so it always returns these other items, although just empty [], which I think is OK","commit_id":"d765fa4cb278992d9d3c222c5cb9ba81017e0da0"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"5959058ca6f98d7f266e92405d84d092272e9c47","unresolved":false,"context_lines":[{"line_number":1403,"context_line":"            status \u003d {"},{"line_number":1404,"context_line":"                constants.POOLS: ["},{"line_number":1405,"context_line":"                    {constants.ID: pool[constants.ID],"},{"line_number":1406,"context_line":"                     constants.PROVISIONING_STATUS: constants.ERROR}],"},{"line_number":1407,"context_line":"                constants.LOADBALANCERS: ["},{"line_number":1408,"context_line":"                    {constants.ID: pool[constants.LOADBALANCER_ID],"},{"line_number":1409,"context_line":"                     constants.PROVISIONING_STATUS: constants.ACTIVE}]}"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_dbf1cfcf","line":1406,"updated":"2020-03-26 21:40:10.000000000","message":"So I\u0027m wondering - here provisioning status is returned but not operating status.  Does it matter that we don\u0027t return that?  Does it matter?  Just thinking of ways to simplify things here.","commit_id":"d765fa4cb278992d9d3c222c5cb9ba81017e0da0"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"9cafd9b9dd3ffbd904ebf25e3c6a55649e414d5e","unresolved":false,"context_lines":[{"line_number":1403,"context_line":"            status \u003d {"},{"line_number":1404,"context_line":"                constants.POOLS: ["},{"line_number":1405,"context_line":"                    {constants.ID: pool[constants.ID],"},{"line_number":1406,"context_line":"                     constants.PROVISIONING_STATUS: constants.ERROR}],"},{"line_number":1407,"context_line":"                constants.LOADBALANCERS: ["},{"line_number":1408,"context_line":"                    {constants.ID: pool[constants.LOADBALANCER_ID],"},{"line_number":1409,"context_line":"                     constants.PROVISIONING_STATUS: constants.ACTIVE}]}"}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_b9fb0145","line":1406,"in_reply_to":"df33271e_dbf1cfcf","updated":"2020-03-30 16:52:29.000000000","message":"And the answer is \u0027yes\u0027, operating status should not be here as it\u0027s indeterminate.  I think we could refactor things as mentioned below in other places such that we don\u0027t have to re-define the status block.","commit_id":"d765fa4cb278992d9d3c222c5cb9ba81017e0da0"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"9cafd9b9dd3ffbd904ebf25e3c6a55649e414d5e","unresolved":false,"context_lines":[{"line_number":1603,"context_line":"            self._add_member(member, ovn_lb, pool_key)"},{"line_number":1604,"context_line":"            pool \u003d {constants.ID: member[constants.POOL_ID],"},{"line_number":1605,"context_line":"                    constants.PROVISIONING_STATUS: constants.ACTIVE,"},{"line_number":1606,"context_line":"                    constants.OPERATING_STATUS: constants.ONLINE}"},{"line_number":1607,"context_line":"            status \u003d {"},{"line_number":1608,"context_line":"                constants.POOLS: [pool],"},{"line_number":1609,"context_line":"                constants.MEMBERS: ["}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_994a7da9","line":1606,"updated":"2020-03-30 16:52:29.000000000","message":"This is Ok here, but in a refactor it could move below, say L1621, then we wouldn\u0027t need to re-define status on L1624.","commit_id":"d765fa4cb278992d9d3c222c5cb9ba81017e0da0"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"9cafd9b9dd3ffbd904ebf25e3c6a55649e414d5e","unresolved":false,"context_lines":[{"line_number":1679,"context_line":"            pool_status \u003d self._remove_member(member, ovn_lb, pool_key)"},{"line_number":1680,"context_line":"            pool \u003d {constants.ID: member[constants.POOL_ID],"},{"line_number":1681,"context_line":"                    constants.PROVISIONING_STATUS: constants.ACTIVE,"},{"line_number":1682,"context_line":"                    constants.OPERATING_STATUS: pool_status}"},{"line_number":1683,"context_line":"            status \u003d {"},{"line_number":1684,"context_line":"                constants.POOLS: [pool],"},{"line_number":1685,"context_line":"                constants.MEMBERS: ["}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_7957b959","line":1682,"updated":"2020-03-30 16:52:29.000000000","message":"This is Ok here, but in a refactor it could move below, say L1697, then we wouldn\u0027t need to re-define status on L1700.","commit_id":"d765fa4cb278992d9d3c222c5cb9ba81017e0da0"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"b9fc2c0e8f7251b63285b81cac1fe67505220c72","unresolved":false,"context_lines":[{"line_number":1679,"context_line":"            pool_status \u003d self._remove_member(member, ovn_lb, pool_key)"},{"line_number":1680,"context_line":"            pool \u003d {constants.ID: member[constants.POOL_ID],"},{"line_number":1681,"context_line":"                    constants.PROVISIONING_STATUS: constants.ACTIVE,"},{"line_number":1682,"context_line":"                    constants.OPERATING_STATUS: pool_status}"},{"line_number":1683,"context_line":"            status \u003d {"},{"line_number":1684,"context_line":"                constants.POOLS: [pool],"},{"line_number":1685,"context_line":"                constants.MEMBERS: ["}],"source_content_type":"text/x-python","patch_set":1,"id":"df33271e_8444db48","line":1682,"in_reply_to":"df33271e_7957b959","updated":"2020-04-09 10:07:52.000000000","message":"Good idea ++","commit_id":"d765fa4cb278992d9d3c222c5cb9ba81017e0da0"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"b9fc2c0e8f7251b63285b81cac1fe67505220c72","unresolved":false,"context_lines":[{"line_number":1284,"context_line":"        except idlutils.RowNotFound:"},{"line_number":1285,"context_line":"            LOG.exception(EXCEPTION_MSG, \"update of listener\")"},{"line_number":1286,"context_line":"            # LB row not found during updating a listner. That is a problem."},{"line_number":1287,"context_line":"            listener_status[constants.PROVISIONING_STATUS] \u003d constants.ERROR"},{"line_number":1288,"context_line":"            lbalancer_status[constants.PROVISIONING_STATUS] \u003d constants.ERROR"},{"line_number":1289,"context_line":"            return status"},{"line_number":1290,"context_line":""},{"line_number":1291,"context_line":"        l_key_when_enabled \u003d self._get_listener_key(listener[constants.ID])"}],"source_content_type":"text/x-python","patch_set":2,"id":"df33271e_4e715276","line":1288,"range":{"start_line":1287,"start_character":12,"end_line":1288,"end_character":77},"updated":"2020-04-09 10:07:52.000000000","message":"++ That looks much better! Thanks!","commit_id":"3744a8cfef1ea3de3c088a11690fab0e68a7fd99"}]}