)]}'
{"ovn_octavia_provider/agent.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"a816b303b49edecbf22f224c3bf579e83bb2833f","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from ovn_octavia_provider import helper as ovn_helper"},{"line_number":20,"context_line":"from ovn_octavia_provider.ovsdb import impl_idl_ovn"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"ovn_conf.register_opts()"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1f493fa4_45ba6bc0","line":22,"updated":"2020-05-01 15:22:18.000000000","message":"Or maybe this just needs to be in helper.py?  If this passes I\u0027ll investigate.","commit_id":"02421333256d6e4cdd954db3054835edfb71d5ba"}],"ovn_octavia_provider/helper.py":[{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"66bfac4004b6397d296062e01782a3fbd26a581f","unresolved":false,"context_lines":[{"line_number":44,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"def get_neutron_client():"},{"line_number":48,"context_line":"    try:"},{"line_number":49,"context_line":"        return clients.NeutronAuth("},{"line_number":50,"context_line":"            endpoint\u003dCONF.neutron.endpoint,"},{"line_number":51,"context_line":"            region\u003dCONF.neutron.region_name,"},{"line_number":52,"context_line":"            endpoint_type\u003dCONF.neutron.endpoint_type,"},{"line_number":53,"context_line":"            service_name\u003dCONF.neutron.service_name,"},{"line_number":54,"context_line":"            insecure\u003dCONF.neutron.insecure,"},{"line_number":55,"context_line":"            ca_cert\u003dCONF.neutron.ca_certificates_file,"},{"line_number":56,"context_line":"        ).neutron_client"},{"line_number":57,"context_line":"    except n_exc.NeutronClientException as e:"},{"line_number":58,"context_line":"        msg \u003d _(\u0027Cannot inialize Neutron Client. Exception: %s. \u0027"},{"line_number":59,"context_line":"                \u0027Please verify Neutron service configuration \u0027"},{"line_number":60,"context_line":"                \u0027in Octavia API configuration.\u0027) % e"},{"line_number":61,"context_line":"        raise driver_exceptions.DriverError("},{"line_number":62,"context_line":"            operator_fault_string\u003dmsg)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"class OvnProviderHelper(object):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1f493fa4_5c6dd496","line":62,"range":{"start_line":47,"start_character":0,"end_line":62,"end_character":38},"updated":"2020-05-06 14:55:15.000000000","message":"Can we place it in common.clients?","commit_id":"d56694ad3af76d810b9ee3763a06e891ca99b1af"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e8859e5c86446fcb9e6d1ee43d962b32b2d7e961","unresolved":false,"context_lines":[{"line_number":44,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"def get_neutron_client():"},{"line_number":48,"context_line":"    try:"},{"line_number":49,"context_line":"        return clients.NeutronAuth("},{"line_number":50,"context_line":"            endpoint\u003dCONF.neutron.endpoint,"},{"line_number":51,"context_line":"            region\u003dCONF.neutron.region_name,"},{"line_number":52,"context_line":"            endpoint_type\u003dCONF.neutron.endpoint_type,"},{"line_number":53,"context_line":"            service_name\u003dCONF.neutron.service_name,"},{"line_number":54,"context_line":"            insecure\u003dCONF.neutron.insecure,"},{"line_number":55,"context_line":"            ca_cert\u003dCONF.neutron.ca_certificates_file,"},{"line_number":56,"context_line":"        ).neutron_client"},{"line_number":57,"context_line":"    except n_exc.NeutronClientException as e:"},{"line_number":58,"context_line":"        msg \u003d _(\u0027Cannot inialize Neutron Client. Exception: %s. \u0027"},{"line_number":59,"context_line":"                \u0027Please verify Neutron service configuration \u0027"},{"line_number":60,"context_line":"                \u0027in Octavia API configuration.\u0027) % e"},{"line_number":61,"context_line":"        raise driver_exceptions.DriverError("},{"line_number":62,"context_line":"            operator_fault_string\u003dmsg)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"class OvnProviderHelper(object):"}],"source_content_type":"text/x-python","patch_set":5,"id":"1f493fa4_a14b0d85","line":62,"range":{"start_line":47,"start_character":0,"end_line":62,"end_character":38},"in_reply_to":"1f493fa4_5c6dd496","updated":"2020-05-06 20:40:11.000000000","message":"I had originally done this in https://review.opendev.org/#/c/724426/ and had this depend on it, but I thought it was part of the config issue, which just wound-up being a wrong mock really.  Let me re-work that and rebase things if it works, or just do this afterwards...","commit_id":"d56694ad3af76d810b9ee3763a06e891ca99b1af"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"f23175c90a8e3950917c6c267c1611b46d4db5ba","unresolved":false,"context_lines":[{"line_number":1388,"context_line":""},{"line_number":1389,"context_line":"            pool_listeners \u003d self._get_pool_listeners(ovn_lb, pool_key)"},{"line_number":1390,"context_line":"            listener_status \u003d []"},{"line_number":1391,"context_line":"            for l in pool_listeners:"},{"line_number":1392,"context_line":"                listener_status.append("},{"line_number":1393,"context_line":"                    {constants.ID: l,"},{"line_number":1394,"context_line":"                     constants.PROVISIONING_STATUS: constants.ACTIVE})"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff570b3c_a73509fa","line":1391,"updated":"2020-05-12 11:01:49.000000000","message":"pep8: E741 ambiguous variable name \u0027l\u0027","commit_id":"58e922d2dc90a38d40493b47151a25c2f1d637b9"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"f23175c90a8e3950917c6c267c1611b46d4db5ba","unresolved":false,"context_lines":[{"line_number":1454,"context_line":"                     constants.PROVISIONING_STATUS: constants.ACTIVE}]}"},{"line_number":1455,"context_line":"            pool_listeners \u003d self._get_pool_listeners(ovn_lb, pool_key)"},{"line_number":1456,"context_line":"            listener_status \u003d []"},{"line_number":1457,"context_line":"            for l in pool_listeners:"},{"line_number":1458,"context_line":"                listener_status.append("},{"line_number":1459,"context_line":"                    {constants.ID: l,"},{"line_number":1460,"context_line":"                     constants.PROVISIONING_STATUS: constants.ACTIVE})"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff570b3c_073b15eb","line":1457,"updated":"2020-05-12 11:01:49.000000000","message":"pep8: E741 ambiguous variable name \u0027l\u0027","commit_id":"58e922d2dc90a38d40493b47151a25c2f1d637b9"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"f23175c90a8e3950917c6c267c1611b46d4db5ba","unresolved":false,"context_lines":[{"line_number":1530,"context_line":"                     constants.PROVISIONING_STATUS: constants.ACTIVE}]}"},{"line_number":1531,"context_line":"            pool_listeners \u003d self._get_pool_listeners(ovn_lb, pool_key)"},{"line_number":1532,"context_line":"            listener_status \u003d []"},{"line_number":1533,"context_line":"            for l in pool_listeners:"},{"line_number":1534,"context_line":"                listener_status.append("},{"line_number":1535,"context_line":"                    {constants.ID: l,"},{"line_number":1536,"context_line":"                     constants.PROVISIONING_STATUS: constants.ACTIVE})"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff570b3c_e73f01d4","line":1533,"updated":"2020-05-12 11:01:49.000000000","message":"pep8: E741 ambiguous variable name \u0027l\u0027","commit_id":"58e922d2dc90a38d40493b47151a25c2f1d637b9"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"f23175c90a8e3950917c6c267c1611b46d4db5ba","unresolved":false,"context_lines":[{"line_number":1594,"context_line":""},{"line_number":1595,"context_line":"            pool_listeners \u003d self._get_pool_listeners(ovn_lb, pool_key)"},{"line_number":1596,"context_line":"            listener_status \u003d []"},{"line_number":1597,"context_line":"            for l in pool_listeners:"},{"line_number":1598,"context_line":"                listener_status.append("},{"line_number":1599,"context_line":"                    {constants.ID: l,"},{"line_number":1600,"context_line":"                     constants.PROVISIONING_STATUS: constants.ACTIVE})"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff570b3c_4724edc6","line":1597,"updated":"2020-05-12 11:01:49.000000000","message":"pep8: E741 ambiguous variable name \u0027l\u0027","commit_id":"58e922d2dc90a38d40493b47151a25c2f1d637b9"}],"ovn_octavia_provider/tests/functional/test_driver.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2424132613b969d335249cde98193a0a3a358c22","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        self._o_driver_lib \u003d self.ovn_driver._ovn_helper._octavia_driver_lib"},{"line_number":62,"context_line":"        self._o_driver_lib.update_loadbalancer_status \u003d mock.Mock()"},{"line_number":63,"context_line":"        self.fake_neutron_client \u003d mock.MagicMock()"},{"line_number":64,"context_line":"        ovn_driver.get_neutron_client \u003d mock.MagicMock()"},{"line_number":65,"context_line":"        ovn_driver.get_neutron_client.return_value \u003d self.fake_neutron_client"},{"line_number":66,"context_line":"        self.fake_neutron_client.show_subnet \u003d self._mock_show_subnet"},{"line_number":67,"context_line":"        self.fake_neutron_client.list_ports \u003d self._mock_list_ports"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f493fa4_c003e572","line":64,"range":{"start_line":64,"start_character":8,"end_line":64,"end_character":18},"updated":"2020-05-04 20:08:12.000000000","message":"this should be ovn_helper, which i think will fix the failure","commit_id":"02421333256d6e4cdd954db3054835edfb71d5ba"}]}