)]}'
{"ovn_octavia_provider/tests/functional/test_driver.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"06c7cd2b022c53148eaa2ebe30e22c41f27c2857","unresolved":true,"context_lines":[{"line_number":285,"context_line":"                    lb_data, pool_SCTP_id, protocol_port\u003d8081, protocol\u003d\u0027SCTP\u0027)"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"        self._delete_load_balancer_and_validate(lb_data, cascade\u003dTrue)"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"    def test_lb_listener_pools_cascade(self):"},{"line_number":290,"context_line":"        self._test_cascade_delete(member\u003dFalse)"},{"line_number":291,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"fa5d7700_5ff2dcf0","line":288,"updated":"2021-03-12 15:09:27.000000000","message":"I guess these tests could be broken into one helper method passing the protocol as a parameter. That would make it easy to add new protocols to be tested in the future. For example:\n\n def _test_listener(self, protocol, port):\n   lb_data \u003d self._create_load_balancer_and_validate(\n        {\u0027vip_network\u0027: \u0027vip_network\u0027,\n         \u0027cidr\u0027: \u002710.0.0.0/24\u0027})\n   self._create_pool_and_validate(lb_data, \"test_pool\", protocol\u003dprotocol)\n   pool_id \u003d lb_data[\u0027pools\u0027][0].pool_id\n\n   # Create member in the pool\n   self._create_member_and_validate(\n       lb_data, pool_id, lb_data[\u0027vip_net_info\u0027][1],\n       lb_data[\u0027vip_net_info\u0027][0], \u002710.0.0.4\u0027)\n   self._create_member_and_validate(lb_data, pool_id,\n                                    net_info[1], net_info[0], \u002720.0.0.4\u0027)\n\n    ... \u003cand so on\u003e\n\n def test_listener_tcp(self):\n     self._test_listener(\u0027TCP\u0027, 80)\n\n def test_listener_udp(self):\n     self._test_listener(\u0027UDP\u0027, 53)\n\n def test_listener_sctp(self):\n     self._test_listener(\u0027SCTP\u0027, 8081)","commit_id":"b796f4ebe052ebace29f29c06e8876342a49f26e"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"74b374b2d6d37b9efecfab7a7f3bbe47c522b6c5","unresolved":true,"context_lines":[{"line_number":285,"context_line":"                    lb_data, pool_SCTP_id, protocol_port\u003d8081, protocol\u003d\u0027SCTP\u0027)"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"        self._delete_load_balancer_and_validate(lb_data, cascade\u003dTrue)"},{"line_number":288,"context_line":""},{"line_number":289,"context_line":"    def test_lb_listener_pools_cascade(self):"},{"line_number":290,"context_line":"        self._test_cascade_delete(member\u003dFalse)"},{"line_number":291,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"8a4e732b_35278c17","line":288,"in_reply_to":"fa5d7700_5ff2dcf0","updated":"2021-03-12 15:28:09.000000000","message":"Yes,  that would be a good cleanup, I\u0027ll put it on the list for Xena.","commit_id":"b796f4ebe052ebace29f29c06e8876342a49f26e"}]}