)]}'
{"ovn_octavia_provider/driver.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d370579a36fa18760abed6934587adc00e566acd","unresolved":true,"context_lines":[{"line_number":293,"context_line":"        pool_key, ovn_lb \u003d self._ovn_helper._find_ovn_lb_by_pool_id(pool_id)"},{"line_number":294,"context_line":"        external_ids \u003d copy.deepcopy(ovn_lb.external_ids)"},{"line_number":295,"context_line":"        existing_members \u003d external_ids[pool_key].split(\u0027,\u0027)"},{"line_number":296,"context_line":"        members_to_delete \u003d copy.copy(existing_members)"},{"line_number":297,"context_line":"        for member in members:"},{"line_number":298,"context_line":"            if (self._check_monitor_options(member) or"},{"line_number":299,"context_line":"                    member.address and self._ip_version_differs(member)):"}],"source_content_type":"text/x-python","patch_set":1,"id":"4bcc17de_f0eb6066","line":296,"updated":"2021-01-22 19:46:34.000000000","message":"What is members_to_delete here?  I\u0027m guessing one of the above calls didn\u0027t return what we expected.","commit_id":"d36a759cb13d3864a7bf533ba7557e65da31e9a7"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"6c53d3775696191763ec9d7362b2ebc4efcc3027","unresolved":true,"context_lines":[{"line_number":293,"context_line":"        pool_key, ovn_lb \u003d self._ovn_helper._find_ovn_lb_by_pool_id(pool_id)"},{"line_number":294,"context_line":"        external_ids \u003d copy.deepcopy(ovn_lb.external_ids)"},{"line_number":295,"context_line":"        existing_members \u003d external_ids[pool_key].split(\u0027,\u0027)"},{"line_number":296,"context_line":"        members_to_delete \u003d copy.copy(existing_members)"},{"line_number":297,"context_line":"        for member in members:"},{"line_number":298,"context_line":"            if (self._check_monitor_options(member) or"},{"line_number":299,"context_line":"                    member.address and self._ip_version_differs(member)):"}],"source_content_type":"text/x-python","patch_set":1,"id":"8d23f244_ed4a3d20","line":296,"in_reply_to":"4bcc17de_f0eb6066","updated":"2021-01-27 11:21:37.000000000","message":"DEBUG ovn_octavia_provider.driver [req-e9b5fcaf-ba26-4638-8dad-f1c728dfa396 - 25f96bca327c4136ab28f251203d71a3 - d5125dbc6522477ebad3d78e8eeaa692 d5125dbc6522477ebad3d78e8eeaa692] Members to delete: [\u0027\u0027]","commit_id":"d36a759cb13d3864a7bf533ba7557e65da31e9a7"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2bc28a754bd8541ab27ed84686250b94d052bf0d","unresolved":true,"context_lines":[{"line_number":293,"context_line":"        pool_key, ovn_lb \u003d self._ovn_helper._find_ovn_lb_by_pool_id(pool_id)"},{"line_number":294,"context_line":"        external_ids \u003d copy.deepcopy(ovn_lb.external_ids)"},{"line_number":295,"context_line":"        existing_members \u003d external_ids[pool_key].split(\u0027,\u0027)"},{"line_number":296,"context_line":"        members_to_delete \u003d copy.copy(existing_members)"},{"line_number":297,"context_line":"        for member in members:"},{"line_number":298,"context_line":"            if (self._check_monitor_options(member) or"},{"line_number":299,"context_line":"                    member.address and self._ip_version_differs(member)):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9957da4c_2fbc758c","line":296,"in_reply_to":"8d23f244_ed4a3d20","updated":"2021-02-24 19:41:34.000000000","message":"Hi Michal, sorry for the slow reply but I didn\u0027t forget about this.\n\nPerhaps something like this would work?\n\nexisting_members \u003d external_ids[pool_key].split(\u0027,\u0027) if external_ids[pool_key] else []","commit_id":"d36a759cb13d3864a7bf533ba7557e65da31e9a7"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d370579a36fa18760abed6934587adc00e566acd","unresolved":true,"context_lines":[{"line_number":327,"context_line":"                try:"},{"line_number":328,"context_line":"                    members_to_delete.remove(member_info_old)"},{"line_number":329,"context_line":"                except ValueError:"},{"line_number":330,"context_line":"                    members_to_delete.remove(member_info)"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"            request_info \u003d {\u0027id\u0027: member.member_id,"},{"line_number":333,"context_line":"                            \u0027address\u0027: member.address,"}],"source_content_type":"text/x-python","patch_set":1,"id":"23b6b0ed_0e435cd0","line":330,"updated":"2021-01-22 19:46:34.000000000","message":"And after either one of these calls?","commit_id":"d36a759cb13d3864a7bf533ba7557e65da31e9a7"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"6c53d3775696191763ec9d7362b2ebc4efcc3027","unresolved":true,"context_lines":[{"line_number":327,"context_line":"                try:"},{"line_number":328,"context_line":"                    members_to_delete.remove(member_info_old)"},{"line_number":329,"context_line":"                except ValueError:"},{"line_number":330,"context_line":"                    members_to_delete.remove(member_info)"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"            request_info \u003d {\u0027id\u0027: member.member_id,"},{"line_number":333,"context_line":"                            \u0027address\u0027: member.address,"}],"source_content_type":"text/x-python","patch_set":1,"id":"82ec0b20_8c2aab3f","line":330,"in_reply_to":"23b6b0ed_0e435cd0","updated":"2021-01-27 11:21:37.000000000","message":"2021-01-27 11:20:09.991 8 DEBUG ovn_octavia_provider.driver [req-9fca30c5-4c95-4914-9b0f-069661a0e991 - 25f96bca327c4136ab28f251203d71a3 - d5125dbc6522477ebad3d78e8eeaa692 d5125dbc6522477ebad3d78e8eeaa692] Members to delete2: [\u0027\u0027] member_batch_update /var/lib/kolla/venv/lib/python3.6/site-packages/ovn_octavia_provider/driver.py:2236","commit_id":"d36a759cb13d3864a7bf533ba7557e65da31e9a7"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"65bbacf7c9895e14a595dda5c06eede086778724","unresolved":true,"context_lines":[{"line_number":339,"context_line":"                       \u0027info\u0027: request_info}"},{"line_number":340,"context_line":"            request_list.append(request)"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"        for member in members_to_delete:"},{"line_number":343,"context_line":"            if member:"},{"line_number":344,"context_line":"                member_info \u003d member.split(\u0027_\u0027)"},{"line_number":345,"context_line":"                request_info \u003d {\u0027id\u0027: member_info[1],"}],"source_content_type":"text/x-python","patch_set":1,"id":"73be61c3_0ad151d5","line":342,"updated":"2021-01-22 13:53:00.000000000","message":"So let\u0027s figure out why members_to_delete has a \u0027\u0027 in there, at least I\u0027m assuming that\u0027s what is causing this?","commit_id":"d36a759cb13d3864a7bf533ba7557e65da31e9a7"},{"author":{"_account_id":22629,"name":"Michal Nasiadka","email":"mnasiadka@gmail.com","username":"mnasiadka"},"change_message_id":"6c53d3775696191763ec9d7362b2ebc4efcc3027","unresolved":true,"context_lines":[{"line_number":339,"context_line":"                       \u0027info\u0027: request_info}"},{"line_number":340,"context_line":"            request_list.append(request)"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"        for member in members_to_delete:"},{"line_number":343,"context_line":"            if member:"},{"line_number":344,"context_line":"                member_info \u003d member.split(\u0027_\u0027)"},{"line_number":345,"context_line":"                request_info \u003d {\u0027id\u0027: member_info[1],"}],"source_content_type":"text/x-python","patch_set":1,"id":"a7d05e6c_f82b81d2","line":342,"in_reply_to":"73be61c3_0ad151d5","updated":"2021-01-27 11:21:37.000000000","message":"That might actually make sense :) updated the bug, let\u0027s see if we can find the source.","commit_id":"d36a759cb13d3864a7bf533ba7557e65da31e9a7"}]}