)]}'
{"ovn_octavia_provider/helper.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"5d045f3edfc6a40a8ecca900033083c700769540","unresolved":true,"context_lines":[{"line_number":463,"context_line":"            pass"},{"line_number":464,"context_line":"        except Exception as e:"},{"line_number":465,"context_line":"            if \u0027subnet not found\u0027 not in e.message:"},{"line_number":466,"context_line":"                raise e"},{"line_number":467,"context_line":"        LOG.warning(\u0027Subnet %s not found while trying to \u0027"},{"line_number":468,"context_line":"                    \u0027fetch its data.\u0027, subnet_id)"},{"line_number":469,"context_line":"        return None"}],"source_content_type":"text/x-python","patch_set":4,"id":"ea66b5a6_5c08b065","line":466,"updated":"2021-06-14 21:39:10.000000000","message":"I actually don\u0027t think this is needed, is it?  Only in the train code?","commit_id":"fd00a12df27faa380e7bb5058440bdec8c86aebf"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"5d045f3edfc6a40a8ecca900033083c700769540","unresolved":true,"context_lines":[{"line_number":1476,"context_line":"        # are associated with the load balancer. This is needed to handle"},{"line_number":1477,"context_line":"        # potential race that happens when lrp and lb are created at the"},{"line_number":1478,"context_line":"        # same time."},{"line_number":1479,"context_line":"        subnet \u003d self._get_subnet(subnet_id)"},{"line_number":1480,"context_line":"        if subnet:"},{"line_number":1481,"context_line":"            ls_name \u003d utils.ovn_name(subnet[\u0027subnet\u0027][\u0027network_id\u0027])"},{"line_number":1482,"context_line":"            ovn_ls \u003d self.ovn_nbdb_api.ls_get(ls_name).execute("}],"source_content_type":"text/x-python","patch_set":4,"id":"c13d8983_004d9945","line":1479,"updated":"2021-06-14 21:39:10.000000000","message":"After thinking about this some more, I think we should limit the scope of the change to just fixing the bug, i.e. put a try/except here for getting the subnet and leave the others alone.  We could maybe add a helper in a follow-on.  The reason being is all the extra changes are going to cause merge conflicts with the Health Monitor patch, which I don\u0027t want to do.  I think limiting the scope to just this section won\u0027t have this problem.","commit_id":"fd00a12df27faa380e7bb5058440bdec8c86aebf"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"c9c4d34e3bc83c12dc7dadd1e3232987dba4f046","unresolved":true,"context_lines":[{"line_number":1483,"context_line":"                        net, ovn_lb.uuid, may_exist\u003dTrue))"},{"line_number":1484,"context_line":"        except n_exc.NotFound:"},{"line_number":1485,"context_line":"            pass"},{"line_number":1486,"context_line":"        except idlutils.RowNotFound:"},{"line_number":1487,"context_line":"            pass"},{"line_number":1488,"context_line":""},{"line_number":1489,"context_line":"        self._execute_commands(commands)"}],"source_content_type":"text/x-python","patch_set":5,"id":"52f81808_43e39767","line":1486,"updated":"2021-06-15 19:10:43.000000000","message":"Ok, this is for the exception _find_lr_of_ls() might throw - can you also add a test for that?","commit_id":"00e7c10271d982ea0309a6f88e4555799b2db781"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"f8ba18c2373a4c18ef6253fc1ad13bcf26d6212c","unresolved":false,"context_lines":[{"line_number":1483,"context_line":"                        net, ovn_lb.uuid, may_exist\u003dTrue))"},{"line_number":1484,"context_line":"        except n_exc.NotFound:"},{"line_number":1485,"context_line":"            pass"},{"line_number":1486,"context_line":"        except idlutils.RowNotFound:"},{"line_number":1487,"context_line":"            pass"},{"line_number":1488,"context_line":""},{"line_number":1489,"context_line":"        self._execute_commands(commands)"}],"source_content_type":"text/x-python","patch_set":5,"id":"93426247_834ad59f","line":1486,"in_reply_to":"0e46a44b_5405ffd8","updated":"2021-06-15 21:34:36.000000000","message":"FYI: The testing for idlutils.RowNotFound is being exercised in test_member_create","commit_id":"00e7c10271d982ea0309a6f88e4555799b2db781"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"8b8d51cc14b36b35496f60e10d9f68a655eb9558","unresolved":false,"context_lines":[{"line_number":1483,"context_line":"                        net, ovn_lb.uuid, may_exist\u003dTrue))"},{"line_number":1484,"context_line":"        except n_exc.NotFound:"},{"line_number":1485,"context_line":"            pass"},{"line_number":1486,"context_line":"        except idlutils.RowNotFound:"},{"line_number":1487,"context_line":"            pass"},{"line_number":1488,"context_line":""},{"line_number":1489,"context_line":"        self._execute_commands(commands)"}],"source_content_type":"text/x-python","patch_set":5,"id":"0e46a44b_5405ffd8","line":1486,"in_reply_to":"52f81808_43e39767","updated":"2021-06-15 21:30:16.000000000","message":"Done","commit_id":"00e7c10271d982ea0309a6f88e4555799b2db781"}],"ovn_octavia_provider/tests/unit/test_helper.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e4f6f82cf799fa89d6897c31bbb2225891d10a24","unresolved":true,"context_lines":[{"line_number":1156,"context_line":"    @mock.patch(\u0027ovn_octavia_provider.common.clients.get_neutron_client\u0027)"},{"line_number":1157,"context_line":"    def test_member_create_lb_add_from_lr(self, net_cli, f_lr, f_ls):"},{"line_number":1158,"context_line":"        fake_subnet \u003d fakes.FakeSubnet.create_one_subnet()"},{"line_number":1159,"context_line":"        net_cli.return_value.show_subnet.side_effect \u003d ["},{"line_number":1160,"context_line":"            {\u0027subnet\u0027: fake_subnet}]"},{"line_number":1161,"context_line":"        f_lr.return_value \u003d self.router"},{"line_number":1162,"context_line":"        f_ls.return_value \u003d [self.network]"}],"source_content_type":"text/x-python","patch_set":3,"id":"078af453_fc7b2ab4","line":1159,"range":{"start_line":1159,"start_character":41,"end_line":1159,"end_character":52},"updated":"2021-06-14 15:50:50.000000000","message":"s/return_value - side_effect is used when throwing an exception, although I think they both strangely work.","commit_id":"6534cacdb700fb956c65c9b9b4a58d58e721cf6f"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"3863e1b5b5907d07907e6254ec1f5192fe4af1a3","unresolved":true,"context_lines":[{"line_number":1156,"context_line":"    @mock.patch(\u0027ovn_octavia_provider.common.clients.get_neutron_client\u0027)"},{"line_number":1157,"context_line":"    def test_member_create_lb_add_from_lr(self, net_cli, f_lr, f_ls):"},{"line_number":1158,"context_line":"        fake_subnet \u003d fakes.FakeSubnet.create_one_subnet()"},{"line_number":1159,"context_line":"        net_cli.return_value.show_subnet.side_effect \u003d ["},{"line_number":1160,"context_line":"            {\u0027subnet\u0027: fake_subnet}]"},{"line_number":1161,"context_line":"        f_lr.return_value \u003d self.router"},{"line_number":1162,"context_line":"        f_ls.return_value \u003d [self.network]"}],"source_content_type":"text/x-python","patch_set":3,"id":"50c10a5b_b2ce3345","line":1159,"range":{"start_line":1159,"start_character":41,"end_line":1159,"end_character":52},"in_reply_to":"078af453_fc7b2ab4","updated":"2021-06-14 15:57:48.000000000","message":"good point. Will fix.","commit_id":"6534cacdb700fb956c65c9b9b4a58d58e721cf6f"},{"author":{"_account_id":11952,"name":"Flavio Fernandes","email":"flavio@flaviof.com","username":"ffernand"},"change_message_id":"fc99215611d8a735ed718e9daecd4491a7a94638","unresolved":false,"context_lines":[{"line_number":1156,"context_line":"    @mock.patch(\u0027ovn_octavia_provider.common.clients.get_neutron_client\u0027)"},{"line_number":1157,"context_line":"    def test_member_create_lb_add_from_lr(self, net_cli, f_lr, f_ls):"},{"line_number":1158,"context_line":"        fake_subnet \u003d fakes.FakeSubnet.create_one_subnet()"},{"line_number":1159,"context_line":"        net_cli.return_value.show_subnet.side_effect \u003d ["},{"line_number":1160,"context_line":"            {\u0027subnet\u0027: fake_subnet}]"},{"line_number":1161,"context_line":"        f_lr.return_value \u003d self.router"},{"line_number":1162,"context_line":"        f_ls.return_value \u003d [self.network]"}],"source_content_type":"text/x-python","patch_set":3,"id":"423d484f_787a79c8","line":1159,"range":{"start_line":1159,"start_character":41,"end_line":1159,"end_character":52},"in_reply_to":"50c10a5b_b2ce3345","updated":"2021-06-14 16:13:40.000000000","message":"done","commit_id":"6534cacdb700fb956c65c9b9b4a58d58e721cf6f"}]}