)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"39dc7c24b742217ec5863c1865a9f6923800be04","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3828047d_c323f955","updated":"2021-11-22 07:44:18.000000000","message":"recheck","commit_id":"7e228b57a2b104b1dda46698aad8c226dbf5ed1b"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"2c59534761e9a83799020f8c327c6d07f7c59267","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a88f9faa_9cdc4885","updated":"2021-11-24 21:25:59.000000000","message":"recheck","commit_id":"7e228b57a2b104b1dda46698aad8c226dbf5ed1b"}],"ovn_octavia_provider/helper.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a36ed27e568fdbba49ad332e016ab56affea7cd6","unresolved":true,"context_lines":[{"line_number":623,"context_line":"                                  \u0027fetch its data.\u0027, sid)"},{"line_number":624,"context_line":"        return ls"},{"line_number":625,"context_line":""},{"line_number":626,"context_line":"    def _find_lr_of_ls(self, ovn_ls, subnet_gateway_ip\u003dNone):"},{"line_number":627,"context_line":"        lsp_router_port \u003d None"},{"line_number":628,"context_line":"        for port in ovn_ls.ports or []:"},{"line_number":629,"context_line":"            if port.type \u003d\u003d \u0027router\u0027:"}],"source_content_type":"text/x-python","patch_set":2,"id":"a9f252e7_b63a1c61","line":626,"range":{"start_line":626,"start_character":37,"end_line":626,"end_character":54},"updated":"2021-11-08 10:30:09.000000000","message":"Just one question: if \"subnet_gateway_ip\u003dNone\", we don\u0027t take into account this parameter? We just consider this port is the LSP router port?","commit_id":"13242bff7103674060b5e92804e0cce9c516dc06"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"f039e6707823965a50661280868fbbd7af95d33a","unresolved":false,"context_lines":[{"line_number":623,"context_line":"                                  \u0027fetch its data.\u0027, sid)"},{"line_number":624,"context_line":"        return ls"},{"line_number":625,"context_line":""},{"line_number":626,"context_line":"    def _find_lr_of_ls(self, ovn_ls, subnet_gateway_ip\u003dNone):"},{"line_number":627,"context_line":"        lsp_router_port \u003d None"},{"line_number":628,"context_line":"        for port in ovn_ls.ports or []:"},{"line_number":629,"context_line":"            if port.type \u003d\u003d \u0027router\u0027:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1d49267d_4d099592","line":626,"range":{"start_line":626,"start_character":37,"end_line":626,"end_character":54},"in_reply_to":"a9f252e7_b63a1c61","updated":"2021-11-10 14:06:20.000000000","message":"Yes, so if there is no subnet_gateway_ip given, it will behave as it was before and will return first router port which will be found.","commit_id":"13242bff7103674060b5e92804e0cce9c516dc06"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a6cdf6e783d80b970d6e4ec8522b66d8bf22363c","unresolved":true,"context_lines":[{"line_number":862,"context_line":"            ls_name \u003d utils.ovn_name(port[\u0027network_id\u0027])"},{"line_number":863,"context_line":"            ovn_ls \u003d self.ovn_nbdb_api.ls_get(ls_name).execute("},{"line_number":864,"context_line":"                check_error\u003dTrue)"},{"line_number":865,"context_line":"            ovn_lr \u003d self._find_lr_of_ls(ovn_ls, subnet.get(\u0027gateway_ip\u0027))"},{"line_number":866,"context_line":"            if ovn_lr:"},{"line_number":867,"context_line":"                commands.extend(self._update_lb_to_lr_association("},{"line_number":868,"context_line":"                    ovn_lb, ovn_lr))"}],"source_content_type":"text/x-python","patch_set":2,"id":"29b68c3b_b51026be","line":865,"range":{"start_line":865,"start_character":49,"end_line":865,"end_character":73},"updated":"2021-11-08 10:28:33.000000000","message":"\"subnet\" could be None (L803). I think you should assign \"subnet \u003d {}\" in L803","commit_id":"13242bff7103674060b5e92804e0cce9c516dc06"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"f039e6707823965a50661280868fbbd7af95d33a","unresolved":false,"context_lines":[{"line_number":862,"context_line":"            ls_name \u003d utils.ovn_name(port[\u0027network_id\u0027])"},{"line_number":863,"context_line":"            ovn_ls \u003d self.ovn_nbdb_api.ls_get(ls_name).execute("},{"line_number":864,"context_line":"                check_error\u003dTrue)"},{"line_number":865,"context_line":"            ovn_lr \u003d self._find_lr_of_ls(ovn_ls, subnet.get(\u0027gateway_ip\u0027))"},{"line_number":866,"context_line":"            if ovn_lr:"},{"line_number":867,"context_line":"                commands.extend(self._update_lb_to_lr_association("},{"line_number":868,"context_line":"                    ovn_lb, ovn_lr))"}],"source_content_type":"text/x-python","patch_set":2,"id":"d31837f0_e05798dc","line":865,"range":{"start_line":865,"start_character":49,"end_line":865,"end_character":73},"in_reply_to":"29b68c3b_b51026be","updated":"2021-11-10 14:06:20.000000000","message":"Good catch, thx.","commit_id":"13242bff7103674060b5e92804e0cce9c516dc06"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"1aef65c3d1bc3080cb36b4b8dcf79b3cde53d9fc","unresolved":true,"context_lines":[{"line_number":800,"context_line":""},{"line_number":801,"context_line":"    def lb_create(self, loadbalancer, protocol\u003dNone):"},{"line_number":802,"context_line":"        port \u003d None"},{"line_number":803,"context_line":"        subnet \u003d {}"},{"line_number":804,"context_line":"        neutron_client \u003d clients.get_neutron_client()"},{"line_number":805,"context_line":"        if loadbalancer.get(constants.VIP_PORT_ID):"},{"line_number":806,"context_line":"            # In case we don\u0027t have vip_network_id"}],"source_content_type":"text/x-python","patch_set":3,"id":"9fdfa72f_2d6432f6","line":803,"range":{"start_line":803,"start_character":17,"end_line":803,"end_character":19},"updated":"2021-11-12 15:14:01.000000000","message":"+1","commit_id":"7e228b57a2b104b1dda46698aad8c226dbf5ed1b"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"08da162883d32a1e56138bfa136bef7f074fcf6f","unresolved":true,"context_lines":[{"line_number":629,"context_line":"            if port.type \u003d\u003d \u0027router\u0027:"},{"line_number":630,"context_line":"                if subnet_gateway_ip:"},{"line_number":631,"context_line":"                    port_cidr \u003d netaddr.IPNetwork("},{"line_number":632,"context_line":"                        port.external_ids[\u0027neutron:cidrs\u0027]).ip"},{"line_number":633,"context_line":"                    if netaddr.IPAddress(subnet_gateway_ip) !\u003d port_cidr:"},{"line_number":634,"context_line":"                        continue"},{"line_number":635,"context_line":"                lsp_router_port \u003d port"}],"source_content_type":"text/x-python","patch_set":4,"id":"f1963018_ae764f37","line":632,"range":{"start_line":632,"start_character":41,"end_line":632,"end_character":58},"updated":"2022-01-24 12:33:59.000000000","message":"this seems to be causing issue, in my local setup a router port it\u0027s neutron:cidrs\"\u003d\"172.24.4.149/24 2001:db8::131/64, and due to multiple address netaddr.IPNetwork fails with ValueError: invalid literal for int() with base 10: \u002724 2001:db8::131/64\u0027, not sure if network with both ipv4/ipv6 subnets supported with octavia ovn provider.","commit_id":"ee800e165469dec8c492893c5ba64d4be7cc3170"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"3a805776a836d087f33a640e12097dc3277a5551","unresolved":true,"context_lines":[{"line_number":629,"context_line":"            if port.type \u003d\u003d \u0027router\u0027:"},{"line_number":630,"context_line":"                if subnet_gateway_ip:"},{"line_number":631,"context_line":"                    port_cidr \u003d netaddr.IPNetwork("},{"line_number":632,"context_line":"                        port.external_ids[\u0027neutron:cidrs\u0027]).ip"},{"line_number":633,"context_line":"                    if netaddr.IPAddress(subnet_gateway_ip) !\u003d port_cidr:"},{"line_number":634,"context_line":"                        continue"},{"line_number":635,"context_line":"                lsp_router_port \u003d port"}],"source_content_type":"text/x-python","patch_set":4,"id":"ad22c136_c06e0094","line":632,"range":{"start_line":632,"start_character":41,"end_line":632,"end_character":58},"in_reply_to":"9ffc857c_2b619c08","updated":"2022-01-28 14:59:14.000000000","message":"Thx, fix proposed https://review.opendev.org/c/openstack/ovn-octavia-provider/+/816868/","commit_id":"ee800e165469dec8c492893c5ba64d4be7cc3170"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"1ed686c30d49505ea90cb13aaacf7c33e7ee11a7","unresolved":true,"context_lines":[{"line_number":629,"context_line":"            if port.type \u003d\u003d \u0027router\u0027:"},{"line_number":630,"context_line":"                if subnet_gateway_ip:"},{"line_number":631,"context_line":"                    port_cidr \u003d netaddr.IPNetwork("},{"line_number":632,"context_line":"                        port.external_ids[\u0027neutron:cidrs\u0027]).ip"},{"line_number":633,"context_line":"                    if netaddr.IPAddress(subnet_gateway_ip) !\u003d port_cidr:"},{"line_number":634,"context_line":"                        continue"},{"line_number":635,"context_line":"                lsp_router_port \u003d port"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ffc857c_2b619c08","line":632,"range":{"start_line":632,"start_character":41,"end_line":632,"end_character":58},"in_reply_to":"f1963018_ae764f37","updated":"2022-01-25 09:00:23.000000000","message":"reported lp for tracking https://bugs.launchpad.net/neutron/+bug/1958961","commit_id":"ee800e165469dec8c492893c5ba64d4be7cc3170"}]}