)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"08fce651b78579ef30e9c16239b2d49555008180","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Set listeners back to ACTIVE upon pool/member action failures"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch ensure the listeners are set back from PENDING_UPDATE"},{"line_number":10,"context_line":"to ACTIVE in case of member or pool update failure."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I95860ae305c3d0c10859afb972d000328e23d614"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ab33f33a_3dd1b698","line":10,"updated":"2022-01-05 22:40:59.000000000","message":"Bug?","commit_id":"a2e5e5b103b337bd5d8f28e453d34cd97ce99be2"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"d851596fe20f2f8943270aeb5220a4658351944c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Set listeners back to ACTIVE upon pool/member action failures"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch ensure the listeners are set back from PENDING_UPDATE"},{"line_number":10,"context_line":"to ACTIVE in case of member or pool update failure."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I95860ae305c3d0c10859afb972d000328e23d614"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"366931fb_bf2d9fef","line":10,"in_reply_to":"ab33f33a_3dd1b698","updated":"2022-01-07 09:42:55.000000000","message":"Done","commit_id":"a2e5e5b103b337bd5d8f28e453d34cd97ce99be2"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"08fce651b78579ef30e9c16239b2d49555008180","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2df47dc5_4e46136f","updated":"2022-01-05 22:40:59.000000000","message":"I promised myself I would not review code in this repository, but I will try and help out.","commit_id":"a2e5e5b103b337bd5d8f28e453d34cd97ce99be2"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"d851596fe20f2f8943270aeb5220a4658351944c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b5400db2_ac9d9c58","updated":"2022-01-07 09:42:55.000000000","message":"Thanks Brian!","commit_id":"a2e5e5b103b337bd5d8f28e453d34cd97ce99be2"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"347cf16781e0d6e72b567213c5e67d0ec2c33734","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"e2b0681e_7eacc15d","updated":"2022-01-10 09:53:29.000000000","message":"Thanks Luis","commit_id":"ed4aea1803389c84b923d33d52a61a57eecb0748"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"c722793fe347963707801301370b06c895356755","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"e92f9743_eaddc736","updated":"2022-01-10 09:58:32.000000000","message":"recheck","commit_id":"ed4aea1803389c84b923d33d52a61a57eecb0748"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"5aa3c4d595a2da38f7956e9976df6e0cabff8985","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"347d5c45_0e120169","updated":"2022-01-17 14:16:19.000000000","message":"recheck","commit_id":"4d01470f5e397bb6de1b10db9f839fa72697ff6b"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"fe6cef50e0f68ce610797136a803a939e8c8403e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"8575bd76_79eb5139","updated":"2022-01-14 11:54:28.000000000","message":"recheck","commit_id":"4d01470f5e397bb6de1b10db9f839fa72697ff6b"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"5a5c73c3ffb452189f1f09d8a50ed8ea09767759","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c75bd786_0bb80a85","updated":"2022-01-14 11:32:15.000000000","message":"recheck","commit_id":"4d01470f5e397bb6de1b10db9f839fa72697ff6b"}],"ovn_octavia_provider/helper.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"08fce651b78579ef30e9c16239b2d49555008180","unresolved":true,"context_lines":[{"line_number":1405,"context_line":"            if listener_id:"},{"line_number":1406,"context_line":"                status[constants.LISTENERS] \u003d ["},{"line_number":1407,"context_line":"                    {constants.ID: listener_id,"},{"line_number":1408,"context_line":"                     constants.PROVISIONING_STATUS: constants.ACTIVE}]"},{"line_number":1409,"context_line":""},{"line_number":1410,"context_line":"        return status"},{"line_number":1411,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"a2c3ef65_8a756bba","line":1408,"updated":"2022-01-05 22:40:59.000000000","message":"Instead of duplicating L1392-1395, this code can probably live un-indented below for both cases.  Same would apply below.","commit_id":"a2e5e5b103b337bd5d8f28e453d34cd97ce99be2"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"d851596fe20f2f8943270aeb5220a4658351944c","unresolved":false,"context_lines":[{"line_number":1405,"context_line":"            if listener_id:"},{"line_number":1406,"context_line":"                status[constants.LISTENERS] \u003d ["},{"line_number":1407,"context_line":"                    {constants.ID: listener_id,"},{"line_number":1408,"context_line":"                     constants.PROVISIONING_STATUS: constants.ACTIVE}]"},{"line_number":1409,"context_line":""},{"line_number":1410,"context_line":"        return status"},{"line_number":1411,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"c5d3be26_8617d980","line":1408,"in_reply_to":"a2c3ef65_8a756bba","updated":"2022-01-07 09:42:55.000000000","message":"Done","commit_id":"a2e5e5b103b337bd5d8f28e453d34cd97ce99be2"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"9f3c34231f945dad59c65b1430eefb54d157b63a","unresolved":true,"context_lines":[{"line_number":1397,"context_line":"                     constants.PROVISIONING_STATUS: constants.ERROR}],"},{"line_number":1398,"context_line":"                constants.LOADBALANCERS: ["},{"line_number":1399,"context_line":"                    {constants.ID: pool[constants.LOADBALANCER_ID],"},{"line_number":1400,"context_line":"                     constants.PROVISIONING_STATUS: constants.ACTIVE}]}"},{"line_number":1401,"context_line":"        if listener_id:"},{"line_number":1402,"context_line":"            status[constants.LISTENERS] \u003d ["},{"line_number":1403,"context_line":"                {constants.ID: listener_id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"7e4261c2_4b5c2ef2","line":1400,"updated":"2022-01-09 19:27:17.000000000","message":"nit: should put blank line here so it\u0027s obvious it\u0027s separate block.","commit_id":"42fed71c0865dc7478ed0a32be70e2a621fae37a"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"68705e0b0c9edfd39ee3391b192f8d012e292e65","unresolved":false,"context_lines":[{"line_number":1397,"context_line":"                     constants.PROVISIONING_STATUS: constants.ERROR}],"},{"line_number":1398,"context_line":"                constants.LOADBALANCERS: ["},{"line_number":1399,"context_line":"                    {constants.ID: pool[constants.LOADBALANCER_ID],"},{"line_number":1400,"context_line":"                     constants.PROVISIONING_STATUS: constants.ACTIVE}]}"},{"line_number":1401,"context_line":"        if listener_id:"},{"line_number":1402,"context_line":"            status[constants.LISTENERS] \u003d ["},{"line_number":1403,"context_line":"                {constants.ID: listener_id,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3fac6451_a93f7c24","line":1400,"in_reply_to":"7e4261c2_4b5c2ef2","updated":"2022-01-10 07:20:53.000000000","message":"Done","commit_id":"42fed71c0865dc7478ed0a32be70e2a621fae37a"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"4af4781f2be6b491ebf7eb1c936669b53d31487b","unresolved":true,"context_lines":[{"line_number":1399,"context_line":"                    {constants.ID: pool[constants.LOADBALANCER_ID],"},{"line_number":1400,"context_line":"                     constants.PROVISIONING_STATUS: constants.ACTIVE}]}"},{"line_number":1401,"context_line":""},{"line_number":1402,"context_line":"        if listener_id:"},{"line_number":1403,"context_line":"            status[constants.LISTENERS] \u003d ["},{"line_number":1404,"context_line":"                {constants.ID: listener_id,"},{"line_number":1405,"context_line":"                 constants.PROVISIONING_STATUS: constants.ACTIVE}]"}],"source_content_type":"text/x-python","patch_set":4,"id":"f5e8c1d8_7df55762","line":1402,"range":{"start_line":1402,"start_character":11,"end_line":1402,"end_character":22},"updated":"2022-01-10 07:45:46.000000000","message":"This one is not correct, a pool may be attached to many listeners.\nWe should use the same approach as you did in the other functions\n\nFor reference, this is the similar task in the amphora driver, it updates all the listeners attached to the pool:\nhttps://opendev.org/openstack/octavia/src/branch/master/octavia/controller/worker/v2/tasks/database_tasks.py#L1200-L1228","commit_id":"8c45b2b7018d75cd6182ab9584ce8e4d99a32ba0"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"d0eb05125ffdccd15eb2fd99f6d847cd6a0f1522","unresolved":true,"context_lines":[{"line_number":1399,"context_line":"                    {constants.ID: pool[constants.LOADBALANCER_ID],"},{"line_number":1400,"context_line":"                     constants.PROVISIONING_STATUS: constants.ACTIVE}]}"},{"line_number":1401,"context_line":""},{"line_number":1402,"context_line":"        if listener_id:"},{"line_number":1403,"context_line":"            status[constants.LISTENERS] \u003d ["},{"line_number":1404,"context_line":"                {constants.ID: listener_id,"},{"line_number":1405,"context_line":"                 constants.PROVISIONING_STATUS: constants.ACTIVE}]"}],"source_content_type":"text/x-python","patch_set":4,"id":"e01ca758_f8cc5493","line":1402,"range":{"start_line":1402,"start_character":11,"end_line":1402,"end_character":22},"in_reply_to":"7d4dacbf_69fbacf1","updated":"2022-01-10 08:02:11.000000000","message":"ok, updating it with a fix for both! Thanks! Nice catch!","commit_id":"8c45b2b7018d75cd6182ab9584ce8e4d99a32ba0"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"78482a7df90970e8bfd85b17c68bfc10800cd1e0","unresolved":true,"context_lines":[{"line_number":1399,"context_line":"                    {constants.ID: pool[constants.LOADBALANCER_ID],"},{"line_number":1400,"context_line":"                     constants.PROVISIONING_STATUS: constants.ACTIVE}]}"},{"line_number":1401,"context_line":""},{"line_number":1402,"context_line":"        if listener_id:"},{"line_number":1403,"context_line":"            status[constants.LISTENERS] \u003d ["},{"line_number":1404,"context_line":"                {constants.ID: listener_id,"},{"line_number":1405,"context_line":"                 constants.PROVISIONING_STATUS: constants.ACTIVE}]"}],"source_content_type":"text/x-python","patch_set":4,"id":"7d4dacbf_69fbacf1","line":1402,"range":{"start_line":1402,"start_character":11,"end_line":1402,"end_character":22},"in_reply_to":"f1968c81_c81b3342","updated":"2022-01-10 07:57:29.000000000","message":"oh yeah, it was wrong before your patch","commit_id":"8c45b2b7018d75cd6182ab9584ce8e4d99a32ba0"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"f137412e31d57a34f8dee55b0605d903e2ed080f","unresolved":true,"context_lines":[{"line_number":1399,"context_line":"                    {constants.ID: pool[constants.LOADBALANCER_ID],"},{"line_number":1400,"context_line":"                     constants.PROVISIONING_STATUS: constants.ACTIVE}]}"},{"line_number":1401,"context_line":""},{"line_number":1402,"context_line":"        if listener_id:"},{"line_number":1403,"context_line":"            status[constants.LISTENERS] \u003d ["},{"line_number":1404,"context_line":"                {constants.ID: listener_id,"},{"line_number":1405,"context_line":"                 constants.PROVISIONING_STATUS: constants.ACTIVE}]"}],"source_content_type":"text/x-python","patch_set":4,"id":"f1968c81_c81b3342","line":1402,"range":{"start_line":1402,"start_character":11,"end_line":1402,"end_character":22},"in_reply_to":"f5e8c1d8_7df55762","updated":"2022-01-10 07:53:22.000000000","message":"So, this was wrong also before this patch when there is no exception?","commit_id":"8c45b2b7018d75cd6182ab9584ce8e4d99a32ba0"}]}