)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"7f8a65e100bb9f09ef90fa839b9e3b8434d08360","unresolved":true,"context_lines":[{"line_number":16,"context_line":"Closes-Bug: #1958964"},{"line_number":17,"context_line":"(cherry picked from commit 6cc77f8a22084d610bdc071c8aab36615f0a6a0b)"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Upstream-Wallaby: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/827694"},{"line_number":20,"context_line":"Upstream-Xena: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/827689"},{"line_number":21,"context_line":"Upstream-Victoria: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/827692"},{"line_number":22,"context_line":"Change-Id: I6e9bdbd4efed55b2a3ca4cb53ab118130a2286dc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9cac98a8_ccf5cbdd","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":16},"updated":"2022-02-09 15:54:24.000000000","message":"Another note on backports, these are not needed as we can find the other branches with the similar change-id, and the \"cherry picked\" line.\nNothing wrong about these lines of course, it would not block merge","commit_id":"1b456fdfeac42d2aa73fcbb74ac07007bccb302c"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"2ca842493ba52b7e34753f86ce0aafd873b6b993","unresolved":true,"context_lines":[{"line_number":19,"context_line":"Upstream-Wallaby: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/827694"},{"line_number":20,"context_line":"Upstream-Xena: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/827689"},{"line_number":21,"context_line":"Upstream-Victoria: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/827692"},{"line_number":22,"context_line":"Change-Id: I6e9bdbd4efed55b2a3ca4cb53ab118130a2286dc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"27727931_7eb07e4f","line":22,"range":{"start_line":22,"start_character":11,"end_line":22,"end_character":52},"updated":"2022-02-09 15:52:26.000000000","message":"The other backports have I07c792c5785f978e7dde238aa3971b87d220a8eb change-id (I guess this one was done manually?), it should be the same so we can find it easily and have it shown in gerrit\n\nNote that uploading it with proper change-id will create a new gerrit review, no problem you can abandon that one then","commit_id":"1b456fdfeac42d2aa73fcbb74ac07007bccb302c"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"6420ce2ab72550a4fa0a71301bb98eef810c9a97","unresolved":false,"context_lines":[{"line_number":19,"context_line":"Upstream-Wallaby: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/827694"},{"line_number":20,"context_line":"Upstream-Xena: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/827689"},{"line_number":21,"context_line":"Upstream-Victoria: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/827692"},{"line_number":22,"context_line":"Change-Id: I6e9bdbd4efed55b2a3ca4cb53ab118130a2286dc"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"d9649f49_747f543e","line":22,"range":{"start_line":22,"start_character":11,"end_line":22,"end_character":52},"in_reply_to":"27727931_7eb07e4f","updated":"2022-02-09 16:09:26.000000000","message":"done at https://review.opendev.org/c/openstack/ovn-octavia-provider/+/828581, let us abandon this one. thx","commit_id":"1b456fdfeac42d2aa73fcbb74ac07007bccb302c"}],"ovn_octavia_provider/driver.py":[{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"987035ffe5c300929957b028805e56bcbf51dfcd","unresolved":true,"context_lines":[{"line_number":2078,"context_line":"    def listener_create(self, listener):"},{"line_number":2079,"context_line":"        self._check_for_supported_protocols(listener.protocol)"},{"line_number":2080,"context_line":"        self._check_for_allowed_cidrs(listener.allowed_cidrs)"},{"line_number":2081,"context_line":""},{"line_number":2082,"context_line":"        admin_state_up \u003d listener.admin_state_up"},{"line_number":2083,"context_line":"        if isinstance(admin_state_up, o_datamodels.UnsetType):"},{"line_number":2084,"context_line":"            admin_state_up \u003d True"}],"source_content_type":"text/x-python","patch_set":5,"id":"2818c6f7_8de9d4c1","side":"PARENT","line":2081,"updated":"2022-02-07 16:27:06.000000000","message":"I was wondering... For the sake of future code consistency, given that you deleted this line in the merged master patch, wouldn\u0027t it be better to make that change consistently on all the backports? Please correct me if I\u0027m wrong though :)","commit_id":"6885cfb046e4eae933f1347f34aefd6e28268d32"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"f7da6695e5c99e429eb2d639526b7b396e3c40a9","unresolved":false,"context_lines":[{"line_number":2078,"context_line":"    def listener_create(self, listener):"},{"line_number":2079,"context_line":"        self._check_for_supported_protocols(listener.protocol)"},{"line_number":2080,"context_line":"        self._check_for_allowed_cidrs(listener.allowed_cidrs)"},{"line_number":2081,"context_line":""},{"line_number":2082,"context_line":"        admin_state_up \u003d listener.admin_state_up"},{"line_number":2083,"context_line":"        if isinstance(admin_state_up, o_datamodels.UnsetType):"},{"line_number":2084,"context_line":"            admin_state_up \u003d True"}],"source_content_type":"text/x-python","patch_set":5,"id":"6a94d3f0_511ade33","side":"PARENT","line":2081,"in_reply_to":"2818c6f7_8de9d4c1","updated":"2022-02-07 16:36:49.000000000","message":"yep! in fact using cherrypick it applies, so these manual cherrypick for keeping the traceability between master -\u003e backports better to remove it too, thx","commit_id":"6885cfb046e4eae933f1347f34aefd6e28268d32"}]}