)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"ee224bf7075ba009f7412e3b93db6d85192c5d5a","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Retry of logical switch association to the load balancer for large networks"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"On load-balancer creation, or other operations related to association of"},{"line_number":10,"context_line":"logical router to the load balancer, all logical switches associated with the"},{"line_number":11,"context_line":"logical router in the target network are also associated with the"},{"line_number":12,"context_line":"load-balancer.  When the topology includes multiple subnets, it may"},{"line_number":13,"context_line":"happen that the operation over the load-balancer match in time with"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"c563c3a1_921d18fe","line":10,"range":{"start_line":9,"start_character":54,"end_line":10,"end_character":35},"updated":"2022-03-11 12:31:57.000000000","message":"nit: related to association of the load balancer to the logical router","commit_id":"4bf3d3cf76acd49c9d5259dbcfc86f261307871f"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"89dcf3b1fa445043f74d534fdc8e1034f61f9351","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Retry of logical switch association to the load balancer for large networks"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"On load-balancer creation, or other operations related to association of"},{"line_number":10,"context_line":"logical router to the load balancer, all logical switches associated with the"},{"line_number":11,"context_line":"logical router in the target network are also associated with the"},{"line_number":12,"context_line":"load-balancer.  When the topology includes multiple subnets, it may"},{"line_number":13,"context_line":"happen that the operation over the load-balancer match in time with"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"30a5240d_c50c1f54","line":10,"range":{"start_line":9,"start_character":54,"end_line":10,"end_character":35},"in_reply_to":"c563c3a1_921d18fe","updated":"2022-03-11 12:35:30.000000000","message":"Done","commit_id":"4bf3d3cf76acd49c9d5259dbcfc86f261307871f"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"ee224bf7075ba009f7412e3b93db6d85192c5d5a","unresolved":true,"context_lines":[{"line_number":13,"context_line":"happen that the operation over the load-balancer match in time with"},{"line_number":14,"context_line":"the removal of some of the subnets."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"For example, the creation of the load-balancer is a transactional atomic"},{"line_number":17,"context_line":"process, so you should consider splitting such transactions and retrying"},{"line_number":18,"context_line":"in case of the above error. In case the attempts are exhausted and the"},{"line_number":19,"context_line":"error remains, we evaluate command by command, in case LsLbAdd or LsLbDel"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"e538dfaa_90e72674","line":16,"range":{"start_line":16,"start_character":1,"end_line":16,"end_character":13},"updated":"2022-03-11 12:31:57.000000000","message":"remote the \"For example\"","commit_id":"4bf3d3cf76acd49c9d5259dbcfc86f261307871f"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"89dcf3b1fa445043f74d534fdc8e1034f61f9351","unresolved":false,"context_lines":[{"line_number":13,"context_line":"happen that the operation over the load-balancer match in time with"},{"line_number":14,"context_line":"the removal of some of the subnets."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"For example, the creation of the load-balancer is a transactional atomic"},{"line_number":17,"context_line":"process, so you should consider splitting such transactions and retrying"},{"line_number":18,"context_line":"in case of the above error. In case the attempts are exhausted and the"},{"line_number":19,"context_line":"error remains, we evaluate command by command, in case LsLbAdd or LsLbDel"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"5172422b_a6c0f0ee","line":16,"range":{"start_line":16,"start_character":1,"end_line":16,"end_character":13},"in_reply_to":"e538dfaa_90e72674","updated":"2022-03-11 12:35:30.000000000","message":"Done","commit_id":"4bf3d3cf76acd49c9d5259dbcfc86f261307871f"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"ee224bf7075ba009f7412e3b93db6d85192c5d5a","unresolved":true,"context_lines":[{"line_number":14,"context_line":"the removal of some of the subnets."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"For example, the creation of the load-balancer is a transactional atomic"},{"line_number":17,"context_line":"process, so you should consider splitting such transactions and retrying"},{"line_number":18,"context_line":"in case of the above error. In case the attempts are exhausted and the"},{"line_number":19,"context_line":"error remains, we evaluate command by command, in case LsLbAdd or LsLbDel"},{"line_number":20,"context_line":"of an Ls associated to the Lr, we can omit the error and go forward."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"a16291ed_5eabc7b8","line":17,"range":{"start_line":17,"start_character":9,"end_line":17,"end_character":42},"updated":"2022-03-11 12:31:57.000000000","message":". This patch is splitting such transactions and ...","commit_id":"4bf3d3cf76acd49c9d5259dbcfc86f261307871f"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"89dcf3b1fa445043f74d534fdc8e1034f61f9351","unresolved":false,"context_lines":[{"line_number":14,"context_line":"the removal of some of the subnets."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"For example, the creation of the load-balancer is a transactional atomic"},{"line_number":17,"context_line":"process, so you should consider splitting such transactions and retrying"},{"line_number":18,"context_line":"in case of the above error. In case the attempts are exhausted and the"},{"line_number":19,"context_line":"error remains, we evaluate command by command, in case LsLbAdd or LsLbDel"},{"line_number":20,"context_line":"of an Ls associated to the Lr, we can omit the error and go forward."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"47cb8bbc_cf6e4b1b","line":17,"range":{"start_line":17,"start_character":9,"end_line":17,"end_character":42},"in_reply_to":"a16291ed_5eabc7b8","updated":"2022-03-11 12:35:30.000000000","message":"Done","commit_id":"4bf3d3cf76acd49c9d5259dbcfc86f261307871f"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"6d0339c23bc4dd4ce3b6bc0b6bdd524651c1ed7e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e8b4ebd9_20f60a42","updated":"2022-02-15 07:52:33.000000000","message":"Executing the commands in 2 blocks looks ok for me","commit_id":"4552f4145ab63dd61dafd37265bd04f2abec97c1"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"1b7c4a225f0820a6ace6b9e1ac444494dfb6f1e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"0d6db76e_fd747418","updated":"2022-02-23 13:41:21.000000000","message":"Just want to mention too, this won\u0027t avoid the issue, just reducing the chances of hitting it","commit_id":"2b3826db5a6b8b6e7a40bba02b6763f4cc6b523b"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"cee0039a6a25198b67e8c9b046f2fcf061b6c066","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a2c6dbd8_a32cb1dd","updated":"2022-02-23 11:55:46.000000000","message":"code looks ok to me, would be great to add some unitest coverage, raising that exception","commit_id":"2b3826db5a6b8b6e7a40bba02b6763f4cc6b523b"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"b67433e2910c735082f1037db2de146c265f3ad8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"3ad1587d_3eea98ab","updated":"2022-03-02 12:25:00.000000000","message":"recheck","commit_id":"3cbf6ac6bf85fd83c0fd52aca1a110addc5ab806"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"aaa2802d72623f9c460521eea327c3fdf555faf3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"15b3bea2_9d6ddcbd","updated":"2022-03-04 14:21:47.000000000","message":"recheck","commit_id":"6f739bea5b0b926cd8d3b4c98ad5d4b4c12ccdb1"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"b6b9391d892b259da4537e429f7110161e1d5fd4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"7a56fe95_8f5079db","updated":"2022-03-04 14:50:36.000000000","message":"recheck","commit_id":"6f739bea5b0b926cd8d3b4c98ad5d4b4c12ccdb1"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"efb6bda857fc0b6445de26fc84b443e35a834867","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"e52a3ffe_2bf4cbb9","updated":"2022-03-04 16:47:01.000000000","message":"recheck","commit_id":"6f739bea5b0b926cd8d3b4c98ad5d4b4c12ccdb1"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"a4d3c85915af8c0eef0451227b042e36b84ea85a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"1f77a439_285030de","updated":"2022-03-07 11:37:07.000000000","message":"Some nits here and there. It also should point to a launchpad bug","commit_id":"0137676c2cd87a91625e572d759a9866741a1406"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"421b220864595ddc706df6baa47762fc980706e5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"89e6ab36_b18bf219","updated":"2022-03-07 17:54:59.000000000","message":"Looks mostly good, just one nit about the unittest (I still need to check those more carefully). Also, please consider adding functional testing coverage","commit_id":"db9827b0cd5bffa41f2686d5bb9e142514469e57"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"496adffb327dd9fe93ff8cbd91829d0d1af3b423","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"b5fc3ebf_c0ede778","in_reply_to":"89e6ab36_b18bf219","updated":"2022-03-11 11:57:54.000000000","message":"done","commit_id":"db9827b0cd5bffa41f2686d5bb9e142514469e57"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"ee224bf7075ba009f7412e3b93db6d85192c5d5a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"366dd62e_984820ac","updated":"2022-03-11 12:31:57.000000000","message":"Looks good, just some nits on the commit message. Lets see the gates!","commit_id":"4bf3d3cf76acd49c9d5259dbcfc86f261307871f"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"c42da94f56c93f7df5a172b2fb3e5d03e63a1034","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"5d2d50b5_0aff1f69","updated":"2022-03-11 16:40:58.000000000","message":"Failures seems unrelated","commit_id":"420ba9c44af560586f3ecb7a067f280d07738911"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"e56d86266a974a443f5410f2259baf47f50766be","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"644d7d3d_d81614ea","updated":"2022-03-11 14:28:49.000000000","message":"recheck","commit_id":"420ba9c44af560586f3ecb7a067f280d07738911"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"9bbff149b0b49afdf8a54ab3df0ca0498366dec2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"7ccea6c6_08dfca7f","updated":"2022-03-11 16:41:04.000000000","message":"recheck","commit_id":"420ba9c44af560586f3ecb7a067f280d07738911"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"076bbd833caa26ceaea8b121534cca6be9598472","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"df4a5e34_f2c42ab0","updated":"2022-03-11 14:29:03.000000000","message":"rechecking to ensure the problem with kuryr gates are not due to this patch","commit_id":"420ba9c44af560586f3ecb7a067f280d07738911"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"ed05535ec8817d43f5822319bdcb4f5e3b3c2dd2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":20,"id":"2c551b00_39b4f00c","updated":"2022-03-14 16:19:24.000000000","message":"Fast approving since ","commit_id":"f07dca455150a6b0762838b6d7b5325e82d63fbb"}],"ovn_octavia_provider/common/utils.py":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"c13c7febff1debf5a16e4d83054c4f56cb7f93a6","unresolved":true,"context_lines":[{"line_number":21,"context_line":"    # is a UUID. If so then there will be no matches."},{"line_number":22,"context_line":"    # We prefix the UUID to enable us to use the Neutron UUID when"},{"line_number":23,"context_line":"    # updating, deleting etc."},{"line_number":24,"context_line":"    if not id.startswith(constants.OVN_NAME_PREFIX):"},{"line_number":25,"context_line":"        return constants.OVN_NAME_PREFIX + \u0027%s\u0027 % id"},{"line_number":26,"context_line":"    return id"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"def ovn_lrouter_port_name(id):"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a2894d0_bde40a17","line":26,"range":{"start_line":24,"start_character":0,"end_line":26,"end_character":13},"updated":"2022-03-07 10:03:40.000000000","message":"this looks unrelated to this patch, perhaps better to split it in a different patch set","commit_id":"6f739bea5b0b926cd8d3b4c98ad5d4b4c12ccdb1"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"81f3a9421ae5513d2d821bd1fba72666dd80f04d","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    # is a UUID. If so then there will be no matches."},{"line_number":22,"context_line":"    # We prefix the UUID to enable us to use the Neutron UUID when"},{"line_number":23,"context_line":"    # updating, deleting etc."},{"line_number":24,"context_line":"    if not id.startswith(constants.OVN_NAME_PREFIX):"},{"line_number":25,"context_line":"        return constants.OVN_NAME_PREFIX + \u0027%s\u0027 % id"},{"line_number":26,"context_line":"    return id"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"def ovn_lrouter_port_name(id):"}],"source_content_type":"text/x-python","patch_set":10,"id":"ed8bd044_46bf6b7b","line":26,"range":{"start_line":24,"start_character":0,"end_line":26,"end_character":13},"in_reply_to":"3fc92ed7_1429f828","updated":"2022-03-07 13:04:06.000000000","message":"Lets go by a new function ovn_uuid(name) just to get uuid from a \"neutron-UUID\" OVN entry, and keep working on network_id parameter accordingly  throughout the code","commit_id":"6f739bea5b0b926cd8d3b4c98ad5d4b4c12ccdb1"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"a4d3c85915af8c0eef0451227b042e36b84ea85a","unresolved":true,"context_lines":[{"line_number":21,"context_line":"    # is a UUID. If so then there will be no matches."},{"line_number":22,"context_line":"    # We prefix the UUID to enable us to use the Neutron UUID when"},{"line_number":23,"context_line":"    # updating, deleting etc."},{"line_number":24,"context_line":"    if not id.startswith(constants.OVN_NAME_PREFIX):"},{"line_number":25,"context_line":"        return constants.OVN_NAME_PREFIX + \u0027%s\u0027 % id"},{"line_number":26,"context_line":"    return id"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"def ovn_lrouter_port_name(id):"}],"source_content_type":"text/x-python","patch_set":10,"id":"3fc92ed7_1429f828","line":26,"range":{"start_line":24,"start_character":0,"end_line":26,"end_character":13},"in_reply_to":"48216f72_630e39d1","updated":"2022-03-07 11:37:07.000000000","message":"I thought this method is to get the ovn name for a given ID, if you already have the ovn name (i.e., neutron-ID), then you should not call here.\n\nIf you want to drop the \"neutron-\", perhaps worth to have another method (instead of ovn_name) to get that (get_id_from_ovn_name or similar).\n\nAlso, not quite sure how this helps in the \"replace(\u0027neutron\u0027, \u0027\u0027)\" case. This will be adding \"neutron-\" to the ID if the ID does not yet container neutron-. It won\u0027t do the removal of \"neutron-\"","commit_id":"6f739bea5b0b926cd8d3b4c98ad5d4b4c12ccdb1"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"18fce05bf5efd9ebd52527586f0c99193ab355c1","unresolved":true,"context_lines":[{"line_number":21,"context_line":"    # is a UUID. If so then there will be no matches."},{"line_number":22,"context_line":"    # We prefix the UUID to enable us to use the Neutron UUID when"},{"line_number":23,"context_line":"    # updating, deleting etc."},{"line_number":24,"context_line":"    if not id.startswith(constants.OVN_NAME_PREFIX):"},{"line_number":25,"context_line":"        return constants.OVN_NAME_PREFIX + \u0027%s\u0027 % id"},{"line_number":26,"context_line":"    return id"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"def ovn_lrouter_port_name(id):"}],"source_content_type":"text/x-python","patch_set":10,"id":"48216f72_630e39d1","line":26,"range":{"start_line":24,"start_character":0,"end_line":26,"end_character":13},"in_reply_to":"9a2894d0_bde40a17","updated":"2022-03-07 10:50:38.000000000","message":"This method is called from several points, just to get neutron-\u003cUUID\u003e name under ovn context, now some of functions that call to this one, are called from methods that works with uuid or name indistinctly, so instead of make replace(\u0027neutron-\u0027,\u0027\u0027) just before called them as was done in ovn_octavia_provider/helper.py#b896 we can control here to transform this function in one able to manage with neutron-UUID or just UUID parameters","commit_id":"6f739bea5b0b926cd8d3b4c98ad5d4b4c12ccdb1"}],"ovn_octavia_provider/helper.py":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"6d0339c23bc4dd4ce3b6bc0b6bdd524651c1ed7e","unresolved":true,"context_lines":[{"line_number":882,"context_line":"                # if this situation arises."},{"line_number":883,"context_line":"                try:"},{"line_number":884,"context_line":"                    self._execute_commands(commands)"},{"line_number":885,"context_line":"                except Exception:"},{"line_number":886,"context_line":"                    LOG.warning(\"Topology has change, trying just \""},{"line_number":887,"context_line":"                                \"one time to find lr association\")"},{"line_number":888,"context_line":"                    commands \u003d self._update_lb_to_lr_association("}],"source_content_type":"text/x-python","patch_set":1,"id":"7d6d1121_b63d3cad","line":885,"range":{"start_line":885,"start_character":16,"end_line":885,"end_character":33},"updated":"2022-02-15 07:52:33.000000000","message":"perhaps wrap the specific exception that would appear in case of ls was deleted in the meantime","commit_id":"4552f4145ab63dd61dafd37265bd04f2abec97c1"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"4725f9d36fd0f3afc142534491d8c0867b7370b3","unresolved":false,"context_lines":[{"line_number":882,"context_line":"                # if this situation arises."},{"line_number":883,"context_line":"                try:"},{"line_number":884,"context_line":"                    self._execute_commands(commands)"},{"line_number":885,"context_line":"                except Exception:"},{"line_number":886,"context_line":"                    LOG.warning(\"Topology has change, trying just \""},{"line_number":887,"context_line":"                                \"one time to find lr association\")"},{"line_number":888,"context_line":"                    commands \u003d self._update_lb_to_lr_association("}],"source_content_type":"text/x-python","patch_set":1,"id":"ce7c5779_1aef22ac","line":885,"range":{"start_line":885,"start_character":16,"end_line":885,"end_character":33},"in_reply_to":"7d6d1121_b63d3cad","updated":"2022-02-15 11:45:10.000000000","message":"Done","commit_id":"4552f4145ab63dd61dafd37265bd04f2abec97c1"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"6d0339c23bc4dd4ce3b6bc0b6bdd524651c1ed7e","unresolved":true,"context_lines":[{"line_number":885,"context_line":"                except Exception:"},{"line_number":886,"context_line":"                    LOG.warning(\"Topology has change, trying just \""},{"line_number":887,"context_line":"                                \"one time to find lr association\")"},{"line_number":888,"context_line":"                    commands \u003d self._update_lb_to_lr_association("},{"line_number":889,"context_line":"                        ovn_lb, ovn_lr)"},{"line_number":890,"context_line":"                    self._execute_commands(commands)"},{"line_number":891,"context_line":""},{"line_number":892,"context_line":"            # NOTE(mjozefcz): In case of LS references where passed -"}],"source_content_type":"text/x-python","patch_set":1,"id":"eb354713_55cd149d","line":889,"range":{"start_line":888,"start_character":20,"end_line":889,"end_character":39},"updated":"2022-02-15 07:52:33.000000000","message":"perhaps better to check if there is any difference between the commands list get here and the one got at line 876. If no difference, then there is no differences between ls and the error is different and re-execution won\u0027t help.\n\nAnyway, perhaps we can try to have a retry option (decorator) instead just executing the same on the except block","commit_id":"4552f4145ab63dd61dafd37265bd04f2abec97c1"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"4725f9d36fd0f3afc142534491d8c0867b7370b3","unresolved":false,"context_lines":[{"line_number":885,"context_line":"                except Exception:"},{"line_number":886,"context_line":"                    LOG.warning(\"Topology has change, trying just \""},{"line_number":887,"context_line":"                                \"one time to find lr association\")"},{"line_number":888,"context_line":"                    commands \u003d self._update_lb_to_lr_association("},{"line_number":889,"context_line":"                        ovn_lb, ovn_lr)"},{"line_number":890,"context_line":"                    self._execute_commands(commands)"},{"line_number":891,"context_line":""},{"line_number":892,"context_line":"            # NOTE(mjozefcz): In case of LS references where passed -"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff7f99c2_ecc73953","line":889,"range":{"start_line":888,"start_character":20,"end_line":889,"end_character":39},"in_reply_to":"eb354713_55cd149d","updated":"2022-02-15 11:45:10.000000000","message":"Done","commit_id":"4552f4145ab63dd61dafd37265bd04f2abec97c1"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"1b7c4a225f0820a6ace6b9e1ac444494dfb6f1e1","unresolved":true,"context_lines":[{"line_number":348,"context_line":"    @tenacity.retry("},{"line_number":349,"context_line":"        retry\u003dtenacity.retry_if_exception_type(idlutils.RowNotFound),"},{"line_number":350,"context_line":"        wait\u003dtenacity.wait_exponential(),"},{"line_number":351,"context_line":"        stop\u003dtenacity.stop_after_attempt(3),"},{"line_number":352,"context_line":"        reraise\u003dTrue)"},{"line_number":353,"context_line":"    def _execute_lb_to_ls_lr_association(self, ovn_lb, ovn_lr):"},{"line_number":354,"context_line":"        # Note(froyo) Large topologies can change from the time we"}],"source_content_type":"text/x-python","patch_set":6,"id":"81e1b7f2_32433d8f","line":351,"range":{"start_line":351,"start_character":41,"end_line":351,"end_character":42},"updated":"2022-02-23 13:41:21.000000000","message":"perhaps use the same number as for find_ovn_lbs_with_retry --\u003e 10","commit_id":"2b3826db5a6b8b6e7a40bba02b6763f4cc6b523b"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"896217daf10e1b5f0e39bc6b752724ba0c113bfb","unresolved":true,"context_lines":[{"line_number":348,"context_line":"    @tenacity.retry("},{"line_number":349,"context_line":"        retry\u003dtenacity.retry_if_exception_type(idlutils.RowNotFound),"},{"line_number":350,"context_line":"        wait\u003dtenacity.wait_exponential(),"},{"line_number":351,"context_line":"        stop\u003dtenacity.stop_after_attempt(3),"},{"line_number":352,"context_line":"        reraise\u003dTrue)"},{"line_number":353,"context_line":"    def _execute_lb_to_ls_lr_association(self, ovn_lb, ovn_lr):"},{"line_number":354,"context_line":"        # Note(froyo) Large topologies can change from the time we"}],"source_content_type":"text/x-python","patch_set":6,"id":"950fa6fe_da7e3e63","line":351,"range":{"start_line":351,"start_character":41,"end_line":351,"end_character":42},"in_reply_to":"0c679abe_66aeb246","updated":"2022-02-23 17:18:01.000000000","message":"right! dismiss my comment!","commit_id":"2b3826db5a6b8b6e7a40bba02b6763f4cc6b523b"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"dadd21941fb977f2fe3ce8b9a1f2982637ea8466","unresolved":true,"context_lines":[{"line_number":348,"context_line":"    @tenacity.retry("},{"line_number":349,"context_line":"        retry\u003dtenacity.retry_if_exception_type(idlutils.RowNotFound),"},{"line_number":350,"context_line":"        wait\u003dtenacity.wait_exponential(),"},{"line_number":351,"context_line":"        stop\u003dtenacity.stop_after_attempt(3),"},{"line_number":352,"context_line":"        reraise\u003dTrue)"},{"line_number":353,"context_line":"    def _execute_lb_to_ls_lr_association(self, ovn_lb, ovn_lr):"},{"line_number":354,"context_line":"        # Note(froyo) Large topologies can change from the time we"}],"source_content_type":"text/x-python","patch_set":6,"id":"0c679abe_66aeb246","line":351,"range":{"start_line":351,"start_character":41,"end_line":351,"end_character":42},"in_reply_to":"81e1b7f2_32433d8f","updated":"2022-02-23 17:16:10.000000000","message":"find_ovn_lbs_with_retry use stop_after_delay(10) (time issue) we are proposing stop_after_attempt(3) (retry issue) IMO 3 is enough.","commit_id":"2b3826db5a6b8b6e7a40bba02b6763f4cc6b523b"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"01b0ba8c7463303fcf0e852e9fba09298eec5727","unresolved":false,"context_lines":[{"line_number":348,"context_line":"    @tenacity.retry("},{"line_number":349,"context_line":"        retry\u003dtenacity.retry_if_exception_type(idlutils.RowNotFound),"},{"line_number":350,"context_line":"        wait\u003dtenacity.wait_exponential(),"},{"line_number":351,"context_line":"        stop\u003dtenacity.stop_after_attempt(3),"},{"line_number":352,"context_line":"        reraise\u003dTrue)"},{"line_number":353,"context_line":"    def _execute_lb_to_ls_lr_association(self, ovn_lb, ovn_lr):"},{"line_number":354,"context_line":"        # Note(froyo) Large topologies can change from the time we"}],"source_content_type":"text/x-python","patch_set":6,"id":"62dc20fe_8d4d886b","line":351,"range":{"start_line":351,"start_character":41,"end_line":351,"end_character":42},"in_reply_to":"950fa6fe_da7e3e63","updated":"2022-03-02 14:19:57.000000000","message":"Done","commit_id":"2b3826db5a6b8b6e7a40bba02b6763f4cc6b523b"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"01b0ba8c7463303fcf0e852e9fba09298eec5727","unresolved":true,"context_lines":[{"line_number":213,"context_line":"        # Delete all LB on N/W from Router"},{"line_number":214,"context_line":"        for nlb in nw_lb:"},{"line_number":215,"context_line":"            try:"},{"line_number":216,"context_line":"                self._update_lb_to_lr_association("},{"line_number":217,"context_line":"                    nlb, router, delete\u003dTrue)"},{"line_number":218,"context_line":"            except idlutils.RowNotFound:"},{"line_number":219,"context_line":"                LOG.warning(\"association still falling, go step by step\")"},{"line_number":220,"context_line":"                self._update_lb_to_lr_association_by_step("}],"source_content_type":"text/x-python","patch_set":9,"id":"e2aeeb18_7ac85e4b","line":217,"range":{"start_line":216,"start_character":0,"end_line":217,"end_character":45},"updated":"2022-03-02 14:19:57.000000000","message":"super nit: probably this fits in one line","commit_id":"3cbf6ac6bf85fd83c0fd52aca1a110addc5ab806"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"18fce05bf5efd9ebd52527586f0c99193ab355c1","unresolved":false,"context_lines":[{"line_number":213,"context_line":"        # Delete all LB on N/W from Router"},{"line_number":214,"context_line":"        for nlb in nw_lb:"},{"line_number":215,"context_line":"            try:"},{"line_number":216,"context_line":"                self._update_lb_to_lr_association("},{"line_number":217,"context_line":"                    nlb, router, delete\u003dTrue)"},{"line_number":218,"context_line":"            except idlutils.RowNotFound:"},{"line_number":219,"context_line":"                LOG.warning(\"association still falling, go step by step\")"},{"line_number":220,"context_line":"                self._update_lb_to_lr_association_by_step("}],"source_content_type":"text/x-python","patch_set":9,"id":"39a60ab2_43437f88","line":217,"range":{"start_line":216,"start_character":0,"end_line":217,"end_character":45},"in_reply_to":"e2aeeb18_7ac85e4b","updated":"2022-03-07 10:50:38.000000000","message":"Done","commit_id":"3cbf6ac6bf85fd83c0fd52aca1a110addc5ab806"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"01b0ba8c7463303fcf0e852e9fba09298eec5727","unresolved":true,"context_lines":[{"line_number":216,"context_line":"                self._update_lb_to_lr_association("},{"line_number":217,"context_line":"                    nlb, router, delete\u003dTrue)"},{"line_number":218,"context_line":"            except idlutils.RowNotFound:"},{"line_number":219,"context_line":"                LOG.warning(\"association still falling, go step by step\")"},{"line_number":220,"context_line":"                self._update_lb_to_lr_association_by_step("},{"line_number":221,"context_line":"                    nlb, router, delete\u003dTrue)"},{"line_number":222,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"d050a8e9_32e04908","line":219,"range":{"start_line":219,"start_character":0,"end_line":219,"end_character":73},"updated":"2022-03-02 14:19:57.000000000","message":"perhaps better something like:\n\"The association of loadbalancer XXX to the logical router YYY failed, trying step by step\"","commit_id":"3cbf6ac6bf85fd83c0fd52aca1a110addc5ab806"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"18fce05bf5efd9ebd52527586f0c99193ab355c1","unresolved":false,"context_lines":[{"line_number":216,"context_line":"                self._update_lb_to_lr_association("},{"line_number":217,"context_line":"                    nlb, router, delete\u003dTrue)"},{"line_number":218,"context_line":"            except idlutils.RowNotFound:"},{"line_number":219,"context_line":"                LOG.warning(\"association still falling, go step by step\")"},{"line_number":220,"context_line":"                self._update_lb_to_lr_association_by_step("},{"line_number":221,"context_line":"                    nlb, router, delete\u003dTrue)"},{"line_number":222,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"8473959d_f290889c","line":219,"range":{"start_line":219,"start_character":0,"end_line":219,"end_character":73},"in_reply_to":"d050a8e9_32e04908","updated":"2022-03-07 10:50:38.000000000","message":"Done","commit_id":"3cbf6ac6bf85fd83c0fd52aca1a110addc5ab806"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"01b0ba8c7463303fcf0e852e9fba09298eec5727","unresolved":true,"context_lines":[{"line_number":248,"context_line":"            try:"},{"line_number":249,"context_line":"                self._update_lb_to_lr_association(lb, info[\u0027router\u0027])"},{"line_number":250,"context_line":"            except idlutils.RowNotFound:"},{"line_number":251,"context_line":"                LOG.warning(\"association still falling, go step by step\")"},{"line_number":252,"context_line":"                self._update_lb_to_lr_association_by_step(lb, info[\u0027router\u0027])"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"        # Add those lb to the network which are unique to the router"}],"source_content_type":"text/x-python","patch_set":9,"id":"93f9d952_069bf917","line":251,"range":{"start_line":251,"start_character":0,"end_line":251,"end_character":73},"updated":"2022-03-02 14:19:57.000000000","message":"ditto","commit_id":"3cbf6ac6bf85fd83c0fd52aca1a110addc5ab806"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"18fce05bf5efd9ebd52527586f0c99193ab355c1","unresolved":false,"context_lines":[{"line_number":248,"context_line":"            try:"},{"line_number":249,"context_line":"                self._update_lb_to_lr_association(lb, info[\u0027router\u0027])"},{"line_number":250,"context_line":"            except idlutils.RowNotFound:"},{"line_number":251,"context_line":"                LOG.warning(\"association still falling, go step by step\")"},{"line_number":252,"context_line":"                self._update_lb_to_lr_association_by_step(lb, info[\u0027router\u0027])"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"        # Add those lb to the network which are unique to the router"}],"source_content_type":"text/x-python","patch_set":9,"id":"99cadb10_760ab7e6","line":251,"range":{"start_line":251,"start_character":0,"end_line":251,"end_character":73},"in_reply_to":"93f9d952_069bf917","updated":"2022-03-07 10:50:38.000000000","message":"Done","commit_id":"3cbf6ac6bf85fd83c0fd52aca1a110addc5ab806"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"01b0ba8c7463303fcf0e852e9fba09298eec5727","unresolved":true,"context_lines":[{"line_number":618,"context_line":"                                         (\u0027external_ids\u0027, lr_rf)))"},{"line_number":619,"context_line":"        return commands"},{"line_number":620,"context_line":""},{"line_number":621,"context_line":"    # Note(froyo) Large topologies can change from the time we"},{"line_number":622,"context_line":"    # list the ls associated to lr until we execute the"},{"line_number":623,"context_line":"    # association command, retry if this situation arises."},{"line_number":624,"context_line":"    # Another function if situation mantains just to execute"},{"line_number":625,"context_line":"    # commands step by step to be sure we can going on"},{"line_number":626,"context_line":""},{"line_number":627,"context_line":"    @tenacity.retry("},{"line_number":628,"context_line":"        retry\u003dtenacity.retry_if_exception_type(idlutils.RowNotFound),"},{"line_number":629,"context_line":"        wait\u003dtenacity.wait_exponential(),"}],"source_content_type":"text/x-python","patch_set":9,"id":"fd3ec6d5_bdbd078c","line":626,"range":{"start_line":621,"start_character":0,"end_line":626,"end_character":0},"updated":"2022-03-02 14:19:57.000000000","message":"better to move it inside the function, at line 633. The second part of the comment should go in the other function L639","commit_id":"3cbf6ac6bf85fd83c0fd52aca1a110addc5ab806"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"18fce05bf5efd9ebd52527586f0c99193ab355c1","unresolved":false,"context_lines":[{"line_number":618,"context_line":"                                         (\u0027external_ids\u0027, lr_rf)))"},{"line_number":619,"context_line":"        return commands"},{"line_number":620,"context_line":""},{"line_number":621,"context_line":"    # Note(froyo) Large topologies can change from the time we"},{"line_number":622,"context_line":"    # list the ls associated to lr until we execute the"},{"line_number":623,"context_line":"    # association command, retry if this situation arises."},{"line_number":624,"context_line":"    # Another function if situation mantains just to execute"},{"line_number":625,"context_line":"    # commands step by step to be sure we can going on"},{"line_number":626,"context_line":""},{"line_number":627,"context_line":"    @tenacity.retry("},{"line_number":628,"context_line":"        retry\u003dtenacity.retry_if_exception_type(idlutils.RowNotFound),"},{"line_number":629,"context_line":"        wait\u003dtenacity.wait_exponential(),"}],"source_content_type":"text/x-python","patch_set":9,"id":"88bd9ee6_b3c26e6a","line":626,"range":{"start_line":621,"start_character":0,"end_line":626,"end_character":0},"in_reply_to":"fd3ec6d5_bdbd078c","updated":"2022-03-07 10:50:38.000000000","message":"Done","commit_id":"3cbf6ac6bf85fd83c0fd52aca1a110addc5ab806"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"01b0ba8c7463303fcf0e852e9fba09298eec5727","unresolved":true,"context_lines":[{"line_number":649,"context_line":"                else:"},{"line_number":650,"context_line":"                    raise idlutils.RowNotFound from exc"},{"line_number":651,"context_line":""},{"line_number":652,"context_line":"    def _get_commands_update_lb_to_lr_association("},{"line_number":653,"context_line":"            self, ovn_lb, ovn_lr, delete\u003dFalse):"},{"line_number":654,"context_line":"        lr_ref \u003d ovn_lb.external_ids.get(ovn_const.LB_EXT_IDS_LR_REF_KEY)"},{"line_number":655,"context_line":"        commands \u003d []"}],"source_content_type":"text/x-python","patch_set":9,"id":"052dddfa_fa1c6dda","line":652,"range":{"start_line":652,"start_character":7,"end_line":652,"end_character":49},"updated":"2022-03-02 14:19:57.000000000","message":"nit: get_lb_to_lr_association_commands","commit_id":"3cbf6ac6bf85fd83c0fd52aca1a110addc5ab806"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"18fce05bf5efd9ebd52527586f0c99193ab355c1","unresolved":false,"context_lines":[{"line_number":649,"context_line":"                else:"},{"line_number":650,"context_line":"                    raise idlutils.RowNotFound from exc"},{"line_number":651,"context_line":""},{"line_number":652,"context_line":"    def _get_commands_update_lb_to_lr_association("},{"line_number":653,"context_line":"            self, ovn_lb, ovn_lr, delete\u003dFalse):"},{"line_number":654,"context_line":"        lr_ref \u003d ovn_lb.external_ids.get(ovn_const.LB_EXT_IDS_LR_REF_KEY)"},{"line_number":655,"context_line":"        commands \u003d []"}],"source_content_type":"text/x-python","patch_set":9,"id":"8efbf448_2b9fb037","line":652,"range":{"start_line":652,"start_character":7,"end_line":652,"end_character":49},"in_reply_to":"052dddfa_fa1c6dda","updated":"2022-03-07 10:50:38.000000000","message":"done","commit_id":"3cbf6ac6bf85fd83c0fd52aca1a110addc5ab806"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"01b0ba8c7463303fcf0e852e9fba09298eec5727","unresolved":true,"context_lines":[{"line_number":652,"context_line":"    def _get_commands_update_lb_to_lr_association("},{"line_number":653,"context_line":"            self, ovn_lb, ovn_lr, delete\u003dFalse):"},{"line_number":654,"context_line":"        lr_ref \u003d ovn_lb.external_ids.get(ovn_const.LB_EXT_IDS_LR_REF_KEY)"},{"line_number":655,"context_line":"        commands \u003d []"},{"line_number":656,"context_line":"        if delete:"},{"line_number":657,"context_line":"            commands \u003d self._del_lb_to_lr_association(ovn_lb, ovn_lr, lr_ref)"},{"line_number":658,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":9,"id":"993cf702_8894b756","line":655,"range":{"start_line":655,"start_character":8,"end_line":655,"end_character":21},"updated":"2022-03-02 14:19:57.000000000","message":"no need for this, as it will be defined at the if or else. It does not hurt either","commit_id":"3cbf6ac6bf85fd83c0fd52aca1a110addc5ab806"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"18fce05bf5efd9ebd52527586f0c99193ab355c1","unresolved":false,"context_lines":[{"line_number":652,"context_line":"    def _get_commands_update_lb_to_lr_association("},{"line_number":653,"context_line":"            self, ovn_lb, ovn_lr, delete\u003dFalse):"},{"line_number":654,"context_line":"        lr_ref \u003d ovn_lb.external_ids.get(ovn_const.LB_EXT_IDS_LR_REF_KEY)"},{"line_number":655,"context_line":"        commands \u003d []"},{"line_number":656,"context_line":"        if delete:"},{"line_number":657,"context_line":"            commands \u003d self._del_lb_to_lr_association(ovn_lb, ovn_lr, lr_ref)"},{"line_number":658,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":9,"id":"e0cf569d_2bde5684","line":655,"range":{"start_line":655,"start_character":8,"end_line":655,"end_character":21},"in_reply_to":"993cf702_8894b756","updated":"2022-03-07 10:50:38.000000000","message":"Done","commit_id":"3cbf6ac6bf85fd83c0fd52aca1a110addc5ab806"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"01b0ba8c7463303fcf0e852e9fba09298eec5727","unresolved":true,"context_lines":[{"line_number":916,"context_line":"            commands \u003d self._update_lb_to_ls_association("},{"line_number":917,"context_line":"                ovn_lb, network_id\u003dport[\u0027network_id\u0027],"},{"line_number":918,"context_line":"                associate\u003dTrue)"},{"line_number":919,"context_line":"            self._execute_commands(commands)"},{"line_number":920,"context_line":"            ls_name \u003d utils.ovn_name(port[\u0027network_id\u0027])"},{"line_number":921,"context_line":"            ovn_ls \u003d self.ovn_nbdb_api.ls_get(ls_name).execute("},{"line_number":922,"context_line":"                check_error\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":9,"id":"0542c0a0_34665aaa","line":919,"range":{"start_line":919,"start_character":12,"end_line":919,"end_character":44},"updated":"2022-03-02 14:19:57.000000000","message":"add a comment here, stating why the commands are executed here","commit_id":"3cbf6ac6bf85fd83c0fd52aca1a110addc5ab806"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"18fce05bf5efd9ebd52527586f0c99193ab355c1","unresolved":false,"context_lines":[{"line_number":916,"context_line":"            commands \u003d self._update_lb_to_ls_association("},{"line_number":917,"context_line":"                ovn_lb, network_id\u003dport[\u0027network_id\u0027],"},{"line_number":918,"context_line":"                associate\u003dTrue)"},{"line_number":919,"context_line":"            self._execute_commands(commands)"},{"line_number":920,"context_line":"            ls_name \u003d utils.ovn_name(port[\u0027network_id\u0027])"},{"line_number":921,"context_line":"            ovn_ls \u003d self.ovn_nbdb_api.ls_get(ls_name).execute("},{"line_number":922,"context_line":"                check_error\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":9,"id":"01af52cf_cb925a5c","line":919,"range":{"start_line":919,"start_character":12,"end_line":919,"end_character":44},"in_reply_to":"0542c0a0_34665aaa","updated":"2022-03-07 10:50:38.000000000","message":"Done","commit_id":"3cbf6ac6bf85fd83c0fd52aca1a110addc5ab806"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"01b0ba8c7463303fcf0e852e9fba09298eec5727","unresolved":true,"context_lines":[{"line_number":925,"context_line":"                try:"},{"line_number":926,"context_line":"                    self._update_lb_to_lr_association(ovn_lb, ovn_lr)"},{"line_number":927,"context_line":"                except idlutils.RowNotFound:"},{"line_number":928,"context_line":"                    LOG.warning(\"association still falling, go step by step\")"},{"line_number":929,"context_line":"                    self._update_lb_to_lr_association_by_step(ovn_lb, ovn_lr)"},{"line_number":930,"context_line":""},{"line_number":931,"context_line":"            # NOTE(mjozefcz): In case of LS references where passed -"}],"source_content_type":"text/x-python","patch_set":9,"id":"0c8dfcf8_c04b97c6","line":928,"range":{"start_line":928,"start_character":20,"end_line":928,"end_character":77},"updated":"2022-03-02 14:19:57.000000000","message":"same comment about the information at the log message","commit_id":"3cbf6ac6bf85fd83c0fd52aca1a110addc5ab806"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"18fce05bf5efd9ebd52527586f0c99193ab355c1","unresolved":false,"context_lines":[{"line_number":925,"context_line":"                try:"},{"line_number":926,"context_line":"                    self._update_lb_to_lr_association(ovn_lb, ovn_lr)"},{"line_number":927,"context_line":"                except idlutils.RowNotFound:"},{"line_number":928,"context_line":"                    LOG.warning(\"association still falling, go step by step\")"},{"line_number":929,"context_line":"                    self._update_lb_to_lr_association_by_step(ovn_lb, ovn_lr)"},{"line_number":930,"context_line":""},{"line_number":931,"context_line":"            # NOTE(mjozefcz): In case of LS references where passed -"}],"source_content_type":"text/x-python","patch_set":9,"id":"907ca761_dab7804a","line":928,"range":{"start_line":928,"start_character":20,"end_line":928,"end_character":77},"in_reply_to":"0c8dfcf8_c04b97c6","updated":"2022-03-07 10:50:38.000000000","message":"Done","commit_id":"3cbf6ac6bf85fd83c0fd52aca1a110addc5ab806"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"01b0ba8c7463303fcf0e852e9fba09298eec5727","unresolved":true,"context_lines":[{"line_number":1572,"context_line":"        commands.extend("},{"line_number":1573,"context_line":"            self._update_lb_to_ls_association("},{"line_number":1574,"context_line":"                ovn_lb, subnet_id\u003dsubnet_id, associate\u003dTrue))"},{"line_number":1575,"context_line":"        self._execute_commands(commands)"},{"line_number":1576,"context_line":""},{"line_number":1577,"context_line":"        # Make sure that all logical switches related to logical router"},{"line_number":1578,"context_line":"        # are associated with the load balancer. This is needed to handle"}],"source_content_type":"text/x-python","patch_set":9,"id":"8761e162_3e35121d","line":1575,"range":{"start_line":1575,"start_character":8,"end_line":1575,"end_character":40},"updated":"2022-03-02 14:19:57.000000000","message":"same as before, add a comment here","commit_id":"3cbf6ac6bf85fd83c0fd52aca1a110addc5ab806"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"18fce05bf5efd9ebd52527586f0c99193ab355c1","unresolved":false,"context_lines":[{"line_number":1572,"context_line":"        commands.extend("},{"line_number":1573,"context_line":"            self._update_lb_to_ls_association("},{"line_number":1574,"context_line":"                ovn_lb, subnet_id\u003dsubnet_id, associate\u003dTrue))"},{"line_number":1575,"context_line":"        self._execute_commands(commands)"},{"line_number":1576,"context_line":""},{"line_number":1577,"context_line":"        # Make sure that all logical switches related to logical router"},{"line_number":1578,"context_line":"        # are associated with the load balancer. This is needed to handle"}],"source_content_type":"text/x-python","patch_set":9,"id":"686a199d_38616c43","line":1575,"range":{"start_line":1575,"start_character":8,"end_line":1575,"end_character":40},"in_reply_to":"8761e162_3e35121d","updated":"2022-03-07 10:50:38.000000000","message":"Done","commit_id":"3cbf6ac6bf85fd83c0fd52aca1a110addc5ab806"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"01b0ba8c7463303fcf0e852e9fba09298eec5727","unresolved":true,"context_lines":[{"line_number":1587,"context_line":"            ovn_lr \u003d self._find_lr_of_ls("},{"line_number":1588,"context_line":"                ovn_ls, subnet[\u0027subnet\u0027].get(\u0027gateway_ip\u0027))"},{"line_number":1589,"context_line":"            if ovn_lr:"},{"line_number":1590,"context_line":"                try:"},{"line_number":1591,"context_line":"                    self._update_lb_to_lr_association(ovn_lb, ovn_lr)"},{"line_number":1592,"context_line":"                except idlutils.RowNotFound:"},{"line_number":1593,"context_line":"                    LOG.warning(\"association still falling, go step by step\")"},{"line_number":1594,"context_line":"                    self._update_lb_to_lr_association_by_step(ovn_lb, ovn_lr)"},{"line_number":1595,"context_line":"        except n_exc.NotFound:"},{"line_number":1596,"context_line":"            pass"},{"line_number":1597,"context_line":"        except idlutils.RowNotFound:"}],"source_content_type":"text/x-python","patch_set":9,"id":"f4515c56_6b193b89","line":1594,"range":{"start_line":1590,"start_character":0,"end_line":1594,"end_character":77},"updated":"2022-03-02 14:19:57.000000000","message":"probably this can be moved out of the try/except now, as the execute_command here was before outside the try/except of line 1582","commit_id":"3cbf6ac6bf85fd83c0fd52aca1a110addc5ab806"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"18fce05bf5efd9ebd52527586f0c99193ab355c1","unresolved":false,"context_lines":[{"line_number":1587,"context_line":"            ovn_lr \u003d self._find_lr_of_ls("},{"line_number":1588,"context_line":"                ovn_ls, subnet[\u0027subnet\u0027].get(\u0027gateway_ip\u0027))"},{"line_number":1589,"context_line":"            if ovn_lr:"},{"line_number":1590,"context_line":"                try:"},{"line_number":1591,"context_line":"                    self._update_lb_to_lr_association(ovn_lb, ovn_lr)"},{"line_number":1592,"context_line":"                except idlutils.RowNotFound:"},{"line_number":1593,"context_line":"                    LOG.warning(\"association still falling, go step by step\")"},{"line_number":1594,"context_line":"                    self._update_lb_to_lr_association_by_step(ovn_lb, ovn_lr)"},{"line_number":1595,"context_line":"        except n_exc.NotFound:"},{"line_number":1596,"context_line":"            pass"},{"line_number":1597,"context_line":"        except idlutils.RowNotFound:"}],"source_content_type":"text/x-python","patch_set":9,"id":"6aa6dfee_086668c0","line":1594,"range":{"start_line":1590,"start_character":0,"end_line":1594,"end_character":77},"in_reply_to":"f4515c56_6b193b89","updated":"2022-03-07 10:50:38.000000000","message":"Done","commit_id":"3cbf6ac6bf85fd83c0fd52aca1a110addc5ab806"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"a4d3c85915af8c0eef0451227b042e36b84ea85a","unresolved":true,"context_lines":[{"line_number":512,"context_line":"    def _update_lb_to_ls_association(self, ovn_lb, network_id\u003dNone,"},{"line_number":513,"context_line":"                                     subnet_id\u003dNone, associate\u003dTrue,"},{"line_number":514,"context_line":"                                     update_ls_ref\u003dTrue):"},{"line_number":515,"context_line":"        # Note(froyo) Large topologies can change from the time we"},{"line_number":516,"context_line":"        # list the ls association commands and the execution, retry"},{"line_number":517,"context_line":"        # if this situation arises."},{"line_number":518,"context_line":"        commands \u003d self._get_lb_to_ls_association_commands("}],"source_content_type":"text/x-python","patch_set":11,"id":"27b2ed28_6037e6a9","line":515,"range":{"start_line":515,"start_character":10,"end_line":515,"end_character":21},"updated":"2022-03-07 11:37:07.000000000","message":"NOTE(froyo):","commit_id":"0137676c2cd87a91625e572d759a9866741a1406"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"81f3a9421ae5513d2d821bd1fba72666dd80f04d","unresolved":false,"context_lines":[{"line_number":512,"context_line":"    def _update_lb_to_ls_association(self, ovn_lb, network_id\u003dNone,"},{"line_number":513,"context_line":"                                     subnet_id\u003dNone, associate\u003dTrue,"},{"line_number":514,"context_line":"                                     update_ls_ref\u003dTrue):"},{"line_number":515,"context_line":"        # Note(froyo) Large topologies can change from the time we"},{"line_number":516,"context_line":"        # list the ls association commands and the execution, retry"},{"line_number":517,"context_line":"        # if this situation arises."},{"line_number":518,"context_line":"        commands \u003d self._get_lb_to_ls_association_commands("}],"source_content_type":"text/x-python","patch_set":11,"id":"0dad883b_818aa410","line":515,"range":{"start_line":515,"start_character":10,"end_line":515,"end_character":21},"in_reply_to":"27b2ed28_6037e6a9","updated":"2022-03-07 13:04:06.000000000","message":"Done","commit_id":"0137676c2cd87a91625e572d759a9866741a1406"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"a4d3c85915af8c0eef0451227b042e36b84ea85a","unresolved":true,"context_lines":[{"line_number":684,"context_line":"    def _get_lb_to_lr_association_commands("},{"line_number":685,"context_line":"            self, ovn_lb, ovn_lr, delete\u003dFalse):"},{"line_number":686,"context_line":"        lr_ref \u003d ovn_lb.external_ids.get(ovn_const.LB_EXT_IDS_LR_REF_KEY)"},{"line_number":687,"context_line":"        if delete:"},{"line_number":688,"context_line":"            commands \u003d self._del_lb_to_lr_association(ovn_lb, ovn_lr, lr_ref)"},{"line_number":689,"context_line":"        else:"},{"line_number":690,"context_line":"            commands \u003d self._add_lb_to_lr_association(ovn_lb, ovn_lr, lr_ref)"},{"line_number":691,"context_line":"        return commands"},{"line_number":692,"context_line":""},{"line_number":693,"context_line":"    def _find_ls_for_lr(self, router):"},{"line_number":694,"context_line":"        neutron_client \u003d clients.get_neutron_client()"}],"source_content_type":"text/x-python","patch_set":11,"id":"f56cf0ce_0828a143","line":691,"range":{"start_line":687,"start_character":0,"end_line":691,"end_character":23},"updated":"2022-03-07 11:37:07.000000000","message":"nit:\nif delete:\n  return self._del_lb_to....\nreturn self._add_lb_to_lr....","commit_id":"0137676c2cd87a91625e572d759a9866741a1406"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"81f3a9421ae5513d2d821bd1fba72666dd80f04d","unresolved":false,"context_lines":[{"line_number":684,"context_line":"    def _get_lb_to_lr_association_commands("},{"line_number":685,"context_line":"            self, ovn_lb, ovn_lr, delete\u003dFalse):"},{"line_number":686,"context_line":"        lr_ref \u003d ovn_lb.external_ids.get(ovn_const.LB_EXT_IDS_LR_REF_KEY)"},{"line_number":687,"context_line":"        if delete:"},{"line_number":688,"context_line":"            commands \u003d self._del_lb_to_lr_association(ovn_lb, ovn_lr, lr_ref)"},{"line_number":689,"context_line":"        else:"},{"line_number":690,"context_line":"            commands \u003d self._add_lb_to_lr_association(ovn_lb, ovn_lr, lr_ref)"},{"line_number":691,"context_line":"        return commands"},{"line_number":692,"context_line":""},{"line_number":693,"context_line":"    def _find_ls_for_lr(self, router):"},{"line_number":694,"context_line":"        neutron_client \u003d clients.get_neutron_client()"}],"source_content_type":"text/x-python","patch_set":11,"id":"37fd90d6_03594c11","line":691,"range":{"start_line":687,"start_character":0,"end_line":691,"end_character":23},"in_reply_to":"f56cf0ce_0828a143","updated":"2022-03-07 13:04:06.000000000","message":"Done","commit_id":"0137676c2cd87a91625e572d759a9866741a1406"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"a4d3c85915af8c0eef0451227b042e36b84ea85a","unresolved":true,"context_lines":[{"line_number":944,"context_line":"                loadbalancer[constants.ID],"},{"line_number":945,"context_line":"                protocol\u003dprotocol)"},{"line_number":946,"context_line":"            ovn_lb \u003d ovn_lb if protocol else ovn_lb[0]"},{"line_number":947,"context_line":"            self._update_lb_to_ls_association("},{"line_number":948,"context_line":"                ovn_lb, network_id\u003dport[\u0027network_id\u0027],"},{"line_number":949,"context_line":"                associate\u003dTrue, update_ls_ref\u003dTrue)"},{"line_number":950,"context_line":"            ls_name \u003d utils.ovn_name(port[\u0027network_id\u0027])"}],"source_content_type":"text/x-python","patch_set":11,"id":"03159b26_d19bc3bd","line":947,"range":{"start_line":947,"start_character":12,"end_line":947,"end_character":46},"updated":"2022-03-07 11:37:07.000000000","message":"add a note here saying that this is about the VIP ls to LB association and that is executed right away","commit_id":"0137676c2cd87a91625e572d759a9866741a1406"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"81f3a9421ae5513d2d821bd1fba72666dd80f04d","unresolved":false,"context_lines":[{"line_number":944,"context_line":"                loadbalancer[constants.ID],"},{"line_number":945,"context_line":"                protocol\u003dprotocol)"},{"line_number":946,"context_line":"            ovn_lb \u003d ovn_lb if protocol else ovn_lb[0]"},{"line_number":947,"context_line":"            self._update_lb_to_ls_association("},{"line_number":948,"context_line":"                ovn_lb, network_id\u003dport[\u0027network_id\u0027],"},{"line_number":949,"context_line":"                associate\u003dTrue, update_ls_ref\u003dTrue)"},{"line_number":950,"context_line":"            ls_name \u003d utils.ovn_name(port[\u0027network_id\u0027])"}],"source_content_type":"text/x-python","patch_set":11,"id":"8f6c874c_cf9adf1b","line":947,"range":{"start_line":947,"start_character":12,"end_line":947,"end_character":46},"in_reply_to":"03159b26_d19bc3bd","updated":"2022-03-07 13:04:06.000000000","message":"Done","commit_id":"0137676c2cd87a91625e572d759a9866741a1406"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"a4d3c85915af8c0eef0451227b042e36b84ea85a","unresolved":true,"context_lines":[{"line_number":952,"context_line":"                check_error\u003dTrue)"},{"line_number":953,"context_line":"            ovn_lr \u003d self._find_lr_of_ls(ovn_ls, subnet.get(\u0027gateway_ip\u0027))"},{"line_number":954,"context_line":"            if ovn_lr:"},{"line_number":955,"context_line":"                try:"},{"line_number":956,"context_line":"                    self._update_lb_to_lr_association(ovn_lb, ovn_lr)"},{"line_number":957,"context_line":"                except idlutils.RowNotFound:"},{"line_number":958,"context_line":"                    LOG.warning(\"The association of loadbalancer %s to the \""}],"source_content_type":"text/x-python","patch_set":11,"id":"b8f45779_ba9fd286","line":955,"range":{"start_line":955,"start_character":4,"end_line":955,"end_character":20},"updated":"2022-03-07 11:37:07.000000000","message":"add note here about this being about adding the lb to the router associated to the VIP ls, and all its connected LS","commit_id":"0137676c2cd87a91625e572d759a9866741a1406"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"81f3a9421ae5513d2d821bd1fba72666dd80f04d","unresolved":false,"context_lines":[{"line_number":952,"context_line":"                check_error\u003dTrue)"},{"line_number":953,"context_line":"            ovn_lr \u003d self._find_lr_of_ls(ovn_ls, subnet.get(\u0027gateway_ip\u0027))"},{"line_number":954,"context_line":"            if ovn_lr:"},{"line_number":955,"context_line":"                try:"},{"line_number":956,"context_line":"                    self._update_lb_to_lr_association(ovn_lb, ovn_lr)"},{"line_number":957,"context_line":"                except idlutils.RowNotFound:"},{"line_number":958,"context_line":"                    LOG.warning(\"The association of loadbalancer %s to the \""}],"source_content_type":"text/x-python","patch_set":11,"id":"31a1299b_5ee3e49d","line":955,"range":{"start_line":955,"start_character":4,"end_line":955,"end_character":20},"in_reply_to":"b8f45779_ba9fd286","updated":"2022-03-07 13:04:06.000000000","message":"Done","commit_id":"0137676c2cd87a91625e572d759a9866741a1406"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"a4d3c85915af8c0eef0451227b042e36b84ea85a","unresolved":true,"context_lines":[{"line_number":1047,"context_line":"        self.delete_vip_port(port_id)"},{"line_number":1048,"context_line":"        return status"},{"line_number":1049,"context_line":""},{"line_number":1050,"context_line":"    # TODO(froyo): atomic process to execute all commands in a transaction"},{"line_number":1051,"context_line":"    # if any of them fails the transaction is aborted"},{"line_number":1052,"context_line":"    def _lb_delete(self, loadbalancer, ovn_lb, status):"},{"line_number":1053,"context_line":"        commands \u003d []"},{"line_number":1054,"context_line":"        if loadbalancer[\u0027cascade\u0027]:"}],"source_content_type":"text/x-python","patch_set":11,"id":"b4ca0b4d_811b5d65","line":1051,"range":{"start_line":1050,"start_character":0,"end_line":1051,"end_character":53},"updated":"2022-03-07 11:37:07.000000000","message":"where this comment apply? move to the relevant line, or inside the def _lb_delete","commit_id":"0137676c2cd87a91625e572d759a9866741a1406"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"81f3a9421ae5513d2d821bd1fba72666dd80f04d","unresolved":false,"context_lines":[{"line_number":1047,"context_line":"        self.delete_vip_port(port_id)"},{"line_number":1048,"context_line":"        return status"},{"line_number":1049,"context_line":""},{"line_number":1050,"context_line":"    # TODO(froyo): atomic process to execute all commands in a transaction"},{"line_number":1051,"context_line":"    # if any of them fails the transaction is aborted"},{"line_number":1052,"context_line":"    def _lb_delete(self, loadbalancer, ovn_lb, status):"},{"line_number":1053,"context_line":"        commands \u003d []"},{"line_number":1054,"context_line":"        if loadbalancer[\u0027cascade\u0027]:"}],"source_content_type":"text/x-python","patch_set":11,"id":"b85e8a8d_6e76e485","line":1051,"range":{"start_line":1050,"start_character":0,"end_line":1051,"end_character":53},"in_reply_to":"b4ca0b4d_811b5d65","updated":"2022-03-07 13:04:06.000000000","message":"Done","commit_id":"0137676c2cd87a91625e572d759a9866741a1406"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"9de23569f844e57b9111b1678621c1677abd42a7","unresolved":true,"context_lines":[{"line_number":676,"context_line":"            except idlutils.RowNotFound as exc:"},{"line_number":677,"context_line":"                if isinstance(command, (cmd.LsLbAddCommand,"},{"line_number":678,"context_line":"                                        cmd.LsLbDelCommand)):"},{"line_number":679,"context_line":"                    LOG.warning(\u0027action lb to ls fail because ls \u0027"},{"line_number":680,"context_line":"                                \u0027is not found, keep going on...\u0027)"},{"line_number":681,"context_line":"                else:"},{"line_number":682,"context_line":"                    raise idlutils.RowNotFound from exc"},{"line_number":683,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"63f536ac_717e1e66","line":680,"range":{"start_line":679,"start_character":0,"end_line":680,"end_character":65},"updated":"2022-03-14 13:21:09.000000000","message":"Would be good to have an ID in the message if possible, otherwise it\u0027s almost impossible to know which LS we are talking about here.","commit_id":"420ba9c44af560586f3ecb7a067f280d07738911"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"4eef8acc714c50ba72739a7dd41fbc64f783864f","unresolved":false,"context_lines":[{"line_number":676,"context_line":"            except idlutils.RowNotFound as exc:"},{"line_number":677,"context_line":"                if isinstance(command, (cmd.LsLbAddCommand,"},{"line_number":678,"context_line":"                                        cmd.LsLbDelCommand)):"},{"line_number":679,"context_line":"                    LOG.warning(\u0027action lb to ls fail because ls \u0027"},{"line_number":680,"context_line":"                                \u0027is not found, keep going on...\u0027)"},{"line_number":681,"context_line":"                else:"},{"line_number":682,"context_line":"                    raise idlutils.RowNotFound from exc"},{"line_number":683,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"a40a6702_3a922659","line":680,"range":{"start_line":679,"start_character":0,"end_line":680,"end_character":65},"in_reply_to":"63f536ac_717e1e66","updated":"2022-03-14 16:16:40.000000000","message":"done, printing just the switch id if command includes it","commit_id":"420ba9c44af560586f3ecb7a067f280d07738911"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"9de23569f844e57b9111b1678621c1677abd42a7","unresolved":true,"context_lines":[{"line_number":679,"context_line":"                    LOG.warning(\u0027action lb to ls fail because ls \u0027"},{"line_number":680,"context_line":"                                \u0027is not found, keep going on...\u0027)"},{"line_number":681,"context_line":"                else:"},{"line_number":682,"context_line":"                    raise idlutils.RowNotFound from exc"},{"line_number":683,"context_line":""},{"line_number":684,"context_line":"    def _get_lb_to_lr_association_commands("},{"line_number":685,"context_line":"            self, ovn_lb, ovn_lr, delete\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":19,"id":"9063f68b_bc8d4ab9","line":682,"range":{"start_line":682,"start_character":20,"end_line":682,"end_character":55},"updated":"2022-03-14 13:21:09.000000000","message":"nit:\n\nraise","commit_id":"420ba9c44af560586f3ecb7a067f280d07738911"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"4eef8acc714c50ba72739a7dd41fbc64f783864f","unresolved":false,"context_lines":[{"line_number":679,"context_line":"                    LOG.warning(\u0027action lb to ls fail because ls \u0027"},{"line_number":680,"context_line":"                                \u0027is not found, keep going on...\u0027)"},{"line_number":681,"context_line":"                else:"},{"line_number":682,"context_line":"                    raise idlutils.RowNotFound from exc"},{"line_number":683,"context_line":""},{"line_number":684,"context_line":"    def _get_lb_to_lr_association_commands("},{"line_number":685,"context_line":"            self, ovn_lb, ovn_lr, delete\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":19,"id":"7b183d86_62b2b507","line":682,"range":{"start_line":682,"start_character":20,"end_line":682,"end_character":55},"in_reply_to":"9063f68b_bc8d4ab9","updated":"2022-03-14 16:16:40.000000000","message":"done","commit_id":"420ba9c44af560586f3ecb7a067f280d07738911"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"ed05535ec8817d43f5822319bdcb4f5e3b3c2dd2","unresolved":true,"context_lines":[{"line_number":680,"context_line":"                                \u0027%s is not found, keep going on...\u0027 %"},{"line_number":681,"context_line":"                                getattr(command, \u0027switch\u0027, \u0027\u0027))"},{"line_number":682,"context_line":"                else:"},{"line_number":683,"context_line":"                    raise e"},{"line_number":684,"context_line":""},{"line_number":685,"context_line":"    def _get_lb_to_lr_association_commands("},{"line_number":686,"context_line":"            self, ovn_lb, ovn_lr, delete\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":20,"id":"a8d5e2c6_94c2ba8b","line":683,"range":{"start_line":683,"start_character":25,"end_line":683,"end_character":27},"updated":"2022-03-14 16:19:24.000000000","message":"nit:\n\nDo not need to specify \"e\", just \"raise\" will reraise the exception here.","commit_id":"f07dca455150a6b0762838b6d7b5325e82d63fbb"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"acdf680b40472611b2d5a816b3bf786a481321e6","unresolved":false,"context_lines":[{"line_number":680,"context_line":"                                \u0027%s is not found, keep going on...\u0027 %"},{"line_number":681,"context_line":"                                getattr(command, \u0027switch\u0027, \u0027\u0027))"},{"line_number":682,"context_line":"                else:"},{"line_number":683,"context_line":"                    raise e"},{"line_number":684,"context_line":""},{"line_number":685,"context_line":"    def _get_lb_to_lr_association_commands("},{"line_number":686,"context_line":"            self, ovn_lb, ovn_lr, delete\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":20,"id":"76b4987f_2861d608","line":683,"range":{"start_line":683,"start_character":25,"end_line":683,"end_character":27},"in_reply_to":"a8d5e2c6_94c2ba8b","updated":"2022-03-14 16:23:21.000000000","message":"Ack","commit_id":"f07dca455150a6b0762838b6d7b5325e82d63fbb"}],"ovn_octavia_provider/tests/unit/test_helper.py":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"421b220864595ddc706df6baa47762fc980706e5","unresolved":true,"context_lines":[{"line_number":2298,"context_line":"        self.mock_add_request.assert_not_called()"},{"line_number":2299,"context_line":""},{"line_number":2300,"context_line":"    @mock.patch.object(ovn_helper.OvnProviderHelper, \u0027_execute_commands\u0027)"},{"line_number":2301,"context_line":"    def test_update_lb_to_ls_association_retry_failed(self, execute):"},{"line_number":2302,"context_line":"        execute.side_effect \u003d [idlutils.RowNotFound for _ in range(4)]"},{"line_number":2303,"context_line":"        self._update_lb_to_ls_association.stop()"},{"line_number":2304,"context_line":"        self.assertRaises("}],"source_content_type":"text/x-python","patch_set":14,"id":"9414370c_dd806536","line":2301,"range":{"start_line":2301,"start_character":8,"end_line":2301,"end_character":53},"updated":"2022-03-07 17:54:59.000000000","message":"test__update_... instead?\n\nAlso, move it after the other test__update_lb_to_ls... functions\n\nSame for the following functions","commit_id":"db9827b0cd5bffa41f2686d5bb9e142514469e57"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"496adffb327dd9fe93ff8cbd91829d0d1af3b423","unresolved":false,"context_lines":[{"line_number":2298,"context_line":"        self.mock_add_request.assert_not_called()"},{"line_number":2299,"context_line":""},{"line_number":2300,"context_line":"    @mock.patch.object(ovn_helper.OvnProviderHelper, \u0027_execute_commands\u0027)"},{"line_number":2301,"context_line":"    def test_update_lb_to_ls_association_retry_failed(self, execute):"},{"line_number":2302,"context_line":"        execute.side_effect \u003d [idlutils.RowNotFound for _ in range(4)]"},{"line_number":2303,"context_line":"        self._update_lb_to_ls_association.stop()"},{"line_number":2304,"context_line":"        self.assertRaises("}],"source_content_type":"text/x-python","patch_set":14,"id":"0a0f70a4_5f016bc9","line":2301,"range":{"start_line":2301,"start_character":8,"end_line":2301,"end_character":53},"in_reply_to":"9414370c_dd806536","updated":"2022-03-11 11:57:54.000000000","message":"done","commit_id":"db9827b0cd5bffa41f2686d5bb9e142514469e57"}]}