)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"eb64bce73653b210f19725bc36dd4bfdc7732489","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2c89a432_a771def5","updated":"2022-03-18 17:06:32.000000000","message":"missing lp bug","commit_id":"70c0314922af5094e8a60f77b2f97f217aa3b11d"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"d20daa42e842c1d9bb5ea0df7b3345e0ed294777","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3e9cce20_8c155430","updated":"2022-03-21 08:27:06.000000000","message":"LGTM","commit_id":"ccd272fd666f49c5d13baef5042c667c245aea90"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"477ec978bb2c3631d2cb4f82ef2d5f41375d1a03","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"25910ed7_f8b04f29","updated":"2022-03-21 14:52:46.000000000","message":"Need to ensure VIP leak is avoided","commit_id":"ccd272fd666f49c5d13baef5042c667c245aea90"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c17dbd61a523d9637bac828d26cd27e86d56da79","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3e5e8298_65a7838b","updated":"2022-03-21 12:18:28.000000000","message":"The VIP deletion exception is used, in \"lb_delete\", to set the \"lbalancer_status\".\n\nThe code is correct.","commit_id":"ccd272fd666f49c5d13baef5042c667c245aea90"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"1fba18b380f53f43a32db3e0a437281c6334ee35","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4369748d_4db0f3d0","updated":"2022-03-21 10:03:37.000000000","message":"recheck","commit_id":"ccd272fd666f49c5d13baef5042c667c245aea90"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"f1ebd0ef662e8fdc74822327fd08a27453df23c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a39171a8_c0cf4077","updated":"2022-03-21 11:41:19.000000000","message":"recheck","commit_id":"ccd272fd666f49c5d13baef5042c667c245aea90"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"5cfaf25eb6b2934f5591da3ca39ac55950e22aaa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b52b5992_8d58ee39","updated":"2022-03-21 15:18:48.000000000","message":"improved robustness, LGTM","commit_id":"5fcc71dbc39186cf2879888d73a54577e61e16f8"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"c3071b1c759cdad88ee5518f64de7124a8ca7a65","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"4096130e_3a203620","updated":"2022-03-23 10:09:27.000000000","message":"recheck","commit_id":"5fcc71dbc39186cf2879888d73a54577e61e16f8"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"caa7554d2fb370311a5e3430f90cb4dfdda3e851","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"e9e4e32e_bb160a76","updated":"2022-03-23 12:04:23.000000000","message":"recheck","commit_id":"5fcc71dbc39186cf2879888d73a54577e61e16f8"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"de8d896011a9d4ecfdfd9094e10746c5a2b2a3ac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"bc7180ea_2e6b8342","updated":"2022-03-24 07:38:36.000000000","message":"recheck","commit_id":"28c50d9147fed8e9757ba073929ce5a547e90f03"}],"ovn_octavia_provider/helper.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"48e3a2aebc386b1bdfb6089c5206faeefd4e4de1","unresolved":true,"context_lines":[{"line_number":1009,"context_line":"                    self.delete_vip_port(port.get(\u0027id\u0027))"},{"line_number":1010,"context_line":"                    LOG.warning(\"Deleting the VIP port %s since LB went into \""},{"line_number":1011,"context_line":"                                \"ERROR state\", str(port.get(\u0027id\u0027)))"},{"line_number":1012,"context_line":"                except Exception:"},{"line_number":1013,"context_line":"                    LOG.exception(\"Error deleting the VIP port %s upon \""},{"line_number":1014,"context_line":"                                  \"loadbalancer %s creation failure\","},{"line_number":1015,"context_line":"                                  str(port.get(\u0027id\u0027)),"}],"source_content_type":"text/x-python","patch_set":2,"id":"987a2dbb_12cf1b23","line":1012,"range":{"start_line":1012,"start_character":16,"end_line":1012,"end_character":33},"updated":"2022-03-21 10:28:11.000000000","message":"Instead of adding the exception catch in the method call, why don\u0027t you add this catch in \"delete_vip_port\"? Also you can add a specific message depending on the exception","commit_id":"ccd272fd666f49c5d13baef5042c667c245aea90"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"9503b305563020a363bbc9798a79af0250688600","unresolved":false,"context_lines":[{"line_number":1009,"context_line":"                    self.delete_vip_port(port.get(\u0027id\u0027))"},{"line_number":1010,"context_line":"                    LOG.warning(\"Deleting the VIP port %s since LB went into \""},{"line_number":1011,"context_line":"                                \"ERROR state\", str(port.get(\u0027id\u0027)))"},{"line_number":1012,"context_line":"                except Exception:"},{"line_number":1013,"context_line":"                    LOG.exception(\"Error deleting the VIP port %s upon \""},{"line_number":1014,"context_line":"                                  \"loadbalancer %s creation failure\","},{"line_number":1015,"context_line":"                                  str(port.get(\u0027id\u0027)),"}],"source_content_type":"text/x-python","patch_set":2,"id":"0bf78659_35e8013a","line":1012,"range":{"start_line":1012,"start_character":16,"end_line":1012,"end_character":33},"in_reply_to":"787be35e_3c33a8e6","updated":"2022-03-22 09:01:20.000000000","message":"Done","commit_id":"ccd272fd666f49c5d13baef5042c667c245aea90"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"76e17bb6c960422d2919841c778672f61b043ddc","unresolved":true,"context_lines":[{"line_number":1009,"context_line":"                    self.delete_vip_port(port.get(\u0027id\u0027))"},{"line_number":1010,"context_line":"                    LOG.warning(\"Deleting the VIP port %s since LB went into \""},{"line_number":1011,"context_line":"                                \"ERROR state\", str(port.get(\u0027id\u0027)))"},{"line_number":1012,"context_line":"                except Exception:"},{"line_number":1013,"context_line":"                    LOG.exception(\"Error deleting the VIP port %s upon \""},{"line_number":1014,"context_line":"                                  \"loadbalancer %s creation failure\","},{"line_number":1015,"context_line":"                                  str(port.get(\u0027id\u0027)),"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffc62c66_0a0ed816","line":1012,"range":{"start_line":1012,"start_character":16,"end_line":1012,"end_character":33},"in_reply_to":"987a2dbb_12cf1b23","updated":"2022-03-21 10:40:32.000000000","message":"mainly because for the other call to this method (L1056), if that fails I need to get the exception and set the proper loadbalancer status. Here there is no need to change the status as it is already on the failure/error part","commit_id":"ccd272fd666f49c5d13baef5042c667c245aea90"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"cc7e24fa18ad7b5e74657ee8c864ca0344d6fec5","unresolved":true,"context_lines":[{"line_number":1009,"context_line":"                    self.delete_vip_port(port.get(\u0027id\u0027))"},{"line_number":1010,"context_line":"                    LOG.warning(\"Deleting the VIP port %s since LB went into \""},{"line_number":1011,"context_line":"                                \"ERROR state\", str(port.get(\u0027id\u0027)))"},{"line_number":1012,"context_line":"                except Exception:"},{"line_number":1013,"context_line":"                    LOG.exception(\"Error deleting the VIP port %s upon \""},{"line_number":1014,"context_line":"                                  \"loadbalancer %s creation failure\","},{"line_number":1015,"context_line":"                                  str(port.get(\u0027id\u0027)),"}],"source_content_type":"text/x-python","patch_set":2,"id":"787be35e_3c33a8e6","line":1012,"range":{"start_line":1012,"start_character":16,"end_line":1012,"end_character":33},"in_reply_to":"ffc62c66_0a0ed816","updated":"2022-03-21 12:01:02.000000000","message":"This is what I\u0027m saying: you can catch always the exception but inside the \"delete_vip_port\".\n\nIn any case, I won\u0027t block this patch.","commit_id":"ccd272fd666f49c5d13baef5042c667c245aea90"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"fa26e1f70936edb50a1348182e1748764cfbe4f1","unresolved":true,"context_lines":[{"line_number":1012,"context_line":"                except Exception:"},{"line_number":1013,"context_line":"                    LOG.exception(\"Error deleting the VIP port %s upon \""},{"line_number":1014,"context_line":"                                  \"loadbalancer %s creation failure\","},{"line_number":1015,"context_line":"                                  str(port.get(\u0027id\u0027)),"},{"line_number":1016,"context_line":"                                  str(loadbalancer[constants.ID]))"},{"line_number":1017,"context_line":"            status \u003d {"},{"line_number":1018,"context_line":"                constants.LOADBALANCERS: ["}],"source_content_type":"text/x-python","patch_set":6,"id":"9b4cbe1b_e662976b","line":1015,"range":{"start_line":1015,"start_character":34,"end_line":1015,"end_character":38},"updated":"2022-03-25 13:23:23.000000000","message":"this cast to string shouldn\u0027t really be needed AFAIK","commit_id":"28c50d9147fed8e9757ba073929ce5a547e90f03"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"fa26e1f70936edb50a1348182e1748764cfbe4f1","unresolved":true,"context_lines":[{"line_number":1013,"context_line":"                    LOG.exception(\"Error deleting the VIP port %s upon \""},{"line_number":1014,"context_line":"                                  \"loadbalancer %s creation failure\","},{"line_number":1015,"context_line":"                                  str(port.get(\u0027id\u0027)),"},{"line_number":1016,"context_line":"                                  str(loadbalancer[constants.ID]))"},{"line_number":1017,"context_line":"            status \u003d {"},{"line_number":1018,"context_line":"                constants.LOADBALANCERS: ["},{"line_number":1019,"context_line":"                    {constants.ID: loadbalancer[constants.ID],"}],"source_content_type":"text/x-python","patch_set":6,"id":"28ef8cde_89c3d9ab","line":1016,"range":{"start_line":1016,"start_character":34,"end_line":1016,"end_character":37},"updated":"2022-03-25 13:23:23.000000000","message":"same here","commit_id":"28c50d9147fed8e9757ba073929ce5a547e90f03"}]}