)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"3b105ada8661e2edbef7f3674794babca4fefff1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"48f33f18_89d15e9f","updated":"2022-03-31 18:50:34.000000000","message":"You should add this to https://review.opendev.org/c/openstack/ovn-octavia-provider/+/800823","commit_id":"dee62cd6a96d5714c8a4084f9813cc610ec278c2"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"c0daef9b44d01a548dece190770a3ab7e38807e3","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d263c4da_9f0aa1b2","in_reply_to":"0ffe0ef6_28d9a7ec","updated":"2022-04-04 12:19:51.000000000","message":"If this patch has the same changes as https://review.opendev.org/c/openstack/ovn-octavia-provider/+/800823 and some more, maybe You can add Brian as co-author of this patch and we will move on with that one. It will be less work todo that way 😊\n@Brian - I hope it will be ok for You 😊","commit_id":"dee62cd6a96d5714c8a4084f9813cc610ec278c2"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"7d103a2ddd20aacfb0d67e733aaa3208dda6ee99","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0ffe0ef6_28d9a7ec","in_reply_to":"48f33f18_89d15e9f","updated":"2022-04-01 07:21:53.000000000","message":"I didn\u0027t remember that patch, and I saw it just before uploading this major one, as there was no movement in the code of that patch since July 2021 (last two patches are just commit msg updates), I thought it was abandoned. \n\nAnyway, I reviewed the code in it and it\u0027s already in this patch, so due to the size of the patch maybe it\u0027s better to abandon the other one and continue with this one, right, what do you think?","commit_id":"dee62cd6a96d5714c8a4084f9813cc610ec278c2"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"518ee9da0cfe7ccd38fed38d9d712a99af392786","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1c7476bd_bc72744f","in_reply_to":"d263c4da_9f0aa1b2","updated":"2022-04-04 12:22:16.000000000","message":"Done","commit_id":"dee62cd6a96d5714c8a4084f9813cc610ec278c2"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"bea699474c82884b6dbd3e1a654eec14cfac195c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a5e9ec3f_b57373d4","updated":"2022-04-05 02:15:10.000000000","message":"Duh, this line down in the check section of zuul.d/project.yaml is triggering the cover job:\n\n        - openstack-tox-cover:\n            required-projects:\n              - openstack/neutron\n\nI forgot it needs neutron to run so that was needed. But then even neutron adds openstack-cover-jobs to it\u0027s template section, I guess if it doesn\u0027t hurt you should do it here just to be safe.","commit_id":"7d96b7ae1b3374288b7d48f48d3552478525404a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"05a23f77b3760febf15e1e153d2df222ff0b2b90","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"28c819d5_59b83684","updated":"2022-04-04 14:22:24.000000000","message":"On question. In the other change I had added openstack-cover-jobs to project.yaml because I think it wasn\u0027t being run at all. I guess it is running now in the gate? I see neutron has it as well, so don\u0027t know if it\u0027s needed here to make sure it\u0027s always run?","commit_id":"7d96b7ae1b3374288b7d48f48d3552478525404a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"88028f96d61ba9821f2bec85baa00e49441367e9","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"45010d17_1b961502","in_reply_to":"0f9a268e_9724d56e","updated":"2022-04-04 15:48:17.000000000","message":"It was more of a question. When I did the other change I had to add the job template in order to get it run in the check queue. I don\u0027t know what changed that it\u0027s running now (maybe some other template changed to include it?), but was wondering why neutron includes the template, which I just use as a sanity check.","commit_id":"7d96b7ae1b3374288b7d48f48d3552478525404a"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"c16a1ed7e3ac52596ed94826ba243c5512f5c821","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"0f9a268e_9724d56e","in_reply_to":"28c819d5_59b83684","updated":"2022-04-04 15:11:03.000000000","message":"I just review last patch on neutron [1] and saw that \"openstack-tox-cover\" is ran on checks but not gates. So, what am I missing?\n\n[1] https://review.opendev.org/c/openstack/neutron/+/834855","commit_id":"7d96b7ae1b3374288b7d48f48d3552478525404a"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"c2f21f153314b33314ec0e91eafc36c464ecc35a","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c1abfa59_bb71e08a","in_reply_to":"45010d17_1b961502","updated":"2022-04-04 18:05:08.000000000","message":"Ok, but I reviewed patchset2 and patchset3 zuul\u0027s check on your patch and they looks exactly the same.","commit_id":"7d96b7ae1b3374288b7d48f48d3552478525404a"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"65182174ea34dd5ddee826d7861d173062351f08","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"60244188_19270a22","in_reply_to":"a5e9ec3f_b57373d4","updated":"2022-04-05 08:01:56.000000000","message":"Yes, of course.\n\nIn any case, feel free to add what you would have considered, you\u0027re co-author :D","commit_id":"7d96b7ae1b3374288b7d48f48d3552478525404a"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"674c03e8bd5accb891d5dfe02f7caf2c2ef041f6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7a74d975_0a29d624","updated":"2022-04-05 14:39:53.000000000","message":"Thanks Fernando!","commit_id":"7f00a1961d5fda9ba098c2dbcc39b978ee8b622e"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"a97e81fdbfccc0e61e86c2d16fcc8c00f90123dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"320ecc14_193a3665","updated":"2022-04-05 11:09:53.000000000","message":"recheck","commit_id":"7f00a1961d5fda9ba098c2dbcc39b978ee8b622e"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"96e6e66337edee136123041265b82ec37c748f3b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"8ae5c3e6_df7276ff","updated":"2022-04-05 09:45:58.000000000","message":"recheck","commit_id":"7f00a1961d5fda9ba098c2dbcc39b978ee8b622e"}]}