)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"519ee42cf7fdeba8ef000f28e9cd88ed12b58cf8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"05fd32e6_5478a865","updated":"2022-05-10 07:42:24.000000000","message":"Failing tempest tests unrelated to this patch. Those 2 tests are failing from this patch in octavia-tempest-plugin https://review.opendev.org/c/openstack/octavia-tempest-plugin/+/839502","commit_id":"eec6adc651f26758ccb32f4ece0ea25f690dcb54"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"b31dcceadc7e4cc8192779b1cb9da3e8d548086f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"fbf6a3b0_c803cf0c","updated":"2022-05-10 08:37:51.000000000","message":"Fix octavia-tempest-plugin proposed https://review.opendev.org/c/openstack/octavia-tempest-plugin/+/841225","commit_id":"eec6adc651f26758ccb32f4ece0ea25f690dcb54"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"9f6707f2bb691e0188eb64d485cdba5a7f9c98ac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"197d09e1_de1f9c37","updated":"2022-05-10 17:35:42.000000000","message":"recheck","commit_id":"eec6adc651f26758ccb32f4ece0ea25f690dcb54"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"0d291de71e888f56aa87ce269dbfcf3a3fea1fd0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"2370654c_e0e34c3a","updated":"2022-05-11 14:50:30.000000000","message":"recheck ovn-octavia-provider-tempest-release unrelated","commit_id":"201e8be0469be0e27d40e720c351cb2a2c095170"}],"ovn_octavia_provider/common/config.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"7a148721cd955297f8dfde48484d2db78b739357","unresolved":true,"context_lines":[{"line_number":105,"context_line":"        neutron_registered_opts \u003d [opt for opt in cfg.CONF.ovn]"},{"line_number":106,"context_line":"        missing_opts \u003d [opt for opt in ovn_opts"},{"line_number":107,"context_line":"                        if opt.name not in neutron_registered_opts]"},{"line_number":108,"context_line":"    except cfg.NoSuchOptError:"},{"line_number":109,"context_line":"        LOG.info(\u0027No found any opts under group ovn registered by Neutron\u0027)"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    cfg.CONF.register_opts(missing_opts, group\u003d\u0027ovn\u0027)"}],"source_content_type":"text/x-python","patch_set":14,"id":"013bff14_53ffa841","line":108,"range":{"start_line":108,"start_character":15,"end_line":108,"end_character":29},"updated":"2022-05-11 09:40:36.000000000","message":"When is this error happening?","commit_id":"eec6adc651f26758ccb32f4ece0ea25f690dcb54"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"ad3f15182f8bf4abd7d04624651c31fcdd8ab6d7","unresolved":true,"context_lines":[{"line_number":105,"context_line":"        neutron_registered_opts \u003d [opt for opt in cfg.CONF.ovn]"},{"line_number":106,"context_line":"        missing_opts \u003d [opt for opt in ovn_opts"},{"line_number":107,"context_line":"                        if opt.name not in neutron_registered_opts]"},{"line_number":108,"context_line":"    except cfg.NoSuchOptError:"},{"line_number":109,"context_line":"        LOG.info(\u0027No found any opts under group ovn registered by Neutron\u0027)"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    cfg.CONF.register_opts(missing_opts, group\u003d\u0027ovn\u0027)"}],"source_content_type":"text/x-python","patch_set":14,"id":"0d8a4f13_b23ab1c6","line":108,"range":{"start_line":108,"start_character":15,"end_line":108,"end_character":29},"in_reply_to":"013bff14_53ffa841","updated":"2022-05-11 10:02:36.000000000","message":"In line 105, it could happen if cfg.CONF doesn\u0027t include group \u0027ovn\u0027","commit_id":"eec6adc651f26758ccb32f4ece0ea25f690dcb54"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"62fd31b4ecac31f64e34ea13bc0242285b92308b","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        neutron_registered_opts \u003d [opt for opt in cfg.CONF.ovn]"},{"line_number":106,"context_line":"        missing_opts \u003d [opt for opt in ovn_opts"},{"line_number":107,"context_line":"                        if opt.name not in neutron_registered_opts]"},{"line_number":108,"context_line":"    except cfg.NoSuchOptError:"},{"line_number":109,"context_line":"        LOG.info(\u0027No found any opts under group ovn registered by Neutron\u0027)"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    cfg.CONF.register_opts(missing_opts, group\u003d\u0027ovn\u0027)"}],"source_content_type":"text/x-python","patch_set":14,"id":"29d7018f_b140d896","line":108,"range":{"start_line":108,"start_character":15,"end_line":108,"end_character":29},"in_reply_to":"0d8a4f13_b23ab1c6","updated":"2022-05-13 12:45:39.000000000","message":"But I though that was the OVN octavia provider plugin. In any case, the config is a user input and he/she can forget populating this section, this this is OK.","commit_id":"eec6adc651f26758ccb32f4ece0ea25f690dcb54"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"471e5202ba5b7d1eac3aaa0e2e66329c3f1a3a87","unresolved":true,"context_lines":[{"line_number":106,"context_line":"        missing_opts \u003d [opt for opt in ovn_opts"},{"line_number":107,"context_line":"                        if opt.name not in neutron_registered_opts]"},{"line_number":108,"context_line":"    except cfg.NoSuchOptError:"},{"line_number":109,"context_line":"        LOG.info(\u0027No found any opts under group ovn registered by Neutron\u0027)"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    cfg.CONF.register_opts(missing_opts, group\u003d\u0027ovn\u0027)"},{"line_number":112,"context_line":"    cfg.CONF.register_opts(neutron_opts, group\u003d\u0027neutron\u0027)"}],"source_content_type":"text/x-python","patch_set":14,"id":"7d3fc822_6eb3c056","line":109,"range":{"start_line":109,"start_character":18,"end_line":109,"end_character":20},"updated":"2022-05-11 12:38:38.000000000","message":"nit: Not...","commit_id":"eec6adc651f26758ccb32f4ece0ea25f690dcb54"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"f46bb92b4c04ac7d75a7ed410341b5d105b0b1c6","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        missing_opts \u003d [opt for opt in ovn_opts"},{"line_number":107,"context_line":"                        if opt.name not in neutron_registered_opts]"},{"line_number":108,"context_line":"    except cfg.NoSuchOptError:"},{"line_number":109,"context_line":"        LOG.info(\u0027No found any opts under group ovn registered by Neutron\u0027)"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    cfg.CONF.register_opts(missing_opts, group\u003d\u0027ovn\u0027)"},{"line_number":112,"context_line":"    cfg.CONF.register_opts(neutron_opts, group\u003d\u0027neutron\u0027)"}],"source_content_type":"text/x-python","patch_set":14,"id":"8b5d17fd_4e11cc63","line":109,"range":{"start_line":109,"start_character":18,"end_line":109,"end_character":20},"in_reply_to":"7d3fc822_6eb3c056","updated":"2022-05-11 13:25:16.000000000","message":"Done","commit_id":"eec6adc651f26758ccb32f4ece0ea25f690dcb54"}],"ovn_octavia_provider/ovsdb/impl_idl_ovn.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"471e5202ba5b7d1eac3aaa0e2e66329c3f1a3a87","unresolved":true,"context_lines":[{"line_number":199,"context_line":"            self.set_lock(self.event_lock_name)"},{"line_number":200,"context_line":"        atexit.register(self.stop)"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    @utils.retry()"},{"line_number":203,"context_line":"    def _get_ovsdb_helper(self, connection_string):"},{"line_number":204,"context_line":"        return idlutils.get_schema_helper(connection_string, self.SCHEMA)"},{"line_number":205,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"690e1789_2c5c3d28","line":202,"range":{"start_line":202,"start_character":0,"end_line":202,"end_character":18},"updated":"2022-05-11 12:38:38.000000000","message":"as I see you use always without max_ param, do you need a new decorator instead of tenacity.retry ?","commit_id":"eec6adc651f26758ccb32f4ece0ea25f690dcb54"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"937d46302aca787dbbb4b44a620b2a95e258340b","unresolved":true,"context_lines":[{"line_number":199,"context_line":"            self.set_lock(self.event_lock_name)"},{"line_number":200,"context_line":"        atexit.register(self.stop)"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    @utils.retry()"},{"line_number":203,"context_line":"    def _get_ovsdb_helper(self, connection_string):"},{"line_number":204,"context_line":"        return idlutils.get_schema_helper(connection_string, self.SCHEMA)"},{"line_number":205,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"cb2da4e2_e120efd6","line":202,"range":{"start_line":202,"start_character":0,"end_line":202,"end_character":18},"in_reply_to":"690e1789_2c5c3d28","updated":"2022-05-11 13:22:58.000000000","message":"yeah,basically the issue is that arguments passed to tenacity.retry are resolved as soon the module is imported, probably before the oslo_config options are registered by the main process, so the main purpose of the new decorator is to avoid that resolution of arguments before config options are loaded. It is the same approach solution used in [1].\n\n[1] https://review.opendev.org/c/openstack/neutron/+/839783","commit_id":"eec6adc651f26758ccb32f4ece0ea25f690dcb54"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"20c77e382041162acfb7af64bb671dae0a91797c","unresolved":true,"context_lines":[{"line_number":199,"context_line":"            self.set_lock(self.event_lock_name)"},{"line_number":200,"context_line":"        atexit.register(self.stop)"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    @utils.retry()"},{"line_number":203,"context_line":"    def _get_ovsdb_helper(self, connection_string):"},{"line_number":204,"context_line":"        return idlutils.get_schema_helper(connection_string, self.SCHEMA)"},{"line_number":205,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"153d8ab8_363be150","line":202,"range":{"start_line":202,"start_character":0,"end_line":202,"end_character":18},"in_reply_to":"cb2da4e2_e120efd6","updated":"2022-05-13 11:17:23.000000000","message":"thanks, that was my feeling, but it is written now","commit_id":"eec6adc651f26758ccb32f4ece0ea25f690dcb54"}]}