)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"2c6c7bb3a70d822566f0c7bf190e80e923d5918f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ef6475fa_ccfdf43c","updated":"2022-07-04 07:27:47.000000000","message":"Looks good, we need to make (in a follow up) all those calls to neutron (e.g. list_ports) a bit more safe by adding tenacity or the like and retry when needed","commit_id":"cd3264a07e047b589e4064855169c37f17343e60"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"6e4597b4fd4ed0d65b47d6da6eea6ce03de679fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"85bdb196_6d9fa15f","updated":"2022-05-17 14:41:09.000000000","message":"recheck ovn-octavia-provider-tempest-release unrelated","commit_id":"cd3264a07e047b589e4064855169c37f17343e60"}],"ovn_octavia_provider/helper.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"27b4aaf2d822ac185b53430c0c515f4d055178a1","unresolved":true,"context_lines":[{"line_number":1935,"context_line":"                LOG.debug(\u0027Leftover port %s has been found. Trying to \u0027"},{"line_number":1936,"context_line":"                          \u0027delete it\u0027, port[\u0027id\u0027])"},{"line_number":1937,"context_line":"                self.delete_vip_port(port[\u0027id\u0027])"},{"line_number":1938,"context_line":"            raise e"},{"line_number":1939,"context_line":""},{"line_number":1940,"context_line":"    @tenacity.retry("},{"line_number":1941,"context_line":"        retry\u003dtenacity.retry_if_exception_type("}],"source_content_type":"text/x-python","patch_set":1,"id":"053c9530_370ea57d","line":1938,"updated":"2022-05-27 08:57:56.000000000","message":"this may make problem to be less often but it\u0027s still race prone as You don\u0027t know if port will not really be created by neutron after You will do list_ports() already.","commit_id":"cd3264a07e047b589e4064855169c37f17343e60"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"c9aa79b4fcf0360028860f3b148d241bd36cc0a1","unresolved":true,"context_lines":[{"line_number":1935,"context_line":"                LOG.debug(\u0027Leftover port %s has been found. Trying to \u0027"},{"line_number":1936,"context_line":"                          \u0027delete it\u0027, port[\u0027id\u0027])"},{"line_number":1937,"context_line":"                self.delete_vip_port(port[\u0027id\u0027])"},{"line_number":1938,"context_line":"            raise e"},{"line_number":1939,"context_line":""},{"line_number":1940,"context_line":"    @tenacity.retry("},{"line_number":1941,"context_line":"        retry\u003dtenacity.retry_if_exception_type("}],"source_content_type":"text/x-python","patch_set":1,"id":"9eb5f416_f0d762d9","line":1938,"in_reply_to":"053c9530_370ea57d","updated":"2022-05-27 09:36:50.000000000","message":"I totally agree, it is already a situation that occurs under very high load levels, so reducing it as much as possible makes it less and less likely, but it is effectively not 0","commit_id":"cd3264a07e047b589e4064855169c37f17343e60"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"3e785a6f2544eca0f752b8f4fd61e2d01ddb86ee","unresolved":true,"context_lines":[{"line_number":1935,"context_line":"                LOG.debug(\u0027Leftover port %s has been found. Trying to \u0027"},{"line_number":1936,"context_line":"                          \u0027delete it\u0027, port[\u0027id\u0027])"},{"line_number":1937,"context_line":"                self.delete_vip_port(port[\u0027id\u0027])"},{"line_number":1938,"context_line":"            raise e"},{"line_number":1939,"context_line":""},{"line_number":1940,"context_line":"    @tenacity.retry("},{"line_number":1941,"context_line":"        retry\u003dtenacity.retry_if_exception_type("}],"source_content_type":"text/x-python","patch_set":1,"id":"a3907720_eabb756c","line":1938,"in_reply_to":"9eb5f416_f0d762d9","updated":"2022-05-27 14:34:13.000000000","message":"if the neutron server is \"misbehaving\" here due to heave load and returning exceptions... the \"list_ports\" can also et a NeutronClientException, right? perhaps worth to have a retry mechanism on that similar to the delete_vip_port one (with other time settings of course)","commit_id":"cd3264a07e047b589e4064855169c37f17343e60"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"930b0bcd0bfa71ca3a081bebf953914138145590","unresolved":true,"context_lines":[{"line_number":1935,"context_line":"                LOG.debug(\u0027Leftover port %s has been found. Trying to \u0027"},{"line_number":1936,"context_line":"                          \u0027delete it\u0027, port[\u0027id\u0027])"},{"line_number":1937,"context_line":"                self.delete_vip_port(port[\u0027id\u0027])"},{"line_number":1938,"context_line":"            raise e"},{"line_number":1939,"context_line":""},{"line_number":1940,"context_line":"    @tenacity.retry("},{"line_number":1941,"context_line":"        retry\u003dtenacity.retry_if_exception_type("}],"source_content_type":"text/x-python","patch_set":1,"id":"76d97be6_cd62f1ee","line":1938,"in_reply_to":"a3907720_eabb756c","updated":"2022-05-27 14:49:03.000000000","message":"NeutronClientException could be triggered by any neutron_client call that give us a Time-out. This retry over list_port will cover the situation where we are not getting the port list, and it could help to reduce a little more that probability that Slawek was talking, but if list_port return the list (regardless of whether it has cost it several retries) we still not be sure if \"our vip port\" to be delete is there.","commit_id":"cd3264a07e047b589e4064855169c37f17343e60"}]}