)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"5c605331702a7447a685a5d9877b68c1f28487e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"51c4bad9_896880d6","updated":"2022-10-11 08:47:21.000000000","message":"Thanks Luis!","commit_id":"07a41614c0b9bcd686885d227f225f4eb36a336b"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"8231d04d8d59a707be6ea5f9490056eb47e5496c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"54bafe69_ea08ff2b","updated":"2022-10-11 08:11:00.000000000","message":"Thanks Luis!","commit_id":"07a41614c0b9bcd686885d227f225f4eb36a336b"}],"ovn_octavia_provider/helper.py":[{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"8231d04d8d59a707be6ea5f9490056eb47e5496c","unresolved":true,"context_lines":[{"line_number":715,"context_line":"        for port in router.ports:"},{"line_number":716,"context_line":"            if port.gateway_chassis:"},{"line_number":717,"context_line":"                continue"},{"line_number":718,"context_line":"            port_network_name \u003d port.external_ids.get("},{"line_number":719,"context_line":"                ovn_const.OVN_NETWORK_NAME_EXT_ID_KEY)"},{"line_number":720,"context_line":"            if port_network_name:"},{"line_number":721,"context_line":"                ls.append(utils.ovn_name(port_network_name))"},{"line_number":722,"context_line":"        return ls"},{"line_number":723,"context_line":""},{"line_number":724,"context_line":"    def _find_lr_of_ls(self, ovn_ls, subnet_gateway_ip\u003dNone):"}],"source_content_type":"text/x-python","patch_set":2,"id":"6fc53fbb_56abe76c","line":721,"range":{"start_line":718,"start_character":0,"end_line":721,"end_character":60},"updated":"2022-10-11 08:11:00.000000000","message":"I guess that this is an optimization because it avoids querying neutron and iterating over the number of subnets that the port has an IP address in but it\u0027s also fixing a bug?\n\nThe original code iterated over all the subnets of a port and appended the associated network to a list. So if I\u0027m reading the original code correctly, the output list for a port that belongs to 2 subnets would look like:\n\nls \u003d [\u0027network1\u0027, \u0027network1\u0027]\n\nNow, the current code would just return\n\nls \u003d [\u0027network1\u0027]\n\nIs this correct? If so, I haven\u0027t checked the callers but is this taken into account there?","commit_id":"07a41614c0b9bcd686885d227f225f4eb36a336b"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"034f3fd4efb86997361c060806f3c2f42d3fa371","unresolved":true,"context_lines":[{"line_number":715,"context_line":"        for port in router.ports:"},{"line_number":716,"context_line":"            if port.gateway_chassis:"},{"line_number":717,"context_line":"                continue"},{"line_number":718,"context_line":"            port_network_name \u003d port.external_ids.get("},{"line_number":719,"context_line":"                ovn_const.OVN_NETWORK_NAME_EXT_ID_KEY)"},{"line_number":720,"context_line":"            if port_network_name:"},{"line_number":721,"context_line":"                ls.append(utils.ovn_name(port_network_name))"},{"line_number":722,"context_line":"        return ls"},{"line_number":723,"context_line":""},{"line_number":724,"context_line":"    def _find_lr_of_ls(self, ovn_ls, subnet_gateway_ip\u003dNone):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba3d0261_acf165f5","line":721,"range":{"start_line":718,"start_character":0,"end_line":721,"end_character":60},"in_reply_to":"6fc53fbb_56abe76c","updated":"2022-10-11 08:14:39.000000000","message":"yep, that is the case, both subnets will have different cidr (e.g., ipv4 and ipv6) but belong to the same network. We only need to as the LS once into the returned list. It was working fine-ish with 2 as the call to add the LB to the LS has the may_exists parameter enable","commit_id":"07a41614c0b9bcd686885d227f225f4eb36a336b"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"dfb239dc97b6950213232a744780bb79b9b74006","unresolved":true,"context_lines":[{"line_number":715,"context_line":"        for port in router.ports:"},{"line_number":716,"context_line":"            if port.gateway_chassis:"},{"line_number":717,"context_line":"                continue"},{"line_number":718,"context_line":"            port_network_name \u003d port.external_ids.get("},{"line_number":719,"context_line":"                ovn_const.OVN_NETWORK_NAME_EXT_ID_KEY)"},{"line_number":720,"context_line":"            if port_network_name:"},{"line_number":721,"context_line":"                ls.append(utils.ovn_name(port_network_name))"},{"line_number":722,"context_line":"        return ls"},{"line_number":723,"context_line":""},{"line_number":724,"context_line":"    def _find_lr_of_ls(self, ovn_ls, subnet_gateway_ip\u003dNone):"}],"source_content_type":"text/x-python","patch_set":2,"id":"d8f05dca_b57d3edb","line":721,"range":{"start_line":718,"start_character":0,"end_line":721,"end_character":60},"in_reply_to":"81eae5bf_a4bd0f14","updated":"2022-10-11 13:28:39.000000000","message":"Thanks for clarifying","commit_id":"07a41614c0b9bcd686885d227f225f4eb36a336b"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"5c605331702a7447a685a5d9877b68c1f28487e1","unresolved":true,"context_lines":[{"line_number":715,"context_line":"        for port in router.ports:"},{"line_number":716,"context_line":"            if port.gateway_chassis:"},{"line_number":717,"context_line":"                continue"},{"line_number":718,"context_line":"            port_network_name \u003d port.external_ids.get("},{"line_number":719,"context_line":"                ovn_const.OVN_NETWORK_NAME_EXT_ID_KEY)"},{"line_number":720,"context_line":"            if port_network_name:"},{"line_number":721,"context_line":"                ls.append(utils.ovn_name(port_network_name))"},{"line_number":722,"context_line":"        return ls"},{"line_number":723,"context_line":""},{"line_number":724,"context_line":"    def _find_lr_of_ls(self, ovn_ls, subnet_gateway_ip\u003dNone):"}],"source_content_type":"text/x-python","patch_set":2,"id":"81eae5bf_a4bd0f14","line":721,"range":{"start_line":718,"start_character":0,"end_line":721,"end_character":60},"in_reply_to":"ba3d0261_acf165f5","updated":"2022-10-11 08:47:21.000000000","message":"Thanks for clarifying. Since a port can only belong to one network I\u0027m fine with this change :)","commit_id":"07a41614c0b9bcd686885d227f225f4eb36a336b"}]}