)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"0bf932c72598d163bc168a45262d37ee14cb4493","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Luis Tomas Bolivar \u003cltomasbo@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-11-21 14:23:37 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make clear distintion between health check and health monitor"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There was quite a mix between (Octavia) Health Monitors and"},{"line_number":10,"context_line":"(OVN) Load Balancer Health Checks. This patch tries to make a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"c0a9d306_54f3a4ac","line":7,"range":{"start_line":7,"start_character":11,"end_line":7,"end_character":21},"updated":"2022-11-21 16:42:42.000000000","message":"nit: distintion -\u003e distinction","commit_id":"efbeefcda7ddf0bdffd49dc83c49c6a9bff91f70"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"73ab99a961cee7641384581e18c1b64c4fd42181","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Luis Tomas Bolivar \u003cltomasbo@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-11-21 14:23:37 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Make clear distintion between health check and health monitor"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There was quite a mix between (Octavia) Health Monitors and"},{"line_number":10,"context_line":"(OVN) Load Balancer Health Checks. This patch tries to make a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7c4896b8_28c13438","line":7,"range":{"start_line":7,"start_character":11,"end_line":7,"end_character":21},"in_reply_to":"c0a9d306_54f3a4ac","updated":"2022-11-22 07:11:22.000000000","message":"Done","commit_id":"efbeefcda7ddf0bdffd49dc83c49c6a9bff91f70"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"0bf932c72598d163bc168a45262d37ee14cb4493","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There was quite a mix between (Octavia) Health Monitors and"},{"line_number":10,"context_line":"(OVN) Load Balancer Health Checks. This patch tries to make a"},{"line_number":11,"context_line":"more clear distintion between Octavia HM and OVN LB HCs."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ib8499d7c4ea102e183ead31f063a3c0a70af6e23"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1dcbe882_950605dd","line":11,"range":{"start_line":11,"start_character":11,"end_line":11,"end_character":21},"updated":"2022-11-21 16:42:42.000000000","message":"same ^","commit_id":"efbeefcda7ddf0bdffd49dc83c49c6a9bff91f70"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"73ab99a961cee7641384581e18c1b64c4fd42181","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There was quite a mix between (Octavia) Health Monitors and"},{"line_number":10,"context_line":"(OVN) Load Balancer Health Checks. This patch tries to make a"},{"line_number":11,"context_line":"more clear distintion between Octavia HM and OVN LB HCs."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: Ib8499d7c4ea102e183ead31f063a3c0a70af6e23"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"50c151d5_f556b4bb","line":11,"range":{"start_line":11,"start_character":11,"end_line":11,"end_character":21},"in_reply_to":"1dcbe882_950605dd","updated":"2022-11-22 07:11:22.000000000","message":"Done","commit_id":"efbeefcda7ddf0bdffd49dc83c49c6a9bff91f70"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"0bf932c72598d163bc168a45262d37ee14cb4493","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f1bd8b49_f9fe8792","updated":"2022-11-21 16:42:42.000000000","message":"Good and necessary patch! just a few minor comments to finish clarifying hm vs lbhc","commit_id":"efbeefcda7ddf0bdffd49dc83c49c6a9bff91f70"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"9719d30cde53956283a961527fc25ffae5f65b63","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b6c0c446_5772321c","updated":"2022-11-22 09:00:12.000000000","message":"There is still some more mix up to fix with octavia health monitors and ovn health checks","commit_id":"43eedaf6e508d14387e3b7fbb6ae5dadd7d8eed8"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"d91607ba035f3367a3f5e91724a160d06ee23320","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9e69c221_b47539de","updated":"2022-11-23 10:21:18.000000000","message":"recheck ovn-octavia-provider-tempest-release unrelated","commit_id":"c2f152f8acbe2e1f67ee2e5de04f7e9098691b94"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"513e582c83ef42dca90a38ea295f624743dcbab2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"450def3d_938691e5","updated":"2022-11-24 06:54:07.000000000","message":"recheck ovn-octavia-provider-tempest-release unrelated\n","commit_id":"c2f152f8acbe2e1f67ee2e5de04f7e9098691b94"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"74f636d8d9a261dbcb2a2e9036101e63b1073a9c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"4ea8b9bd_80db4c3a","updated":"2022-11-25 11:06:56.000000000","message":"LGTM","commit_id":"9cb8cd5054e64ab7fd13b4b63259b639b4f26c50"}],"ovn_octavia_provider/helper.py":[{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"0bf932c72598d163bc168a45262d37ee14cb4493","unresolved":true,"context_lines":[{"line_number":2273,"context_line":"            LOG.exception(ovn_const.EXCEPTION_MSG, \"set of health check\")"},{"line_number":2274,"context_line":"        return status"},{"line_number":2275,"context_line":""},{"line_number":2276,"context_line":"    def _update_hm_vip(self, ovn_lb, vip_port):"},{"line_number":2277,"context_line":"        lbhc \u003d self._lookup_lbhc_by_id(ovn_lb.health_check)"},{"line_number":2278,"context_line":"        if not lbhc:"},{"line_number":2279,"context_line":"            LOG.error(\"Could not find HM with key: %s\", ovn_lb.health_check)"}],"source_content_type":"text/x-python","patch_set":1,"id":"06f1e981_5f2563c3","line":2276,"range":{"start_line":2276,"start_character":8,"end_line":2276,"end_character":22},"updated":"2022-11-21 16:42:42.000000000","message":"Following the same rule, this should be rename to _update_lbhc_vip, right?","commit_id":"efbeefcda7ddf0bdffd49dc83c49c6a9bff91f70"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"73ab99a961cee7641384581e18c1b64c4fd42181","unresolved":false,"context_lines":[{"line_number":2273,"context_line":"            LOG.exception(ovn_const.EXCEPTION_MSG, \"set of health check\")"},{"line_number":2274,"context_line":"        return status"},{"line_number":2275,"context_line":""},{"line_number":2276,"context_line":"    def _update_hm_vip(self, ovn_lb, vip_port):"},{"line_number":2277,"context_line":"        lbhc \u003d self._lookup_lbhc_by_id(ovn_lb.health_check)"},{"line_number":2278,"context_line":"        if not lbhc:"},{"line_number":2279,"context_line":"            LOG.error(\"Could not find HM with key: %s\", ovn_lb.health_check)"}],"source_content_type":"text/x-python","patch_set":1,"id":"99033fd3_f9c2d451","line":2276,"range":{"start_line":2276,"start_character":8,"end_line":2276,"end_character":22},"in_reply_to":"06f1e981_5f2563c3","updated":"2022-11-22 07:11:22.000000000","message":"Done","commit_id":"efbeefcda7ddf0bdffd49dc83c49c6a9bff91f70"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"0bf932c72598d163bc168a45262d37ee14cb4493","unresolved":true,"context_lines":[{"line_number":2359,"context_line":"        self._execute_commands(commands)"},{"line_number":2360,"context_line":"        return True"},{"line_number":2361,"context_line":""},{"line_number":2362,"context_line":"    def _lookup_lbhc_by_id(self, hm_id):"},{"line_number":2363,"context_line":"        lbhcs \u003d self.ovn_nbdb_api.db_list_rows("},{"line_number":2364,"context_line":"            \u0027Load_Balancer_Health_Check\u0027).execute(check_error\u003dTrue)"},{"line_number":2365,"context_line":"        for lbhc in lbhcs:"}],"source_content_type":"text/x-python","patch_set":1,"id":"fd6c593f_26c16487","line":2362,"range":{"start_line":2362,"start_character":8,"end_line":2362,"end_character":26},"updated":"2022-11-21 16:42:42.000000000","message":"should be _lookup_lbhc_by_hm_id, as we are looking in the whole list by the key LB_EXT_IDS_HM_KEY \u003d \u0027octavia:healthmonitor\u0027","commit_id":"efbeefcda7ddf0bdffd49dc83c49c6a9bff91f70"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"73ab99a961cee7641384581e18c1b64c4fd42181","unresolved":false,"context_lines":[{"line_number":2359,"context_line":"        self._execute_commands(commands)"},{"line_number":2360,"context_line":"        return True"},{"line_number":2361,"context_line":""},{"line_number":2362,"context_line":"    def _lookup_lbhc_by_id(self, hm_id):"},{"line_number":2363,"context_line":"        lbhcs \u003d self.ovn_nbdb_api.db_list_rows("},{"line_number":2364,"context_line":"            \u0027Load_Balancer_Health_Check\u0027).execute(check_error\u003dTrue)"},{"line_number":2365,"context_line":"        for lbhc in lbhcs:"}],"source_content_type":"text/x-python","patch_set":1,"id":"f08d6f0c_85726eb9","line":2362,"range":{"start_line":2362,"start_character":8,"end_line":2362,"end_character":26},"in_reply_to":"fd6c593f_26c16487","updated":"2022-11-22 07:11:22.000000000","message":"makes sense!","commit_id":"efbeefcda7ddf0bdffd49dc83c49c6a9bff91f70"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"6aa5b122299296626914a3b6c248a9d67b27359b","unresolved":true,"context_lines":[{"line_number":2270,"context_line":"                hms_key.append(hm_id)"},{"line_number":2271,"context_line":"                txn.add(self.ovn_nbdb_api.db_set("},{"line_number":2272,"context_line":"                    \u0027Load_Balancer\u0027, ovn_lb.uuid,"},{"line_number":2273,"context_line":"                    (\u0027external_ids\u0027, {ovn_const.LB_EXT_IDS_HMS_KEY: hms_key})))"},{"line_number":2274,"context_line":"            status \u003d {constants.ID: hm_id,"},{"line_number":2275,"context_line":"                      constants.PROVISIONING_STATUS: constants.ACTIVE,"},{"line_number":2276,"context_line":"                      constants.OPERATING_STATUS: operating_status}"}],"source_content_type":"text/x-python","patch_set":3,"id":"360d0d51_efbbf938","line":2273,"range":{"start_line":2273,"start_character":68,"end_line":2273,"end_character":75},"updated":"2022-11-24 17:15:07.000000000","message":"IIRC you would need to scape this one using jsonutils.dump (as done in L1723) because external_ids accepts only map of string-string pairs\n\nIn this case you should also need to use jsonutils.load (as done L1693) to use this key for search if it required","commit_id":"c2f152f8acbe2e1f67ee2e5de04f7e9098691b94"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"1e4646363b1a05ec89bf6841ba2f7ff78f4395c3","unresolved":false,"context_lines":[{"line_number":2270,"context_line":"                hms_key.append(hm_id)"},{"line_number":2271,"context_line":"                txn.add(self.ovn_nbdb_api.db_set("},{"line_number":2272,"context_line":"                    \u0027Load_Balancer\u0027, ovn_lb.uuid,"},{"line_number":2273,"context_line":"                    (\u0027external_ids\u0027, {ovn_const.LB_EXT_IDS_HMS_KEY: hms_key})))"},{"line_number":2274,"context_line":"            status \u003d {constants.ID: hm_id,"},{"line_number":2275,"context_line":"                      constants.PROVISIONING_STATUS: constants.ACTIVE,"},{"line_number":2276,"context_line":"                      constants.OPERATING_STATUS: operating_status}"}],"source_content_type":"text/x-python","patch_set":3,"id":"bbe141ea_b32aa2c8","line":2273,"range":{"start_line":2273,"start_character":68,"end_line":2273,"end_character":75},"in_reply_to":"360d0d51_efbbf938","updated":"2022-11-28 09:48:28.000000000","message":"Done","commit_id":"c2f152f8acbe2e1f67ee2e5de04f7e9098691b94"}]}