)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"01517b15687c9b01741f8a7ac284ff2bca1b1edb","unresolved":true,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch return the correct status to Octavia API for the"},{"line_number":13,"context_line":"listeners related to the pool, ensuring they could be modified and"},{"line_number":14,"context_line":"not considered as inmutable."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: #1999813"},{"line_number":17,"context_line":"Change-Id: I4f6e4a8acb7c7bb030aaadc6875894d6fc00d740"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"f6352c58_7afc9176","line":14,"range":{"start_line":14,"start_character":18,"end_line":14,"end_character":27},"updated":"2022-12-21 10:11:15.000000000","message":"nitty nit: immutable","commit_id":"421665e2d269c47dd9cf9c55183735e3ac110dfc"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"993d8177c5c7e2e418f921bc4758bbfff1ff08ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0a24d997_0bc915f7","updated":"2022-12-19 07:31:50.000000000","message":"Just some nit to make the code more uniform with previous assumptions","commit_id":"e38351f24b94ab719e2abf76dee9c14720b3919a"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"1e5c15099935b1465e4906efaacf4217d6c45bdd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b37a13e5_0598ffa8","updated":"2022-12-20 06:24:07.000000000","message":"other than the red CI (unrelated) looks good to me","commit_id":"4ffbc31fb43f073df73150a8e8fa23df7b6341d9"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"70a54a15f99178d4ad110cfa60ed9e90ca3a40cd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"72a0c3ff_36df0ee4","updated":"2022-12-21 16:34:03.000000000","message":"recheck ovn-octavia-provider-functional-master cursor commit/rollback reset","commit_id":"421665e2d269c47dd9cf9c55183735e3ac110dfc"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"85c3106646a15b802cd9e45f26f851e19f65b0c6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ca839759_82a66e2d","updated":"2022-12-21 13:39:16.000000000","message":"recheck ovn-octavia-provider-functional-master cursor commit/rollback reset\n","commit_id":"421665e2d269c47dd9cf9c55183735e3ac110dfc"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"020dddb6124c1e4b3f4e6c80e7af3111ea6225a5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b5bd2669_4a29342d","updated":"2022-12-21 10:38:06.000000000","message":"recheck ovn-octavia-provider-functional-release cursor commit/rollback ","commit_id":"421665e2d269c47dd9cf9c55183735e3ac110dfc"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"9ceecf2ab1490fc7fac684324be753f89105d4b8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c1fd22e1_8e0a9481","updated":"2022-12-22 08:01:12.000000000","message":"recheck ovn-octavia-provider-functional-release cursor commit/rollback reset\n","commit_id":"421665e2d269c47dd9cf9c55183735e3ac110dfc"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"695c7fe6d98353fdadba0b28d6f3012509cbebbe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e47b97b2_f7345c59","updated":"2022-12-22 09:44:04.000000000","message":"recheck ovn-octavia-provider-tempest-release timeout","commit_id":"421665e2d269c47dd9cf9c55183735e3ac110dfc"}],"ovn_octavia_provider/helper.py":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"993d8177c5c7e2e418f921bc4758bbfff1ff08ce","unresolved":true,"context_lines":[{"line_number":2428,"context_line":""},{"line_number":2429,"context_line":"        listener_id \u003d self._get_pool_listeners(ovn_lb, pool_key)"},{"line_number":2430,"context_line":""},{"line_number":2431,"context_line":"        if listener_id:"},{"line_number":2432,"context_line":"            status[constants.LISTENERS] \u003d ["},{"line_number":2433,"context_line":"                {constants.ID: listener_id[0],"},{"line_number":2434,"context_line":"                 constants.PROVISIONING_STATUS: constants.ACTIVE,"},{"line_number":2435,"context_line":"                 constants.OPERATING_STATUS: constants.ONLINE}]"},{"line_number":2436,"context_line":""},{"line_number":2437,"context_line":"        # Update status for all members in the pool"},{"line_number":2438,"context_line":"        member_status \u003d []"}],"source_content_type":"text/x-python","patch_set":2,"id":"5ad1f2b4_a323dca5","line":2435,"range":{"start_line":2431,"start_character":1,"end_line":2435,"end_character":63},"updated":"2022-12-19 07:31:50.000000000","message":"although in practice there can only be one listener per pool, in theory there may be many and that is the assumption in other places in the code, for instance line 1593.\n\nTo keep consistency I would name it pool_listeners instead of listener id, and do a loop (for) over it, as done in the pool_delete/pool_update functions","commit_id":"e38351f24b94ab719e2abf76dee9c14720b3919a"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"5be9e8518f3d65ab2c59b29160972bc9f2882b28","unresolved":false,"context_lines":[{"line_number":2428,"context_line":""},{"line_number":2429,"context_line":"        listener_id \u003d self._get_pool_listeners(ovn_lb, pool_key)"},{"line_number":2430,"context_line":""},{"line_number":2431,"context_line":"        if listener_id:"},{"line_number":2432,"context_line":"            status[constants.LISTENERS] \u003d ["},{"line_number":2433,"context_line":"                {constants.ID: listener_id[0],"},{"line_number":2434,"context_line":"                 constants.PROVISIONING_STATUS: constants.ACTIVE,"},{"line_number":2435,"context_line":"                 constants.OPERATING_STATUS: constants.ONLINE}]"},{"line_number":2436,"context_line":""},{"line_number":2437,"context_line":"        # Update status for all members in the pool"},{"line_number":2438,"context_line":"        member_status \u003d []"}],"source_content_type":"text/x-python","patch_set":2,"id":"b9c150bd_cb4ca6b5","line":2435,"range":{"start_line":2431,"start_character":1,"end_line":2435,"end_character":63},"in_reply_to":"5ad1f2b4_a323dca5","updated":"2022-12-19 15:40:07.000000000","message":"Done","commit_id":"e38351f24b94ab719e2abf76dee9c14720b3919a"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"993d8177c5c7e2e418f921bc4758bbfff1ff08ce","unresolved":true,"context_lines":[{"line_number":2583,"context_line":"            status[constants.POOLS] \u003d ["},{"line_number":2584,"context_line":"                {constants.ID: pool_id,"},{"line_number":2585,"context_line":"                 constants.PROVISIONING_STATUS: constants.ACTIVE}]"},{"line_number":2586,"context_line":"            if listener_id:"},{"line_number":2587,"context_line":"                status[constants.LISTENERS] \u003d ["},{"line_number":2588,"context_line":"                    {constants.ID: listener_id[0],"},{"line_number":2589,"context_line":"                     constants.PROVISIONING_STATUS: constants.ACTIVE}]"}],"source_content_type":"text/x-python","patch_set":2,"id":"a76910fe_8021f6ee","line":2586,"range":{"start_line":2586,"start_character":15,"end_line":2586,"end_character":26},"updated":"2022-12-19 07:31:50.000000000","message":"same here","commit_id":"e38351f24b94ab719e2abf76dee9c14720b3919a"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"5be9e8518f3d65ab2c59b29160972bc9f2882b28","unresolved":false,"context_lines":[{"line_number":2583,"context_line":"            status[constants.POOLS] \u003d ["},{"line_number":2584,"context_line":"                {constants.ID: pool_id,"},{"line_number":2585,"context_line":"                 constants.PROVISIONING_STATUS: constants.ACTIVE}]"},{"line_number":2586,"context_line":"            if listener_id:"},{"line_number":2587,"context_line":"                status[constants.LISTENERS] \u003d ["},{"line_number":2588,"context_line":"                    {constants.ID: listener_id[0],"},{"line_number":2589,"context_line":"                     constants.PROVISIONING_STATUS: constants.ACTIVE}]"}],"source_content_type":"text/x-python","patch_set":2,"id":"eab7c06f_43ade9d0","line":2586,"range":{"start_line":2586,"start_character":15,"end_line":2586,"end_character":26},"in_reply_to":"a76910fe_8021f6ee","updated":"2022-12-19 15:40:07.000000000","message":"Done","commit_id":"e38351f24b94ab719e2abf76dee9c14720b3919a"}]}
