)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"d84fc17fe74cd2ad2af18d83ec9092252a32ff80","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Fernando Royo \u003cfroyo@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-12-19 15:36:41 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Uncouple status of a new HM according to existing member statuses"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When a new HM is created, the provisioning status is conditioned"},{"line_number":10,"context_line":"by the status of the existing members on the pool. At this way when"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"26db043d_fabb8f69","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":65},"updated":"2022-12-20 06:29:53.000000000","message":"Uncouple HM status of member statuses","commit_id":"232f4af5a9a463b71f39fb4eeeb1937c21682d91"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"bf2d1da4fccd690ab1fdd4c2d405493daf0ca6af","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Fernando Royo \u003cfroyo@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-12-19 15:36:41 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Uncouple status of a new HM according to existing member statuses"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When a new HM is created, the provisioning status is conditioned"},{"line_number":10,"context_line":"by the status of the existing members on the pool. At this way when"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"742a9ac1_7bf0860b","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":65},"in_reply_to":"26db043d_fabb8f69","updated":"2022-12-20 08:40:35.000000000","message":"Done","commit_id":"232f4af5a9a463b71f39fb4eeeb1937c21682d91"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"d84fc17fe74cd2ad2af18d83ec9092252a32ff80","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Uncouple status of a new HM according to existing member statuses"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When a new HM is created, the provisioning status is conditioned"},{"line_number":10,"context_line":"by the status of the existing members on the pool. At this way when"},{"line_number":11,"context_line":"any of the member is in ERROR status (e.g. when a member is configure"},{"line_number":12,"context_line":"with non existing address) the HM created will be in ERROR status."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"aade834a_7d86be74","line":10,"range":{"start_line":10,"start_character":51,"end_line":10,"end_character":67},"updated":"2022-12-20 06:29:53.000000000","message":"When any of the members is...","commit_id":"232f4af5a9a463b71f39fb4eeeb1937c21682d91"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"bf2d1da4fccd690ab1fdd4c2d405493daf0ca6af","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Uncouple status of a new HM according to existing member statuses"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When a new HM is created, the provisioning status is conditioned"},{"line_number":10,"context_line":"by the status of the existing members on the pool. At this way when"},{"line_number":11,"context_line":"any of the member is in ERROR status (e.g. when a member is configure"},{"line_number":12,"context_line":"with non existing address) the HM created will be in ERROR status."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"a6085291_8c4861a2","line":10,"range":{"start_line":10,"start_character":51,"end_line":10,"end_character":67},"in_reply_to":"aade834a_7d86be74","updated":"2022-12-20 08:40:35.000000000","message":"Done","commit_id":"232f4af5a9a463b71f39fb4eeeb1937c21682d91"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"d84fc17fe74cd2ad2af18d83ec9092252a32ff80","unresolved":true,"context_lines":[{"line_number":9,"context_line":"When a new HM is created, the provisioning status is conditioned"},{"line_number":10,"context_line":"by the status of the existing members on the pool. At this way when"},{"line_number":11,"context_line":"any of the member is in ERROR status (e.g. when a member is configure"},{"line_number":12,"context_line":"with non existing address) the HM created will be in ERROR status."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"It looks make more sense to warn about the member problem but let the"},{"line_number":15,"context_line":"HM continue with its normal flow of operation over the possible"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"11fa26de_49a8a51c","line":12,"range":{"start_line":12,"start_character":34,"end_line":12,"end_character":65},"updated":"2022-12-20 06:29:53.000000000","message":"the created HM is in ERROR status","commit_id":"232f4af5a9a463b71f39fb4eeeb1937c21682d91"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"bf2d1da4fccd690ab1fdd4c2d405493daf0ca6af","unresolved":false,"context_lines":[{"line_number":9,"context_line":"When a new HM is created, the provisioning status is conditioned"},{"line_number":10,"context_line":"by the status of the existing members on the pool. At this way when"},{"line_number":11,"context_line":"any of the member is in ERROR status (e.g. when a member is configure"},{"line_number":12,"context_line":"with non existing address) the HM created will be in ERROR status."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"It looks make more sense to warn about the member problem but let the"},{"line_number":15,"context_line":"HM continue with its normal flow of operation over the possible"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"d04c63f3_9def886e","line":12,"range":{"start_line":12,"start_character":34,"end_line":12,"end_character":65},"in_reply_to":"11fa26de_49a8a51c","updated":"2022-12-20 08:40:35.000000000","message":"Done","commit_id":"232f4af5a9a463b71f39fb4eeeb1937c21682d91"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"d84fc17fe74cd2ad2af18d83ec9092252a32ff80","unresolved":true,"context_lines":[{"line_number":11,"context_line":"any of the member is in ERROR status (e.g. when a member is configure"},{"line_number":12,"context_line":"with non existing address) the HM created will be in ERROR status."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"It looks make more sense to warn about the member problem but let the"},{"line_number":15,"context_line":"HM continue with its normal flow of operation over the possible"},{"line_number":16,"context_line":"remaining members that exist for the pool on which it is created."},{"line_number":17,"context_line":"This patch remove the break after found an problematic member (port not"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9271ae0b_c355bea7","line":14,"range":{"start_line":14,"start_character":1,"end_line":14,"end_character":33},"updated":"2022-12-20 06:29:53.000000000","message":"It makes more sense to warn about...","commit_id":"232f4af5a9a463b71f39fb4eeeb1937c21682d91"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"bf2d1da4fccd690ab1fdd4c2d405493daf0ca6af","unresolved":false,"context_lines":[{"line_number":11,"context_line":"any of the member is in ERROR status (e.g. when a member is configure"},{"line_number":12,"context_line":"with non existing address) the HM created will be in ERROR status."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"It looks make more sense to warn about the member problem but let the"},{"line_number":15,"context_line":"HM continue with its normal flow of operation over the possible"},{"line_number":16,"context_line":"remaining members that exist for the pool on which it is created."},{"line_number":17,"context_line":"This patch remove the break after found an problematic member (port not"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"42e11e20_527f267f","line":14,"range":{"start_line":14,"start_character":1,"end_line":14,"end_character":33},"in_reply_to":"9271ae0b_c355bea7","updated":"2022-12-20 08:40:35.000000000","message":"Done","commit_id":"232f4af5a9a463b71f39fb4eeeb1937c21682d91"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"d84fc17fe74cd2ad2af18d83ec9092252a32ff80","unresolved":true,"context_lines":[{"line_number":14,"context_line":"It looks make more sense to warn about the member problem but let the"},{"line_number":15,"context_line":"HM continue with its normal flow of operation over the possible"},{"line_number":16,"context_line":"remaining members that exist for the pool on which it is created."},{"line_number":17,"context_line":"This patch remove the break after found an problematic member (port not"},{"line_number":18,"context_line":"found) and just warning the issue, but continue with the rest of the"},{"line_number":19,"context_line":"members."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"252a4079_831594be","line":17,"range":{"start_line":17,"start_character":11,"end_line":17,"end_character":19},"updated":"2022-12-20 06:29:53.000000000","message":"removes the break after finding a problematic member","commit_id":"232f4af5a9a463b71f39fb4eeeb1937c21682d91"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"bf2d1da4fccd690ab1fdd4c2d405493daf0ca6af","unresolved":false,"context_lines":[{"line_number":14,"context_line":"It looks make more sense to warn about the member problem but let the"},{"line_number":15,"context_line":"HM continue with its normal flow of operation over the possible"},{"line_number":16,"context_line":"remaining members that exist for the pool on which it is created."},{"line_number":17,"context_line":"This patch remove the break after found an problematic member (port not"},{"line_number":18,"context_line":"found) and just warning the issue, but continue with the rest of the"},{"line_number":19,"context_line":"members."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"946a34ea_587eb796","line":17,"range":{"start_line":17,"start_character":11,"end_line":17,"end_character":19},"in_reply_to":"252a4079_831594be","updated":"2022-12-20 08:40:35.000000000","message":"Done","commit_id":"232f4af5a9a463b71f39fb4eeeb1937c21682d91"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"d84fc17fe74cd2ad2af18d83ec9092252a32ff80","unresolved":true,"context_lines":[{"line_number":15,"context_line":"HM continue with its normal flow of operation over the possible"},{"line_number":16,"context_line":"remaining members that exist for the pool on which it is created."},{"line_number":17,"context_line":"This patch remove the break after found an problematic member (port not"},{"line_number":18,"context_line":"found) and just warning the issue, but continue with the rest of the"},{"line_number":19,"context_line":"members."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Closes-Bug: #2000071"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"81cc607b_e3694f24","line":18,"range":{"start_line":18,"start_character":15,"end_line":18,"end_character":34},"updated":"2022-12-20 06:29:53.000000000","message":"and just log a warning about the issue","commit_id":"232f4af5a9a463b71f39fb4eeeb1937c21682d91"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"bf2d1da4fccd690ab1fdd4c2d405493daf0ca6af","unresolved":false,"context_lines":[{"line_number":15,"context_line":"HM continue with its normal flow of operation over the possible"},{"line_number":16,"context_line":"remaining members that exist for the pool on which it is created."},{"line_number":17,"context_line":"This patch remove the break after found an problematic member (port not"},{"line_number":18,"context_line":"found) and just warning the issue, but continue with the rest of the"},{"line_number":19,"context_line":"members."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Closes-Bug: #2000071"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"d146f87e_153ccdc7","line":18,"range":{"start_line":18,"start_character":15,"end_line":18,"end_character":34},"in_reply_to":"81cc607b_e3694f24","updated":"2022-12-20 08:40:35.000000000","message":"Done","commit_id":"232f4af5a9a463b71f39fb4eeeb1937c21682d91"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"d84fc17fe74cd2ad2af18d83ec9092252a32ff80","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8cb6328b_5c4d778b","updated":"2022-12-20 06:29:53.000000000","message":"Just some typo/nits","commit_id":"232f4af5a9a463b71f39fb4eeeb1937c21682d91"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"024a67e50c75a14ee86296fe592d8bea5a92d3be","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"f0d47eca_cff1ff31","updated":"2022-12-21 06:48:47.000000000","message":"LGTM","commit_id":"548d65d1a50612c6b24f85e6ffbdd1cd32bae8e4"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"1da9d1017f9f1373df21993088e246d2535452ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e66f1e77_94a3c881","updated":"2022-12-20 16:44:16.000000000","message":"recheck openstack-tox-py310 unrelated","commit_id":"548d65d1a50612c6b24f85e6ffbdd1cd32bae8e4"}],"ovn_octavia_provider/helper.py":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"d84fc17fe74cd2ad2af18d83ec9092252a32ff80","unresolved":true,"context_lines":[{"line_number":2313,"context_line":"                LOG.error(\"Member %(member)s Logical_Switch_Port not found. \""},{"line_number":2314,"context_line":"                          \"Cannot create a Health Monitor for pool %(pool)s.\","},{"line_number":2315,"context_line":"                          {\u0027member\u0027: member_ip, \u0027pool\u0027: pool_key})"},{"line_number":2316,"context_line":"                continue"},{"line_number":2317,"context_line":""},{"line_number":2318,"context_line":"            network_id \u003d member_lsp.external_ids.get("},{"line_number":2319,"context_line":"                ovn_const.OVN_NETWORK_NAME_EXT_ID_KEY).split(\u0027neutron-\u0027)[1]"}],"source_content_type":"text/x-python","patch_set":1,"id":"6ce3fe7c_e235ea49","line":2316,"updated":"2022-12-20 06:29:53.000000000","message":"perhaps we should add a comment here about why it is ok to continue, unlike in the other cases where we raise the error","commit_id":"232f4af5a9a463b71f39fb4eeeb1937c21682d91"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"bf2d1da4fccd690ab1fdd4c2d405493daf0ca6af","unresolved":false,"context_lines":[{"line_number":2313,"context_line":"                LOG.error(\"Member %(member)s Logical_Switch_Port not found. \""},{"line_number":2314,"context_line":"                          \"Cannot create a Health Monitor for pool %(pool)s.\","},{"line_number":2315,"context_line":"                          {\u0027member\u0027: member_ip, \u0027pool\u0027: pool_key})"},{"line_number":2316,"context_line":"                continue"},{"line_number":2317,"context_line":""},{"line_number":2318,"context_line":"            network_id \u003d member_lsp.external_ids.get("},{"line_number":2319,"context_line":"                ovn_const.OVN_NETWORK_NAME_EXT_ID_KEY).split(\u0027neutron-\u0027)[1]"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a4faa3a_6cddf156","line":2316,"in_reply_to":"6ce3fe7c_e235ea49","updated":"2022-12-20 08:40:35.000000000","message":"Done","commit_id":"232f4af5a9a463b71f39fb4eeeb1937c21682d91"}]}
