)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"d097ecd911cc6b86c5e36157bcf91c662c113d7f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e0df41b2_83925a3b","updated":"2023-01-31 16:25:56.000000000","message":"recheck check if error is persistent","commit_id":"f972887d488debb6bea209242617c19da7cfbcc8"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"9622aa60d9c2f232c3123e291c2298ab4840e06a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f9392046_318ea058","updated":"2023-01-25 10:57:47.000000000","message":"recheck ovn-octavia-provider-tempest-release timeout","commit_id":"f972887d488debb6bea209242617c19da7cfbcc8"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"e68cb3f82baea7990584e014a0c571f502f64f84","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"fbc7899e_ee3a5e2d","updated":"2023-02-10 07:32:26.000000000","message":"also, an extra comment here... I remember doing this change in Kuryr-kubernetes back in the time and we hit a lot of unexpected issues in the following months, so, given the current tempest execution is really limited due to several reason, this should require manual testing to try to limit the \"surprises\"","commit_id":"8587b282641e8294eb4655242d7f3a8c357c8e71"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"6833ae40b9dd5a53ad1e33c7133d5de0ca7b18aa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"c1b103d5_f8d37769","updated":"2023-02-10 07:31:10.000000000","message":"overall looks good, just 2 requests/questions:\n- A release note is needed for this, please add it\n- do we need to also add the dependency to the test-requirements or this is only needed on the tempest side ?","commit_id":"8587b282641e8294eb4655242d7f3a8c357c8e71"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"9edf12f96dd8de5f931601b760c4946c5766ab04","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":9,"id":"c4e1adb8_b29f4508","in_reply_to":"c1b103d5_f8d37769","updated":"2023-02-10 09:18:39.000000000","message":"Thanks for catching the missing release notes. I created them, but somehow missed to add them to Git.\n\nDo you mean the openstacksdk dependency? It should not be needed in test-requirements.txt.","commit_id":"8587b282641e8294eb4655242d7f3a8c357c8e71"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"f263996be59fb59db83e95e083724c2f357af625","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"edb2f3b7_596dbd7d","updated":"2023-02-16 07:10:55.000000000","message":"recheck ovn-octavia-provider-tempest-master timeout exception","commit_id":"012aabf9f7982f89655ceed6f9cd9440186c80dd"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"cca3777c46ae9232129deed7b4921fd787a43262","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"c4c292ac_36501793","updated":"2023-02-15 07:20:20.000000000","message":"recheck ovn-octavia-provider-tempest-release unrelated inmutable loadbalancer","commit_id":"012aabf9f7982f89655ceed6f9cd9440186c80dd"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"5b37a56aab08b5ca66186c09be59f282572361e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"7c5a32f2_c2c689a1","updated":"2023-04-26 06:34:04.000000000","message":"Great work here, I think this is ready to go in","commit_id":"31a9e19dbbc515563125ab41e174ff667ac445f4"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"43f41bb76b9f555d52d38b2e563ecec3cde0eac1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"8ecda6d2_81063178","updated":"2023-04-25 13:43:49.000000000","message":"LGTM! just a question regarding the mapping of exceptions done from neutronclient to openstack client.","commit_id":"31a9e19dbbc515563125ab41e174ff667ac445f4"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"d7d23de94717145d81abd690d785259515cc1d79","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"f4d1f1db_02ee56f0","updated":"2023-05-03 18:55:04.000000000","message":"recheck depends-on merged","commit_id":"31a9e19dbbc515563125ab41e174ff667ac445f4"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"20d7120d6da98b1410d462588075984f59139eed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"0735c53b_412f013e","updated":"2023-05-04 07:27:36.000000000","message":"recheck ovn-octavia-functional-release commit/rollback reset","commit_id":"31a9e19dbbc515563125ab41e174ff667ac445f4"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"eb32fb1b680a072411e6f011a56e90a39b03c937","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"d01f9e7b_9fa8b269","updated":"2023-05-04 05:58:36.000000000","message":"recheck ovn-octavia-functional-release unrelated rollback reset","commit_id":"31a9e19dbbc515563125ab41e174ff667ac445f4"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"ceed4a6176bfcde48172ac78587f90d1c5353914","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"20449fef_0d205e29","updated":"2023-05-05 05:54:37.000000000","message":"recheck ovn-octavia-provider-funcional-release","commit_id":"31a9e19dbbc515563125ab41e174ff667ac445f4"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"0501c238878bdd26f881c65cc286d1356ec9ba11","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"dd1c7ec4_def5636f","updated":"2023-05-08 15:10:37.000000000","message":"recheck ovn-octavia-provider-funcional-release","commit_id":"31a9e19dbbc515563125ab41e174ff667ac445f4"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"cf8eac71c683f5042df69f0d1917de9e3f2b8a6b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"59dd71ac_df59a3e5","updated":"2023-05-04 14:53:57.000000000","message":"recheck ovn-octavia-provider-functional-master cursor commit/rollback reset","commit_id":"31a9e19dbbc515563125ab41e174ff667ac445f4"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"667132ae78c0e80476e33a5ecb2ec4219f3163b4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"67d9c718_9ae394e5","updated":"2023-05-04 10:56:42.000000000","message":"recheck ovn-octavia-provider-functional-master cursor commit/rollback reset","commit_id":"31a9e19dbbc515563125ab41e174ff667ac445f4"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"a6e860ac19f4a6ae44b88e093fec5bed8e9cd4e2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"b8b83924_1cb12fc4","updated":"2023-05-04 12:57:45.000000000","message":"recheck ovn-octavia-provider-functional-master cursor commit/rollback reset","commit_id":"31a9e19dbbc515563125ab41e174ff667ac445f4"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"1c90608f99462bcb9f875f048d89f5003b1a2df2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"5dd3cb10_d85b3d23","updated":"2023-05-04 09:03:53.000000000","message":"recheck ovn-octavia-provider-functional-release timeout","commit_id":"31a9e19dbbc515563125ab41e174ff667ac445f4"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"6deb05acf4c2b1c4c20fa12502f530610d077efe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"f70f91cc_4e0a1126","updated":"2023-05-05 13:28:14.000000000","message":"recheck wanna give it a try too","commit_id":"31a9e19dbbc515563125ab41e174ff667ac445f4"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"56393eec4b62e447d4a33f61aaeba4639f6b029b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"b99a6f70_f3803a8e","updated":"2023-05-05 05:54:11.000000000","message":"we used to hit the rollback issue before every now and then, but here we are getting it way more frequently, I wonder if it is related to the move to openstacksdk","commit_id":"31a9e19dbbc515563125ab41e174ff667ac445f4"}],"ovn_octavia_provider/common/config.py":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"6833ae40b9dd5a53ad1e33c7133d5de0ca7b18aa","unresolved":true,"context_lines":[{"line_number":78,"context_line":"                      \u0027to 60 seconds.\u0027)),"},{"line_number":79,"context_line":"]"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"neutron_opts \u003d ["},{"line_number":82,"context_line":"    cfg.StrOpt(\u0027endpoint\u0027, help\u003d_(\u0027A new endpoint to override the endpoint \u0027"},{"line_number":83,"context_line":"                                  \u0027in the keystone catalog.\u0027),"},{"line_number":84,"context_line":"               deprecated_for_removal\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":9,"id":"a7f21c7d_759a709a","line":81,"range":{"start_line":81,"start_character":0,"end_line":81,"end_character":16},"updated":"2023-02-10 07:31:10.000000000","message":"do we need deprecation notes for service_name, region_name and insecure too?","commit_id":"8587b282641e8294eb4655242d7f3a8c357c8e71"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"76d0f5a447cebd9cf0f67b167443a5d46e84a0c0","unresolved":false,"context_lines":[{"line_number":78,"context_line":"                      \u0027to 60 seconds.\u0027)),"},{"line_number":79,"context_line":"]"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"neutron_opts \u003d ["},{"line_number":82,"context_line":"    cfg.StrOpt(\u0027endpoint\u0027, help\u003d_(\u0027A new endpoint to override the endpoint \u0027"},{"line_number":83,"context_line":"                                  \u0027in the keystone catalog.\u0027),"},{"line_number":84,"context_line":"               deprecated_for_removal\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":9,"id":"fca577f1_fa8b0160","line":81,"range":{"start_line":81,"start_character":0,"end_line":81,"end_character":16},"in_reply_to":"317d64a7_b2f29cbd","updated":"2023-02-10 10:30:16.000000000","message":"ohh, great","commit_id":"8587b282641e8294eb4655242d7f3a8c357c8e71"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"85fd2ae7892afa8d41aa9682f801594aad216889","unresolved":true,"context_lines":[{"line_number":78,"context_line":"                      \u0027to 60 seconds.\u0027)),"},{"line_number":79,"context_line":"]"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"neutron_opts \u003d ["},{"line_number":82,"context_line":"    cfg.StrOpt(\u0027endpoint\u0027, help\u003d_(\u0027A new endpoint to override the endpoint \u0027"},{"line_number":83,"context_line":"                                  \u0027in the keystone catalog.\u0027),"},{"line_number":84,"context_line":"               deprecated_for_removal\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":9,"id":"dc4fecd3_37bba692","line":81,"range":{"start_line":81,"start_character":0,"end_line":81,"end_character":16},"in_reply_to":"6d86aa30_4b0bb377","updated":"2023-02-10 09:45:02.000000000","message":"but you are removing them from here, if they are not deprecated, should they still be there?","commit_id":"8587b282641e8294eb4655242d7f3a8c357c8e71"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"9edf12f96dd8de5f931601b760c4946c5766ab04","unresolved":true,"context_lines":[{"line_number":78,"context_line":"                      \u0027to 60 seconds.\u0027)),"},{"line_number":79,"context_line":"]"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"neutron_opts \u003d ["},{"line_number":82,"context_line":"    cfg.StrOpt(\u0027endpoint\u0027, help\u003d_(\u0027A new endpoint to override the endpoint \u0027"},{"line_number":83,"context_line":"                                  \u0027in the keystone catalog.\u0027),"},{"line_number":84,"context_line":"               deprecated_for_removal\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":9,"id":"6d86aa30_4b0bb377","line":81,"range":{"start_line":81,"start_character":0,"end_line":81,"end_character":16},"in_reply_to":"a7f21c7d_759a709a","updated":"2023-02-10 09:18:39.000000000","message":"It\u0027s not entirely clear to me which options are deprecated and which aren\u0027t, but according to https://opendev.org/openstack/keystoneauth/src/branch/master/keystoneauth1/tests/unit/loading/test_adapter.py#L191 service_name and region_name are not deprecated. I have found no hints that insecure would be deprecated either.","commit_id":"8587b282641e8294eb4655242d7f3a8c357c8e71"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"87b6571bfcda623c68b04e5a950f2dd7a5b356e8","unresolved":true,"context_lines":[{"line_number":78,"context_line":"                      \u0027to 60 seconds.\u0027)),"},{"line_number":79,"context_line":"]"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"neutron_opts \u003d ["},{"line_number":82,"context_line":"    cfg.StrOpt(\u0027endpoint\u0027, help\u003d_(\u0027A new endpoint to override the endpoint \u0027"},{"line_number":83,"context_line":"                                  \u0027in the keystone catalog.\u0027),"},{"line_number":84,"context_line":"               deprecated_for_removal\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":9,"id":"317d64a7_b2f29cbd","line":81,"range":{"start_line":81,"start_character":0,"end_line":81,"end_character":16},"in_reply_to":"dc4fecd3_37bba692","updated":"2023-02-10 10:01:00.000000000","message":"these options are now automatically handled/added by keystoneauth\n\nhttps://opendev.org/openstack/keystoneauth/src/commit/d2b729d0c010f4077669f812aa2878a8cd2b59ee/keystoneauth1/loading/adapter.py#L178\nhttps://opendev.org/openstack/keystoneauth/src/commit/cc58eca84fb9e3ba975adb3bb4529c10dcbddbde/keystoneauth1/loading/session.py#L203\n\n(through the calls to keystoneauth in register_opts)","commit_id":"8587b282641e8294eb4655242d7f3a8c357c8e71"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"40b8badd33d78699854329abf0d806761c1d929b","unresolved":true,"context_lines":[{"line_number":147,"context_line":"        missing_neutron_opts \u003d [opt for opt in neutron_opts"},{"line_number":148,"context_line":"                                if opt.name not in neutron_registered_opts]"},{"line_number":149,"context_line":"    except cfg.NoSuchOptError:"},{"line_number":150,"context_line":"        LOG.info(\u0027Not found any opts under group neutron\u0027)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    cfg.CONF.register_opts(missing_ovn_opts, group\u003d\u0027ovn\u0027)"},{"line_number":153,"context_line":"    cfg.CONF.register_opts(missing_neutron_opts, group\u003d\u0027neutron\u0027)"}],"source_content_type":"text/x-python","patch_set":14,"id":"96397dac_afb776fe","line":150,"range":{"start_line":150,"start_character":18,"end_line":150,"end_character":56},"updated":"2023-04-25 16:27:32.000000000","message":"Nit: I\u0027m not a native speaker, but that doesn\u0027t sound like proper English to me. Maybe \"Could not find any...\"?","commit_id":"31a9e19dbbc515563125ab41e174ff667ac445f4"}],"ovn_octavia_provider/helper.py":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"6833ae40b9dd5a53ad1e33c7133d5de0ca7b18aa","unresolved":true,"context_lines":[{"line_number":2060,"context_line":"        except openstack.exceptions.HttpException as e:"},{"line_number":2061,"context_line":"            # NOTE (froyo): whatever other exception as e.g. Timeout"},{"line_number":2062,"context_line":"            # we should try to ensure no leftover port remains"},{"line_number":2063,"context_line":"            port \u003d neutron_client.find_port("},{"line_number":2064,"context_line":"                name_or_id\u003df\u0027{ovn_const.LB_VIP_PORT_PREFIX}{lb_id}\u0027,"},{"line_number":2065,"context_line":"                network_id\u003dvip_d[constants.VIP_NETWORK_ID])"},{"line_number":2066,"context_line":"            if port:"},{"line_number":2067,"context_line":"                LOG.debug(\u0027Leftover port %s has been found. Trying to \u0027"},{"line_number":2068,"context_line":"                          \u0027delete it\u0027, port.id)"}],"source_content_type":"text/x-python","patch_set":9,"id":"6b9f15dc_c8bc04fe","line":2065,"range":{"start_line":2063,"start_character":0,"end_line":2065,"end_character":59},"updated":"2023-02-10 07:31:10.000000000","message":"technically there may be different ports with the same name, but as the name used has the id of the loadbalancer, lets assume this is fine (before we were just assuming the first one was the right one anyway","commit_id":"8587b282641e8294eb4655242d7f3a8c357c8e71"},{"author":{"_account_id":34429,"name":"Tom Weininger","email":"dienste@weinimo.de","username":"tweining"},"change_message_id":"9edf12f96dd8de5f931601b760c4946c5766ab04","unresolved":false,"context_lines":[{"line_number":2060,"context_line":"        except openstack.exceptions.HttpException as e:"},{"line_number":2061,"context_line":"            # NOTE (froyo): whatever other exception as e.g. Timeout"},{"line_number":2062,"context_line":"            # we should try to ensure no leftover port remains"},{"line_number":2063,"context_line":"            port \u003d neutron_client.find_port("},{"line_number":2064,"context_line":"                name_or_id\u003df\u0027{ovn_const.LB_VIP_PORT_PREFIX}{lb_id}\u0027,"},{"line_number":2065,"context_line":"                network_id\u003dvip_d[constants.VIP_NETWORK_ID])"},{"line_number":2066,"context_line":"            if port:"},{"line_number":2067,"context_line":"                LOG.debug(\u0027Leftover port %s has been found. Trying to \u0027"},{"line_number":2068,"context_line":"                          \u0027delete it\u0027, port.id)"}],"source_content_type":"text/x-python","patch_set":9,"id":"431b5c43_e2bbd63f","line":2065,"range":{"start_line":2063,"start_character":0,"end_line":2065,"end_character":59},"in_reply_to":"6b9f15dc_c8bc04fe","updated":"2023-02-10 09:18:39.000000000","message":"Ack","commit_id":"8587b282641e8294eb4655242d7f3a8c357c8e71"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"43f41bb76b9f555d52d38b2e563ecec3cde0eac1","unresolved":true,"context_lines":[{"line_number":441,"context_line":""},{"line_number":442,"context_line":"    @tenacity.retry("},{"line_number":443,"context_line":"        retry\u003dtenacity.retry_if_exception_type("},{"line_number":444,"context_line":"            openstack.exceptions.HttpException),"},{"line_number":445,"context_line":"        wait\u003dtenacity.wait_exponential(),"},{"line_number":446,"context_line":"        stop\u003dtenacity.stop_after_delay(10),"},{"line_number":447,"context_line":"        reraise\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":14,"id":"ef038a87_b2ca5d07","line":444,"updated":"2023-04-25 13:43:49.000000000","message":"Just question, are in some place define those mapping between neutronClient exceptions and openstacksdk Exceptions?","commit_id":"31a9e19dbbc515563125ab41e174ff667ac445f4"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"afef0199e695e7ffe8827b43501ea00ec119dbd4","unresolved":false,"context_lines":[{"line_number":441,"context_line":""},{"line_number":442,"context_line":"    @tenacity.retry("},{"line_number":443,"context_line":"        retry\u003dtenacity.retry_if_exception_type("},{"line_number":444,"context_line":"            openstack.exceptions.HttpException),"},{"line_number":445,"context_line":"        wait\u003dtenacity.wait_exponential(),"},{"line_number":446,"context_line":"        stop\u003dtenacity.stop_after_delay(10),"},{"line_number":447,"context_line":"        reraise\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":14,"id":"de149e19_043f70ca","line":444,"in_reply_to":"6c8773fd_c1d184f8","updated":"2023-04-25 15:50:18.000000000","message":"Ack","commit_id":"31a9e19dbbc515563125ab41e174ff667ac445f4"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"c0cea8eb3a8ff8b1aec7e7923d7d0b6af90264a6","unresolved":true,"context_lines":[{"line_number":441,"context_line":""},{"line_number":442,"context_line":"    @tenacity.retry("},{"line_number":443,"context_line":"        retry\u003dtenacity.retry_if_exception_type("},{"line_number":444,"context_line":"            openstack.exceptions.HttpException),"},{"line_number":445,"context_line":"        wait\u003dtenacity.wait_exponential(),"},{"line_number":446,"context_line":"        stop\u003dtenacity.stop_after_delay(10),"},{"line_number":447,"context_line":"        reraise\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":14,"id":"6c8773fd_c1d184f8","line":444,"in_reply_to":"7c7b4119_53fec063","updated":"2023-04-25 15:39:17.000000000","message":"So NeutronClientException is the generic exception for API errors:\nhttps://opendev.org/openstack/python-neutronclient/src/branch/master/neutronclient/common/exceptions.py#L64\nhttps://opendev.org/openstack/python-neutronclient/src/branch/master/neutronclient/v2_0/client.py#L88\n\nTo me, openstack.exceptions.HttpException and NeutronClientException have the same meaning","commit_id":"31a9e19dbbc515563125ab41e174ff667ac445f4"},{"author":{"_account_id":29244,"name":"Gregory Thiemonge","email":"gthiemon@redhat.com","username":"gthiemonge"},"change_message_id":"690d585acad7842f991d3a1135b54f887ef924e2","unresolved":true,"context_lines":[{"line_number":441,"context_line":""},{"line_number":442,"context_line":"    @tenacity.retry("},{"line_number":443,"context_line":"        retry\u003dtenacity.retry_if_exception_type("},{"line_number":444,"context_line":"            openstack.exceptions.HttpException),"},{"line_number":445,"context_line":"        wait\u003dtenacity.wait_exponential(),"},{"line_number":446,"context_line":"        stop\u003dtenacity.stop_after_delay(10),"},{"line_number":447,"context_line":"        reraise\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":14,"id":"7c7b4119_53fec063","line":444,"in_reply_to":"ef038a87_b2ca5d07","updated":"2023-04-25 15:35:17.000000000","message":"hmm I will double-check, but maybe we should use SDKException here\nhttps://opendev.org/openstack/openstacksdk/src/branch/master/openstack/exceptions.py#L25\n\nHTTPException is for any errors from API responses (404, 503, etc..)\nSDKException is more generic and could include connection issue","commit_id":"31a9e19dbbc515563125ab41e174ff667ac445f4"}]}