)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"2098ec9852e7bba836abed1f3bd30dc400508dae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c20482f9_9ff0adf3","updated":"2023-02-17 09:51:54.000000000","message":"I suppose that you still need to add some UT tests, but just some nits/comments ","commit_id":"3741526d5cf919e81c548d75d1eee3985b63dadd"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"8db818ec9f898b92b6697faa4f2819f0d81bfe05","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"0a253c4b_d4710694","updated":"2023-02-21 07:36:51.000000000","message":"reducing tox coverage to 91 to generate cover report and checking differences with local cover where it is passing","commit_id":"66f2b908dbdae2219a12bd87aa5e5b2de0db64f9"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"84c3a5e173d15b2cb82f7bd7330efecea621b108","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"39050054_c8135ecc","updated":"2023-02-21 15:45:37.000000000","message":"LGTM","commit_id":"ba4ea1134b1da4ce1dcd186d4962d12270699fef"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"4b9c5b131c2af45b78fa30abc92f4a796606a145","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"73aa8877_e2868e59","updated":"2023-02-27 08:59:38.000000000","message":"recheck all gates failed, unrelated","commit_id":"ba4ea1134b1da4ce1dcd186d4962d12270699fef"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"cd4e49eb9ba01118f07fb8686de4647c2bac29ed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"0fb8fd7f_38174632","updated":"2023-02-27 10:03:59.000000000","message":"recheck openstack-tox-cover cover was passing on previous attempts (and locally), checking if just a hiccup","commit_id":"ba4ea1134b1da4ce1dcd186d4962d12270699fef"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"3cc11aa20ae8e1519339e8243e4f30cc3db0f3f7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"7c9c066e_637c1642","updated":"2023-02-27 13:27:02.000000000","message":"recheck unstable gates","commit_id":"ba4ea1134b1da4ce1dcd186d4962d12270699fef"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"9c1d11e224c95a5be34ad45ee31d5172ee094765","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"a5f92ee8_dce847d9","updated":"2023-02-27 11:39:43.000000000","message":"recheck unstable gates","commit_id":"ba4ea1134b1da4ce1dcd186d4962d12270699fef"}],"ovn_octavia_provider/helper.py":[{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"2098ec9852e7bba836abed1f3bd30dc400508dae","unresolved":true,"context_lines":[{"line_number":2307,"context_line":"                txn.add(self.ovn_nbdb_api.db_add("},{"line_number":2308,"context_line":"                    \u0027Load_Balancer\u0027, ovn_lb.uuid,"},{"line_number":2309,"context_line":"                    \u0027health_check\u0027, health_check))"},{"line_number":2310,"context_line":"                if fip is not None:"},{"line_number":2311,"context_line":"                    fip_health_check \u003d txn.add("},{"line_number":2312,"context_line":"                        self.ovn_nbdb_api.db_create("},{"line_number":2313,"context_line":"                            \u0027Load_Balancer_Health_Check\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3408f42d_2368e0aa","line":2310,"updated":"2023-02-17 09:51:54.000000000","message":"nit: just \u0027if fip:\u0027 is enough","commit_id":"3741526d5cf919e81c548d75d1eee3985b63dadd"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"66d4fc767bb3a426094e0993979a8580c88bb4af","unresolved":false,"context_lines":[{"line_number":2307,"context_line":"                txn.add(self.ovn_nbdb_api.db_add("},{"line_number":2308,"context_line":"                    \u0027Load_Balancer\u0027, ovn_lb.uuid,"},{"line_number":2309,"context_line":"                    \u0027health_check\u0027, health_check))"},{"line_number":2310,"context_line":"                if fip is not None:"},{"line_number":2311,"context_line":"                    fip_health_check \u003d txn.add("},{"line_number":2312,"context_line":"                        self.ovn_nbdb_api.db_create("},{"line_number":2313,"context_line":"                            \u0027Load_Balancer_Health_Check\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"91dacef2_0e5a5f32","line":2310,"in_reply_to":"0efec59b_e06e20cf","updated":"2023-02-17 10:57:30.000000000","message":"oh, right! weird situation but you are right L2260","commit_id":"3741526d5cf919e81c548d75d1eee3985b63dadd"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"247d18e72ef1f7542f9e3c24700839c485b3aa91","unresolved":true,"context_lines":[{"line_number":2307,"context_line":"                txn.add(self.ovn_nbdb_api.db_add("},{"line_number":2308,"context_line":"                    \u0027Load_Balancer\u0027, ovn_lb.uuid,"},{"line_number":2309,"context_line":"                    \u0027health_check\u0027, health_check))"},{"line_number":2310,"context_line":"                if fip is not None:"},{"line_number":2311,"context_line":"                    fip_health_check \u003d txn.add("},{"line_number":2312,"context_line":"                        self.ovn_nbdb_api.db_create("},{"line_number":2313,"context_line":"                            \u0027Load_Balancer_Health_Check\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"0efec59b_e06e20cf","line":2310,"in_reply_to":"3408f42d_2368e0aa","updated":"2023-02-17 10:48:59.000000000","message":"is not enough, as it there is no vip_port, fip will be set to [], in in that case the lbhc needs to be created anyway","commit_id":"3741526d5cf919e81c548d75d1eee3985b63dadd"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"2098ec9852e7bba836abed1f3bd30dc400508dae","unresolved":true,"context_lines":[{"line_number":2341,"context_line":"            fip \u003d fip + \u0027:\u0027 + str(vip_port)"},{"line_number":2342,"context_line":"            if len(ovn_lb.health_check) !\u003d 2:"},{"line_number":2343,"context_line":"                LOG.error(\"There should be two HCs associated to the Load \""},{"line_number":2344,"context_line":"                          \"Balancer as %s t has a FIP associated to it\","},{"line_number":2345,"context_line":"                          ovn_lb.uuid)"},{"line_number":2346,"context_line":"                return False"},{"line_number":2347,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a3fed11_c44c5c13","line":2344,"updated":"2023-02-17 09:51:54.000000000","message":"nit: typo t","commit_id":"3741526d5cf919e81c548d75d1eee3985b63dadd"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"247d18e72ef1f7542f9e3c24700839c485b3aa91","unresolved":false,"context_lines":[{"line_number":2341,"context_line":"            fip \u003d fip + \u0027:\u0027 + str(vip_port)"},{"line_number":2342,"context_line":"            if len(ovn_lb.health_check) !\u003d 2:"},{"line_number":2343,"context_line":"                LOG.error(\"There should be two HCs associated to the Load \""},{"line_number":2344,"context_line":"                          \"Balancer as %s t has a FIP associated to it\","},{"line_number":2345,"context_line":"                          ovn_lb.uuid)"},{"line_number":2346,"context_line":"                return False"},{"line_number":2347,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9e43485b_4d8406ab","line":2344,"in_reply_to":"3a3fed11_c44c5c13","updated":"2023-02-17 10:48:59.000000000","message":"Done","commit_id":"3741526d5cf919e81c548d75d1eee3985b63dadd"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"2098ec9852e7bba836abed1f3bd30dc400508dae","unresolved":true,"context_lines":[{"line_number":2343,"context_line":"                LOG.error(\"There should be two HCs associated to the Load \""},{"line_number":2344,"context_line":"                          \"Balancer as %s t has a FIP associated to it\","},{"line_number":2345,"context_line":"                          ovn_lb.uuid)"},{"line_number":2346,"context_line":"                return False"},{"line_number":2347,"context_line":""},{"line_number":2348,"context_line":"        commands \u003d []"},{"line_number":2349,"context_line":"        commands.append("}],"source_content_type":"text/x-python","patch_set":2,"id":"c2da8c1b_0c1e954a","line":2346,"updated":"2023-02-17 09:51:54.000000000","message":"Just thinking on backward compatibility those existing LBs that have a just one HC (VIP) and also a FIP associated, if they update to this version they couldn\u0027t update the HM anymore due to this line, so maybe we could just warn the msg in the log, try to create it, and continue updating.","commit_id":"3741526d5cf919e81c548d75d1eee3985b63dadd"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"66d4fc767bb3a426094e0993979a8580c88bb4af","unresolved":false,"context_lines":[{"line_number":2343,"context_line":"                LOG.error(\"There should be two HCs associated to the Load \""},{"line_number":2344,"context_line":"                          \"Balancer as %s t has a FIP associated to it\","},{"line_number":2345,"context_line":"                          ovn_lb.uuid)"},{"line_number":2346,"context_line":"                return False"},{"line_number":2347,"context_line":""},{"line_number":2348,"context_line":"        commands \u003d []"},{"line_number":2349,"context_line":"        commands.append("}],"source_content_type":"text/x-python","patch_set":2,"id":"3d065aba_85f449b3","line":2346,"in_reply_to":"af2ec56a_b5f0548d","updated":"2023-02-17 10:57:30.000000000","message":"Done","commit_id":"3741526d5cf919e81c548d75d1eee3985b63dadd"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"247d18e72ef1f7542f9e3c24700839c485b3aa91","unresolved":true,"context_lines":[{"line_number":2343,"context_line":"                LOG.error(\"There should be two HCs associated to the Load \""},{"line_number":2344,"context_line":"                          \"Balancer as %s t has a FIP associated to it\","},{"line_number":2345,"context_line":"                          ovn_lb.uuid)"},{"line_number":2346,"context_line":"                return False"},{"line_number":2347,"context_line":""},{"line_number":2348,"context_line":"        commands \u003d []"},{"line_number":2349,"context_line":"        commands.append("}],"source_content_type":"text/x-python","patch_set":2,"id":"af2ec56a_b5f0548d","line":2346,"in_reply_to":"c2da8c1b_0c1e954a","updated":"2023-02-17 10:48:59.000000000","message":"umm, nice catch! This will only be executed on listener_create or listener_update. In the listener_create it will set the operating_status to error. But still worth to try to fix instead","commit_id":"3741526d5cf919e81c548d75d1eee3985b63dadd"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"a4315e9f922d8e9b9005eaf4301481062e24e8e1","unresolved":true,"context_lines":[{"line_number":2419,"context_line":"            return False"},{"line_number":2420,"context_line":""},{"line_number":2421,"context_line":"        vip_version \u003d netaddr.IPAddress(vip).version"},{"line_number":2422,"context_line":"        if vip_version \u003d\u003d 6:"},{"line_number":2423,"context_line":"            vip_lbhc \u003d [lbhc for lbhc in ovn_lb.health_check"},{"line_number":2424,"context_line":"                        if lbhc.vip \u003d\u003d [] or lbhc.vip[1:].split(\"]\")[0] \u003d\u003d vip]"},{"line_number":2425,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":11,"id":"c35b12e1_1c66b81a","line":2422,"range":{"start_line":2422,"start_character":26,"end_line":2422,"end_character":27},"updated":"2023-02-27 08:43:47.000000000","message":"we have constants for that in neutron_lib.constants module. You should use it but this can be changed in follow up patch.","commit_id":"ba4ea1134b1da4ce1dcd186d4962d12270699fef"}]}