)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"b52536b37587d590b09ef3fe81075a04bc8286b6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"13b566db_de515772","updated":"2023-03-02 06:46:56.000000000","message":"This looks good to me, perhaps it would be nice to also add coverage for loadbalancer creation at once (lb, listener, pool, members), including the HM","commit_id":"13c731346a9c4c76dd6078c8e0edbcec51542ca0"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"b34ef720dbd2ec42b30c6062beddb996a914c17c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e9796c2b_a0a00815","updated":"2023-03-02 16:11:28.000000000","message":"recheck after https://review.opendev.org/875400 is merged","commit_id":"13c731346a9c4c76dd6078c8e0edbcec51542ca0"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"bbee39d73e9f14718465a1d5b5c0f5210f4ea3fc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f37cfc3e_1b011cc4","updated":"2023-03-01 13:40:14.000000000","message":"recheck ovn-octavia-provider-functional-release cursor reset commit/rollback","commit_id":"13c731346a9c4c76dd6078c8e0edbcec51542ca0"}],"ovn_octavia_provider/tests/functional/base.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"440414e6bbd6cc46902db1f1b031f4498d2fefb2","unresolved":true,"context_lines":[{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    def _create_hm_model(self, pool_id, name, delay, timeout, max_retries,"},{"line_number":163,"context_line":"                         type, max_retries_down\u003d3, admin_state_up\u003dTrue):"},{"line_number":164,"context_line":"        m_hm \u003d octavia_data_model.HealthMonitor()"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        m_hm.healthmonitor_id \u003d uuidutils.generate_uuid()"},{"line_number":167,"context_line":"        m_hm.pool_id \u003d pool_id"}],"source_content_type":"text/x-python","patch_set":1,"id":"dcecb3ce_cc2cc2f7","line":164,"range":{"start_line":164,"start_character":8,"end_line":164,"end_character":49},"updated":"2023-03-01 09:29:21.000000000","message":"nit: you can create the object in one single line, passing the values as arguments to the HealthMonitor class instantiation.","commit_id":"10806fe4283c5bd536427e928edc6ed88a1da289"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"d6c805dbb23b2254bc1f061b5db93d33cbae4567","unresolved":false,"context_lines":[{"line_number":161,"context_line":""},{"line_number":162,"context_line":"    def _create_hm_model(self, pool_id, name, delay, timeout, max_retries,"},{"line_number":163,"context_line":"                         type, max_retries_down\u003d3, admin_state_up\u003dTrue):"},{"line_number":164,"context_line":"        m_hm \u003d octavia_data_model.HealthMonitor()"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        m_hm.healthmonitor_id \u003d uuidutils.generate_uuid()"},{"line_number":167,"context_line":"        m_hm.pool_id \u003d pool_id"}],"source_content_type":"text/x-python","patch_set":1,"id":"6366e519_3ab908a1","line":164,"range":{"start_line":164,"start_character":8,"end_line":164,"end_character":49},"in_reply_to":"dcecb3ce_cc2cc2f7","updated":"2023-03-01 10:32:01.000000000","message":"Done","commit_id":"10806fe4283c5bd536427e928edc6ed88a1da289"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"440414e6bbd6cc46902db1f1b031f4498d2fefb2","unresolved":true,"context_lines":[{"line_number":966,"context_line":"        self._wait_for_status_and_validate(lb_data, [expected_status])"},{"line_number":967,"context_line":""},{"line_number":968,"context_line":"    def _create_hm_and_validate(self, lb_data, pool_id, name, delay, timeout,"},{"line_number":969,"context_line":"                                max_retries, type):"},{"line_number":970,"context_line":"        self._o_driver_lib.update_loadbalancer_status.reset_mock()"},{"line_number":971,"context_line":"        pool \u003d self._get_pool_from_lb_data(lb_data, pool_id\u003dpool_id)"},{"line_number":972,"context_line":"        pool_status \u003d {\u0027id\u0027: pool.pool_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ef9b5e13_57794629","line":969,"range":{"start_line":969,"start_character":45,"end_line":969,"end_character":49},"updated":"2023-03-01 09:29:21.000000000","message":"This is shadowing a built-in variable","commit_id":"10806fe4283c5bd536427e928edc6ed88a1da289"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"d6c805dbb23b2254bc1f061b5db93d33cbae4567","unresolved":false,"context_lines":[{"line_number":966,"context_line":"        self._wait_for_status_and_validate(lb_data, [expected_status])"},{"line_number":967,"context_line":""},{"line_number":968,"context_line":"    def _create_hm_and_validate(self, lb_data, pool_id, name, delay, timeout,"},{"line_number":969,"context_line":"                                max_retries, type):"},{"line_number":970,"context_line":"        self._o_driver_lib.update_loadbalancer_status.reset_mock()"},{"line_number":971,"context_line":"        pool \u003d self._get_pool_from_lb_data(lb_data, pool_id\u003dpool_id)"},{"line_number":972,"context_line":"        pool_status \u003d {\u0027id\u0027: pool.pool_id,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3852c2c9_2c50aca2","line":969,"range":{"start_line":969,"start_character":45,"end_line":969,"end_character":49},"in_reply_to":"ef9b5e13_57794629","updated":"2023-03-01 10:32:01.000000000","message":"ouch! good catch!","commit_id":"10806fe4283c5bd536427e928edc6ed88a1da289"}]}
