)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"b19705ef78b9c64ccb3764499d8800bc3dc5ba96","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Apply admin_state_up on a new member creation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When a new member is added, if it is done with a admin_state_up to"},{"line_number":10,"context_line":"False, the member should not take part on the request balancing"},{"line_number":11,"context_line":"over the LB VIP, although Octavia API applies the member"},{"line_number":12,"context_line":"operation_status well, but the member receives requests."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"af69e003_05ef00b1","line":9,"range":{"start_line":9,"start_character":47,"end_line":9,"end_character":49},"updated":"2023-04-19 06:25:20.000000000","message":"an","commit_id":"d9c827fde44058731fdd50baeba9ecc7412dcd4a"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"c2d52e2c4a388bf5102d2e184e4a624b3f0de132","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Apply admin_state_up on a new member creation"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When a new member is added, if it is done with a admin_state_up to"},{"line_number":10,"context_line":"False, the member should not take part on the request balancing"},{"line_number":11,"context_line":"over the LB VIP, although Octavia API applies the member"},{"line_number":12,"context_line":"operation_status well, but the member receives requests."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3e4ae413_a24d9e93","line":9,"range":{"start_line":9,"start_character":47,"end_line":9,"end_character":49},"in_reply_to":"af69e003_05ef00b1","updated":"2023-04-19 09:00:12.000000000","message":"Done","commit_id":"d9c827fde44058731fdd50baeba9ecc7412dcd4a"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"b19705ef78b9c64ccb3764499d8800bc3dc5ba96","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When a new member is added, if it is done with a admin_state_up to"},{"line_number":10,"context_line":"False, the member should not take part on the request balancing"},{"line_number":11,"context_line":"over the LB VIP, although Octavia API applies the member"},{"line_number":12,"context_line":"operation_status well, but the member receives requests."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch fix this issue, not adding the member to the vips, at"},{"line_number":15,"context_line":"this way request over LB VIP are not taking that member as a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"8ec54975_fc417d23","line":12,"range":{"start_line":11,"start_character":17,"end_line":12,"end_character":56},"updated":"2023-04-19 06:25:20.000000000","message":"perhaps needs some rephrase, I\u0027m not sure I\u0027m getting what you mean here","commit_id":"d9c827fde44058731fdd50baeba9ecc7412dcd4a"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"c2d52e2c4a388bf5102d2e184e4a624b3f0de132","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When a new member is added, if it is done with a admin_state_up to"},{"line_number":10,"context_line":"False, the member should not take part on the request balancing"},{"line_number":11,"context_line":"over the LB VIP, although Octavia API applies the member"},{"line_number":12,"context_line":"operation_status well, but the member receives requests."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch fix this issue, not adding the member to the vips, at"},{"line_number":15,"context_line":"this way request over LB VIP are not taking that member as a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"324a7c32_a8ed1644","line":12,"range":{"start_line":11,"start_character":17,"end_line":12,"end_character":56},"in_reply_to":"8ec54975_fc417d23","updated":"2023-04-19 09:00:12.000000000","message":"Done","commit_id":"d9c827fde44058731fdd50baeba9ecc7412dcd4a"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"b19705ef78b9c64ccb3764499d8800bc3dc5ba96","unresolved":true,"context_lines":[{"line_number":11,"context_line":"over the LB VIP, although Octavia API applies the member"},{"line_number":12,"context_line":"operation_status well, but the member receives requests."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch fix this issue, not adding the member to the vips, at"},{"line_number":15,"context_line":"this way request over LB VIP are not taking that member as a"},{"line_number":16,"context_line":"candidate."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Closes-Bug: 2016862"},{"line_number":19,"context_line":"Change-Id: Iec7f6b1da8548a29eb9cc0e2544e77e1a6c6fb1e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"15bb6c49_1ed7e10c","line":16,"range":{"start_line":14,"start_character":0,"end_line":16,"end_character":10},"updated":"2023-04-19 06:25:20.000000000","message":"perhaps rephase as: \"This patch fixes this issue by not adding the member to the vips (at OVN NB) so that request over LB VIP are not taking into account that member.\"","commit_id":"d9c827fde44058731fdd50baeba9ecc7412dcd4a"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"c2d52e2c4a388bf5102d2e184e4a624b3f0de132","unresolved":false,"context_lines":[{"line_number":11,"context_line":"over the LB VIP, although Octavia API applies the member"},{"line_number":12,"context_line":"operation_status well, but the member receives requests."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch fix this issue, not adding the member to the vips, at"},{"line_number":15,"context_line":"this way request over LB VIP are not taking that member as a"},{"line_number":16,"context_line":"candidate."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Closes-Bug: 2016862"},{"line_number":19,"context_line":"Change-Id: Iec7f6b1da8548a29eb9cc0e2544e77e1a6c6fb1e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"2b59724a_fe103a39","line":16,"range":{"start_line":14,"start_character":0,"end_line":16,"end_character":10},"in_reply_to":"15bb6c49_1ed7e10c","updated":"2023-04-19 09:00:12.000000000","message":"Done","commit_id":"d9c827fde44058731fdd50baeba9ecc7412dcd4a"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"b19705ef78b9c64ccb3764499d8800bc3dc5ba96","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7c749161_260b88f5","updated":"2023-04-19 06:25:20.000000000","message":"Just some nits on the commit message, the code LGTM","commit_id":"d9c827fde44058731fdd50baeba9ecc7412dcd4a"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"345a7e1f6f6243ac5d26456d5435310de46119f6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"80d75698_d5b961d7","updated":"2023-04-19 09:03:55.000000000","message":"thanks!","commit_id":"35083393ad887d3c86c0d74efd1a5eef5f39c357"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"bee69fad4dd7958d58f816b90c88d1c67b988003","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5c83da78_08f6e409","updated":"2023-05-08 12:21:05.000000000","message":"recheck ovn-octavia-provider-functional-master unrelated","commit_id":"383541a194c6366ef06151aea463eb9a9dfd6d69"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"161ec7969ef95eaa0ef84cf7888dbbc2b2057aef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"472fdf9a_f48ed446","updated":"2023-05-08 14:35:54.000000000","message":"recheck ovn-octavia-provider-functional-release looks unrelated, in a devstack they run OK","commit_id":"383541a194c6366ef06151aea463eb9a9dfd6d69"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"32f8af0eb2f4d7dfdfe50ede8273f88dd97d2cba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"0db340ac_8d7d1ca9","updated":"2023-05-08 15:45:29.000000000","message":"tests broken by changes in [1]\n\n[1] https://review.opendev.org/c/openstack/neutron/+/879827","commit_id":"383541a194c6366ef06151aea463eb9a9dfd6d69"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"156b2d22a3b174c6331f0119ca1d778010d32580","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"05db2050_93407b28","updated":"2023-05-16 15:29:47.000000000","message":"recheck ovn-octavia-provider-functional-master cursor reset commit/rollback","commit_id":"b10fb3741824bb0f24c6f2ea99c321bfa120a261"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"39eecc2a476889bc6f5509c73f1d46d007ba9658","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"230f6694_3917275f","updated":"2023-05-26 06:18:59.000000000","message":"just a nit","commit_id":"111abca837ea44e69f3026e3fb0c5c655dc4bbe0"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"403711499023a4a4195c5b1f69e5a8ffca084cc7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"f52e1dbf_9770ef53","updated":"2023-05-26 08:11:24.000000000","message":"recheck ovn-octavia-provider-tempest-release LB inmutable","commit_id":"01309d067c800c3bb07978c1db7e62a1c8b49a73"}],"ovn_octavia_provider/helper.py":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"39eecc2a476889bc6f5509c73f1d46d007ba9658","unresolved":true,"context_lines":[{"line_number":1954,"context_line":"        operating_status \u003d constants.NO_MONITOR"},{"line_number":1955,"context_line":"        if not member[constants.ADMIN_STATE_UP]:"},{"line_number":1956,"context_line":"            operating_status \u003d constants.OFFLINE"},{"line_number":1957,"context_line":"        if (new_member and operating_status \u003d\u003d constants.NO_MONITOR and"},{"line_number":1958,"context_line":"                ovn_lb.health_check):"},{"line_number":1959,"context_line":"            operating_status \u003d constants.ONLINE"},{"line_number":1960,"context_line":"            mb_ip, mb_port, mb_subnet, mb_id \u003d self._extract_member_info("}],"source_content_type":"text/x-python","patch_set":6,"id":"58468844_d2106cb6","line":1957,"range":{"start_line":1957,"start_character":8,"end_line":1957,"end_character":11},"updated":"2023-05-26 06:18:59.000000000","message":"elif? as if the if in line 1955 success there is no need to check this","commit_id":"111abca837ea44e69f3026e3fb0c5c655dc4bbe0"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"ec0e3df612c76da331d23b539e4cf8082ae4cdbb","unresolved":false,"context_lines":[{"line_number":1954,"context_line":"        operating_status \u003d constants.NO_MONITOR"},{"line_number":1955,"context_line":"        if not member[constants.ADMIN_STATE_UP]:"},{"line_number":1956,"context_line":"            operating_status \u003d constants.OFFLINE"},{"line_number":1957,"context_line":"        if (new_member and operating_status \u003d\u003d constants.NO_MONITOR and"},{"line_number":1958,"context_line":"                ovn_lb.health_check):"},{"line_number":1959,"context_line":"            operating_status \u003d constants.ONLINE"},{"line_number":1960,"context_line":"            mb_ip, mb_port, mb_subnet, mb_id \u003d self._extract_member_info("}],"source_content_type":"text/x-python","patch_set":6,"id":"6619ee07_c2031522","line":1957,"range":{"start_line":1957,"start_character":8,"end_line":1957,"end_character":11},"in_reply_to":"58468844_d2106cb6","updated":"2023-05-26 06:43:07.000000000","message":"yep, good catch!","commit_id":"111abca837ea44e69f3026e3fb0c5c655dc4bbe0"}]}