)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"9429890919c6d78d9531187ba7145ac31f099232","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"420877cc_4818854e","updated":"2023-04-24 06:56:37.000000000","message":"Just a question, high chances is me not fully understanding the logic/edge case in there, but adding -1 to ensure this is not missed","commit_id":"ac3fe18b1a2a8a00b373149bee07414c2c1d725d"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"7df38c32c2e219dc1f3a1f98a4bf959f991663d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f64ebd1c_ae532cfa","updated":"2023-05-08 12:12:08.000000000","message":"Thx!","commit_id":"ac3fe18b1a2a8a00b373149bee07414c2c1d725d"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"7c4ad99b5625d70a95efe2b40473a56ab93e9326","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c331d181_958b7387","updated":"2023-04-25 12:16:23.000000000","message":"not sure if a release note would be a nice addition here as some API calls that before would fail now will (properly) succeed","commit_id":"ac3fe18b1a2a8a00b373149bee07414c2c1d725d"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"fb71e8467fc32f87ca12abd457aa93bdc556b555","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1c061c56_6e085c5b","updated":"2023-04-20 13:17:20.000000000","message":"recheck ovn-octavia-provider-functional-release cursor reset commit/rollback","commit_id":"ac3fe18b1a2a8a00b373149bee07414c2c1d725d"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"6fccc98318f82f4303ec06b9f893dcae8674dd32","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a0178100_6eafe6e1","updated":"2023-05-08 15:45:00.000000000","message":"tests broken by changes in [1]\n\n[1] https://review.opendev.org/c/openstack/neutron/+/879827","commit_id":"ac3fe18b1a2a8a00b373149bee07414c2c1d725d"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"4e6af3c3c18d8a2c6005f29de19b95a0441de382","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"30fa709c_7ac6bb31","updated":"2023-05-17 13:23:16.000000000","message":"recheck ovn-octavia-provider-functional-master cursor reset commit/rollback","commit_id":"8beeeb9112f6c61758f844774bfe4c5d6e8c6a08"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"46b9a79018fbf26924b44b24af71a88178d256b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"3a9d9019_f46dc5f9","updated":"2023-05-17 12:11:40.000000000","message":"recheck ovn-octavia-provider-functional-master cursor reset commit/rollback","commit_id":"8beeeb9112f6c61758f844774bfe4c5d6e8c6a08"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"618b96cbb86e5078218f85b5f4a199709196fb77","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"edf2742c_4d7b756f","updated":"2023-05-10 11:51:54.000000000","message":"recheck ovn-octavia-provider-functional-master cursor reset commit/rollback","commit_id":"8beeeb9112f6c61758f844774bfe4c5d6e8c6a08"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"e31dc8a3da280679f9782a0a7fe10b03307aa0f7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fc109f71_a7e053e6","updated":"2023-05-11 06:32:45.000000000","message":"recheck ovn-octavia-provider-functional-master cursor reset commit/rollback","commit_id":"8beeeb9112f6c61758f844774bfe4c5d6e8c6a08"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"0ec93ab0cb9ff464ebaf06acbc9ca21fc503745e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"059bb644_b65db184","updated":"2023-05-17 16:00:19.000000000","message":"recheck ovn-octavia-provider-functional-release cursor reset commit/rollback","commit_id":"8beeeb9112f6c61758f844774bfe4c5d6e8c6a08"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"6b09f851e18340ab2bcee52706927ff8e9669ba2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"44940270_a8bcef8f","updated":"2023-05-18 07:12:33.000000000","message":"recheck ovn-octavia-provider-functional-release cursor reset commit/rollback","commit_id":"8beeeb9112f6c61758f844774bfe4c5d6e8c6a08"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"952f3d785a94a87430a7fbc186f1716fa728a6ef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"63522262_26e6d124","updated":"2023-05-18 09:23:06.000000000","message":"recheck ovn-octavia-provider-functional-release cursor reset commit/rollback","commit_id":"8beeeb9112f6c61758f844774bfe4c5d6e8c6a08"}],"ovn_octavia_provider/helper.py":[{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"9429890919c6d78d9531187ba7145ac31f099232","unresolved":true,"context_lines":[{"line_number":2079,"context_line":"                    member_status[constants.OPERATING_STATUS] \u003d ("},{"line_number":2080,"context_line":"                        constants.OFFLINE)"},{"line_number":2081,"context_line":""},{"line_number":2082,"context_line":"                if constants.OPERATING_STATUS in member_status:"},{"line_number":2083,"context_line":"                    self._update_external_ids_member_status("},{"line_number":2084,"context_line":"                        ovn_lb,"},{"line_number":2085,"context_line":"                        member[constants.ID],"},{"line_number":2086,"context_line":"                        member_status[constants.OPERATING_STATUS])"},{"line_number":2087,"context_line":""},{"line_number":2088,"context_line":"                # NOTE(froyo): If we are toggling from/to OFFLINE due to an"},{"line_number":2089,"context_line":"                # admin_state_up change, in that case we should update vips"}],"source_content_type":"text/x-python","patch_set":2,"id":"852529ab_5731b4fd","line":2086,"range":{"start_line":2082,"start_character":1,"end_line":2086,"end_character":66},"updated":"2023-04-24 06:56:37.000000000","message":"what happens here if the update is the other way around? from UP to DOWN? don\u0027t we need to update this too? meaning this should be out of the if at 2068 (as it was before)?","commit_id":"ac3fe18b1a2a8a00b373149bee07414c2c1d725d"},{"author":{"_account_id":34451,"name":"Fernando Royo","email":"froyo@redhat.com","username":"froyo"},"change_message_id":"7c3f00aa1c896ceff4dad2131e3db499563071d6","unresolved":true,"context_lines":[{"line_number":2079,"context_line":"                    member_status[constants.OPERATING_STATUS] \u003d ("},{"line_number":2080,"context_line":"                        constants.OFFLINE)"},{"line_number":2081,"context_line":""},{"line_number":2082,"context_line":"                if constants.OPERATING_STATUS in member_status:"},{"line_number":2083,"context_line":"                    self._update_external_ids_member_status("},{"line_number":2084,"context_line":"                        ovn_lb,"},{"line_number":2085,"context_line":"                        member[constants.ID],"},{"line_number":2086,"context_line":"                        member_status[constants.OPERATING_STATUS])"},{"line_number":2087,"context_line":""},{"line_number":2088,"context_line":"                # NOTE(froyo): If we are toggling from/to OFFLINE due to an"},{"line_number":2089,"context_line":"                # admin_state_up change, in that case we should update vips"}],"source_content_type":"text/x-python","patch_set":2,"id":"87d6d7d9_9794a6db","line":2086,"range":{"start_line":2082,"start_character":1,"end_line":2086,"end_character":66},"in_reply_to":"852529ab_5731b4fd","updated":"2023-04-25 11:53:57.000000000","message":"It works same way, when the member is enabled or disabled we receive admin_state_up in the member object. \n\nIMO make sense to have this inside the if at 2068, to just update in case we receive an change regarding the operating_status.","commit_id":"ac3fe18b1a2a8a00b373149bee07414c2c1d725d"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"4300b9a318c74127bc9f0b17691b09e8461121de","unresolved":false,"context_lines":[{"line_number":2079,"context_line":"                    member_status[constants.OPERATING_STATUS] \u003d ("},{"line_number":2080,"context_line":"                        constants.OFFLINE)"},{"line_number":2081,"context_line":""},{"line_number":2082,"context_line":"                if constants.OPERATING_STATUS in member_status:"},{"line_number":2083,"context_line":"                    self._update_external_ids_member_status("},{"line_number":2084,"context_line":"                        ovn_lb,"},{"line_number":2085,"context_line":"                        member[constants.ID],"},{"line_number":2086,"context_line":"                        member_status[constants.OPERATING_STATUS])"},{"line_number":2087,"context_line":""},{"line_number":2088,"context_line":"                # NOTE(froyo): If we are toggling from/to OFFLINE due to an"},{"line_number":2089,"context_line":"                # admin_state_up change, in that case we should update vips"}],"source_content_type":"text/x-python","patch_set":2,"id":"12b70358_2b778627","line":2086,"range":{"start_line":2082,"start_character":1,"end_line":2086,"end_character":66},"in_reply_to":"87d6d7d9_9794a6db","updated":"2023-04-25 12:15:10.000000000","message":"right, it is true or false, but the admin_state_up field will be there, sorry for the noise","commit_id":"ac3fe18b1a2a8a00b373149bee07414c2c1d725d"}]}