)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"9033f0a9f02d94598f75c3df637992f77495abe1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"77edf752_0995fa38","updated":"2023-06-07 09:43:21.000000000","message":"Just tiny remarks.","commit_id":"f8d73b97e06389aa51d49311baf646ad60f2f439"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"7624161d0c56d70263f27554e134f050e8837ba7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"202c07bd_d3ff88e3","updated":"2023-06-07 09:30:43.000000000","message":"This needs to also handle updates/deletes as well as testing side","commit_id":"f8d73b97e06389aa51d49311baf646ad60f2f439"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"47b3da80ec317ac2b87a6f9f472901692eebc8a6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a372da22_430de0b2","updated":"2023-06-07 15:13:45.000000000","message":"I don\u0027t think we should use the term \"session persistence\" here as OVN cannot accomplish that in load balancing. For example, if the member list grows or shrinks, the flow will land on a different member server even with this patch.","commit_id":"441467a442b777c8a1474fcd47a0bf81fc8c75f5"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"2f3df9672dddfe442387a4061453e74ecf26a846","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"abcf4b55_909b0c90","updated":"2023-06-07 10:56:23.000000000","message":"missing release note and functional testing","commit_id":"441467a442b777c8a1474fcd47a0bf81fc8c75f5"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"d11ec7196dd6ab05c210ffc1ec4d38d877c512bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b2d2dcdb_2dbbf5d5","in_reply_to":"a372da22_430de0b2","updated":"2023-06-08 06:48:23.000000000","message":"I don\u0027t agree. Internally what is used is the \"affinity_timeout\" which is what ovn supports. Externally we use what is already there in the Octavia API for this. We can update docs to ensure there is no misunderstanding on this","commit_id":"441467a442b777c8a1474fcd47a0bf81fc8c75f5"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"1b6820a1a99b87d1fcd4388708b76e2bb994cdbd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"b471b322_8d7e4b24","updated":"2023-07-11 08:59:56.000000000","message":"waiting for manual testing","commit_id":"4f258cfa36ea2d93ef89e8e832d5204226b40f8d"}],"ovn_octavia_provider/common/constants.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"9033f0a9f02d94598f75c3df637992f77495abe1","unresolved":true,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"AFFINITY_TIMEOUT \u003d \"affinity_timeout\""},{"line_number":117,"context_line":"# This driver only supports SOURCE_IP sesssion persistency option"},{"line_number":118,"context_line":"OVN_SESSION_PERSISTENCE \u003d [constants.SESSION_PERSISTENCE_SOURCE_IP]"}],"source_content_type":"text/x-python","patch_set":1,"id":"18b7a561_8e14497a","line":118,"range":{"start_line":118,"start_character":0,"end_line":118,"end_character":23},"updated":"2023-06-07 09:43:21.000000000","message":"It\u0027s called \"SUPPORTED\" or \"NATIVE\" in lines 86, 89 and 92.","commit_id":"f8d73b97e06389aa51d49311baf646ad60f2f439"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"c024e210e0d7204a0123d7a04b665f709d6f5cb7","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"AFFINITY_TIMEOUT \u003d \"affinity_timeout\""},{"line_number":117,"context_line":"# This driver only supports SOURCE_IP sesssion persistency option"},{"line_number":118,"context_line":"OVN_SESSION_PERSISTENCE \u003d [constants.SESSION_PERSISTENCE_SOURCE_IP]"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a77a68f_adb1afc6","line":118,"range":{"start_line":118,"start_character":0,"end_line":118,"end_character":23},"in_reply_to":"18b7a561_8e14497a","updated":"2023-06-07 10:08:02.000000000","message":"Done","commit_id":"f8d73b97e06389aa51d49311baf646ad60f2f439"}],"ovn_octavia_provider/driver.py":[{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"9033f0a9f02d94598f75c3df637992f77495abe1","unresolved":true,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def _check_for_supported_session_perssitence(self, session):"},{"line_number":72,"context_line":"        if session.type not in ovn_const.OVN_SESSION_PERSISTENCE:"},{"line_number":73,"context_line":"            msg \u003d _(\u0027OVN provider does not support %s session persistence\u0027"},{"line_number":74,"context_line":"                    ) % session.type"},{"line_number":75,"context_line":"            raise driver_exceptions.UnsupportedOptionError("},{"line_number":76,"context_line":"                user_fault_string\u003dmsg,"}],"source_content_type":"text/x-python","patch_set":1,"id":"0302a914_96a7fe39","line":73,"updated":"2023-06-07 09:43:21.000000000","message":"Maybe it\u0027s worth to say what works?","commit_id":"f8d73b97e06389aa51d49311baf646ad60f2f439"},{"author":{"_account_id":23567,"name":"Luis Tomas Bolivar","email":"ltomasbo@redhat.com","username":"ltomasbo"},"change_message_id":"c024e210e0d7204a0123d7a04b665f709d6f5cb7","unresolved":false,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def _check_for_supported_session_perssitence(self, session):"},{"line_number":72,"context_line":"        if session.type not in ovn_const.OVN_SESSION_PERSISTENCE:"},{"line_number":73,"context_line":"            msg \u003d _(\u0027OVN provider does not support %s session persistence\u0027"},{"line_number":74,"context_line":"                    ) % session.type"},{"line_number":75,"context_line":"            raise driver_exceptions.UnsupportedOptionError("},{"line_number":76,"context_line":"                user_fault_string\u003dmsg,"}],"source_content_type":"text/x-python","patch_set":1,"id":"c78f47b6_a282360b","line":73,"in_reply_to":"0302a914_96a7fe39","updated":"2023-06-07 10:08:02.000000000","message":"Done","commit_id":"f8d73b97e06389aa51d49311baf646ad60f2f439"}],"releasenotes/notes/session-persistence-b409428a8907f542.yaml":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"36d3a10ad2020bf2ba3f175999c121d7850e992b","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Now the OVN Octavia provider uses the affinity_timeout option of OVN"},{"line_number":5,"context_line":"    Load Balancers to support pools sessions persistence. It only supports"},{"line_number":6,"context_line":"    the SOURCE_IP option type. If not timeout is set, by default 360 seconds"},{"line_number":7,"context_line":"    is set if the session persistence is enabled."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"f272fd18_f76cf615","line":6,"range":{"start_line":6,"start_character":34,"end_line":6,"end_character":37},"updated":"2023-07-11 14:28:36.000000000","message":"nit: no","commit_id":"382ddb0329f93873e25a55be65bf43000332a21a"}]}